75871 Commits (9ba8d767e090f8041c96656edb85ef117945fd54)

 

All Branches   

Search

Author	SHA1	Message	Date
Alberto Miedes Garcés	9ba8d767e0	Make Resque honor RAILS_LOG_BASE_PATH	4 years ago
Alberto Miedes Garcés	c7950727d2	Merge branch 'master' into make-logger-dir-configurable-via-env-again	4 years ago
Juan Ramón	f9db9e60d8	Merge pull request #15857 from CartoDB/juanra/increase-version-to-deploy ... increase version	4 years ago
juanrmn	26ed6bec8a	..	4 years ago
juanrmn	6a29d339fd	increase version	4 years ago
Juan Ramón	231dab22e3	Merge pull request #15855 from CartoDB/do-subscriptions ... Do subscriptions	4 years ago
juanrmn	6f7b8a79c1	news.md...	4 years ago
juanrmn	ae12ff7905	Merge branch 'master' of github.com:CartoDB/cartodb into do-subscriptions	4 years ago
Juan Ramón	062e2a35ee	Merge pull request #15836 from CartoDB/feature/juanra-do-update-redis-script-by-user ... DO: script to update redis data only for a given user	4 years ago
Juan Ramón	c0e2114d64	Merge pull request #15850 from CartoDB/bug/ch106113/datasets-in-catalog-should-be-able-to-be ... bug/ch106113/datasets-in-catalog-should-be-able-to-be	4 years ago
Juan Ramón	610facc3fd	Merge pull request #15852 from CartoDB/bug/ch106097/dashboard-sync-unsyncable-datasets-exceeding ... bug/ch106097/dashboard-sync-unsyncable-datasets-exceeding	4 years ago
Jesús Arroyo Torrens	b90101e92a	Show "Not connected" message only for active subscriptions	4 years ago
Jesús Arroyo Torrens	56c7aeb80c	Add connect action to sync size icon	4 years ago
juanrmn	5321f42e0f	bugfix	4 years ago
Alberto Miedes Garcés	958abaf13d	Merge pull request #15848 from CartoDB/amiedes-token-hotfix-1 ... Pass Carto::User instead of User	4 years ago
Alberto Miedes Garcés	5b7529ba5d	Update NEWS.md	4 years ago
juanrmn	f570427586	do not try to get BQ metadata for 'requested' datasets	4 years ago
Alberto Miedes Garcés	fa8d1a50ae	Pass Carto::User instead of User	4 years ago
Alberto Miedes Garcés	892eba5194	Merge pull request #15840 from CartoDB/feature/ch104097/migrate-oauthtoken-from-sequel-to-ar ... Migrate OauthToken from Sequel to AR	4 years ago
Alberto Miedes Garcés	65111b2682	Remove Sequel #filter call	4 years ago
Alberto Miedes Garcés	4cbfb54840	Restore compatibility with oauth-plugin gem ... The oob? method is used from the gem, and the name of the tokens association is also hardcoded there	4 years ago
Rafa de la Torre	29360e5bdc	Merge pull request #15844 from CartoDB/chore/ch104737/migrate-and-remove-old-externaldataimport ... Migrate and remove old ::ExternalDataImport sequel model	4 years ago
Rafa de la Torre	f6324fea93	Fix dependency loading issue that affects ::DataImport validations	4 years ago
Rafa de la Torre	4722a293e9	Fix for strange issue loading initializers and autoloading classes ... There's a race condition that causes DEFAULT_REDIS_OBJECT to be set to nil. I couldn't figure out yet why that happens.	4 years ago
Rafa de la Torre	ed40cf90d8	Fix problem in tests with autoloader ... For the autoloader to work fine, the file `table_regristrar.rb` should be located in: app/models/cartodb/table_registrar.rb because of its scope in the definition: ``` module CartoDB class TableRegistrar ... end end ``` Otherwise it *may* give this error: /var/lib/gems/2.5.0/gems/activesupport-4.2.11.3/lib/active_support/dependencies.rb:495:in `load_missing_constant': Unable to autoload constant TableRegistrar, expected /cartodb/app/models/table_registrar. rb to define it (LoadError) (TBH I don't know what kind of magic made it work before)	4 years ago
Rafa de la Torre	afcb351c19	Fix problem in tests with autoloader ... Otherwise after the last commit I get this failure when running tests: ``` bundle exec rspec --fail-fast --require ./spec/rspec_configuration.rb ./spec/services/visualization/common_data_service_spec.rb:163 Run options: include {:locations=>{"./spec/services/visualization/common_data_service_spec.rb"=>[163]}} CartoDB::Visualization::CommonDataService INFO: _CDB_LinkGhostTables() called with username=<NULL>, event_name=CREATE FOREIGN TABLE destroying common data remote visualizations unknown OID 47469: failed to recognize type of 'bbox'. It will be treated as String. INFO: _CDB_LinkGhostTables() called with username=<NULL>, event_name=CREATE FOREIGN TABLE delete remote visualizations that have been imported but keep the import (FAILED - 1) Dropping leaked test database cartodb_test_user_caed9ac1-61ca-43c2-8ed2-365c3c50beb3_db Failures: 1) CartoDB::Visualization::CommonDataService destroying common data remote visualizations delete remote visualizations that have been imported but keep the import Failure/Error: viz = FactoryGirl.create(:carto_table_visualization, user_id: @user.id) LoadError: Unable to autoload constant QuotaChecker, expected /cartodb/app/models/quota_checker.rb to define it # ./app/models/carto/visualization.rb:819:in `validate_change_to_public' # ./app/models/carto/visualization.rb:797:in `validate_privacy_changes' # ./spec/services/visualization/common_data_service_spec.rb:164:in `block (3 levels) in <top (required)>' ```	4 years ago
Rafa de la Torre	92d0da9d9b	Delete deprecated and re-wired ::ExternalDataImport Sequel model ... All usages have been replaced by new Carto::ExternalDataImport model.	4 years ago
Rafa de la Torre	fe0c07646e	Provide alternative implementation of external_source_visualization ... to use the new AR hierarchy. I believe they are only used from specs. See this file: ./spec/models/user_table_shared_examples.rb But I'd say it is better to wait for the removal of the ::UserTable model to tackle that issue.	4 years ago
Rafa de la Torre	9c864a45a5	Remove external_data_imports association ... That assotiation is actually only used from the DataImportExporter that actually uses the Carto::DataImport AR model, so removing from the code in prep for full deletion of old Sequel model.	4 years ago
Rafa de la Torre	08dfce52b6	Remove unused external_source_visualization methods ... That method is only used from the VisualizationFactory#create_canonical_visualization which is only invoked on Carto::UserTable models (via an after_create hook, BTW).	4 years ago
Rafa de la Torre	455a7d6665	Update NEWS.md	4 years ago
Rafa de la Torre	ac96c4b2eb	Fix spec by actually iterating and deleting external_data_imports ... Otherwise, the block is ignored by AR and this error happens because of FK constraints: ``` 1) Carto::VisualizationQueryBuilder filters raster tables Failure/Error: Unable to find matching line from backtrace Sequel::ForeignKeyConstraintViolation: PG::ForeignKeyViolation: ERROR: update or delete on table "data_imports" violates foreign key constraint "external_data_imports_data_import_id_fkey" on table "external_data_imports" DETAIL: Key (id)=(21998397-f7d1-4273-afb3-0b1ee18af108) is still referenced from table "external_data_imports". # ./spec/support/factories/users.rb:209:in `delete_user_data' # ./spec/factories/users_helper.rb:18:in `block (2 levels) in <top (required)>' ```	4 years ago
Rafa de la Torre	f65dc5a648	Replace usages of ::ExternalDataImport by Carto::ExternalDataImport	4 years ago
Rafa de la Torre	f8d65e67b9	Use AR Carto::ExternalDataImport and simplify code	4 years ago
Rafa de la Torre	39e4877261	Add missing class_name in associations ... This is potentially a problem otherwise, especially because the class is not defined within the scope of the `module Carto`. Anyway, being explicit about the class fulfilling the assotiation seems like a good idea.	4 years ago
Rafa de la Torre	7c2917aed8	Remove superfluous ExternalDataImpoort#initialize method ... It was created at the time to save a few keystrokes. But it doesn't really provide anything. Deleting it keep old and new models more similar.	4 years ago
Alberto Miedes Garcés	8f4fec9357	Merge branch 'master' into feature/ch104097/migrate-oauthtoken-from-sequel-to-ar	4 years ago
Jesús Arroyo Torrens	92e496d35e	Merge pull request #15847 from CartoDB/do-subscriptions ... DO subscriptions improvements	4 years ago
Jesús Arroyo Torrens	9e924eb7d6	Update NEWS	4 years ago
Jesús Arroyo Torrens	43cc2d503b	Update dev version	4 years ago
Jesús Arroyo Torrens	4b91110315	Merge pull request #15846 from CartoDB/feature/ch105389/remove-delete-table-for-do-subs ... Hide some dataset bulk actions for DO subscriptions	4 years ago
Jesús Arroyo Torrens	4a7dbdc5a3	Manage DO subscription dataset bulk actions. Refactor in dataset quick actions	4 years ago
Rafa de la Torre	4d9f8e391f	Make logger honor the environment variable RAILS_LOG_BASE_PATH again	4 years ago
Jesús Arroyo Torrens	febc49a53b	Update dev version	4 years ago
Jesús Arroyo Torrens	f2ea90fff2	Merge pull request #15842 from CartoDB/feature/ch105389/remove-delete-table-for-do-subs ... Remove table options for DO subscriptions	4 years ago
Jesús Arroyo Torrens	f231aa5ded	Add tests	4 years ago
Jesús Arroyo Torrens	8e2c93f764	Update table options for DO subscriptions	4 years ago
Juan Ramón	e038ec580a	Merge pull request #15839 from CartoDB/bug/ch105311/subscriptions-in-prod-trying-to-connect-an ... bug/ch105311/subscriptions-in-prod-trying-to-connect-an	4 years ago
juanrmn	32d1c661b4	it worked in local...	4 years ago
juanrmn	c6ddaf1fb5	fix tests...	4 years ago