Code review changes

NEWS.md

@@ -15,7 +15,7 @@ This release introduces a new API Key system. In order to migrate existing users
 * Update CARTO logo in maps (https://github.com/CartoDB/design/issues/1324)
 * Password expiration ([Central#2226](https://github.com/CartoDB/cartodb-central#2226))
 * New rake to fix inconsistent permissions (`bundle exec rake cartodb:permissions:fix_permission_acl`)
-* Support FileGeodatabase format uploads (https://github.com/CartoDB/product/issues/121)
+* Support FileGeodatabase format uploads (https://github.com/CartoDB/cartodb/issues/10730)
 
 ### Bug fixes / enhancements
 * Keep selected popup tab after fetch (https://github.com/CartoDB/support/issues/1396)

services/importer/lib/importer/downloader.rb

@@ -374,10 +374,6 @@ module CartoDB
           content_types: ['application/gpx+xml'],
           extensions: ['.gpx']
         },
-        {
-          content_types: ['application/zip'],
-          extensions: ['.zip', '.carto', '.gdb.zip']
-        },
         {
           content_types: ['application/x-gzip'],
           extensions: ['.tgz', '.gz']

services/importer/lib/importer/gpkg_splitter.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 require 'open3'
 require_relative './source_file'
 require_relative './unp'

services/importer/lib/importer/unp.rb

@@ -19,9 +19,9 @@ module CartoDB
       SUPPORTED_FORMATS     = %w{
         .csv .shp .ods .xls .xlsx .tif .tiff .kml .kmz
         .js .json .tar .gz .tgz .osm .bz2 .geojson .gpkg
-        .gpx .tab .tsv .txt .gdb
+        .gpx .tab .tsv .txt .gdb .fgdb
       }
-      SPLITTERS = [KmlSplitter, OsmSplitter, GpxSplitter, FgdbSplitter, GpkgSplitter]
+      SPLITTERS = [KmlSplitter, OsmSplitter, GpxSplitter, FgdbSplitter, GpkgSplitter].freeze
 
       DEFAULT_IMPORTER_TMP_SUBFOLDER = '/tmp/imports/'
 

services/importer/spec/unit/unp_spec.rb

@@ -197,6 +197,7 @@ describe Unp do
       unp.supported?('foo.xls').should eq true
       unp.supported?('foo.gpkg').should eq true
       unp.supported?('foo.gdb').should eq true
+      unp.supported?('foo.fgdb').should eq true
     end
   end