Recovering old Visualization::Member methods and fixing more tests

pull/12363/head
Luis Mayoral 7 years ago
parent 70b48c5d29
commit d458dd01b4
No known key found for this signature in database
GPG Key ID: 2E0B596CFA8F6EA1

@ -141,7 +141,6 @@ WORKING_SPECS_4 = \
services/sql-api/spec/sql_api_spec.rb \
spec/requests/admin/organizations_controller_spec.rb \
spec/requests/admin/visualizations_spec.rb \
spec/requests/api/json/visualizations_controller_spec.rb \
spec/requests/carto/api/visualizations_controller_spec.rb \
spec/requests/carto/api/tables_controller_spec.rb \
spec/queries/carto/visualization_query_builder_spec.rb \

@ -589,6 +589,31 @@ module CartoDB
end
end
# @param user_id String UUID of the actor that likes the visualization
# @throws AlreadyLikedError
def add_like_from(user_id)
Like.create(actor: user_id, subject: id)
reload_likes
self
rescue Sequel::DatabaseError => exception
if exception.message =~ /duplicate key/i
raise AlreadyLikedError
else
raise exception
end
end
def remove_like_from(user_id)
item = likes.select { |like| like.actor == user_id }
item.first.destroy unless item.first.nil?
reload_likes
self
end
def liked_by?(user_id)
!(likes.select { |like| like.actor == user_id }.first.nil?)
end
# @param viewer_user ::User
def qualified_name(viewer_user=nil)
if viewer_user.nil? || is_owner?(viewer_user)

@ -4,7 +4,6 @@ require 'rack/test'
require 'json'
require 'uri'
require_relative '../../spec_helper'
require_relative '../../../app/controllers/api/json/visualizations_controller'
require_relative '../../../services/data-repository/backend/sequel'
require 'helpers/unique_names_helper'
@ -12,7 +11,7 @@ require 'helpers/unique_names_helper'
# add the specs to ./spec/requests/api/json/visualizations_controller_shared_examples.rb instead.
# You can then run it with ./spec/requests/api/json/visualizations_controller_specs.rb and
# ./spec/requests/carto/api/visualizations_controller_specs.rb.
describe Api::Json::VisualizationsController do
describe Carto::Api::VisualizationsController do
include UniqueNamesHelper
include Rack::Test::Methods
include DataRepository

Loading…
Cancel
Save