From cd29bdd5354977a9a11e2aba66cf5faa77063c96 Mon Sep 17 00:00:00 2001 From: manmorjim Date: Tue, 20 Apr 2021 10:17:49 +0200 Subject: [PATCH] add guard-code for users and visualizations --- app/controllers/carto/api/vizjson3_presenter.rb | 3 ++- app/services/carto/visualization_backup_service.rb | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/controllers/carto/api/vizjson3_presenter.rb b/app/controllers/carto/api/vizjson3_presenter.rb index 7340a3c1f2..6af4373918 100644 --- a/app/controllers/carto/api/vizjson3_presenter.rb +++ b/app/controllers/carto/api/vizjson3_presenter.rb @@ -166,8 +166,9 @@ module Carto end def datasource_vizjson(options, forced_privacy_version) + username = @visualization.user.username unless @visualization.user.nil? ds = { - user_name: @visualization.user.username, + user_name: username, maps_api_template: ApplicationHelper.maps_api_template(api_templates_type(options)), stat_tag: @visualization.id } diff --git a/app/services/carto/visualization_backup_service.rb b/app/services/carto/visualization_backup_service.rb index a62e07f6c0..d71314dceb 100644 --- a/app/services/carto/visualization_backup_service.rb +++ b/app/services/carto/visualization_backup_service.rb @@ -7,6 +7,8 @@ module Carto include ::LoggerHelper def create_visualization_backup(visualization:, category:, with_mapcaps: true, with_password: true) + return unless Carto::Visualization.exists?(id: visualization.id) + export_json = export_visualization_json_hash( visualization.id, visualization.user,