From c863930edf50c137993e99a55c8c817fa77985e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20Arroyo=20Torrens?= <jarroyo@cartodb.com>
Date: Thu, 6 Aug 2020 15:14:39 +0200
Subject: [PATCH] Eslint fix vue

---
 .../components/Catalog/DatasetHeader.vue      |  2 +-
 .../Catalog/browser/FilterDetail.vue          |  2 +-
 .../Catalog/browser/FilterSummary.vue         |  6 ++----
 .../components/Catalog/browser/SearchBox.vue  |  6 +++---
 .../components/MapCard/TypeBadge.vue          |  4 ++--
 .../components/NotificationWarning.vue        |  2 +-
 .../new-dashboard/components/Page.vue         |  2 +-
 .../Subscriptions/ModalSubscription.vue       |  2 +-
 .../new-dashboard/pages/Data/Catalog.vue      | 21 +++++++++----------
 .../pages/Data/CatalogDatasetData.vue         |  4 ++--
 .../pages/Data/CatalogDatasetSummary.vue      |  2 +-
 .../new-dashboard/pages/Data/Data.vue         |  3 +--
 .../new-dashboard/pages/Data/Datasets.vue     |  2 +-
 package.json                                  |  6 +++---
 14 files changed, 30 insertions(+), 34 deletions(-)

diff --git a/lib/assets/javascripts/new-dashboard/components/Catalog/DatasetHeader.vue b/lib/assets/javascripts/new-dashboard/components/Catalog/DatasetHeader.vue
index cdf71d92b6..266aec8514 100644
--- a/lib/assets/javascripts/new-dashboard/components/Catalog/DatasetHeader.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Catalog/DatasetHeader.vue
@@ -165,7 +165,7 @@ export default {
       if (this.isPublicWebsite) {
         window.location.replace(this.getFormURL());
       } else {
-        this.$store.dispatch('catalog/requestDataset', { user: this.$store.state.user, dataset: this.dataset })
+        this.$store.dispatch('catalog/requestDataset', { user: this.$store.state.user, dataset: this.dataset });
       }
     },
     showModal (mode) {
diff --git a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterDetail.vue b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterDetail.vue
index 19db78ff90..4d1e21890a 100644
--- a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterDetail.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterDetail.vue
@@ -30,7 +30,7 @@ export default {
   },
   computed: {
     ...mapState({
-      filterMetadata: function(state) {
+      filterMetadata (state) {
         return state.catalog.filtersAvailable[this.filterId];
       }
     }),
diff --git a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterSummary.vue b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterSummary.vue
index be6bc81f6d..f4a98e1f77 100644
--- a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterSummary.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/FilterSummary.vue
@@ -186,12 +186,10 @@ export default {
     },
     activeSuggestedFilter (suggestedFilter) {
       const newFilter = {};
-      const currentFilter = this.$store.state.catalog.filter.categories[
-        suggestedFilter.category
-      ];
+      const currentFilter = this.$store.state.catalog.filter.categories[suggestedFilter.category];
       newFilter[suggestedFilter.category] = [
         ...currentFilter,
-        {id:suggestedFilter.option.id, name:suggestedFilter.option.name}
+        {id: suggestedFilter.option.id, name: suggestedFilter.option.name}
       ];
       this.$store.commit('catalog/setFilter', newFilter);
     },
diff --git a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/SearchBox.vue b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/SearchBox.vue
index f63dc0f36b..b899874753 100644
--- a/lib/assets/javascripts/new-dashboard/components/Catalog/browser/SearchBox.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Catalog/browser/SearchBox.vue
@@ -43,10 +43,10 @@ export default {
   },
   computed: {
     ...mapState({
-      filter: state => state.catalog.filter,
+      filter: state => state.catalog.filter
     }),
     searchText () {
-      return this.filter.searchText
+      return this.filter.searchText;
     }
   },
   methods: {
@@ -61,7 +61,7 @@ export default {
   watch: {
     searchText: {
       immediate: true,
-      handler(newValue) {
+      handler (newValue) {
         this.filterText = newValue;
       }
     }
diff --git a/lib/assets/javascripts/new-dashboard/components/MapCard/TypeBadge.vue b/lib/assets/javascripts/new-dashboard/components/MapCard/TypeBadge.vue
index 1177893866..49517c4ee5 100644
--- a/lib/assets/javascripts/new-dashboard/components/MapCard/TypeBadge.vue
+++ b/lib/assets/javascripts/new-dashboard/components/MapCard/TypeBadge.vue
@@ -1,5 +1,5 @@
 <template>
-  <span 
+  <span
   class="title is-xsmall is-semibold typeBadge"
   :class="{
     'is-kuviz': isKuviz && !inCondensedCard,
@@ -48,4 +48,4 @@ export default {
   }
 }
 
-</style>
\ No newline at end of file
+</style>
diff --git a/lib/assets/javascripts/new-dashboard/components/NotificationWarning.vue b/lib/assets/javascripts/new-dashboard/components/NotificationWarning.vue
index 191db619be..ad66daa077 100644
--- a/lib/assets/javascripts/new-dashboard/components/NotificationWarning.vue
+++ b/lib/assets/javascripts/new-dashboard/components/NotificationWarning.vue
@@ -62,4 +62,4 @@ export default {
     height: 16px;
   }
 }
-</style>
\ No newline at end of file
+</style>
diff --git a/lib/assets/javascripts/new-dashboard/components/Page.vue b/lib/assets/javascripts/new-dashboard/components/Page.vue
index 24e07b5307..f16e09d8f3 100644
--- a/lib/assets/javascripts/new-dashboard/components/Page.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Page.vue
@@ -8,7 +8,7 @@
 
 export default {
   name: 'Page'
-}
+};
 </script>
 
 <style scoped lang="scss">
diff --git a/lib/assets/javascripts/new-dashboard/components/Subscriptions/ModalSubscription.vue b/lib/assets/javascripts/new-dashboard/components/Subscriptions/ModalSubscription.vue
index df25facdc1..a5c733d0db 100644
--- a/lib/assets/javascripts/new-dashboard/components/Subscriptions/ModalSubscription.vue
+++ b/lib/assets/javascripts/new-dashboard/components/Subscriptions/ModalSubscription.vue
@@ -295,7 +295,7 @@ export default {
           dataset: this.dataset
         });
       }
-      //GTM event trigger
+      // GTM event trigger
       window.dataLayer = window.dataLayer || [];
       window.dataLayer.push({ event: 'requestDataset' });
     },
diff --git a/lib/assets/javascripts/new-dashboard/pages/Data/Catalog.vue b/lib/assets/javascripts/new-dashboard/pages/Data/Catalog.vue
index 8883214415..97f5e70014 100644
--- a/lib/assets/javascripts/new-dashboard/pages/Data/Catalog.vue
+++ b/lib/assets/javascripts/new-dashboard/pages/Data/Catalog.vue
@@ -86,18 +86,17 @@
 import SectionTitle from 'new-dashboard/components/SectionTitle';
 
 import { mapState } from 'vuex';
-import Button from  'new-dashboard/components/Button';
-import DatasetListItem from  'new-dashboard/components/Catalog/browser/DatasetListItem';
-import FilterBox from  'new-dashboard/components/Catalog/browser/FilterBox';
-import FilterSummary from  'new-dashboard/components/Catalog/browser/FilterSummary';
-import LoadingBar from  'new-dashboard/components/Catalog/browser/LoadingBar';
-import Pager from  'new-dashboard/components/Catalog/browser/Pager';
-import SearchBox from  'new-dashboard/components/Catalog/browser/SearchBox';
+import Button from 'new-dashboard/components/Button';
+import DatasetListItem from 'new-dashboard/components/Catalog/browser/DatasetListItem';
+import FilterBox from 'new-dashboard/components/Catalog/browser/FilterBox';
+import FilterSummary from 'new-dashboard/components/Catalog/browser/FilterSummary';
+import LoadingBar from 'new-dashboard/components/Catalog/browser/LoadingBar';
+import Pager from 'new-dashboard/components/Catalog/browser/Pager';
+import SearchBox from 'new-dashboard/components/Catalog/browser/SearchBox';
 import { filtersMetadata } from 'new-dashboard/utils/catalog/constants';
 import { toTitleCase } from 'new-dashboard/utils/catalog/string-to-title-case';
 import icon_by_environment from 'new-dashboard/mixins/catalog/icon_by_environment';
 
-
 export default {
   name: 'CatalogPage',
   mixins: [icon_by_environment],
@@ -162,7 +161,7 @@ export default {
     hideFilters () {
       this.filterDetail = false;
     },
-    getFilterLabel(filterId) {
+    getFilterLabel (filterId) {
       return filtersMetadata[filterId]
         ? filtersMetadata[filterId].label
         : toTitleCase(filterId);
@@ -170,7 +169,7 @@ export default {
     navigateToContact () {
       window.open('https://carto.com/contact/', '_blank');
     },
-    goToPage(pageNum) {
+    goToPage (pageNum) {
       this.$store.dispatch('catalog/setPage', pageNum);
     }
   },
@@ -312,4 +311,4 @@ input::-ms-clear {
   opacity: 0;
 }
 
-</style>
\ No newline at end of file
+</style>
diff --git a/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetData.vue b/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetData.vue
index eb23ed6f5b..337db1c91b 100644
--- a/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetData.vue
+++ b/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetData.vue
@@ -148,7 +148,7 @@ export default {
   components: {
     NotAvailable
   },
-  data() {
+  data () {
     return {
       tooltip: {
         visible: false,
@@ -162,7 +162,7 @@ export default {
   },
   watch: {
     dataset: {
-      handler: function(value) {
+      handler (value) {
         if (value && value.category_name) {
           sendCustomDimensions(
             value.category_name,
diff --git a/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetSummary.vue b/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetSummary.vue
index 7772be65d5..df1c7dfbd5 100644
--- a/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetSummary.vue
+++ b/lib/assets/javascripts/new-dashboard/pages/Data/CatalogDatasetSummary.vue
@@ -106,7 +106,7 @@ export default {
   name: 'CatalogDatasetSummary',
   watch: {
     dataset: {
-      handler: function(value) {
+      handler (value) {
         if (value && value.category_name) {
           sendCustomDimensions(
             value.category_name,
diff --git a/lib/assets/javascripts/new-dashboard/pages/Data/Data.vue b/lib/assets/javascripts/new-dashboard/pages/Data/Data.vue
index 60f38a9613..de0b41b96c 100644
--- a/lib/assets/javascripts/new-dashboard/pages/Data/Data.vue
+++ b/lib/assets/javascripts/new-dashboard/pages/Data/Data.vue
@@ -38,8 +38,7 @@ export default {
       return isAllowed(this.$route.params.filter);
     },
     showDataCatalog () {
-      return true;
-      // return !accounts.accountsWithDataCatalogLimits.includes(this.planAccountType);
+      return !accounts.accountsWithDataCatalogLimits.includes(this.planAccountType);
     }
   }
 };
diff --git a/lib/assets/javascripts/new-dashboard/pages/Data/Datasets.vue b/lib/assets/javascripts/new-dashboard/pages/Data/Datasets.vue
index 9372ab7a80..6a21b3488f 100644
--- a/lib/assets/javascripts/new-dashboard/pages/Data/Datasets.vue
+++ b/lib/assets/javascripts/new-dashboard/pages/Data/Datasets.vue
@@ -136,7 +136,7 @@ export default {
   },
   watch: {
     datasets: {
-      handler: function () {
+      handler () {
         if (this.datasets && Object.values(this.datasets).length) {
           if (this.datasetId && this.createVis) {
             const selectedDataset = Object.values(this.datasets).find(elem => elem.name === this.datasetId);
diff --git a/package.json b/package.json
index 7dc951d03e..94f6f321e6 100644
--- a/package.json
+++ b/package.json
@@ -102,7 +102,7 @@
     "copy-webpack-plugin": "^4.5.1",
     "css-loader": "^0.28.11",
     "csswring": "^3.0.5",
-    "eslint": "~4.8.0",
+    "eslint": "^4.8.0",
     "eslint-config-semistandard": "~11.0.0",
     "eslint-config-standard": "~10.2.1",
     "eslint-plugin-import": "~2.7.0",
@@ -217,9 +217,9 @@
     "test:new_dashboard:ci": "jest --config lib/assets/test/spec/new-dashboard/unit/jest.conf.js",
     "test:new_dashboard:update": "jest --config lib/assets/test/spec/new-dashboard/unit/jest.conf.js --updateSnapshot",
     "test:editor": "grunt affected_editor_specs",
-    "lint": "eslint .",
+    "lint": "eslint . --ext .js,.vue",
+    "lint:fix": "eslint . --ext .js,.vue --fix",
     "lint:css": "stylelint './app/assets/stylesheets/**/*.scss'",
-    "lint:fix": "eslint . --fix",
     "bump": "npm --no-git-tag-version version prerelease --preid=assets",
     "postversion": "git add package.json package-lock.json && git commit -m 'Bump assets version' && git push",
     "update-internal-deps": "rm -rf node_modules && npm install",