Merge pull request #16297 from CartoDB/rtorre/add-some-warnings

Add some warnings about updating extensions

NEWS.md

@@ -26,6 +26,7 @@ Development
 - Use fully qualified table name while creating a new map from a shared dataset [#16241](https://github.com/CartoDB/cartodb/pull/16241)
 - Add new events for DO full access [#16290](https://github.com/CartoDB/cartodb/pull/16290)
 - Fix an issue that prevents API OPTIONS from succeeding because of undue CSRF check [#16292](https://github.com/CartoDB/cartodb/pull/16292)
+- Fix a regression test and add some warnings to source code [#16297](https://github.com/CartoDB/cartodb/pull/16297)
 
 4.45.0 (2021-04-14)
 -------------------

app/models/user/db_service.rb

@@ -21,6 +21,8 @@ module CartoDB
       SCHEMA_GEOCODING = 'cdb'.freeze
       SCHEMA_CDB_DATASERVICES_API = 'cdb_dataservices_client'.freeze
       SCHEMA_AGGREGATION_TABLES = 'aggregation'.freeze
+
+      # WARNING: Do not forget about updating dependencies in cartodb-platform and carto-postgres-artifacts
       CDB_DATASERVICES_CLIENT_VERSION = '0.31.0'.freeze
 
       attr_accessor :user
@@ -661,6 +663,7 @@ module CartoDB
       # Upgrade the cartodb postgresql extension
       def upgrade_cartodb_postgres_extension(statement_timeout = nil, cdb_extension_target_version = nil)
         if cdb_extension_target_version.nil?
+          # WARNING: Do not forget about updating dependencies in cartodb-platform and carto-postgres-artifacts
           cdb_extension_target_version = '0.37.1'
         end
 

spec/models/data_import_spec.rb

@@ -412,7 +412,7 @@ describe DataImport do
 
     data_import = DataImport.create(
       user_id: @user.id,
-      data_source: "http://mydatasource.cartodb.wadus.com/foo.csv",
+      data_source: "http://localhost/foo.csv",
       synchronization_id: sync_job.id,
       updated_at: Time.now
     ).run_import!