Merge pull request #16405 from CartoDB/feature/sc-220191/notification-about-data-migrations-to-carto3

[sc220191] Notification about data migrations to CARTO 3
pull/16387/head^2
Shylpx 2 years ago committed by GitHub
commit c3ecb05125
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -19,6 +19,7 @@ Development
* Setting to enable/disable import notifications [16354](https://github.com/CartoDB/cartodb/pull/16354) * Setting to enable/disable import notifications [16354](https://github.com/CartoDB/cartodb/pull/16354)
* Setting to enable/disable random username generation on SAML authentication process [16372](https://github.com/CartoDB/cartodb/pull/16372) * Setting to enable/disable random username generation on SAML authentication process [16372](https://github.com/CartoDB/cartodb/pull/16372)
* Add type guessing capabilities to the ArcGIS connector [#16385](https://github.com/CartoDB/cartodb/pull/16385) * Add type guessing capabilities to the ArcGIS connector [#16385](https://github.com/CartoDB/cartodb/pull/16385)
* Add notification about data migrations to CARTO 3 [#16405](https://github.com/CartoDB/cartodb/pull/16405)
### Bug fixes / enhancements ### Bug fixes / enhancements
- Fix rubocop integration [#16382](https://github.com/CartoDB/cartodb/pull/16382) - Fix rubocop integration [#16382](https://github.com/CartoDB/cartodb/pull/16382)

@ -74,7 +74,9 @@ export default {
return !!this.$store.getters['user/isNotificationVisible']; return !!this.$store.getters['user/isNotificationVisible'];
}, },
isCarto3ReleaseNotificationVisible () { isCarto3ReleaseNotificationVisible () {
return this.isEnterprise && this.displayCarto3ReleaseNotification; // HACK: Disabling notification
return false;
// return this.isEnterprise && this.displayCarto3ReleaseNotification;
}, },
baseUrl () { baseUrl () {
return this.$store.state.user.base_url; return this.$store.state.user.base_url;

@ -39,11 +39,19 @@
<UserDropdown :userModel="user" :notificationsCount="notificationsCount" :open="isDropdownOpen" :baseUrl="baseUrl" v-click-outside="closeDropdown" @linkClick="closeDropdown" /> <UserDropdown :userModel="user" :notificationsCount="notificationsCount" :open="isDropdownOpen" :baseUrl="baseUrl" v-click-outside="closeDropdown" @linkClick="closeDropdown" />
<NotificationPopup <NotificationPopup
v-if="!popupWasShown('popups.newPlatform') && isEnterprise"
class="notification-popup"
:title="$t('NewPlatformMessage.title')"
:message="$t('NewPlatformMessage.message')"
:messageHasHTML="true"
@click.native.stop.prevent="toggleDropdown"/>
<!-- <NotificationPopup
v-if="!popupWasShown('feedback.popupWasShown')" v-if="!popupWasShown('feedback.popupWasShown')"
class="notification-popup" class="notification-popup"
:title="$t('FeedbackMessage.title')" :title="$t('FeedbackMessage.title')"
:message="$t('FeedbackMessage.message')" :message="$t('FeedbackMessage.message')"
@click.native.stop.prevent="toggleDropdown"/> @click.native.stop.prevent="toggleDropdown"/> -->
<!-- <NotificationPopup <!-- <NotificationPopup
v-if="!popupWasShown('popups.DataObservatorySamples') && !isOnPremise" v-if="!popupWasShown('popups.DataObservatorySamples') && !isOnPremise"
@ -111,8 +119,9 @@ export default {
}; };
}, },
mounted () { mounted () {
this.markPopupAsRead('feedback.popupWasShown'); this.markPopupAsRead('popups.newPlatform');
this.markPopupAsRead('popups.directDBConnection'); // this.markPopupAsRead('feedback.popupWasShown');
// this.markPopupAsRead('popups.directDBConnection');
}, },
computed: { computed: {
hasDBFFActive () { hasDBFFActive () {
@ -132,6 +141,9 @@ export default {
!this.isFirstTimeInDashboard && !this.isFirstTimeInDashboard &&
!this.hasDropdownOpenedForFirstTime && !this.hasDropdownOpenedForFirstTime &&
!this.popupWasShown; !this.popupWasShown;
},
isEnterprise () {
return this.$props.user && this.$props.user.is_enterprise;
} }
}, },
methods: { methods: {

@ -7,11 +7,10 @@
{{ title }} {{ title }}
</p> </p>
<p class="notification__paragraph text is-small" v-if="messageHasHTML" v-html="message"></p> <template v-for="(paragraph, index) in message">
<p class="notification__paragraph text is-small" v-if="messageHasHTML" v-html="paragraph" :key="index"></p>
<p class="notification__paragraph text is-small" v-if="!messageHasHTML"> <p class="notification__paragraph text is-small" v-else :key="index">{{ paragraph }}</p>
{{ message }} </template>
</p>
</div> </div>
</a> </a>
</template> </template>
@ -21,7 +20,7 @@ export default {
name: 'NotificationPopup', name: 'NotificationPopup',
props: { props: {
title: String, title: String,
message: String, message: Array,
messageHasHTML: { messageHasHTML: {
type: Boolean, type: Boolean,
default: false default: false

@ -557,6 +557,13 @@
"maps": "0 maps | {maps} map | {maps} maps", "maps": "0 maps | {maps} map | {maps} maps",
"datasets": "0 datasets | {datasets} dataset | {datasets} datasets" "datasets": "0 datasets | {datasets} dataset | {datasets} datasets"
}, },
"NewPlatformMessage": {
"title": "New version of the CARTO Platform",
"message": [
"To start using the latest version of our platform, please create your account <a href='https://carto.com/signup' target='_blank'>here</a>. We will then align it to your current subscription plan.",
"If you need help migrating your data to the new version of CARTO, reach out to our <a href='mailto:enterprise-support@carto.com'>Support team</a>."
]
},
"FeedbackMessage": { "FeedbackMessage": {
"title": "Let us know what you think.", "title": "Let us know what you think.",
"message": "Missing something? Should we be doing something differently?" "message": "Missing something? Should we be doing something differently?"

@ -70,7 +70,7 @@ exports[`NavigationBar.vue should render regular navbar with user dropdown close
<div class="navbar-user"> <div class="navbar-user">
<div class="navbar-avatar" style="background-image: url(//cartodb-libs.global.ssl.fastly.net/cartodbui/assets/unversioned/images/avatars/avatar_ghost_yellow.png);"></div> <div class="navbar-avatar" style="background-image: url(//cartodb-libs.global.ssl.fastly.net/cartodbui/assets/unversioned/images/avatars/avatar_ghost_yellow.png);"></div>
<userdropdown-stub baseurl="" usermodel="[object Object]"></userdropdown-stub> <userdropdown-stub baseurl="" usermodel="[object Object]"></userdropdown-stub>
<notificationpopup-stub title="FeedbackMessage.title" message="FeedbackMessage.message" class="notification-popup"></notificationpopup-stub> <!---->
</div> <span class="navbar-searchClose"><img svg-inline="" src="../../assets/icons/navbar/close.svg"></span> </div> <span class="navbar-searchClose"><img svg-inline="" src="../../assets/icons/navbar/close.svg"></span>
</div> </div>
</nav> </nav>

2
package-lock.json generated

@ -1,6 +1,6 @@
{ {
"name": "cartodb-ui", "name": "cartodb-ui",
"version": "1.0.0-assets.286", "version": "1.0.0-assets.287",
"lockfileVersion": 1, "lockfileVersion": 1,
"requires": true, "requires": true,
"dependencies": { "dependencies": {

@ -1,6 +1,6 @@
{ {
"name": "cartodb-ui", "name": "cartodb-ui",
"version": "1.0.0-assets.286", "version": "1.0.0-assets.287",
"description": "CARTO UI frontend", "description": "CARTO UI frontend",
"repository": { "repository": {
"type": "git", "type": "git",

Loading…
Cancel
Save