Make dry run endpoint use POST, same parameters as imports

pull/15414/head
Javier Goizueta 5 years ago
parent d6be9dd82e
commit c29c19fafa

@ -103,10 +103,10 @@ module Carto
def dryrun
provider_id = params[:provider_id]
parameters = build_connection_parameters(provider_id, params)
params[:provider] = provider_id
if Carto::Connector.dry_run?(provider_id)
begin
connector = Carto::Connector.new(parameters, user: current_user, logger: nil)
connector = Carto::Connector.new(params, user: current_user, logger: nil)
render_jsonp(connector.dry_run.except(:client_error))
rescue Carto::Connector::NotImplemented => e
render_jsonp({ errors: e.message }, 501)

@ -728,7 +728,7 @@ CartoDB::Application.routes.draw do
get 'connectors/:provider_id/connect' => 'connectors#connect', as: :api_v1_connectors_connect
get 'connectors/:provider_id/projects' => 'connectors#projects', as: :api_v1_connectors_projects
get 'connectors/:provider_id/:project_id/tables' => 'connectors#project_tables', as: :api_v1_connectors_project_tables
get 'connectors/:provider_id/dryrun' => 'connectors#dryrun', as: :api_v1_connectors_dryrun
post 'connectors/:provider_id/dryrun' => 'connectors#dryrun', as: :api_v1_connectors_dryrun
end
end

Loading…
Cancel
Save