Merge pull request #16324 from CartoDB/feature/ch169849/decathlon-pen-test-diagnosis-endpoint-shouldn

Add setting to disable diagnosis page

NEWS.md

@@ -44,6 +44,7 @@ Development
 - Use Google Maps provider if the base layer is Google [#16314](https://github.com/CartoDB/cartodb/pull/16314)
 - Allow importing datasets with exhausted map quota [#16320](https://github.com/CartoDB/cartodb/pull/16320)
 - Fix empty ArcGIS imports [#16322](https://github.com/CartoDB/cartodb/pull/16322)
+- Add setting to disable diagnosis page [#16324](https://github.com/CartoDB/cartodb/pull/16324)
 
 4.45.0 (2021-04-14)
 -------------------

app/controllers/home_controller.rb

@@ -41,7 +41,8 @@ class HomeController < ApplicationController
   end
 
   def app_diagnosis
-    return head(400) if Cartodb.config[:cartodb_com_hosted] == false
+    return head(:not_found) if Cartodb.config[:cartodb_com_hosted] == false ||
+                               Cartodb.config[:diagnosis_page_disabled] == true
 
     @diagnosis = [
       diagnosis_output('Configuration') { configuration_diagnosis },

config/app_config.yml.sample

@@ -793,6 +793,7 @@ defaults: &defaults
       enabled: true
       prefix_namespace: 'dbdirect:'
       hash_key: 'ips'
+  diagnosis_page_disabled: false
 
 development:
   <<: *defaults

config/app_config.yml.sample.py2

@@ -789,6 +789,7 @@ defaults: &defaults
       enabled: true
       prefix_namespace: 'dbdirect:'
       hash_key: 'ips'
+  diagnosis_page_disabled: false
 
 development:
   <<: *defaults