From bc12b5b0d639305e6cb00b868be89765139d38fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20Matall=C3=ADn?=
Date: Mon, 28 Aug 2017 18:39:46 +0200
Subject: [PATCH] replace nbsp to actual spaces
---
Guardfile | 4 +--
.../stylesheets/sessions/sessions.css.scss | 4 +--
config/app_config.yml.sample | 2 +-
.../twitter-import-details.tpl | 2 +-
.../content/datasets/dataset-item.tpl | 2 +-
.../content/datasets/datasets-no-result.tpl | 10 ++++----
.../components/table/body/table-body-cell.tpl | 2 +-
.../components/table/head/table-head-item.tpl | 2 +-
.../core/javascripts/cartodb3/editor.js | 2 +-
.../editor/layers/change-view-buttons.tpl | 2 +-
.../helpers/reset-style-per-node.spec.js | 2 +-
.../imports/background_import_item_view.js | 6 ++---
.../imports/twitter_import_details.jst.ejs | 2 +-
.../dialogs/change_privacy/start.jst.ejs | 4 +--
.../listing/datasets/dataset_item_view.js | 2 +-
.../datasets/remote_dataset_item_view.js | 4 +--
.../imports/data_import/data_header_view.js | 2 +-
.../imports/import_selected_dataset_view.js | 2 +-
.../service_import/service_list_item_view.js | 2 +-
.../dialogs/create/listing/imports_view.js | 4 +--
.../delete_items_view_template.jst.ejs | 6 ++---
.../edit_vis_metadata_dialog_model.js | 2 +-
.../map/image_picker/assets_item_view.js | 2 +-
.../date_picker/date_picker_view.js | 2 +-
.../cartodb/common/local_storage.js | 2 +-
.../views/create/listing/dataset_item.jst.ejs | 2 +-
.../create/listing/datasets_no_result.jst.ejs | 10 ++++----
.../dashboard_header/notifications/view.js | 4 +--
.../settings_dropdown_view.js | 2 +-
.../user_support_template.jst.ejs | 2 +-
.../common/views/support_banner.jst.ejs | 2 +-
.../datasets/remote_datasets_item.js | 4 +--
.../javascripts/cartodb/dashboard/router.js | 2 +-
.../views/content_no_results.jst.ejs | 10 ++++----
.../dashboard/views/datasets_item.jst.ejs | 2 +-
.../cartodb/dashboard/views/maps_item.jst.ejs | 2 +-
.../list/dataset_item_template.jst.ejs | 2 +-
.../javascripts/cartodb/models/carto.js | 4 +--
.../cartodb/models/carto/category.js | 4 +--
.../cartodb/models/synchronization.js | 2 +-
lib/assets/javascripts/cartodb/models/user.js | 4 +--
.../old_common/forms/text_custom_combo.js | 2 +-
.../cartodb/old_common/forms/widgets.js | 2 +-
.../public_table/table_router_public.js | 2 +-
.../javascripts/cartodb/table/actions_menu.js | 2 +-
.../table/menu_modules/carto_editor.js | 2 +-
.../table/menu_modules/carto_wizard.js | 2 +-
.../infowindow/infowindow_base_pane.js | 2 +-
.../table/menu_modules/legend_editor.js | 2 +-
.../cartodb/table/menu_modules/sql.js | 2 +-
.../menu_modules/wizards/category_wizard.js | 6 ++---
.../javascripts/cartodb/table/table_router.js | 4 +--
.../cartodb/table/watching_notifier_view.js | 2 +-
.../test/spec/cartodb/models/carto.spec.js | 20 +++++++--------
services/importer/Guardfile | 4 +--
.../regression/failing/fsq_places_uniq.csv | Bin 1753802 -> 1753802 bytes
.../carto/api/grantables_controller_spec.rb | 2 +-
spec/support/data/clubbing.csv | 24 +++++++++---------
58 files changed, 107 insertions(+), 107 deletions(-)
diff --git a/Guardfile b/Guardfile
index 9cdf59c066..94b38f6c48 100644
--- a/Guardfile
+++ b/Guardfile
@@ -16,10 +16,10 @@ guard 'minitest', test_folders: 'services' do
# Rails 3.2
# watch(%r|^app/controllers/(.*)\.rb|) { |m| "test/controllers/#{m[1]}_test.rb" }
# watch(%r|^app/helpers/(.*)\.rb|) { |m| "test/helpers/#{m[1]}_test.rb" }
- # watch(%r|^app/models/(.*)\.rb|) { |m| "test/unit/#{m[1]}_test.rb" }
+ # watch(%r|^app/models/(.*)\.rb|) { |m| "test/unit/#{m[1]}_test.rb" }
# Rails
# watch(%r|^app/controllers/(.*)\.rb|) { |m| "test/functional/#{m[1]}_test.rb" }
# watch(%r|^app/helpers/(.*)\.rb|) { |m| "test/helpers/#{m[1]}_test.rb" }
- # watch(%r|^app/models/(.*)\.rb|) { |m| "test/unit/#{m[1]}_test.rb" }
+ # watch(%r|^app/models/(.*)\.rb|) { |m| "test/unit/#{m[1]}_test.rb" }
end
diff --git a/app/assets/stylesheets/sessions/sessions.css.scss b/app/assets/stylesheets/sessions/sessions.css.scss
index ae82d26f0c..fc92f26e25 100644
--- a/app/assets/stylesheets/sessions/sessions.css.scss
+++ b/app/assets/stylesheets/sessions/sessions.css.scss
@@ -111,7 +111,7 @@ $cWhite: #FFFFFF;
text-decoration: none;
}
- a:hover {
+ a:hover {
text-decoration: underline;
}
}
@@ -128,7 +128,7 @@ $cWhite: #FFFFFF;
color: $cWhite;
text-decoration: none;
- &:hover {
+ &:hover {
text-decoration: underline;
}
}
diff --git a/config/app_config.yml.sample b/config/app_config.yml.sample
index 0c71949400..97a2134b19 100644
--- a/config/app_config.yml.sample
+++ b/config/app_config.yml.sample
@@ -245,7 +245,7 @@ defaults: &defaults
"user_name", "style_version", "tile_style", "query_wrapper"]
default_tile_styles:
point: "{\n marker-fill: #FF6600;\n marker-opacity: 0.9;\n marker-width: 12;\n marker-line-color: white;\n marker-line-width: 3;\n marker-line-opacity: 0.9;\n marker-placement: point;\n marker-type: ellipse;\n marker-allow-overlap: true;\n}"
- geometry: "{\n // points\n [mapnik-geometry-type=point] {\n marker-fill: #FF6600;\n marker-opacity: 1;\n marker-width: 12;\n marker-line-color: white;\n marker-line-width: 3;\n marker-line-opacity: 0.9;\n marker-placement: point;\n marker-type: ellipse;marker-allow-overlap: true;\n }\n\n //lines\n [mapnik-geometry-type=linestring] {\n line-color: #FF6600; \n line-width: 2; \n line-opacity: 0.7;\n }\n\n //polygons\n [mapnik-geometry-type=polygon] {\n polygon-fill:#FF6600;\n polygon-opacity: 0.7;\n line-opacity:1;\n line-color: #FFFFFF;\n }\n }"
+ geometry: "{\n // points\n [mapnik-geometry-type=point] {\n marker-fill: #FF6600;\n marker-opacity: 1;\n marker-width: 12;\n marker-line-color: white;\n marker-line-width: 3;\n marker-line-opacity: 0.9;\n marker-placement: point;\n marker-type: ellipse;marker-allow-overlap: true;\n }\n\n //lines\n [mapnik-geometry-type=linestring] {\n line-color: #FF6600; \n line-width: 2; \n line-opacity: 0.7;\n }\n\n //polygons\n [mapnik-geometry-type=polygon] {\n polygon-fill:#FF6600;\n polygon-opacity: 0.7;\n line-opacity:1;\n line-color: #FFFFFF;\n }\n }"
polygon: "{\n polygon-fill:#FF6600;\n polygon-opacity: 0.7;\n line-opacity:1;\n line-color: #FFFFFF;\n}"
multipolygon: "{\n polygon-fill:#FF6600;\n polygon-opacity: 0.7;\n line-opacity:1;\n line-color: #FFFFFF;\n}"
multilinestring: "{\n line-color:#FF6600;\n line-width:1;\n line-opacity: 0.7;\n}"
diff --git a/lib/assets/core/javascripts/cartodb3/components/background-importer/twitter-import-details.tpl b/lib/assets/core/javascripts/cartodb3/components/background-importer/twitter-import-details.tpl
index eeffeba36e..f8e47c7040 100755
--- a/lib/assets/core/javascripts/cartodb3/components/background-importer/twitter-import-details.tpl
+++ b/lib/assets/core/javascripts/cartodb3/components/background-importer/twitter-import-details.tpl
@@ -29,7 +29,7 @@
<% } %>
- <% if (tweetsCost > 0 || availableTweets <= 0) { %>
+ <% if (tweetsCost > 0 || availableTweets <= 0) { %>
<%- _t('components.background-importer.twitter-import-details.no-more-credits', { blockPriceFormatted: blockPriceFormatted, blockSizeFormatted: blockSizeFormatted }) %>
<% } else { %>
<% if (availableTweets != 1) { %>
diff --git a/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/dataset-item.tpl b/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/dataset-item.tpl
index 30df8f41b0..51c50f35bd 100755
--- a/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/dataset-item.tpl
+++ b/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/dataset-item.tpl
@@ -50,7 +50,7 @@
<%- _t('components.modals.add-layer.datasets.item.by') %>
-
+
<% } %>
diff --git a/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/datasets-no-result.tpl b/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/datasets-no-result.tpl
index 9772509b96..01440777e6 100755
--- a/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/datasets-no-result.tpl
+++ b/lib/assets/core/javascripts/cartodb3/components/modals/add-layer/content/datasets/datasets-no-result.tpl
@@ -7,20 +7,20 @@
<% } else { %> CDB-IconFont-lens <% } %>" />
- <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
+ <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
<%- _t('components.modals.add-layer.datasets.no-results.desc') %>
<% } %>
- <% if (( tag || q ) && totalItems === 0 && totalEntries === 0) { %>
- 0 <%- tag || q %> <%- type %> <%- _t('components.modals.add-layer.datasets.no-results.found') %>
+ <% if (( tag || q ) && totalItems === 0 && totalEntries === 0) { %>
+ 0 <%- tag || q %> <%- type %> <%- _t('components.modals.add-layer.datasets.no-results.found') %>
<% } %>
- <% if (page === 1 && !tag && !q && totalItems === 0 && totalEntries === 0) { %>
+ <% if (page === 1 && !tag && !q && totalItems === 0 && totalEntries === 0) { %>
<%- _t('components.modals.add-layer.datasets.no-results.there-are-no') %> <%- shared === "only" ? 'shared' : '' %> <%- locked ? 'locked' : '' %> <%- library ? 'library' : '' %> <%- type %>
<% } %>
- <% if (!tag && !q && totalItems === 0 && totalEntries === 0) { %>
+ <% if (!tag && !q && totalItems === 0 && totalEntries === 0) { %>
<%- _t('components.modals.add-layer.datasets.no-results.no-fun', { type: type }) %>
<% } %>
diff --git a/lib/assets/core/javascripts/cartodb3/components/table/body/table-body-cell.tpl b/lib/assets/core/javascripts/cartodb3/components/table/body/table-body-cell.tpl
index 6a5056eec0..e0a3b29d36 100755
--- a/lib/assets/core/javascripts/cartodb3/components/table/body/table-body-cell.tpl
+++ b/lib/assets/core/javascripts/cartodb3/components/table/body/table-body-cell.tpl
@@ -1,7 +1,7 @@
+ <%- name === 'cartodb_id' || (type === 'geometry' && geometry !== 'point') ? 'Table-headItemWrapper--short' : '' %>
">
diff --git a/lib/assets/core/javascripts/cartodb3/editor.js b/lib/assets/core/javascripts/cartodb3/editor.js
index 5038713faf..4b3eceec53 100755
--- a/lib/assets/core/javascripts/cartodb3/editor.js
+++ b/lib/assets/core/javascripts/cartodb3/editor.js
@@ -431,7 +431,7 @@ if (!configModel.get('cartodb_com_hosted')) {
$('.js-editorMenu').append(feedbackView.render().el);
}
-document.title = visDefinitionModel.get('name') + ' | CARTO';
+document.title = visDefinitionModel.get('name') + ' | CARTO';
if (window.__backboneAgent) {
window.__backboneAgent.handleBackbone(Backbone);
diff --git a/lib/assets/core/javascripts/cartodb3/editor/layers/change-view-buttons.tpl b/lib/assets/core/javascripts/cartodb3/editor/layers/change-view-buttons.tpl
index a4864f0a34..782f9ab2a4 100755
--- a/lib/assets/core/javascripts/cartodb3/editor/layers/change-view-buttons.tpl
+++ b/lib/assets/core/javascripts/cartodb3/editor/layers/change-view-buttons.tpl
@@ -47,7 +47,7 @@
<% if (isReadOnly || !isVisible) { %>data-tooltip="<%- _t('editor.edit-feature.geometry-disabled') %>"<% } %>
>
<% if (queryGeometryModel === 'point' || !queryGeometryModel) { %>
-
+
- <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
+ <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
There are no results in this page
<% } %>
- <% if (( tag || q ) && totalItems === 0 && totalEntries === 0) { %>
- 0 <%- tag || q %> <%- type %> found
+ <% if (( tag || q ) && totalItems === 0 && totalEntries === 0) { %>
+ 0 <%- tag || q %> <%- type %> found
<% } %>
- <% if (page === 1 && !tag && !q && totalItems === 0 && totalEntries === 0) { %>
+ <% if (page === 1 && !tag && !q && totalItems === 0 && totalEntries === 0) { %>
There are no <%- shared === "only" ? 'shared' : '' %> <%- locked ? 'locked' : '' %> <%- library ? 'library' : '' %> <%- type %>
<% } %>
- <% if (!tag && !q && totalItems === 0 && totalEntries === 0) { %>
+ <% if (!tag && !q && totalItems === 0 && totalEntries === 0) { %>
No <%- type %>, no fun
<% } %>
diff --git a/lib/assets/javascripts/cartodb/common/views/dashboard_header/notifications/view.js b/lib/assets/javascripts/cartodb/common/views/dashboard_header/notifications/view.js
index f50511adbd..08a251efa4 100644
--- a/lib/assets/javascripts/cartodb/common/views/dashboard_header/notifications/view.js
+++ b/lib/assets/javascripts/cartodb/common/views/dashboard_header/notifications/view.js
@@ -105,7 +105,7 @@ module.exports = cdb.core.View.extend({
d.userType = 'org';
} else if (d.isOrgOwner) {
d.userType = 'admin';
- } else if (d.accountType === "internal" || d.accountType === "partner" || d.accountType === "ambassador") {
+ } else if (d.accountType === "internal" || d.accountType === "partner" || d.accountType === "ambassador") {
d.userType = 'internal'
}
@@ -177,7 +177,7 @@ module.exports = cdb.core.View.extend({
if (window.organization_notifications) {
for (var n = 0; n < window.organization_notifications.length; n++) {
var notification = window.organization_notifications[n];
- var icon = notification.icon ? ('CDB-IconFont-' + notification.icon) : 'CDB-IconFont-alert';
+ var icon = notification.icon ? ('CDB-IconFont-' + notification.icon) : 'CDB-IconFont-alert';
arr.push({
iconFont: icon,
diff --git a/lib/assets/javascripts/cartodb/common/views/dashboard_header/settings_dropdown_view.js b/lib/assets/javascripts/cartodb/common/views/dashboard_header/settings_dropdown_view.js
index 0110e05342..8432a59900 100644
--- a/lib/assets/javascripts/cartodb/common/views/dashboard_header/settings_dropdown_view.js
+++ b/lib/assets/javascripts/cartodb/common/views/dashboard_header/settings_dropdown_view.js
@@ -67,7 +67,7 @@ module.exports = cdb.admin.DropdownMenu.extend({
var accountType = this.shortDisplayName(user);
var userUrl = this.model.viewUrl();
- var upgradeUrl = window.upgrade_url || cdb.config.get('upgrade_url') || '';
+ var upgradeUrl = window.upgrade_url || cdb.config.get('upgrade_url') || '';
this.$el.html(this.template_base({
name: user.fullName() || user.get('username'),
diff --git a/lib/assets/javascripts/cartodb/common/views/dashboard_header/user_support_template.jst.ejs b/lib/assets/javascripts/cartodb/common/views/dashboard_header/user_support_template.jst.ejs
index f2f3b021fa..433b7aa290 100644
--- a/lib/assets/javascripts/cartodb/common/views/dashboard_header/user_support_template.jst.ejs
+++ b/lib/assets/javascripts/cartodb/common/views/dashboard_header/user_support_template.jst.ejs
@@ -1,6 +1,6 @@
<% if (userType === 'org') { %>
-<% } else if (userType === 'client' || userType === 'internal') { %>
+<% } else if (userType === 'client' || userType === 'internal') { %>
<% } else { %>
diff --git a/lib/assets/javascripts/cartodb/common/views/support_banner.jst.ejs b/lib/assets/javascripts/cartodb/common/views/support_banner.jst.ejs
index a18d7f3b1b..3683f5e96f 100644
--- a/lib/assets/javascripts/cartodb/common/views/support_banner.jst.ejs
+++ b/lib/assets/javascripts/cartodb/common/views/support_banner.jst.ejs
@@ -34,7 +34,7 @@
Contact administrator
- <% } else if (userType === 'client' || userType === 'internal') { %>
+ <% } else if (userType === 'client' || userType === 'internal') { %>
Contact us
diff --git a/lib/assets/javascripts/cartodb/dashboard/datasets/remote_datasets_item.js b/lib/assets/javascripts/cartodb/dashboard/datasets/remote_datasets_item.js
index 01345de06b..55e655b83b 100644
--- a/lib/assets/javascripts/cartodb/dashboard/datasets/remote_datasets_item.js
+++ b/lib/assets/javascripts/cartodb/dashboard/datasets/remote_datasets_item.js
@@ -33,8 +33,8 @@ module.exports = DatasetsItem.extend({
var vis = this.model;
var table = this.table;
var tags = vis.get('tags') || [];
- var description = vis.get('description') && Utils.stripHTML(markdown.toHTML(vis.get('description'))) || '';
- var source = vis.get('source') && markdown.toHTML(vis.get('source')) || '';
+ var description = vis.get('description') && Utils.stripHTML(markdown.toHTML(vis.get('description'))) || '';
+ var source = vis.get('source') && markdown.toHTML(vis.get('source')) || '';
var d = {
isRaster: vis.get('kind') === 'raster',
diff --git a/lib/assets/javascripts/cartodb/dashboard/router.js b/lib/assets/javascripts/cartodb/dashboard/router.js
index d48c7723b8..f407c100ef 100644
--- a/lib/assets/javascripts/cartodb/dashboard/router.js
+++ b/lib/assets/javascripts/cartodb/dashboard/router.js
@@ -155,7 +155,7 @@ module.exports = Router.extend({
},
normalizeFragmentOrUrl: function(fragmentOrUrl) {
- return fragmentOrUrl && fragmentOrUrl.toString().replace(this._dashboardUrl, '') || this.currentDashboardUrl().toString();
+ return fragmentOrUrl && fragmentOrUrl.toString().replace(this._dashboardUrl, '') || this.currentDashboardUrl().toString();
},
/**
diff --git a/lib/assets/javascripts/cartodb/dashboard/views/content_no_results.jst.ejs b/lib/assets/javascripts/cartodb/dashboard/views/content_no_results.jst.ejs
index 67ca8e7384..e5057e19bd 100644
--- a/lib/assets/javascripts/cartodb/dashboard/views/content_no_results.jst.ejs
+++ b/lib/assets/javascripts/cartodb/dashboard/views/content_no_results.jst.ejs
@@ -15,8 +15,8 @@
You haven't liked any <%- type %> yet
<% } %>
- <% if (isSearching && totalItems === 0 && totalEntries === 0) { %>
- 0 <%- tag || q %> <%- type %> found
+ <% if (isSearching && totalItems === 0 && totalEntries === 0) { %>
+ 0 <%- tag || q %> <%- type %> found
<% } %>
<% if (page === 1 && !isSearching && !liked && totalItems === 0 && totalEntries === 0) { %>
@@ -24,15 +24,15 @@
<% } %>
- <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
+ <% if (page > 1 || totalItems === 0 && totalEntries > 0) { %>
Back to your first page
<% } %>
- <% if (isSearching && totalItems === 0 && totalEntries === 0) { %>
+ <% if (isSearching && totalItems === 0 && totalEntries === 0) { %>
Back to your <%- type %>
<% } %>
- <% if (!liked && !isSearching && totalItems === 0 && totalEntries === 0) { %>
+ <% if (!liked && !isSearching && totalItems === 0 && totalEntries === 0) { %>
No <%- type %>, no fun
<% } %>
diff --git a/lib/assets/javascripts/cartodb/dashboard/views/datasets_item.jst.ejs b/lib/assets/javascripts/cartodb/dashboard/views/datasets_item.jst.ejs
index 10c22d9641..85c2602161 100644
--- a/lib/assets/javascripts/cartodb/dashboard/views/datasets_item.jst.ejs
+++ b/lib/assets/javascripts/cartodb/dashboard/views/datasets_item.jst.ejs
@@ -51,7 +51,7 @@
<%- timeDiff %>
<% if (!isOwner) { %>
by
-
+
<% } %>
diff --git a/lib/assets/javascripts/cartodb/dashboard/views/maps_item.jst.ejs b/lib/assets/javascripts/cartodb/dashboard/views/maps_item.jst.ejs
index 7a42363a7d..fe2f80ade7 100644
--- a/lib/assets/javascripts/cartodb/dashboard/views/maps_item.jst.ejs
+++ b/lib/assets/javascripts/cartodb/dashboard/views/maps_item.jst.ejs
@@ -31,7 +31,7 @@
<%- timeDiff %> <% if (!isOwner) { %>by<% } %>
<% if (!isOwner) { %>
-
+
<% } %>
diff --git a/lib/assets/javascripts/cartodb/data_library/content/list/dataset_item_template.jst.ejs b/lib/assets/javascripts/cartodb/data_library/content/list/dataset_item_template.jst.ejs
index e5f29a1f1b..f3348d4117 100644
--- a/lib/assets/javascripts/cartodb/data_library/content/list/dataset_item_template.jst.ejs
+++ b/lib/assets/javascripts/cartodb/data_library/content/list/dataset_item_template.jst.ejs
@@ -11,7 +11,7 @@
|