Merge pull request #13766 from CartoDB/4204_viz_metadata

allows export of external metadata without sync

NEWS.md

@@ -165,6 +165,7 @@ ion for time-series (#12670)
 * Hide legend title and header if not enabled (https://github.com/CartoDB/support/issues/1349)
 
 ### Bug fixes / enhancements
+* Allows import of an exported dataset with external data imports without a syncronization (#13766)
 * Fix users with unexisting physical tables on export ([#13721](https://github.com/CartoDB/cartodb/issues/13721))
 * Fix saving hdpi url templates when not needed (#13746)
 * Fix analysis modal alignment and password form (CartoDB/onpremises/issues/520)

app/services/carto/visualizations_export_persistence_service.rb

@@ -93,13 +93,12 @@ module Carto
 
           new_user_layers = map.base_layers.select(&:custom?).select { |l| !contains_equivalent_base_layer?(user.layers, l) }
           new_user_layers.map(&:dup).map { |l| user.layers << l }
-
           data_import = map.user_table.try(:data_import)
           if data_import
             data_import.table_id = map.user_table.id
             data_import.save!
             data_import.external_data_imports.each do |edi|
-              edi.synchronization_id = sync.id
+              edi.synchronization_id = sync.id if sync
               edi.save!
             end
           end

spec/services/carto/visualizations_export_service_2_spec.rb

@@ -1665,6 +1665,20 @@ describe Carto::VisualizationsExportService2 do
 
         destroy_visualization(imported_viz.id)
       end
+
+      it 'imports an exported dataset with external data import without a synchronization' do
+        @table.data_import = FactoryGirl.create(:data_import, user: @user2, table_id: @table.id)
+        @table.save!
+        FactoryGirl.create(:external_data_import_with_external_source, data_import: @table.data_import)
+        exported_string = export_service.export_visualization_json_string(@table_visualization.id, @user2)
+        built_viz = export_service.build_visualization_from_json_export(exported_string)
+        @user2.in_database.execute("CREATE TABLE #{@table_visualization.name} (cartodb_id int)")
+
+        imported_viz = Carto::VisualizationsExportPersistenceService.new.save_import(@user2, built_viz)
+
+        imported_viz.should be
+        destroy_visualization(imported_viz.id)
+      end
     end
   end
 end