From ad5a42e640553db85be1c1135cce45ffd0d36744 Mon Sep 17 00:00:00 2001 From: Ivan Malagon Date: Mon, 13 Mar 2017 17:21:24 +0100 Subject: [PATCH] Leaving only affected specs code --- Gruntfile.js | 2 +- .../onboardings/generic/generic-onboarding-launcher.js | 2 -- .../components/onboardings/generic/generic-onboarding-view.js | 2 -- .../layers/analysis-onboarding/analysis-onboarding.tpl | 2 -- .../analysis-onboarding/analysis-onboarding-view.spec.js | 4 ---- lib/build/tasks/jasmine.js | 2 +- tree.config.json | 2 +- 7 files changed, 3 insertions(+), 13 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 675490f1aa..c4f851ca60 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -357,7 +357,7 @@ var SHRINKWRAP_MODULES_TO_VALIDATE = [ }); }); - grunt.registerTask('affected_dev', 'Revolutionising testing at Carto', [ + grunt.registerTask('affected_dev', 'Build only specs affected by changes in current branch', [ 'copy_builder', 'affected', 'browserify:affected_specs', diff --git a/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-launcher.js b/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-launcher.js index f1df730b05..1b8ba11591 100644 --- a/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-launcher.js +++ b/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-launcher.js @@ -19,8 +19,6 @@ var GenericOnboardingLauncher = function (launcherOpts, viewOpts) { throw new Error('notificationKey is required'); } - // Modified - if (!launcherOpts.onboardings) { throw new Error('onboardings is required'); } diff --git a/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-view.js b/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-view.js index 1ef8ab2a34..f172378234 100644 --- a/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-view.js +++ b/lib/assets/core/javascripts/cartodb3/components/onboardings/generic/generic-onboarding-view.js @@ -132,8 +132,6 @@ module.exports = CoreView.extend({ CoreView.prototype.clean.apply(this); }, - // This is a view - _setMiddlePad: function (position, padding, body) { var $window = $(window); var $top = this.$('.' + this._selector + '-pads--left .' + this._selector + '-padTop'); diff --git a/lib/assets/core/javascripts/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding.tpl b/lib/assets/core/javascripts/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding.tpl index a4165d35f2..0fe4bf9ffd 100644 --- a/lib/assets/core/javascripts/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding.tpl +++ b/lib/assets/core/javascripts/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding.tpl @@ -5,8 +5,6 @@
- -
diff --git a/lib/assets/core/test/spec/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding-view.spec.js b/lib/assets/core/test/spec/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding-view.spec.js index 74f4d066f9..37ac6119fd 100644 --- a/lib/assets/core/test/spec/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding-view.spec.js +++ b/lib/assets/core/test/spec/cartodb3/components/onboardings/layers/analysis-onboarding/analysis-onboarding-view.spec.js @@ -9,10 +9,6 @@ var LayerDefinitionModel = require('../../../../../../../javascripts/cartodb3/da var LayerDefinitionsCollection = require('../../../../../../../javascripts/cartodb3/data/layer-definitions-collection'); var helper = require('../../onboarding-tests-helper'); -// Modified -// Modified twice - - describe('components/onboardings/layers/analysis-onboarding/analysis-onboarding-view', function () { beforeEach(function () { this.configModel = new ConfigModel({ diff --git a/lib/build/tasks/jasmine.js b/lib/build/tasks/jasmine.js index 2980880856..d89cb336e2 100644 --- a/lib/build/tasks/jasmine.js +++ b/lib/build/tasks/jasmine.js @@ -45,4 +45,4 @@ module.exports = { vendor: ['node_modules/jasmine-ajax/lib/mock-ajax.js'] } } -}; \ No newline at end of file +}; diff --git a/tree.config.json b/tree.config.json index 5e27bb27f5..2895a96300 100644 --- a/tree.config.json +++ b/tree.config.json @@ -5,4 +5,4 @@ ["lib/assets/core", "lib/assets"], ["lib/assets/client", "lib/assets"] ] -} \ No newline at end of file +}