From 8df52ed862d01a79fc6206029bc80181719d47dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Miedes=20Garc=C3=A9s?= Date: Fri, 9 Apr 2021 09:29:07 +0200 Subject: [PATCH] Don't validate user email domains against DNS Not needed anymore as we ask for explicit email verification before provisioning users --- config/initializers/email_address.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/config/initializers/email_address.rb b/config/initializers/email_address.rb index 18735e124b..9e41e66ac4 100644 --- a/config/initializers/email_address.rb +++ b/config/initializers/email_address.rb @@ -1,4 +1,8 @@ -EmailAddress::Config.configure(local_format: :conventional, host_validation: Cartodb.config[:disable_email_mx_check] ? :syntax : :mx ) +# Previously we validated email domains against DNS records, but since we forced the email verification before +# provisioning users this is not needed anymore. +# Also, some user emails coming from SAML IDPs may have domains which don't have a corresponding DNS record +# https://app.clubhouse.io/cartoteam/story/145527/reef-set-up-sso#activity-146696 +EmailAddress::Config.configure(local_format: :conventional, host_validation: :syntax) class EmailValidator < ActiveModel::EachValidator def validate_each(record, attribute, value)