Rename connector remote_table_name method for clarity

Use simply table_name to refer to the imported table name,
to avoid confusion with possible remote table names.
bq-mix
Javier Goizueta 5 years ago
parent 5c4faf3efd
commit 69f3dc3d1a

@ -55,7 +55,7 @@ module Carto
@provider.remote_data_updated?
end
def remote_table_name
def table_name
@provider.table_name
end

@ -46,7 +46,7 @@ module CartoDB
@job.log "ConnectorRunner #{@json_params.except('connection').to_json}"
# TODO: logging with CartoDB::Logger
table_name = @job.table_name
if should_import?(@connector.remote_table_name)
if should_import?(@connector.table_name)
@job.log "Copy connected table"
warnings = @connector.copy_table(schema_name: @job.schema, table_name: @job.table_name)
@job.log 'Georeference geometry column'
@ -59,7 +59,7 @@ module CartoDB
@job.log "ConnectorRunner Error #{error}"
@results.push result_for(@job.schema, table_name, error)
else
if should_import?(@connector.remote_table_name)
if should_import?(@connector.table_name)
@job.log "ConnectorRunner created table #{table_name}"
@job.log "job schema: #{@job.schema}"
@results.push result_for(@job.schema, table_name)
@ -117,7 +117,7 @@ module CartoDB
end
def result_table_name
Carto::DB::Sanitize.sanitize_identifier @connector.remote_table_name
Carto::DB::Sanitize.sanitize_identifier @connector.table_name
end
def result_for(schema, table_name, error = nil)

Loading…
Cancel
Save