Merge pull request #16420 from CartoDB/bug/sc-229113/all-users-add-fixed-banner-on-the-top-of

[sc220191] Add fixed banner about data migration to the new platform
pull/16422/head
Shylpx 2 years ago committed by GitHub
commit 64bc263488
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -20,6 +20,7 @@ Development
* Setting to enable/disable random username generation on SAML authentication process [16372](https://github.com/CartoDB/cartodb/pull/16372)
* Add type guessing capabilities to the ArcGIS connector [#16385](https://github.com/CartoDB/cartodb/pull/16385)
* Add notification about data migrations to CARTO 3 [#16405](https://github.com/CartoDB/cartodb/pull/16405)
* Update banner to notify about data migrations to CARTO 3 [#16420](https://github.com/CartoDB/cartodb/pull/16420)
### Bug fixes / enhancements
- Fix rubocop integration [#16382](https://github.com/CartoDB/cartodb/pull/16382)

@ -52,14 +52,14 @@ export default {
MamufasImportView
},
data: () => ({
displayCarto3ReleaseNotification: notificationIsVisible(window.localStorage.getItem('carto3ReleaseVisible'))
displayCarto3ReleaseNotification: notificationIsVisible(window.localStorage.getItem('carto3ReleaseVisibleV2'))
}),
created () {
sendMetric(MetricsTypes.VISITED_PRIVATE_PAGE, { page: 'dashboard' });
},
methods: {
closeCarto3Release () {
window.localStorage.setItem('carto3ReleaseVisible', new Date().getTime());
window.localStorage.setItem('carto3ReleaseVisibleV2', new Date().getTime());
this.displayCarto3ReleaseNotification = false;
}
},
@ -74,9 +74,7 @@ export default {
return !!this.$store.getters['user/isNotificationVisible'];
},
isCarto3ReleaseNotificationVisible () {
// HACK: Disabling notification
return false;
// return this.isEnterprise && this.displayCarto3ReleaseNotification;
return this.isEnterprise && this.displayCarto3ReleaseNotification;
},
baseUrl () {
return this.$store.state.user.base_url;

@ -10,20 +10,23 @@
class="text"
v-html="
$t('Carto3Release.message', {
link: `<a href='https://carto.com/blog/announcing-carto-spatial-extension-bigquery/' target='_blank'>${$t('Carto3Release.link')}</a>`,
link: `<a href='https://carto.com/signup' target='_blank'>${$t('Carto3Release.link')}</a>`,
contact: `<a href='mailto:enterprise-support@carto.com' target='_blank'>${$t('Carto3Release.contactUs')}</a>`
})
"
>
</span>
</div>
</span>
<button
<!-- HACK: Non-closable banner -->
<!-- <button
class="notification__close-button"
@click="close"
aria-label="Close"
>
<img src="../assets/icons/common/close-black.svg" />
</button>
</button> -->
</div>
</template>

@ -1,8 +1,9 @@
{
"Carto3Release": {
"title": "New release",
"message": "Announcing the launch of the cloud native Spatial Extension for BigQuery, {link}!",
"link": "find out more"
"title": "Try out the new CARTO platform!",
"message": "Create your account {link}. {contact} so we can match your current plan and help you migrate your data.",
"link": "here",
"contactUs": "Contact us"
},
"MapCard": {
"shared": {

2
package-lock.json generated

@ -1,6 +1,6 @@
{
"name": "cartodb-ui",
"version": "1.0.0-assets.288",
"version": "1.0.0-assets.289",
"lockfileVersion": 1,
"requires": true,
"dependencies": {

@ -1,6 +1,6 @@
{
"name": "cartodb-ui",
"version": "1.0.0-assets.288",
"version": "1.0.0-assets.289",
"description": "CARTO UI frontend",
"repository": {
"type": "git",

Loading…
Cancel
Save