Rename dataset_info do endpoint to entity_info

app/controllers/carto/api/public/data_observatory_controller.rb

@@ -91,9 +91,9 @@ module Carto
           head :no_content
         end
 
-        def dataset_info
+        def entity_info
           doss = Carto::DoSyncServiceFactory.get_for_user(@user)
-          render json: doss.dataset_info(params[:dataset_id]).merge(doss.dataset_estimates)
+          render json: doss.dataset_info(params[:entity_id]).merge(doss.dataset_estimates)
         end
 
         def sync_info

config/routes.rb

@@ -616,7 +616,7 @@ CartoDB::Application.routes.draw do
         delete 'subscriptions' => 'data_observatory#unsubscribe', as: :api_v4_do_subscriptions_destroy
         get 'subscription_info' => 'data_observatory#subscription_info', as: :api_v4_do_subscription_info
 
-        get 'dataset_info' => 'data_observatory#dataset_info', as: :api_v4_do_dataset_info
+        get 'entity_info' => 'data_observatory#entity_info', as: :api_v4_do_entity_info
 
         get 'subscriptions/:subscription_id/sync' => 'data_observatory#sync_info', as: :api_v4_do_subscription_sync_info, constraints: { subscription_id: /[\w\.\-]+/ }
         post 'subscriptions/:subscription_id/sync' => 'data_observatory#create_sync', as: :api_v4_do_subscription_create_sync, constraints: { subscription_id: /[\w\.\-]+/ }

spec/requests/carto/api/public/data_observatory_controller_spec.rb

@@ -468,10 +468,9 @@ describe Carto::Api::Public::DataObservatoryController do
     end
   end
 
-  describe 'dataset_info' do
+  describe 'entity_info' do
     before(:all) do
-      @url_helper = 'api_v4_do_dataset_info'
-      # @payload = { dataset_id: 'carto.abc.dataset1' }
+      @url_helper = 'api_v4_do_entity_info'
     end
 
     before(:each) do
@@ -490,15 +489,11 @@ describe Carto::Api::Public::DataObservatoryController do
       @doss.stubs(:dataset_info).with(dataset_id).returns(dataset_info)
       dataset_estimates = { estimated_size: 10000, estimated_row_count: 1000, estimated_columns_count: 1000 }
       @doss.stubs(:dataset_estimates).with(dataset_id).returns(dataset_estimates)
-      get_json endpoint_url(api_key: @master, dataset_id: dataset_id), @headers do |response|
+      get_json endpoint_url(api_key: @master, entity_id: dataset_id), @headers do |response|
         expect(response.status).to eq(200)
         expect(response.body).to eq(dataset_info.merge(dataset_estimates))
       end
     end
-
-    # it 'returns 404 if the dataset does not exist' do
-    # end
-
   end
 
   describe 'subscribe' do