From 385a580c3b392f35c0ca6d8cc3d8ced6bd0c67a6 Mon Sep 17 00:00:00 2001 From: Ivan Malagon Date: Tue, 20 Feb 2018 18:08:23 +0100 Subject: [PATCH] Fix lint problems --- .eslintignore | 7 ++++++- .../list-view/input-categories-list-view.spec.js | 1 - .../test/spec/builder/embed/embed-overlay-view.spec.js | 2 +- .../test/spec/builder/routes/handle-modals-route.spec.js | 4 ++-- .../dashboard/views/public-profile/fav-map-view.spec.js | 4 ++-- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.eslintignore b/.eslintignore index a0dd4fd00d..fdc9778dc3 100644 --- a/.eslintignore +++ b/.eslintignore @@ -6,7 +6,11 @@ /lib/assets/javascripts/cdb /lib/assets/javascripts/utils /lib/assets/javascripts/vendor/jquery-ui.js -/lib/assets/test +/lib/assets/test/lib +/lib/assets/test/spec/cartodb +/lib/assets/test/spec/node_modules +/lib/assets/test/spec/SpecHelper.js +/lib/assets/test/spec/SpecHelper3.js /lib/build/* !/lib/build/tasks /lib/carto @@ -21,3 +25,4 @@ /services /spec /vendor +/coverage diff --git a/lib/assets/test/spec/builder/components/form-components/editors/fill/input-color/input-qualitative-ramps/categories-list/list-view/input-categories-list-view.spec.js b/lib/assets/test/spec/builder/components/form-components/editors/fill/input-color/input-qualitative-ramps/categories-list/list-view/input-categories-list-view.spec.js index 48c6416fd6..698fbbbbe7 100644 --- a/lib/assets/test/spec/builder/components/form-components/editors/fill/input-color/input-qualitative-ramps/categories-list/list-view/input-categories-list-view.spec.js +++ b/lib/assets/test/spec/builder/components/form-components/editors/fill/input-color/input-qualitative-ramps/categories-list/list-view/input-categories-list-view.spec.js @@ -293,5 +293,4 @@ describe('components/form-components/editors/fill/input-color/input-qualitative- view.remove(); }); }); - }); diff --git a/lib/assets/test/spec/builder/embed/embed-overlay-view.spec.js b/lib/assets/test/spec/builder/embed/embed-overlay-view.spec.js index 76190d2791..6c08dc1966 100644 --- a/lib/assets/test/spec/builder/embed/embed-overlay-view.spec.js +++ b/lib/assets/test/spec/builder/embed/embed-overlay-view.spec.js @@ -120,7 +120,7 @@ describe('embed/embed-overlay-view', function () { template: legendsCanvas }); - options = { + var options = { title: TITLE, description: description, legends: false, diff --git a/lib/assets/test/spec/builder/routes/handle-modals-route.spec.js b/lib/assets/test/spec/builder/routes/handle-modals-route.spec.js index 8f4009174e..12ca73b9c6 100644 --- a/lib/assets/test/spec/builder/routes/handle-modals-route.spec.js +++ b/lib/assets/test/spec/builder/routes/handle-modals-route.spec.js @@ -3,7 +3,7 @@ var handleModalsRoute = require('builder/routes/handle-modals-route'); describe('routes/handleModalsRoute', function () { it('should handle modals route', function () { var modals = { - keepOpenOnRouteChange: function () { return false }, + keepOpenOnRouteChange: function () { return false; }, destroy: jasmine.createSpy('destroy') }; @@ -14,7 +14,7 @@ describe('routes/handleModalsRoute', function () { it('should not destroy modals when route changes and `keepOpenOnRouteChange` property is enabled', function () { var modals = { - keepOpenOnRouteChange: function () { return true }, + keepOpenOnRouteChange: function () { return true; }, destroy: jasmine.createSpy('destroy') }; diff --git a/lib/assets/test/spec/dashboard/views/public-profile/fav-map-view.spec.js b/lib/assets/test/spec/dashboard/views/public-profile/fav-map-view.spec.js index 490c5706d8..148df5230e 100644 --- a/lib/assets/test/spec/dashboard/views/public-profile/fav-map-view.spec.js +++ b/lib/assets/test/spec/dashboard/views/public-profile/fav-map-view.spec.js @@ -108,8 +108,8 @@ describe('dashboard/views/public-profile/fav-map-view', function () { expect(argEl).toBe(this.view.el); expect(argOpts.scrollWheelZoom).toBe(false); expect(argOpts.zoomControl).toBe(false); - - var tileLayerArgs = L.tileLayer.calls.argsFor(0); + + var tileLayerArgs = L.tileLayer.calls.argsFor(0); expect(tileLayerArgs[0]).toBe('https://cartodb-basemaps-{s}.global.ssl.fastly.net/rastertiles/voyager_nolabels/{z}/{x}/{y}.png'); expect(tileLayerArgs[1].attribution).toBe('Wubba lubba dub dub'); });