From 9deedf0d02c39aa58d5b75f9f18e7815cb021ed6 Mon Sep 17 00:00:00 2001 From: Javier Arce Date: Mon, 15 Jun 2015 18:35:20 +0200 Subject: [PATCH 1/2] Prevents an error when value is an integer --- .../javascripts/cartodb/table/menu_modules/legend_editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js b/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js index 57a222d0be..cf2e4ee7c5 100644 --- a/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js +++ b/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js @@ -220,7 +220,7 @@ cdb.admin.mod.LegendEditorItem = cdb.core.View.extend({ var tempModel = new cdb.core.Model(); var value = this.model.get("value") || ""; - var hasURL = value.indexOf("http") != -1; + var hasURL = value.toString().indexOf("http") != -1; var color = hasURL ? "" : value; var file = hasURL ? value : ""; From 433fc8a7fa8a8aba449fed2801dc69eb6cd3e9b0 Mon Sep 17 00:00:00 2001 From: Javier Arce Date: Thu, 2 Jul 2015 15:22:54 +0200 Subject: [PATCH 2/2] Adds !== comparator --- .../javascripts/cartodb/table/menu_modules/legend_editor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js b/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js index cf2e4ee7c5..aa04b1f734 100644 --- a/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js +++ b/lib/assets/javascripts/cartodb/table/menu_modules/legend_editor.js @@ -220,7 +220,7 @@ cdb.admin.mod.LegendEditorItem = cdb.core.View.extend({ var tempModel = new cdb.core.Model(); var value = this.model.get("value") || ""; - var hasURL = value.toString().indexOf("http") != -1; + var hasURL = value.toString().indexOf("http") !== -1; var color = hasURL ? "" : value; var file = hasURL ? value : "";