From 1b95a474ac502f01d98d97fc53b46883b8291cf6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jes=C3=BAs=20Arroyo=20Torrens?= <jarroyo@cartodb.com>
Date: Wed, 31 Mar 2021 09:10:57 +0200
Subject: [PATCH] Enable rubocop linter/constant

---
 .rubocop.yml            |  8 --------
 lib/tasks/services.rake | 23 +++++++++++------------
 package.json            |  2 +-
 3 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 37d9e7c7fb..f57f051a9c 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -190,11 +190,3 @@ Rails/UnknownEnv:
     - production
     - staging
     - test
-
-
-####################
-#  Lint
-####################
-
-Lint/ConstantDefinitionInBlock:
-  Enabled: false
diff --git a/lib/tasks/services.rake b/lib/tasks/services.rake
index 9f23603805..c44a75bd73 100644
--- a/lib/tasks/services.rake
+++ b/lib/tasks/services.rake
@@ -1,18 +1,17 @@
-namespace :cartodb do
-  namespace :services do
-
-    # Prefixes corresponding to User columns names/REDIS keys that store providers
-    DS_PROVIDED_SERVICES = ['geocoder', 'routing', 'isolines'].freeze
+# Prefixes corresponding to User columns names/REDIS keys that store providers
+DS_PROVIDED_SERVICES = ['geocoder', 'routing', 'isolines'].freeze
 
-    # service provider names
-    DS_PROVIDERS = ['heremaps', 'google', 'mapzen', 'mapbox', 'tomtom', 'geocodio'].freeze
+# service provider names
+DS_PROVIDERS = ['heremaps', 'google', 'mapzen', 'mapbox', 'tomtom', 'geocodio'].freeze
 
-    # Prefixes/infixes corresponding to User columns names/REDIS keys that store quotas / soft limits
-    # note that there's a couple of naming incosistence due to historical reasons:
-    # * here_isolines refers to isolines in general, not only those provided by here
-    # * mapzen_routing refers to routing in general
-    DS_SERVICES = ['geocoding', 'here_isolines', 'mapzen_routing'].freeze
+# Prefixes/infixes corresponding to User columns names/REDIS keys that store quotas / soft limits
+# note that there's a couple of naming incosistence due to historical reasons:
+# * here_isolines refers to isolines in general, not only those provided by here
+# * mapzen_routing refers to routing in general
+DS_SERVICES = ['geocoding', 'here_isolines', 'mapzen_routing'].freeze
 
+namespace :cartodb do
+  namespace :services do
     def assert_valid_arg(args, parameter, accepted_values: nil)
       value = args[parameter]
       if value.blank?
diff --git a/package.json b/package.json
index 691d511103..57aed2fc57 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cartodb-ui",
-  "version": "1.0.0-assets.231",
+  "version": "1.0.0-assets.232",
   "description": "CARTO UI frontend",
   "repository": {
     "type": "git",