Merge pull request #16359 from CartoDB/bug/sc-186291/dsc-admin-notification-about-seat-limit-reached

NEWS.md

@@ -67,6 +67,7 @@ Development
 - Fix scrolling on widget's sidebar in builder [#16350](https://github.com/CartoDB/cartodb/pull/16350)
 - Fix Auth URL generation while establishing a connection with Google Drive [#16357](https://github.com/CartoDB/cartodb/pull/16357)
 - Fix adding license metadata to a dataset [#16356](https://github.com/CartoDB/cartodb/pull/16356)
+- Fix notifications when organization seats limit is reached [#16359](https://github.com/CartoDB/cartodb/pull/16359)
 
 4.45.0 (2021-04-14)
 -------------------

app/models/carto/organization.rb

@@ -140,7 +140,7 @@ module Carto
     end
 
     def notify_if_seat_limit_reached
-      ::Resque.enqueue(::Resque::OrganizationJobs::Mail::SeatLimitReached, id) if will_reach_seat_limit?
+      ::Resque.enqueue(::Resque::OrganizationJobs::Mail::SeatLimitReached, id) if reached_seats_limit?
     end
 
     def database_name
@@ -249,8 +249,8 @@ module Carto
       assets.map { |asset| Carto::Asset.find(asset.id) }.map(&:destroy).all?
     end
 
-    def will_reach_seat_limit?
-      remaining_seats <= 1
+    def reached_seats_limit?
+      remaining_seats < 1
     end
 
     def authentication_methods_available