cartodb4/node-pg-copy-streams
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #8 from CartoDB/copyto-detach-connection-after-done

Browse Source 
Do not detach streams before finishing
This commit is contained in:
Daniel G. Aubert 2019-05-24 17:20:37 +02:00 committed by GitHub
commit be101502d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS.carto.md
View File

@ -3,6 +3,9 @@
## v2.2.0-carto.1 ## v2.2.0-carto.1
Released 2018-mm-dd Released 2018-mm-dd
Bug fixes:
* Copy to: ensure stream is detached when finished
## v1.2.0-carto.3 ## v1.2.0-carto.3
Released 2018-11-21 Released 2018-11-21

2
copy-to.js
View File

@ -23,6 +23,7 @@ CopyStreamQuery.prototype.submit = function(connection) {
connection.query(this.text) connection.query(this.text)
this.connection = connection this.connection = connection
this.connection.removeAllListeners('copyData') this.connection.removeAllListeners('copyData')
this.on('end', () => this._detach())
connection.stream.pipe(this) connection.stream.pipe(this)
} }
@ -84,7 +85,6 @@ CopyStreamQuery.prototype._transform = function(chunk, enc, cb) {
case code.ErrorResponse: case code.ErrorResponse:
case code.CopyDone: case code.CopyDone:
pushBufferIfneeded(); pushBufferIfneeded();
this._detach()
this.push(null) this.push(null)
return cb(); return cb();
break; break;