From 6b029e98fc709756c9033cca8080029d0aa33a71 Mon Sep 17 00:00:00 2001
From: Patrick Hogan <patrick@callinize.com>
Date: Sun, 21 Dec 2014 14:49:25 -0800
Subject: [PATCH] Allow for blank tokens due to dynamic data

Metadata for users such as name, email, etc are not always present for users.  For example, I am running express and I want to log the %x{company}%x{username} so that when I look at my logs I can immediately understand which user this affects.  Or for example, I could log %x{payingOrTial} the type of user.

This works well when the user is logged in.  However, my logger encompasses everything.  I log when the server boots up.  I log during the login screen where a user is not yet logged in.  In these circumstances there is no way to retrieve this metadata.

So for example

```
"username": function () {
            var session = require('continuation-local-storage').getNamespace('api.callinize');
            if(!session) session = require('continuation-local-storage').getNamespace('dashboard.callinize');
            var username = session && session.get('user') && session.get('user').username;
            if(!username) return "";
            return " " + username + " ";
        }
```

I try to get the metadata.  If I get no metdata I return a blank string.  Unfortunately, in the current implementation, due to the OR operator, even if I have a replacement of "" || matchedString,

```
  replaceToken(conversionCharacter, loggingEvent, specifier) ||
          matchedString;
```

the blank string equals false and puts the token in the log instead of the blank string.  This makes the log lines get long with information that is not relevant.  The better thing to do is simply allow for blank strings.  This lets the user have control over their logs and also allows for more metadata to go in the logs, without having to pick only metadata that is always present.
---
 lib/layouts.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/layouts.js b/lib/layouts.js
index 270f336..94f273d 100644
--- a/lib/layouts.js
+++ b/lib/layouts.js
@@ -295,9 +295,7 @@ function patternLayout (pattern, tokens) {
       } else {
         // Create a raw replacement string based on the conversion
         // character and specifier
-        var replacement = 
-          replaceToken(conversionCharacter, loggingEvent, specifier) || 
-          matchedString;
+        var replacement = replaceToken(conversionCharacter, loggingEvent, specifier);
 
         // Format the replacement according to any padding or
         // truncation specified