don't create functions in a loop

test/configureNoLevels-test.js

@@ -68,29 +68,33 @@ function getTopLevelContext(nop, configToTest, name) {
 
 showProgress('Populating batch object...');
 
-// Populating the batches programmatically, as there are 
-// (configs.length x strLevels.length x strLevels.length) = 324 
-// possible test combinations
-for (var cfg in configs) {
-  var configToTest = configs[cfg];
-  var nop = configToTest === 'nop';
-  var context;
-  if (nop) {
-    context = 'Setting up loggers with initial levels, then NOT setting a configuration,';
-  }
-  else {
-    context = 'Setting up loggers with initial levels, then setting a configuration which '+cfg+',';
-  }
+function checkForMismatch(topic) {
+  var er = topic.log4js.levels.toLevel(topic.baseLevel)
+    .isLessThanOrEqualTo(topic.log4js.levels.toLevel(topic.comparisonLevel));
 
-  showProgress('Setting up the vows batch and context for '+context);
-  // each config to be tested has its own vows batch with a single top-level context
-  var batch={};
-  batch[context]= getTopLevelContext(nop, configToTest, context);
-  batches.push(batch);
+  assert.equal(
+    er, 
+    topic.expectedResult, 
+    'Mismatch: for setLevel(' + topic.baseLevel + 
+      ') was expecting a comparison with ' + topic.comparisonLevel + 
+      ' to be ' + topic.expectedResult
+  );
+}
 
-  // each top-level context has strLevels sub-contexts, one per logger 
-  // which has set to a specific level in the top-level context's topic
-  strLevels.forEach(function (baseLevel) {
+function checkExpectedResult(topic) {
+  var result = topic.log4js
+    .getLogger(getLoggerName(topic.baseLevel))
+    .isLevelEnabled(topic.log4js.levels.toLevel(topic.comparisonLevel));
+  
+  assert.equal(
+    result, 
+    topic.expectedResult, 
+    'Failed: ' + getLoggerName(topic.baseLevel) + 
+      '.isLevelEnabled( ' + topic.comparisonLevel + ' ) returned ' + result
+  );
+}
+
+function setupBaseLevelAndCompareToOtherLevels(baseLevel) {
   var baseLevelSubContext = 'and checking the logger whose level was set to '+baseLevel ;
   var subContext = { topic: baseLevel };
   batch[context][baseLevelSubContext] = subContext;
@@ -98,7 +102,13 @@ for (var cfg in configs) {
   // each logging level has strLevels sub-contexts,
   // to exhaustively test all the combinations of 
   // setLevel(baseLevel) and isLevelEnabled(comparisonLevel) per config
-    strLevels.forEach(function (comparisonLevel) {
+  strLevels.forEach(compareToOtherLevels(subContext));
+}
+
+function compareToOtherLevels(subContext) {
+  var baseLevel = subContext.topic;
+
+  return function (comparisonLevel) {
     var comparisonLevelSubContext = 'with isLevelEnabled('+comparisonLevel+')';
 
     // calculate this independently of log4js, but we'll add a vow 
@@ -119,36 +129,39 @@ for (var cfg in configs) {
     };
 
     var vow = 'should return '+expectedResult;
-      subContext[comparisonLevelSubContext][vow] = function(topic) {
-        var result = topic.log4js
-          .getLogger(getLoggerName(topic.baseLevel))
-          .isLevelEnabled(topic.log4js.levels.toLevel(topic.comparisonLevel));
-
-        assert.equal(
-          result, 
-          topic.expectedResult, 
-          'Failed: ' + getLoggerName(topic.baseLevel) + 
-            '.isLevelEnabled( ' + topic.comparisonLevel + ' ) returned ' + result
-        );
-      };
+    subContext[comparisonLevelSubContext][vow] = checkExpectedResult;
     
     // the extra vow to check the comparison between baseLevel and
     // comparisonLevel we performed earlier matches log4js'
     // comparison too
     var subSubContext = subContext[comparisonLevelSubContext];
-      subSubContext['finally checking for comparison mismatch with log4js'] = function(topic) {
-        var er = topic.log4js.levels.toLevel(topic.baseLevel)
-          .isLessThanOrEqualTo(topic.log4js.levels.toLevel(topic.comparisonLevel));
-        assert.equal(
-          er, 
-          topic.expectedResult, 
-          'Mismatch: for setLevel(' + topic.baseLevel + 
-            ') was expecting a comparison with ' + topic.comparisonLevel + 
-            ' to be ' + topic.expectedResult
-        );
+    subSubContext['finally checking for comparison mismatch with log4js'] = checkForMismatch;
   };
-    });
-  });
+}
+
+// Populating the batches programmatically, as there are 
+// (configs.length x strLevels.length x strLevels.length) = 324 
+// possible test combinations
+for (var cfg in configs) {
+  var configToTest = configs[cfg];
+  var nop = configToTest === 'nop';
+  var context;
+  if (nop) {
+    context = 'Setting up loggers with initial levels, then NOT setting a configuration,';
+  }
+  else {
+    context = 'Setting up loggers with initial levels, then setting a configuration which '+cfg+',';
+  }
+
+  showProgress('Setting up the vows batch and context for '+context);
+  // each config to be tested has its own vows batch with a single top-level context
+  var batch={};
+  batch[context]= getTopLevelContext(nop, configToTest, context);
+  batches.push(batch);
+
+  // each top-level context has strLevels sub-contexts, one per logger 
+  // which has set to a specific level in the top-level context's topic
+  strLevels.forEach(setupBaseLevelAndCompareToOtherLevels);
 }
 
 showProgress('Running tests');