Juan Ignacio Sánchez Lara
c3c28dfd5e
Simpler quota check matching
2018-04-11 12:14:11 +02:00
Juan Ignacio Sánchez Lara
33f23e0902
Minor instead of patch for TomTom support at Python lib
2018-04-10 11:36:34 +02:00
Juan Ignacio Sánchez Lara
94aeceb894
Fixes encoding
2018-04-10 09:32:23 +02:00
Juan Ignacio Sánchez Lara
e21d3e2e70
TomTom Python lib version
2018-04-09 16:29:00 +02:00
Juan Ignacio Sánchez Lara
3b121c8793
Merge branch 'master' into Added_TomTom_services
2018-04-09 13:07:04 +02:00
Mario de Frutos
50aa537a7a
Bump python library version
2018-03-27 16:36:04 +02:00
Juan Ignacio Sánchez Lara
2a47000f32
coordinates_to_polygon should always return multipolygon to avoid inconsistencies
2018-03-27 16:36:04 +02:00
Antonio
552a7d4886
Fixing Mapbox geocoding validity checks
2018-03-16 16:55:08 +01:00
Antonio
e78063ae75
Fixed geocoding validity
2018-03-16 16:01:00 +01:00
Antonio
d66804b93d
Fixed test
2018-03-16 14:47:56 +01:00
Antonio
6572891036
Merging changes
2018-03-16 14:30:01 +01:00
Antonio
c90859e58b
Fixed error when checking quota
2018-03-14 16:26:00 +01:00
Antonio
f5cbc195cc
Fixed tests
2018-03-14 13:31:00 +01:00
Mario de Frutos
0196292093
Bump version
2018-03-14 11:20:12 +01:00
Mario de Frutos
f652a52a8d
Use routing quota instead of monthly quota
2018-03-14 11:19:48 +01:00
Antonio
ffa1080277
isochrones fix
2018-03-13 14:58:40 +01:00
Antonio
39800122b2
Merging
2018-03-02 17:25:32 +01:00
Antonio
c9d0f0447f
Added server functions (untested)
2018-03-02 16:40:12 +01:00
Antonio
596189185f
Added configuration for TomTom services
2018-03-02 16:01:22 +01:00
Antonio
35f743164e
Keep deleting points that got None
2018-03-02 10:27:37 +01:00
Antonio
4308b5f351
Remove too far away points (filtering by time)
2018-03-02 10:23:58 +01:00
Antonio
9fb04fdc24
Version bumped
2018-02-28 11:49:23 +01:00
Antonio
a2fd0bf142
Merge branch 'master' into 1333-Mapbox_isolines_almost_shoreline
2018-02-28 11:48:00 +01:00
Mario de Frutos
ad46de1156
Bump version and update NEWS.md
2018-02-27 18:11:50 +01:00
Mario de Frutos
97f1611d62
Only get mapzen/mapbox values in case the provider of routing is one of these
2018-02-27 18:09:21 +01:00
Antonio
bc4c9fea33
Using Mapbox returned destinations as coordinates for isolines
2018-02-26 12:45:08 +01:00
Antonio
177c19f935
Added TomTom isolines
2018-02-23 15:59:54 +01:00
Antonio Carlón
e646000f24
Merge pull request #468 from CartoDB/remove_legacy_mapzen
...
Remove legacy mapzen
2018-02-22 12:41:48 +01:00
Mario de Frutos
cbc19b869c
Fix CR suggestions
2018-02-22 11:14:33 +01:00
Mario de Frutos
e3f23adfdd
Bump to version 0.17.0
2018-02-21 19:14:47 +01:00
Mario de Frutos
39dabffb85
Now is not mandatory to have mapzen configuration becuase its deprecated as provider
2018-02-21 19:14:29 +01:00
Mario de Frutos
03e1d1ca61
Change default provider to mapbox instead of mapzen
2018-02-21 19:13:59 +01:00
Antonio
90d8d207eb
Added geocoding and routing services
2018-02-16 17:43:22 +01:00
Mario de Frutos
c14fb057d3
Update README.md
2018-02-14 11:03:51 +01:00
Mario de Frutos
9e247685b8
Merge pull request #465 from CartoDB/457-Fix_Mapbox_Python_tests
...
457 fix mapbox python tests
2018-02-14 10:21:29 +01:00
Juan Ignacio Sánchez Lara
1fdb4d3b3a
Pythonic refactor, importing single method
2018-02-13 18:24:21 +01:00
Juan Ignacio Sánchez Lara
029541f298
api_key -> mapbox_api_key rename refactor
2018-02-13 16:16:13 +01:00
Juan Ignacio Sánchez Lara
45d9edbba6
Mapbox test API key is supplied now through a MAPBOX_API_KEY environment variable
2018-02-13 15:58:10 +01:00
Antonio
8674dabeb2
Version bumped
2018-02-13 08:38:54 +01:00
Antonio
080a386b8f
Fixed mapbox requests and responses
2018-02-12 18:02:37 +01:00
Antonio
b65d003742
Using Mapbox permanent geocoder by default
2018-02-09 09:07:31 +01:00
Mario de Frutos
2f54ef7e4e
Merge pull request #452 from CartoDB/fix_misplaced_coordinate_polyline
...
Multiple fixes
2018-02-05 09:30:24 +01:00
Mario de Frutos
a791d02dcc
422 errors from mapbox return empty response
2018-02-02 14:11:22 +01:00
Mario de Frutos
e2612645c3
Bump to version 0.16.5
2018-02-02 13:18:47 +01:00
Mario de Frutos
c5fed2cc80
Check for empty coordinates when we transform to polygon
2018-02-02 13:18:32 +01:00
Mario de Frutos
a1f339376e
By default the polyline comes with 6 decimals so we avoid to use 5 by default
2018-02-02 13:17:56 +01:00
Mario de Frutos
5c7d1e9ac1
Solve some dependencies bugs
2018-02-02 12:29:48 +01:00
Mario de Frutos
6e54507b5a
Move exceptions to a proper place
2018-02-02 12:06:43 +01:00
Mario de Frutos
88ad551e4a
Bump python version to 0.16.4
2018-02-01 18:40:21 +01:00
Mario de Frutos
0df0b0d49c
Avoid treating quota exception as bug exception
2018-02-01 18:21:15 +01:00
Mario de Frutos
6ae8aa45fd
CR changes
2018-01-31 16:13:20 +01:00
Mario de Frutos
07f00cc0ae
Added tests for the client/channel part of google
2018-01-31 13:17:36 +01:00
Mario de Frutos
544e0fa763
Going green with non empty request strings
2018-01-31 12:25:35 +01:00
Mario de Frutos
2bbd6bac91
Going red with non empty request string
2018-01-31 12:25:18 +01:00
Mario de Frutos
2f8dbbb5dc
Dont raise exception when empty params passed to HERE geocoder
2018-01-31 12:16:13 +01:00
Mario de Frutos
56c90cc541
Bump version to 0.16.3
2018-01-31 12:12:52 +01:00
Mario de Frutos
3583cc6f47
Going green with empty requests that leads to 404 responses
2018-01-31 12:11:25 +01:00
Mario de Frutos
850dc09a4f
Going green with empty responses
2018-01-31 12:11:25 +01:00
Mario de Frutos
876bae6b56
Going red with bad request parameters
2018-01-31 12:11:25 +01:00
Antonio
e0b1632fa8
Fixed tests
2018-01-30 09:13:43 +01:00
Antonio
51bf6c2a43
Fixed valid Mapbox types
2018-01-29 18:39:11 +01:00
Antonio
1a2785dff4
Version bumped
2018-01-18 15:21:06 +01:00
Antonio
d442fab9da
Fixed encoding problem with Mapbox geocoding
2018-01-18 11:55:25 +01:00
Antonio
6c53846e33
Fixed country code problem. Added test
2018-01-16 16:36:24 +01:00
Mario de Frutos
5781f78c7f
Revert "Removed suspect import"
...
This reverts commit 9c1ec1ddde
2018-01-16 11:04:29 +01:00
Antonio
9c1ec1ddde
Removed suspect import
2018-01-16 10:02:41 +01:00
Antonio
6339623ad9
Added ServiceManager for Mapbox services
2018-01-12 12:24:17 +01:00
Antonio
7dc87ad38e
Rotating API keys for Mapbox
2018-01-11 10:18:01 +01:00
Antonio Carlón
b10f48166d
Merge branch 'development' into Clients_for_Mapbox_services
2018-01-10 12:50:20 +01:00
Mario de Frutos
6047300259
Move the new params parameter to the end to avoid breaking backward compatibility
2018-01-10 12:41:08 +01:00
Antonio
c0cc5fe6a7
Logging GetMeta and GetData parameters
2018-01-10 12:31:49 +01:00
Antonio
d3e01b4d53
Reverted default providers to mapzen to allow dark deployment
2018-01-09 17:15:03 +01:00
Antonio
dd6ad0119c
Added CR suggestions
2018-01-09 16:21:55 +01:00
Antonio
e7c0628751
Solving errors and refactor
2018-01-04 15:00:52 +01:00
Antonio
51d97228dc
Added CR suggestions
2018-01-04 12:30:58 +01:00
Antonio
801c5a3cee
Solved data conversion issues
2018-01-03 14:14:25 +01:00
Antonio
941af522ae
Bumped Python library version
2018-01-03 09:47:55 +01:00
Antonio
bb86f080fc
Added limits/quotas and tests for Mapbox services
2018-01-02 16:21:57 +01:00
Antonio
c46174210d
Added cdb_dataservices_server functions
2017-12-29 14:07:51 +01:00
Antonio
af07def7fc
Added parameters for PLPython functions
2017-12-28 11:36:02 +01:00
Antonio
bc9dbdbb72
Removed routing client from isolines
2017-12-27 16:31:29 +01:00
Antonio
dabd596271
Added QPS decorator
2017-12-27 14:55:50 +01:00
Antonio
8c0af7d51d
Pure Python implementation of clients for Mapbox services
2017-12-27 13:43:14 +01:00
Juan Ignacio Sánchez Lara
da8e5f6e36
Extract parsing and return fix
2017-11-14 13:15:11 +01:00
Juan Ignacio Sánchez Lara
f540a3d6b3
Bump version
2017-11-13 19:09:52 +01:00
Juan Ignacio Sánchez Lara
e26bf2a803
Proper parsing of client and channel parameters
2017-11-13 19:09:17 +01:00
Juan Ignacio Sánchez Lara
43dd9f6ada
Better regexp and wrong input handling
2017-11-08 17:33:00 +01:00
Juan Ignacio Sánchez Lara
2cf4072b21
Support for multiple parameters at client (such as channel)
2017-11-08 11:07:35 +01:00
Rafa de la Torre
1936374124
Version 0.15.5 of the python library
2017-10-06 16:03:03 +02:00
Rafa de la Torre
3ed41b065a
Marginally improve tests for #382
2017-10-06 15:27:51 +02:00
Rafa de la Torre
6c3260b6ee
Move credentials tests to GoogleMapsClientFactoryTestCase
2017-10-06 15:23:44 +02:00
Rafa de la Torre
5005572f89
Add tests for GoogleMapsClientFactory
2017-10-06 15:18:51 +02:00
Rafa de la Torre
27fde5a910
Use "{id}:{secret}" as caching key
2017-10-06 15:12:05 +02:00
Rafa de la Torre
b8e1120169
Revert "Use a different client_id for the test"
...
This reverts commit 854fbb803c
2017-10-06 15:03:08 +02:00
Rafa de la Torre
8e33cf9723
Fix google services key validity check #382
2017-10-06 14:40:53 +02:00
Rafa de la Torre
7b988e3f78
Add tests for #382
...
The examples are not arbitrary: base64 by default ignores characters
that are not in its alphabet. When decoding, the dashes and underscores
are not b64-valid and therefore ignored, resulting in a sequence with
the wrong padding.
2017-10-06 14:37:26 +02:00
Rafa de la Torre
f79ac9297d
Add again the check for valid credentials
...
As our check is more strict that the one provided in googlemaps library.
2017-10-06 13:44:08 +02:00
Rafa de la Torre
854fbb803c
Use a different client_id for the test
2017-10-06 13:41:50 +02:00
Rafa de la Torre
d029ad7041
GoogleMapsClientFactory to persist clients #401
...
Add a GoogleMapsClientFactory and remove the check for valid key,
which is no longer needed, as it is done in the google library.
2017-10-06 12:05:34 +02:00
Rafa de la Torre
445d4cf97d
Upgrade googlemaps python library to v2.5.1
...
This closes #383
2017-10-04 16:22:33 +02:00
Rafa de la Torre
f0a3249b4e
Keep metrics keys consistent
...
See cartodb repo and our internal documentation:
https://github.com/CartoDB/cartodb/search?utf8=%E2%9C%93&q=failed_responses&type=
2017-09-07 11:24:38 +02:00
Mario de Frutos
475df918c7
Fix invalid geometries due to generalize option
...
They add a note saying that use their simplification option could
lead to a self-intersection (which is the problem we have) and it's
creating invalid geometries
See it here https://mapzen.com/documentation/mobility/isochrone/api-reference/#other-request-parameters
2017-08-30 17:35:08 +02:00
Mario de Frutos
c13dba71a4
Deactivated DO credits usage for users that have quota
...
See https://github.com/CartoDB/bigmetadata/issues/215
2017-08-24 14:35:20 +02:00
Daniel García Aubert
13a876b854
Fix typo while logging caught error in geocoder
2017-07-21 14:43:41 +02:00
Daniel García Aubert
1503b5bb2b
Release artifacts:
...
- Server extension version 0.25.0
- Client extension version 0.18.0
- Python library version 0.15.2
2017-07-13 15:34:44 +02:00
Rafa de la Torre
49a53e4cd7
Fix non-zero-padded days in tests
...
See https://github.com/CartoDB/dataservices-api/issues/204 and related
tickets.
2017-07-07 15:14:27 +02:00
Mario de Frutos
61efb66aba
Add an extra check for google credentials
...
If the user has a wrong base64 padded secret key the googlemaps
python library is returning "TypeError: Incorrect padding" which
is very hard to understand. So now we check if the secret key is
a valid base64 string
2017-05-26 11:51:32 +02:00
Rafael Porres Molina
37eeab5b9e
past participle of set is set
2017-05-24 15:41:12 +02:00
Javier Goizueta
524d15c1a9
Fix uses of cartodb cdb_conf functions
2017-03-30 18:10:53 +02:00
Javier Goizueta
aac89e0236
New versions 0.16.0 (client), 0.23.0 (server), 0.15.0 (python)
2017-03-28 17:53:40 +02:00
Javier Goizueta
f0b0a9e7f2
Merge pull request #355 from CartoDB/346-user-rate-limits
...
Service rate limits
2017-03-28 17:48:46 +02:00
Rafa de la Torre
77dfda11d9
Merge pull request #353 from CartoDB/udpate-docs
...
Fix links and improve readability
2017-03-28 11:53:07 +02:00
Javier Goizueta
2c15110255
Rename constructor arguments for consistency
2017-03-28 10:53:16 +02:00
Javier Goizueta
63c03894cc
Fix bugs
2017-03-21 15:45:05 +01:00
Javier Goizueta
942c6ac63d
Fix indentation
2017-03-21 15:44:50 +01:00
Javier Goizueta
208469f534
Add rate limits configuration writing tests
2017-03-21 15:43:33 +01:00
Javier Goizueta
73f97128ed
Reorganization of configuration modules, fix circular dependencies
...
The new module cartodb_services/config is intended for services configuration objects
Some legacy configuration objects remain under cartodb_services/metrics.
The refactored configuration backends are also not moved here
2017-03-21 15:42:53 +01:00
Javier Goizueta
945c6cd685
WIP: support for storing rate limits configuration
2017-03-16 19:12:39 +01:00
Javier Goizueta
7f6c19b292
Minor changes for clarity
...
* ServiceManager check method renamed as assert_within_limits
* Legacy classes moved to separate files
2017-03-16 17:59:22 +01:00
Javier Goizueta
9a04ad06a0
Move rate limits out of Config
...
The (legacy) Config object rate limit-related modifications are reverted.
For the legacy case, configuration is handled in a specific RateLimits builder class.
2017-03-15 19:32:50 +01:00
Javier Goizueta
cebd7d2141
Apply ServiceManager to Google Geocoder
...
Note that the Goolge geocoder uses QuotaService to account for used quota,
but it doesn't have a quota limit.
2017-03-15 17:58:14 +01:00
Javier Goizueta
680206a437
Missing import
2017-03-15 12:51:56 +01:00
Javier Goizueta
77b5ff0b9e
Fix problem with db config default arguments
2017-03-15 12:46:25 +01:00
Javier Goizueta
05b29967c7
Merge branch 'development' into 346-user-rate-limits
...
# Conflicts:
# README.md
# server/extension/sql/20_geocode_street.sql
# server/lib/python/cartodb_services/cartodb_services/metrics/config.py
2017-03-14 19:00:53 +01:00
Javier Goizueta
6c5ca97468
Complete rate-limiting for Mapzen & Here gecoding
...
ServiceManager class has been introduced to handle service configuration at
SQL level (with a LegacyServiceManager alternative for non-refactored services).
These new classes take the responsibility of rate limits and quota checking.
Tests have been added for ServiceManager and rate limits, but currently they
check only the limits configuration since Lua support would be needed
to use rratelimit with MockRedis.
2017-03-14 18:51:18 +01:00
Rafa de la Torre
a64557b50e
New version 0.14.1 of python library
2017-03-13 15:10:03 +01:00
Rafa de la Torre
4e14e9b0c0
Fix links and improve readability
2017-03-13 13:12:06 +01:00
Rafa de la Torre
26d025a5d1
Remove tests that no longer apply #206
2017-03-10 13:15:56 +01:00
Rafa de la Torre
80e7ed90a8
Make get_metrics read just zero-padded dates #206
2017-03-10 13:14:36 +01:00
Javier Goizueta
250d384d06
Geocoder, per user, cofigurable rate limits
...
WIP, specially the GeocoderConfig part is flaky and ugly
2017-03-09 18:42:48 +01:00
Rafa de la Torre
fc1e05658e
Bump version of python library to 0.14.0
2017-03-08 13:13:19 +01:00
Rafa de la Torre
b8ec3dc306
Merge pull request #342 from CartoDB/remove-mapzen-forcing-layers-equal-address
...
Remove the search_type if its address from the params sent to Mapzen
2017-03-08 13:07:07 +01:00
Rafa de la Torre
ffdb6524da
Fix bug: search_type can be None
...
Found via unit test:
```sh
$ nosetests -x test/
....................................................................................E
======================================================================
ERROR: test_geocode_address_with_valid_params (test.test_mapzengeocoder.MapzenGeocoderTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/requests_mock/mocker.py", line 177, in inner
return func(*args, **kwargs)
File "/home/ubuntu/src/dataservices-api/server/lib/python/cartodb_services/test/test_mapzengeocoder.py", line 100, in test_geocode_address_with_valid_params
country='ESP')
File "/home/ubuntu/src/dataservices-api/server/lib/python/cartodb_services/cartodb_services/mapzen/qps.py", line 28, in wrapped_function
return QPSService(retry_timeout=timeout, queries_per_second=qps).call(original_function, *args, **kwargs)
File "/home/ubuntu/src/dataservices-api/server/lib/python/cartodb_services/cartodb_services/mapzen/qps.py", line 53, in call
raise e
AttributeError: 'NoneType' object has no attribute 'lower'
----------------------------------------------------------------------
Ran 85 tests in 0.140s
FAILED (errors=1)
```
2017-03-08 10:19:32 +01:00
Rafa de la Torre
82a7477d37
Beautify code
2017-03-08 10:14:37 +01:00
Rafa de la Torre
25ba9866ae
Small PoC with rratelimit #346
2017-03-07 13:31:06 +01:00
Javier Goizueta
6dca3f4e58
Change default arguent value for clarity
...
It is valie to pass None in service_params arguments, so make it the default.
2017-03-06 19:01:05 +01:00
Javier Goizueta
d01170471e
Missing @property
2017-03-06 18:58:00 +01:00
Javier Goizueta
89762c1a7f
Use service params configuration in Mapzen services
2017-03-06 15:25:11 +01:00
Javier Goizueta
1081e81047
Add Mapzen service params to configuration
2017-03-06 14:34:23 +01:00
Javier Goizueta
29cdd8099a
Add service configuration (URL, etc) for Mapzen Geocoding
2017-03-06 10:20:20 +01:00
Javier Goizueta
c0374f5800
Add service configuration (URL, etc) for Here Routing
2017-03-02 17:55:08 +01:00
Javier Goizueta
677d2acead
Add service configuration (URL, etc) for Here Geocoding
...
See #343
2017-03-02 17:15:14 +01:00
nygeog
a9e942a48b
remove the search_type if its address from the params sent to mapzen
...
remove the search_type if its address from the params sent to mapzen
2017-02-02 10:23:09 -05:00
Mario de Frutos
c364c7f5ed
Merge pull request #339 from CartoDB/obs-getdata-getmeta-wrappers
...
Obs_GetData OBS_GetMeta wrappers
2017-02-01 10:05:52 +01:00
Mario de Frutos
c550a5d4e9
Merge pull request #321 from CartoDB/fix-default-isolines-provider
...
Change default isolines provider
2017-02-01 09:41:21 +01:00
John Krauss
8204bb3451
fix error-causing raise (which obscures real error)
2017-01-26 12:27:29 +01:00
Rafa de la Torre
a0dd7c7497
Fix tests: zero-pad months in redis key #335
2017-01-04 11:11:27 +01:00
Rafa de la Torre
9700ae966c
Remove uneeded math for simplicity's sake
2016-12-28 14:44:48 +01:00
Javier Goizueta
bdf9627586
Fix typo
...
I needed to fix this; I felt some kitten was being killed somewhere
because of this. And it made baby Jesus cry.
2016-12-27 17:11:39 +01:00
Mario de Frutos
80b23c62c3
QPS timeout was badly calculated
...
timedelta microseconds is just the microseconds part of the timedelta
object not the elapsed time in microseconds.
I've change to use the total_seconds method to get all the elapsed time
in seconds and transform to miliseconds.
2016-12-23 11:40:30 +01:00
