cartodb4/dataservices-api
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #595 from CartoDB/development

Browse Source 
Fix origin/destination in isolines
This commit is contained in:
Antonio Carlón 2020-03-27 09:13:29 +01:00 committed by GitHub
commit f68f997eb7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/lib/python/cartodb_services/cartodb_services/here/routing.py
View File

@ -115,7 +115,7 @@ class HereMapsRoutingIsoline(Traceable):
def __parse_source_param(self, source, options): def __parse_source_param(self, source, options):
key = 'start' key = 'start'
if 'is_destination' in options and options['is_destination']: if 'is_destination' in options and options['is_destination'].lower() == 'true':
key = 'destination' key = 'destination'
return {key: source} return {key: source}

2
server/lib/python/cartodb_services/setup.py
View File

@ -10,7 +10,7 @@ from setuptools import setup, find_packages
setup( setup(
name='cartodb_services', name='cartodb_services',
version='0.23.1', version='0.23.2',
description='CartoDB Services API Python Library', description='CartoDB Services API Python Library',

10
server/lib/python/cartodb_services/test/test_heremapsrouting.py
View File

@ -204,6 +204,16 @@ class HereMapsRoutingIsolineTestCase(unittest.TestCase):
'fastest;car;traffic:false;motorway:-1') 'fastest;car;traffic:false;motorway:-1')
def test_source_parameters_works_properly(self, req_mock): def test_source_parameters_works_properly(self, req_mock):
req_mock.register_uri('GET', requests_mock.ANY,
text=self.GOOD_RESPONSE)
response = self.routing.calculate_isochrone('geo!33.0,1.0', 'car',
['1000', '2000'],
['is_destination=false'])
parsed_url = urlparse(req_mock.request_history[0].url)
url_params = parse_qs(parsed_url.query)
self.assertEqual(url_params['start'][0], 'geo!33.0,1.0')
def test_destination_parameters_works_properly(self, req_mock):
req_mock.register_uri('GET', requests_mock.ANY, req_mock.register_uri('GET', requests_mock.ANY,
text=self.GOOD_RESPONSE) text=self.GOOD_RESPONSE)
response = self.routing.calculate_isochrone('geo!33.0,1.0', 'car', response = self.routing.calculate_isochrone('geo!33.0,1.0', 'car',