cartodb4/dataservices-api
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #628 from CartoDB/bug/sc-254346/opianalytics-here-isolines-returning-null

Browse Source
This commit is contained in:
Moisés Calzado 2022-09-05 13:24:52 +02:00 committed by GitHub
commit 94512eea59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
.github/workflows/main.yml vendored
View File

@ -8,18 +8,17 @@ jobs:
matrix: matrix:
pg_version: [10, 12] pg_version: [10, 12]
env: env:
PG_VERSION: ${{ matrix.pg_version }} PG_VERSION: ${{ matrix.pg_version }}
steps: steps:
- uses: actions/checkout@v1 - uses: actions/checkout@v1
- name: Set CLOUDSDK_PYTHON path - name: Set CLOUDSDK_PYTHON path
run: echo "CLOUDSDK_PYTHON=/usr/bin/python" >> $GITHUB_ENV run: echo "CLOUDSDK_PYTHON=/usr/bin/python" >> $GITHUB_ENV
- name: Set up docker registry - name: Setup gcloud authentication
env: uses: google-github-actions/setup-gcloud@v0
SA_TO_USE: ${{ secrets.GCS }} with:
run: | service_account_key: ${{ secrets.GCS }}
echo "${SA_TO_USE}" | base64 -d | docker login -u _json_key --password-stdin https://gcr.io
- name: Pull base image - name: Pull base image
run: docker pull gcr.io/cartodb-on-gcp-ci-testing/cartodb-postgresql-base:${{ matrix.pg_version }} run: docker pull gcr.io/cartodb-on-gcp-ci-testing/cartodb-postgresql-base:${{ matrix.pg_version }}
@ -47,9 +46,9 @@ jobs:
- name: Run python library tests - name: Run python library tests
run: docker-compose -f docker-compose.yaml exec -T postgres-server bash -c "cd /dataservices-api/server/ && MAPBOX_API_KEY=$MAPBOX_API_KEY TOMTOM_API_KEY=$TOMTOM_API_KEY GEOCODIO_API_KEY=$GEOCODIO_API_KEY nosetests lib/python/cartodb_services/test" run: docker-compose -f docker-compose.yaml exec -T postgres-server bash -c "cd /dataservices-api/server/ && MAPBOX_API_KEY=$MAPBOX_API_KEY TOMTOM_API_KEY=$TOMTOM_API_KEY GEOCODIO_API_KEY=$GEOCODIO_API_KEY nosetests lib/python/cartodb_services/test"
env: env:
MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }} MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }}
TOMTOM_API_KEY: ${{ secrets.TOMTOM_API_KEY }} TOMTOM_API_KEY: ${{ secrets.TOMTOM_API_KEY }}
GEOCODIO_API_KEY: ${{ secrets.GEOCODIO_API_KEY }} GEOCODIO_API_KEY: ${{ secrets.GEOCODIO_API_KEY }}
timeout-minutes: 5 timeout-minutes: 5
- name: Run server tests - name: Run server tests

5
NEWS.md
View File

@ -1,3 +1,8 @@
Sep 5th, 2022
==============
* Version `0.24.2` of the Python library
* Fix error calculating isolines with HERE
May 26th, 2021 May 26th, 2021
============== ==============
* Version `0.40.1` of the server extension * Version `0.40.1` of the server extension

5
server/lib/python/cartodb_services/cartodb_services/here/routing.py
View File

@ -345,6 +345,9 @@ class HereMapsRoutingIsolineV8(Traceable):
mode_params.update({'routingmode': mode_type}) mode_params.update({'routingmode': mode_type})
if not ('mode_traffic' in options and options['mode_traffic'] == 'enabled'): if not ('mode_traffic' in options and options['mode_traffic'] == 'enabled'):
mode_params.update({'departuretime': 'any'}) if 'is_destination' in options and options['is_destination'].lower() == 'true':
mode_params.update({'arrivaltime': 'any'})
else:
mode_params.update({'departuretime': 'any'})
return mode_params return mode_params

2
server/lib/python/cartodb_services/setup.py
View File

@ -10,7 +10,7 @@ from setuptools import setup, find_packages
setup( setup(
name='cartodb_services', name='cartodb_services',
version='0.24.1', version='0.24.2',
description='CartoDB Services API Python Library', description='CartoDB Services API Python Library',