cartodb4/crankshaft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix ordering problems in input columns

Browse Source
This commit is contained in:
Andy Eschbacher 2016-09-26 10:10:52 -04:00
parent 1148aa417a
commit 06452562b9
1 changed files with 38 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
src/py/crankshaft/test/test_pysal_utils.py
View File

@ -9,23 +9,23 @@ class PysalUtilsTest(unittest.TestCase):
"""Testing class for utility functions related to PySAL integrations""" """Testing class for utility functions related to PySAL integrations"""
def setUp(self): def setUp(self):
self.params = OrderedDict([("id_col", "cartodb_id"), self.params1 = OrderedDict([("id_col", "cartodb_id"),
("attr1", "andy"), ("attr1", "andy"),
("attr2", "jay_z"), ("attr2", "jay_z"),
("subquery", "SELECT * FROM a_list"),
("geom_col", "the_geom"),
("num_ngbrs", 321)])
self.params2 = OrderedDict([("id_col", "cartodb_id"),
("attr1", "price"),
("attr2", "sq_meters"),
("subquery", "SELECT * FROM a_list"), ("subquery", "SELECT * FROM a_list"),
("geom_col", "the_geom"), ("geom_col", "the_geom"),
("num_ngbrs", 321)]) ("num_ngbrs", 321)])
self.params2 = OrderedDict([("id_col", "cartodb_id"),
("numerator", "price"),
("denominator", "sq_meters"),
("subquery", "SELECT * FROM pecan"),
("geom_col", "the_geom"),
("num_ngbrs", 321)])
self.params3 = OrderedDict([("id_col", "cartodb_id"), self.params3 = OrderedDict([("id_col", "cartodb_id"),
("attr1", "numerator"), ("numerator", "sq_meters"),
("attr2", "denominator"), ("denominator", "price"),
("subquery", "SELECT * FROM pecan"), ("subquery", "SELECT * FROM pecan"),
("geom_col", "the_geom"), ("geom_col", "the_geom"),
("num_ngbrs", 321)]) ("num_ngbrs", 321)])
@ -39,20 +39,20 @@ class PysalUtilsTest(unittest.TestCase):
def test_query_attr_select(self): def test_query_attr_select(self):
"""Test query_attr_select""" """Test query_attr_select"""
ans = "i.\"andy\"::numeric As attr1, " \ ans1 = ("i.\"andy\"::numeric As attr1, "
"i.\"jay_z\"::numeric As attr2, " "i.\"jay_z\"::numeric As attr2, ")
ans2 = "i.\"price\"::numeric As attr1, " \ ans2 = ("i.\"price\"::numeric As attr1, "
"i.\"sq_meters\"::numeric As attr2, " "i.\"sq_meters\"::numeric As attr2, ")
ans3 = "i.\"numerator\"::numeric As attr1, " \ ans3 = ("i.\"sq_meters\"::numeric As attr1, "
"i.\"denominator\"::numeric As attr2, " "i.\"price\"::numeric As attr2, ")
ans_array = "i.\"_2013_dec\"::numeric As attr1, " \ ans_array = ("i.\"_2013_dec\"::numeric As attr1, "
"i.\"_2014_jan\"::numeric As attr2, " \ "i.\"_2014_jan\"::numeric As attr2, "
"i.\"_2014_feb\"::numeric As attr3, " "i.\"_2014_feb\"::numeric As attr3, ")
self.assertEqual(pu.query_attr_select(self.params), ans) self.assertEqual(pu.query_attr_select(self.params1), ans1)
self.assertEqual(pu.query_attr_select(self.params2), ans2) self.assertEqual(pu.query_attr_select(self.params2), ans2)
self.assertEqual(pu.query_attr_select(self.params3), ans3) self.assertEqual(pu.query_attr_select(self.params3), ans3)
self.assertEqual(pu.query_attr_select(self.params_array), ans_array) self.assertEqual(pu.query_attr_select(self.params_array), ans_array)
@ -60,21 +60,20 @@ class PysalUtilsTest(unittest.TestCase):
def test_query_attr_where(self): def test_query_attr_where(self):
"""Test pu.query_attr_where""" """Test pu.query_attr_where"""
ans = "idx_replace.\"andy\" IS NOT NULL AND " \ ans1 = ("idx_replace.\"andy\" IS NOT NULL AND "
"idx_replace.\"jay_z\" IS NOT NULL AND " \ "idx_replace.\"jay_z\" IS NOT NULL")
"idx_replace.\"jay_z\" <> 0"
ans_array = "idx_replace.\"_2013_dec\" IS NOT NULL AND " \ ans_array = ("idx_replace.\"_2013_dec\" IS NOT NULL AND "
"idx_replace.\"_2014_jan\" IS NOT NULL AND " \ "idx_replace.\"_2014_jan\" IS NOT NULL AND "
"idx_replace.\"_2014_feb\" IS NOT NULL" "idx_replace.\"_2014_feb\" IS NOT NULL")
self.assertEqual(pu.query_attr_where(self.params), ans) self.assertEqual(pu.query_attr_where(self.params1), ans1)
self.assertEqual(pu.query_attr_where(self.params_array), ans_array) self.assertEqual(pu.query_attr_where(self.params_array), ans_array)
def test_knn(self): def test_knn(self):
"""Test knn neighbors constructor""" """Test knn neighbors constructor"""
ans = "SELECT i.\"cartodb_id\" As id, " \ ans1 = "SELECT i.\"cartodb_id\" As id, " \
"i.\"andy\"::numeric As attr1, " \ "i.\"andy\"::numeric As attr1, " \
"i.\"jay_z\"::numeric As attr2, " \ "i.\"jay_z\"::numeric As attr2, " \
"(SELECT ARRAY(SELECT j.\"cartodb_id\" " \ "(SELECT ARRAY(SELECT j.\"cartodb_id\" " \
@ -82,15 +81,13 @@ class PysalUtilsTest(unittest.TestCase):
"WHERE " \ "WHERE " \
"i.\"cartodb_id\" <> j.\"cartodb_id\" AND " \ "i.\"cartodb_id\" <> j.\"cartodb_id\" AND " \
"j.\"andy\" IS NOT NULL AND " \ "j.\"andy\" IS NOT NULL AND " \
"j.\"jay_z\" IS NOT NULL AND " \ "j.\"jay_z\" IS NOT NULL " \
"j.\"jay_z\" <> 0 " \
"ORDER BY " \ "ORDER BY " \
"j.\"the_geom\" <-> i.\"the_geom\" ASC " \ "j.\"the_geom\" <-> i.\"the_geom\" ASC " \
"LIMIT 321)) As neighbors " \ "LIMIT 321)) As neighbors " \
"FROM (SELECT * FROM a_list) As i " \ "FROM (SELECT * FROM a_list) As i " \
"WHERE i.\"andy\" IS NOT NULL AND " \ "WHERE i.\"andy\" IS NOT NULL AND " \
"i.\"jay_z\" IS NOT NULL AND " \ "i.\"jay_z\" IS NOT NULL " \
"i.\"jay_z\" <> 0 " \
"ORDER BY i.\"cartodb_id\" ASC;" "ORDER BY i.\"cartodb_id\" ASC;"
ans_array = "SELECT i.\"cartodb_id\" As id, " \ ans_array = "SELECT i.\"cartodb_id\" As id, " \
@ -111,13 +108,13 @@ class PysalUtilsTest(unittest.TestCase):
"i.\"_2014_feb\" IS NOT NULL "\ "i.\"_2014_feb\" IS NOT NULL "\
"ORDER BY i.\"cartodb_id\" ASC;" "ORDER BY i.\"cartodb_id\" ASC;"
self.assertEqual(pu.knn(self.params), ans) self.assertEqual(pu.knn(self.params1), ans1)
self.assertEqual(pu.knn(self.params_array), ans_array) self.assertEqual(pu.knn(self.params_array), ans_array)
def test_queen(self): def test_queen(self):
"""Test queen neighbors constructor""" """Test queen neighbors constructor"""
ans = "SELECT i.\"cartodb_id\" As id, " \ ans1 = "SELECT i.\"cartodb_id\" As id, " \
"i.\"andy\"::numeric As attr1, " \ "i.\"andy\"::numeric As attr1, " \
"i.\"jay_z\"::numeric As attr2, " \ "i.\"jay_z\"::numeric As attr2, " \
"(SELECT ARRAY(SELECT j.\"cartodb_id\" " \ "(SELECT ARRAY(SELECT j.\"cartodb_id\" " \
@ -127,23 +124,21 @@ class PysalUtilsTest(unittest.TestCase):
"ST_Touches(i.\"the_geom\", " \ "ST_Touches(i.\"the_geom\", " \
"j.\"the_geom\") AND " \ "j.\"the_geom\") AND " \
"j.\"andy\" IS NOT NULL AND " \ "j.\"andy\" IS NOT NULL AND " \
"j.\"jay_z\" IS NOT NULL AND " \ "j.\"jay_z\" IS NOT NULL)" \
"j.\"jay_z\" <> 0)" \
") As neighbors " \ ") As neighbors " \
"FROM (SELECT * FROM a_list) As i " \ "FROM (SELECT * FROM a_list) As i " \
"WHERE i.\"andy\" IS NOT NULL AND " \ "WHERE i.\"andy\" IS NOT NULL AND " \
"i.\"jay_z\" IS NOT NULL AND " \ "i.\"jay_z\" IS NOT NULL " \
"i.\"jay_z\" <> 0 " \
"ORDER BY i.\"cartodb_id\" ASC;" "ORDER BY i.\"cartodb_id\" ASC;"
self.assertEqual(pu.queen(self.params), ans) self.assertEqual(pu.queen(self.params1), ans1)
def test_construct_neighbor_query(self): def test_construct_neighbor_query(self):
"""Test construct_neighbor_query""" """Test construct_neighbor_query"""
# Compare to raw knn query # Compare to raw knn query
self.assertEqual(pu.construct_neighbor_query('knn', self.params), self.assertEqual(pu.construct_neighbor_query('knn', self.params1),
pu.knn(self.params)) pu.knn(self.params1))
def test_get_attributes(self): def test_get_attributes(self):
"""Test get_attributes""" """Test get_attributes"""