Raúl Marín
da570c50aa
Merge remote-tracking branch 'carto/master' into federated_functions
2019-11-15 13:50:21 +01:00
Raúl Marín
d549ecced4
Merge pull request #385 from CartoDB/federated_functions_permissions
...
Federated functions permissions
2019-11-15 13:47:16 +01:00
Raúl Marín
fde12c818a
Update comments
2019-11-15 13:09:52 +01:00
Raúl Marín
e99e4a02c9
Remove TODO
...
Since the server registration requires superadmin priviledges
it doesn't make sense to over protect the role creation
2019-11-14 19:00:09 +01:00
Raúl Marín
fa5f0bcbc1
CDB_Federated_Server_Grant_Access: comment about search_path
2019-11-14 18:55:38 +01:00
Raúl Marín
adca727169
Revert "Go back to public user mappings"
...
This reverts commit 64e185b841
2019-11-14 18:46:45 +01:00
Raúl Marín
0893fae025
Revert "CDB_Federated_Server_Unregister: Drop owned in cascade"
...
This reverts commit 1b86517007
2019-11-14 18:46:02 +01:00
Raúl Marín
e69d3b1c30
Place all views in a shared schema
2019-11-14 18:45:09 +01:00
Rafa de la Torre
a57431a04d
Merge pull request #384 from CartoDB/federated_diagnostics_latency
...
Federated diagnostics latency
2019-11-14 18:29:25 +01:00
Rafa de la Torre
064cc2a76b
Fix for missing port in pg_foreign_server: default to standard 5432
2019-11-14 17:57:05 +01:00
Rafa de la Torre
7f9905cbd5
Test what happens when missing PG port
2019-11-14 17:56:29 +01:00
Raúl Marín
6e455efcdd
Improve warning
2019-11-14 14:15:56 +01:00
Raúl Marín
1b86517007
CDB_Federated_Server_Unregister: Drop owned in cascade
...
Since now views might be owned by other roles, we need to drop them
in cascade to force deletion
2019-11-14 14:07:41 +01:00
Raúl Marín
64e185b841
Go back to public user mappings
2019-11-14 13:43:28 +01:00
Raúl Marín
38d8a470bc
Federated Server: Grant all over postgis and cartodb schemas
2019-11-14 13:24:32 +01:00
Raúl Marín
4920029560
CDB_FederatedServerTables: Improve permission handling and error messages
2019-11-14 13:10:21 +01:00
Rafa de la Torre
9b91704480
Calculate stats only when they make sense
2019-11-13 19:27:56 +01:00
Rafa de la Torre
a340f98b96
Update tests with latency stats
2019-11-13 19:19:39 +01:00
Rafa de la Torre
57dcfc2a35
Add a bunch of statistics
2019-11-13 18:55:09 +01:00
Rafa de la Torre
3ae7b1fe05
Fix bug: do not initialize samples in every iter
2019-11-13 18:27:14 +01:00
Rafa de la Torre
f7d10adbc2
Fix another python2/3 incompat: xrange
2019-11-13 17:16:53 +01:00
Rafa de la Torre
203bd64058
Fix python2/3 compat issue
2019-11-13 17:02:22 +01:00
Rafa de la Torre
19c6de2096
Comment out suspected line
...
This may be causing the error
ERROR: could not compile PL/Python function "__cdb_fs_tcp_foreign_server_latency"
DETAIL: SyntaxError: invalid syntax (<string>, line 26)
when testing in PG12 + plpythonu3
2019-11-13 14:52:24 +01:00
Raúl Marín
e231500c46
Give permissions over cartodb to the FS role
2019-11-13 14:20:08 +01:00
Rafa de la Torre
4b9c048235
Close socket properly before the next iteration
...
This avoid the errors `[Errno 106] Transport endpoint is already
connected` which are due to connections kept in TIME_WAIT state.
We don't use socket.SO_REUSEADDR as it would make the first connection
a special case compared to the following ones.
2019-11-13 12:25:41 +01:00
Rafa de la Torre
5897d8a9cb
Fix timer start in measurements
2019-11-13 12:24:59 +01:00
Rafa de la Torre
980657c4a4
Do not add None to samples in case of connection error
...
Otherwise we get `TypeError: unsupported operand type(s) for +: 'float'
and 'NoneType'` when calculating the average.
2019-11-13 12:16:21 +01:00
Rafa de la Torre
a4a4a1dff1
Honor n_samples param
2019-11-13 12:13:42 +01:00
Rafa de la Torre
0362825b8c
Encapsulate python in __CDB_FS_TCP_Foreign_Server_Latency
...
Instead of having a generic function, merge
__CDB_FS_TCP_Network_Latency and __CDB_FS_Foreign_Server_Host_PG into
one function so that it can only "ping" federated servers.
2019-11-13 11:44:24 +01:00
Raúl Marín
9eab5e2533
__CDB_FS_Generate_Server_Role_Name: set to STABLE
...
current_database() is stable, not immutable
2019-11-12 18:15:20 +01:00
Raúl Marín
0d455d9521
__CDB_FS_List_Foreign_Schemas_PG: Remove extra role generation
2019-11-12 18:14:36 +01:00
Rafa de la Torre
364933b6b9
Compatibility with PG 9.6 and 10
...
See https://www.postgresql.org/message-id/flat/55137679-fd6b-baf0-bfbf-6558ce5cb409%40postgrespro.ru
2019-11-12 15:57:15 +01:00
Rafa de la Torre
18f9f79fe8
Rename key to server_latency_ms to be self-explanatory
2019-11-12 15:08:26 +01:00
Rafa de la Torre
a032cc08e0
Measure latency as the avg of n_samples
2019-11-12 15:01:56 +01:00
Rafa de la Torre
9dc547c838
Add test for wrong port
2019-11-12 13:37:04 +01:00
Rafa de la Torre
d3ae4b808c
Remove default port 5432 in generic function
2019-11-12 13:27:42 +01:00
Rafa de la Torre
26f91001ee
Retrieve port from the catalog
2019-11-12 13:06:14 +01:00
Rafa de la Torre
43b242e610
Retrieve host from the catalog
2019-11-12 13:02:04 +01:00
Rafa de la Torre
e14c49b223
Add kind of meaningful test for latency
2019-11-12 12:59:36 +01:00
Rafa de la Torre
8c7a75dd0c
Implement __CDB_FS_TCP_Network_Latency
2019-11-12 12:42:28 +01:00
Rafa de la Torre
dbed2d1ede
More scaffolding for latency in diagnostics
2019-11-12 12:41:37 +01:00
Rafa de la Torre
1c27443ff4
Stub remote server latency (WIP)
2019-11-12 12:41:37 +01:00
Rafa de la Torre
944b111bb1
Merge pull request #383 from CartoDB/federated_diagnostics
...
Retrieve target PG and postgis versions
2019-11-12 10:45:26 +01:00
Rafa de la Torre
d5ecb39250
Replace hardcoded 5432 by @@PGPORT@@
...
as requested in review comment
2019-11-12 10:32:25 +01:00
Rafa de la Torre
0ad7cd485d
Simplify function with aggregate
2019-11-11 21:34:51 +01:00
Rafa de la Torre
6e9ee296c5
Remove useless commented code
2019-11-11 20:48:14 +01:00
Rafa de la Torre
d87d27d7e5
Use pg_options_to_table instead of manual parsing
2019-11-11 20:42:00 +01:00
Rafa de la Torre
5c9f6964a3
Fix typo: hardcoded loopback server
2019-11-11 18:46:07 +01:00
Rafa de la Torre
d76e3ccc3e
Add server options to diagnostics
2019-11-11 16:02:04 +01:00
Rafa de la Torre
eba6cf4565
Test when postgis is not installed in the remote
2019-11-08 20:27:24 +01:00
