Raul Marin
048234cd80
CDB_Groups_API: Secure search_path
2019-10-03 18:58:27 +02:00
Raul Marin
a580bedefc
Set safe schema on some functions
2019-10-03 18:58:27 +02:00
Raul Marin
0e891eff7f
Remove cartodb from search path
...
All calls to the extension functions should, and are,
be properly qualified, so there is no need to keep
the cartodb schema in the search_path
2019-10-03 18:58:27 +02:00
Raul Marin
52b3290d26
CDB_TableMetadata: Use secure search_path
2019-10-03 18:58:27 +02:00
Raul Marin
186ee37a57
CDB_Username: Set secure search_path
2019-10-03 18:58:27 +02:00
Raul Marin
0898881470
Oauth: Set secure search_path
2019-10-03 18:58:27 +02:00
Raul Marin
4dfd71639a
CDB_OAuthReassignTableOwnerOnCreation: Use CDB_Conf_GetConf
...
Instead of accessing the cdb_conf table directly
2019-10-03 18:58:27 +02:00
Raul Marin
c6b90aac8a
GhostTables: Set secure search_path
2019-10-03 18:58:27 +02:00
Raul Marin
2f178bd89e
_CDB_SetUp_User_PG_FDW_Server: Minor log changes
2019-10-01 11:02:34 +02:00
Raul Marin
32489c4eab
Ghost tables: Add missing tags
...
- Add materialized views commands.
- Add missing alter trigger.
- Add 'IMPORT FOREIGN SCHEMA' since it might create new tables.
- Add 'DROP EXTENSION' and 'DROP TYPE' since they alter table columns.
- Add 'DROP SCHEMA' and 'DROP SERVER' as they drop tables.
2019-10-01 11:02:34 +02:00
Rafa de la Torre
402d97daa6
Merge remote-tracking branch 'origin/master' into user-defined-fdw
2019-07-17 09:18:35 +02:00
Rafa de la Torre
e41d2ec019
Add a flag to force drop of user FDW and related objects
...
If force = true then it will add the subclause `CASCADE` to the SQL
DDL sentences that support it, otherwise it'll use `RESTRICT` which is
the default and exact opposite.
2019-07-16 17:40:05 +02:00
Rafa de la Torre
3c460f1a85
Add a bunch of RAISE NOTICE's to inform user about progress
2019-07-16 17:03:23 +02:00
Rafa de la Torre
ce1e9ac41c
Prefix all objects created with cdb_fdw_
...
Build the DB objects related to a user FDW with the following form:
`cdb_fdw_name`. This is aimed at easily inspect and filter them.
As requested in code review.
2019-07-16 15:35:35 +02:00
Rafa de la Torre
0f33ee8b22
Prepend an underscore (_) to functions meant to be run by superuser
...
_CDB_SetUp_User_PG_FDW_Server and _CDB_Drop_User_PG_FDW_Server are
meant to be executed by a superuser. Therefore they shouldn't be
considered part of the public API and hence the _CDB_Private_Function
naming convention.
2019-07-16 14:32:32 +02:00
Rafa de la Torre
a32dea0282
Remove SECURITY DEFINER from user-defined FDW's
2019-07-16 13:26:03 +02:00
Rafa de la Torre
3a255df9d0
Rename PG-FDW's-specific functions to _PG_FDW_
...
As per review comment.
2019-07-16 13:14:11 +02:00
Rafa de la Torre
99096d41e0
Drop the role when dropping a user-defined FDW
2019-07-15 17:25:48 +02:00
Rafa de la Torre
3a10ef7e76
Add ability to grant fdw role to org members
2019-07-15 16:54:23 +02:00
Rafa de la Torre
37004db047
Add new function to drop a user-defined foreign server
2019-07-15 16:14:07 +02:00
Rafa de la Torre
70220e04c1
Allow for imports of tables in different source schemas
2019-07-15 13:13:21 +02:00
Gonzalo Riestra
a5cb9f268d
reassign ownership for sequences and functions as well
2019-07-15 12:31:44 +02:00
Rafa de la Torre
d2d909145d
Add convenience function to import fdw tables
2019-07-12 16:53:34 +02:00
Rafa de la Torre
34dec227c4
Rename to CDB_SetUp_User_Foreign_Server
2019-07-12 16:53:34 +02:00
Rafa de la Torre
99e92e2505
Create a "PUBLIC" user mapping
2019-07-12 16:53:34 +02:00
Rafa de la Torre
c58a084102
Tweak ownership of db objects
2019-07-12 16:53:34 +02:00
Rafa de la Torre
b7907ff82f
Fix typo granting perms
2019-07-12 16:53:34 +02:00
Rafa de la Torre
12d955075a
Fix bug iterating user_mapping options
2019-07-12 16:53:34 +02:00
Rafa de la Torre
10a4d85c01
Fix typo in example: missing closing }
2019-07-12 16:53:24 +02:00
Rafa de la Torre
524bb6ad42
Fix copy/paste typos
2019-07-12 12:49:59 +02:00
Rafa de la Torre
4da89d8abd
First version of the function WIP
2019-07-12 12:40:02 +02:00
Rafa de la Torre
c7311ba48e
A stub of a convenient FDW function
2019-07-12 12:00:30 +02:00
Mario de Frutos Dieguez
0f1c98c743
Check for empty strings as well
2019-07-04 17:48:01 +02:00
Mario de Frutos Dieguez
8ecd2cd5e2
Reuser creator_role
...
Co-Authored-By: Alberto Romeu <alrocar@users.noreply.github.com>
2019-07-04 17:48:00 +02:00
Mario de Frutos Dieguez
f4be59cae0
Added tests
2019-07-04 17:48:00 +02:00
Mario de Frutos Dieguez
5744921065
OAuth functions
...
- Create/drop reassign event trigger and the function with the logic
- Function that reassings owner to ownership role if defined
2019-07-04 17:47:36 +02:00
Javier Goizueta
bf140890d8
Merge pull request #365 from CartoDB/table-syncer-notmps
...
Sync tables without using temporary hash tables
2019-07-04 16:05:21 +02:00
Rafa de la Torre
29a31d4c40
Merge pull request #362 from CartoDB/fdw-affected-tables
...
Make CDB_Get_Foreign_Updated_At robust to missing CDB_TableMetadata
2019-07-04 16:02:46 +02:00
Javier Goizueta
dbd403a2f6
Fix cases of double-quoting identifiers
2019-07-04 12:47:58 +02:00
Javier Goizueta
7bdee5c13e
Avoid double-quoting
...
Since dst_schema is a REGNAMESPACE, it is automatically quoted when casted to TEXT
2019-07-03 18:34:54 +02:00
Javier Goizueta
2e1fe2933c
Fix whitespace
2019-07-03 16:56:29 +02:00
Rafa de la Torre
446f4113d9
Return NULL instead of NOW()
...
The absence of foreign CDB_TableMetadata actually means that we cannot
really tell when a remote table was modified.
Therefore we're using NULL with the meaning of "I don't know when it
was last modified".
To be taken in other caching layers, to adjust headers accordingly.
2019-07-03 16:19:46 +02:00
Javier Goizueta
5963c67376
Order the columns of a cartodbfied table consistently
...
The final order of the columns of a cartodbfied table wasn't uniquely specified, so could vary across PG versions.
This was a problem in particular for having deterministic test results.
2019-07-03 16:16:37 +02:00
Javier Goizueta
f5f18ca57c
Fix the order of the columns
2019-07-02 18:14:18 +02:00
Javier Goizueta
d8c840d126
Quote table and column names when necessary
...
Also use type NAME when appropriate. Note that quoted column names are not NAMES (may be longer).
2019-07-02 18:14:04 +02:00
Javier Goizueta
65483743b4
Remove unused vars
2019-07-02 17:44:06 +02:00
Javier Goizueta
470bae6268
Merge branch 'master' into table-syncer-notmps
...
# Conflicts:
# scripts-available/CDB_SyncTable.sql
2019-07-02 12:21:49 +02:00
Javier Goizueta
69cc56b589
Remove schema from public function examples
2019-07-01 15:13:48 +02:00
Javier Goizueta
1028b24333
Fix cartodb schema references
2019-07-01 14:48:42 +02:00
Rafa de la Torre
c06d24aa19
Make CDB_Get_Foreign_Updated_At robust to missing CDB_TableMetadata
...
This may happen with non-carto DB's, when checking the updated_at
times and not finding the corresponding remote.cdb_tablemetadata
imported from the foreign non-carto DB.
Instead of failing, return a NOW() timestampt, so that caching logic
just assumes there may have been changes.
This makes it work today, and leaves open the possibility of adding
the required carto metadata for homogeneous caching in the future.
2019-06-28 16:25:52 +02:00