Raul Ochoa
5d22464036
Merge pull request #113 from CartoDB/issue-108
...
Improve cartodb._CDB_total_relation_size performance
2015-08-18 11:17:42 +02:00
Rafa de la Torre
53754236e3
Fix for quota test after merge with master
...
Now cartodbfyied tables take less space because of the timestamp
columns.
2015-08-17 15:56:48 +02:00
Rafa de la Torre
3f588df6f6
Drop function in order to change return value
2015-08-17 15:28:37 +02:00
Rafa de la Torre
2b48f90374
Merge remote-tracking branch 'origin/master' into new_cartodbfy
...
Conflicts:
test/CDB_QuotaTest.sql
2015-08-17 15:27:33 +02:00
Raul Ochoa
50169e58d5
Raise better notice on _CDB_total_relation_size errors
2015-08-17 10:25:31 +02:00
Raul Ochoa
6bc91c7125
Using exception with pg_total_relation_size for better performance
...
IF EXISTS is too slow, one order of magnitude, than using exception
handling. In combination with thousands of tables to check total
relation size that's a problem.
Exception handles specifically undefined_table as it was the original
issue but also any other exception to guarantee a size is always
returned and no error is raised.
2015-08-17 10:17:07 +02:00
Paul Ramsey
a61a92a8f7
Merge pull request #109 from CartoDB/new_cartodbfy_bw_compat_signature
...
Replace CDB_CartodbfyTable by new CartodbfyTable2
2015-08-14 10:34:54 -07:00
Rafa de la Torre
47d8429277
Use return value from cartodbfy
2015-08-14 17:41:55 +02:00
Rafa de la Torre
565edcb50d
Make cartodbfy return destoid
2015-08-14 16:53:43 +02:00
Rafa de la Torre
b7b5be1f3f
Add minor piece of doc
2015-08-14 16:10:38 +02:00
Rafa de la Torre
900531f0c1
Disable a couple of tests
...
Comment out tests that check cartodb_id text columns. These are no
longer taken into consideration as candidate primary ID (candidate
columns should be numeric).
2015-08-14 13:46:01 +02:00
Rafa de la Torre
010dd13e4d
Simple fix for type cheking in test
2015-08-14 13:40:10 +02:00
Rafa de la Torre
72ebc398f8
Recover _CDB_check_prerequisites (sorry, my fault)
2015-08-14 12:30:01 +02:00
Rafa de la Torre
3d89d8231f
Fix deletion of cartodb_postgresql_unpriv_user
...
only used in tests
2015-08-14 09:48:34 +00:00
Rafa de la Torre
f211669e9e
Tweak expected output of test_ddl_triggers
...
Just touch expected output to adapt to NOTICEs and other stuff that
don't affect functionality.
2015-08-14 10:57:11 +02:00
Paul Ramsey
7f55a0263b
Fix regclass mismatch on column alter/drop
...
This logic SHOULD BE MOVED TO Cartodbfy internals.
2015-08-13 16:10:23 -07:00
Paul Ramsey
d268cd07cb
Fix many tests and handle ownership issues involved
...
with Cartodbfy being invoked by schema triggers. Some
issues with regclass interpretation in tests still remain.
Some issues with slightly different behavior to old version
remain. Some issues with error messages / notification messages
changing a little still remain.
2015-08-13 15:59:45 -07:00
Raul Ochoa
219d876973
Merge pull request #110 from CartoDB/issue-108
...
Fixes CDB_UserDataSize failing due `ERROR: relation "*" does not exist.`
2015-08-13 19:01:05 +02:00
Raul Ochoa
60cc218664
Merge pull request #112 from CartoDB/issue-98
...
Review test to validate permissions in public tables
2015-08-13 19:00:09 +02:00
Raul Ochoa
e959bba335
Validates it's enought to grant publicuser to user.
...
Reference to PR where it will be actually fixed for now.
2015-08-13 18:53:41 +02:00
Raul Ochoa
714ba9d0dc
Keep all test running :D
2015-08-13 13:27:27 +02:00
Raul Ochoa
4e31d3a37e
Fixes CDB_UserDataSize failing due ERROR: relation "*" does not exist.
...
Adds new _CDB_total_relation_size function that handles nonexistent
tables and does fallback to size=0.
That function could be used to cache total relation size or query another
table view with a cached total relation size.
Fixes #108
2015-08-13 13:23:35 +02:00
Rafa de la Torre
a5321ec7a5
Replace CDB_CartodbfyTable by new CartodbfyTable2
...
- Delete old CDB_CartodbfyTable code
- Delete auxiliary functions no longer used
- Modify the new CDB_CartodbfyTable signature to be backwards
compatible.
2015-08-12 18:39:07 +02:00
Rafa de la Torre
c00d607ee2
Merge pull request #107 from CartoDB/new_cartodbfy_rtorre
...
Do not create timestamp columns/triggers on cartodbfy
2015-08-12 18:34:33 +02:00
Rafa de la Torre
8a031f56f5
Recover test for cartodb_id not-null constraint
2015-08-12 15:58:30 +00:00
Rafa de la Torre
8c41203db6
Fix for the_geom does not exist
...
When creating triggers, expectation is to have the columns the_geom and
the_geom_webmercator even if the source table does not have any geometry
columns. Populate it in the rewrite with NULL values and right types.
2015-08-12 17:34:47 +02:00
Rafa de la Torre
6b9ab3d956
Fix quota test
...
Now the cartodbfied table is a bit smaller because it does not have the
timestamp columns.
2015-08-12 10:26:37 +02:00
Raul Ochoa
14213c5d6a
Test scenario to show how public tables can be accessed by other roles
...
This will require changes in cartodb/cartodb rails app because user/role
creation happens over there. So it's not possible to fix all the problems
within the extension right now.
2015-08-12 10:10:21 +02:00
Rafa de la Torre
c11d1bbf50
Fix CDB_CartodbfyTableTest
...
by removing references to created_at and updated_at columns
2015-08-11 19:52:37 +02:00
Rafa de la Torre
67f8a8cd69
Fix test_ddl_triggers.sql
...
by removing references to created_at & updated_at columns
2015-08-11 19:18:10 +02:00
Rafa de la Torre
d6afdf751f
Do not create timestamp columns/triggers on cartodbfy
2015-08-11 19:07:01 +02:00
Paul Ramsey
1a1f45cdad
Add raster table calls, like the old function has
2015-08-11 05:40:31 -07:00
Paul Ramsey
b195aa4b68
Enable trigger addition routine
2015-08-10 08:42:13 -07:00
javi santana
cb57af9074
added requirements for test
2015-08-10 11:01:28 +02:00
javi
513488da0e
change random value for quota test again
2015-07-28 09:05:03 +02:00
javi
7921cad4f5
readded removed tests by error
2015-07-27 16:49:59 +02:00
javi santana
10ba742324
Merge pull request #100 from CartoDB/release_0.8.2
...
Release 0.8.2
2015-07-27 16:19:16 +02:00
javi
788d2a7f10
ready for 0.8.2
2015-07-27 16:12:42 +02:00
javi
189a73ce4d
fixed tests
2015-07-27 16:12:15 +02:00
javi santana
d52e05c474
Merge pull request #99 from CartoDB/usertables_fix
...
added tests for usertables to check private tables are not returned
2015-07-27 16:04:45 +02:00
javi
400248cd5d
remove connection permissions to public user
2015-07-27 11:20:55 +02:00
javi
92b5d1f8f4
creating in setup
2015-07-27 11:15:14 +02:00
javi
68fdd9ce33
just add login permissions to public user
2015-07-27 11:07:46 +02:00
javi
53e6b38c32
enabling user again (no sense)
2015-07-27 11:03:21 +02:00
javi
c71faf21e2
do not create publicuser since a previous tests is doing it
2015-07-27 10:57:38 +02:00
javi
12260b9fc3
test cleanup
2015-07-27 10:54:43 +02:00
javi
1b3db28a74
added tests for organization
2015-07-27 10:51:20 +02:00
javi
5d6c2111bf
updates tests
2015-07-27 10:37:07 +02:00
javi
df36e83cb5
revoke permissions to list private tables to public user
2015-07-27 10:31:55 +02:00
javi
e05613d5c4
added tests for usertables to check private tables are not returned
2015-07-27 10:25:44 +02:00
