Raul Ochoa
6bc91c7125
Using exception with pg_total_relation_size for better performance
...
IF EXISTS is too slow, one order of magnitude, than using exception
handling. In combination with thousands of tables to check total
relation size that's a problem.
Exception handles specifically undefined_table as it was the original
issue but also any other exception to guarantee a size is always
returned and no error is raised.
2015-08-17 10:17:07 +02:00
Paul Ramsey
a61a92a8f7
Merge pull request #109 from CartoDB/new_cartodbfy_bw_compat_signature
...
Replace CDB_CartodbfyTable by new CartodbfyTable2
2015-08-14 10:34:54 -07:00
Rafa de la Torre
47d8429277
Use return value from cartodbfy
2015-08-14 17:41:55 +02:00
Rafa de la Torre
565edcb50d
Make cartodbfy return destoid
2015-08-14 16:53:43 +02:00
Juan Ignacio Sánchez Lara
a08600a1f8
Exclude cartodb schema from CDB_UserTables
2015-08-14 16:31:19 +02:00
Rafa de la Torre
b7b5be1f3f
Add minor piece of doc
2015-08-14 16:10:38 +02:00
Juan Ignacio Sánchez Lara
e11f4ef169
Group name validation delegated to role creation
2015-08-14 15:40:36 +02:00
Juan Ignacio Sánchez Lara
db89bf1a94
Grant select on configuration table to org members
2015-08-14 15:28:19 +02:00
Juan Ignacio Sánchez Lara
466e4d81c6
format instead of string concatenation
2015-08-14 15:22:00 +02:00
Juan Ignacio Sánchez Lara
ae634e7814
Server notification must happen after role creation
2015-08-14 15:04:14 +02:00
Juan Ignacio Sánchez Lara
d1f19a0234
Groups API configuration example
2015-08-14 14:03:53 +02:00
Juan Ignacio Sánchez Lara
d4bcb97f9b
CDB_CONF and create and drop group api calls
2015-08-14 14:00:58 +02:00
Juan Ignacio Sánchez Lara
a0aac4e9c9
Info about if not exist log output
2015-08-14 14:00:58 +02:00
Juan Ignacio Sánchez Lara
725453ce2b
Configuration table and functions
2015-08-14 14:00:58 +02:00
Juan Ignacio Sánchez Lara
7262d34b06
IMMUTABLE-STABLE-VOLATILE specification
2015-08-14 14:00:58 +02:00
Juan Ignacio Sánchez Lara
3ee4978240
Roles simplification, without md5 and prepending database name
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
2ece2979a6
Drop cartodb schema before dropping publicuser
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
401d3e9066
publicuser back
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
79e1926766
Group management done by organization admin
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
e2dd1e014e
test_valid_group_names and test_not_valid_group_names
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
1915e28a0f
Cleaner debug output
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
bd46796bb7
Fix spacing
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
898d3c14fd
test_group_management_functions_cant_be_used_by_normal_members and warning -> error processing
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
154f6df1dc
_CDB_Group_GroupRole based on current database m5
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
9a3fbb668c
Dynamic variable binding
2015-08-14 14:00:57 +02:00
Juan Ignacio Sánchez Lara
6baa626756
Groups will be 0.9.0
2015-08-14 14:00:56 +02:00
Juan Ignacio Sánchez Lara
c29733eb87
publicuser uncommenting
2015-08-14 14:00:26 +02:00
Juan Ignacio Sánchez Lara
52f73b1a01
CDB_Group_Table_GrantReadWrite
2015-08-14 14:00:26 +02:00
Juan Ignacio Sánchez Lara
28af048c92
Methods doc
2015-08-14 14:00:26 +02:00
Juan Ignacio Sánchez Lara
1279742e50
CDB_Group_CreateGroup should not return role, since it's an internal implementation detail
2015-08-14 14:00:26 +02:00
Juan Ignacio Sánchez Lara
b633466724
Non-public API method naming
2015-08-14 14:00:26 +02:00
Juan Ignacio Sánchez Lara
e04f0caa6c
Permission granting
2015-08-14 14:00:25 +02:00
Juan Ignacio Sánchez Lara
5afdd77dcf
Rename group
2015-08-14 14:00:25 +02:00
Juan Ignacio Sánchez Lara
eafb0f4557
Groups API extension version
2015-08-14 14:00:25 +02:00
Juan Ignacio Sánchez Lara
42e72ac9d5
cartodb.CDB_Group_CreateGroup cartodb.CDB_Group_DropGroup
2015-08-14 13:58:10 +02:00
Juan Ignacio Sánchez Lara
2824a9c457
Ignore vim temporal files
2015-08-14 13:58:10 +02:00
Rafa de la Torre
900531f0c1
Disable a couple of tests
...
Comment out tests that check cartodb_id text columns. These are no
longer taken into consideration as candidate primary ID (candidate
columns should be numeric).
2015-08-14 13:46:01 +02:00
Rafa de la Torre
010dd13e4d
Simple fix for type cheking in test
2015-08-14 13:40:10 +02:00
Rafa de la Torre
72ebc398f8
Recover _CDB_check_prerequisites (sorry, my fault)
2015-08-14 12:30:01 +02:00
Rafa de la Torre
3d89d8231f
Fix deletion of cartodb_postgresql_unpriv_user
...
only used in tests
2015-08-14 09:48:34 +00:00
Rafa de la Torre
f211669e9e
Tweak expected output of test_ddl_triggers
...
Just touch expected output to adapt to NOTICEs and other stuff that
don't affect functionality.
2015-08-14 10:57:11 +02:00
Paul Ramsey
7f55a0263b
Fix regclass mismatch on column alter/drop
...
This logic SHOULD BE MOVED TO Cartodbfy internals.
2015-08-13 16:10:23 -07:00
Paul Ramsey
d268cd07cb
Fix many tests and handle ownership issues involved
...
with Cartodbfy being invoked by schema triggers. Some
issues with regclass interpretation in tests still remain.
Some issues with slightly different behavior to old version
remain. Some issues with error messages / notification messages
changing a little still remain.
2015-08-13 15:59:45 -07:00
Raul Ochoa
219d876973
Merge pull request #110 from CartoDB/issue-108
...
Fixes CDB_UserDataSize failing due `ERROR: relation "*" does not exist.`
2015-08-13 19:01:05 +02:00
Raul Ochoa
60cc218664
Merge pull request #112 from CartoDB/issue-98
...
Review test to validate permissions in public tables
2015-08-13 19:00:09 +02:00
Raul Ochoa
e959bba335
Validates it's enought to grant publicuser to user.
...
Reference to PR where it will be actually fixed for now.
2015-08-13 18:53:41 +02:00
Raul Ochoa
714ba9d0dc
Keep all test running :D
2015-08-13 13:27:27 +02:00
Raul Ochoa
4e31d3a37e
Fixes CDB_UserDataSize failing due ERROR: relation "*" does not exist.
...
Adds new _CDB_total_relation_size function that handles nonexistent
tables and does fallback to size=0.
That function could be used to cache total relation size or query another
table view with a cached total relation size.
Fixes #108
2015-08-13 13:23:35 +02:00
Rafa de la Torre
a5321ec7a5
Replace CDB_CartodbfyTable by new CartodbfyTable2
...
- Delete old CDB_CartodbfyTable code
- Delete auxiliary functions no longer used
- Modify the new CDB_CartodbfyTable signature to be backwards
compatible.
2015-08-12 18:39:07 +02:00
Rafa de la Torre
c00d607ee2
Merge pull request #107 from CartoDB/new_cartodbfy_rtorre
...
Do not create timestamp columns/triggers on cartodbfy
2015-08-12 18:34:33 +02:00
