From f442c21fa4f35f60bfcc402f679e0a2f7ed2a48f Mon Sep 17 00:00:00 2001 From: Rafa de la Torre Date: Tue, 28 May 2019 09:34:10 +0200 Subject: [PATCH] Fix the test/CDB_AnalysisCheckTest.sql These tests are failing in PG11: ``` *** /home/travis/build/CartoDB/cartodb-postgresql/expected/test/CDB_AnalysisCheckTest.out 2019-05-27 16:09:45.063543994 +0000 --- /home/travis/build/CartoDB/cartodb-postgresql/results/test/CDB_AnalysisCheckTest.out 2019-05-27 16:12:39.770847666 +0000 *************** *** 5,12 **** CREATE TABLE CREATE TABLE CREATE TABLE - (analysis_2f13a3dbd7_41bd92976fc6dd97072afe4ee450054f4c0715d5,public,analysis_2f13a3dbd7_41bd92976fc6dd97072afe4ee450054f4c0715d5) (analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94,public,analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94) 0 1 --- 5,12 ---- CREATE TABLE CREATE TABLE CREATE TABLE (analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94,public,analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94) + (analysis_2f13a3dbd7_41bd92976fc6dd97072afe4ee450054f4c0715d5,public,analysis_2f13a3dbd7_41bd92976fc6dd97072afe4ee450054f4c0715d5) 0 1 ``` The reason for that is that they rely on row ordering that cannot be guaranteed as per SQL Standard. Forcing that assumed ordering is enough to get it working again. --- test/CDB_AnalysisCheckTest.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/CDB_AnalysisCheckTest.sql b/test/CDB_AnalysisCheckTest.sql index a1aa527..1f85e7a 100644 --- a/test/CDB_AnalysisCheckTest.sql +++ b/test/CDB_AnalysisCheckTest.sql @@ -7,7 +7,7 @@ SELECT _CDB_AnalysisDataSize('public'); CREATE TABLE analysis_2f13a3dbd7_41bd92976fc6dd97072afe4ee450054f4c0715d5(id int); CREATE TABLE analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94(id int); CREATE TABLE analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da9(id int); -SELECT _CDB_AnalysisTablesInSchema('public'); +SELECT _CDB_AnalysisTablesInSchema('public') t ORDER BY t; SELECT _CDB_AnalysisDataSize('public'); SELECT CDB_CheckAnalysisQuota('analysis_2f13a3dbd7_f00cee44e9e6152b450bde3a92eb9ae0d099da94'); SELECT CDB_SetUserQuotaInBytes(1);