Simon
|
ac474cb253
|
Merge branch 'middlewarify' into layergroup-token-param
|
2017-09-27 16:31:08 +02:00 |
|
Simon
|
84cd93b1b0
|
make jshint happy
|
2017-09-26 18:25:47 +02:00 |
|
Simon
|
134cc9ac0c
|
changing req.locals to res.locals
|
2017-09-26 18:23:49 +02:00 |
|
Daniel García Aubert
|
4600005a86
|
Bring ported test back
|
2017-09-26 17:31:57 +02:00 |
|
Simon
|
b94dfe066d
|
removing some repeated things
|
2017-09-26 15:39:48 +02:00 |
|
Simon
|
3f6afb4530
|
validation middleware for layer route (conflicting route)
|
2017-09-26 14:56:20 +02:00 |
|
Simon
|
540fda1e6c
|
Merge branch 'master' into middlewarify
|
2017-09-26 14:53:57 +02:00 |
|
Daniel García Aubert
|
4899c7ffef
|
Inject prepare context middleware to controllers
|
2017-09-25 19:40:27 +02:00 |
|
Raul Ochoa
|
b943b09532
|
Merge pull request #736 from CartoDB/static-named-maps-override-bbox
Static named maps override bbox
|
2017-09-25 14:10:27 +02:00 |
|
Daniel García Aubert
|
f0920aedef
|
Remove unused module
|
2017-09-25 13:43:15 +02:00 |
|
Daniel García Aubert
|
b236112069
|
Split prepare context middleware and fix unit test
|
2017-09-25 13:40:22 +02:00 |
|
Daniel García Aubert
|
0e8fb68794
|
Extract token param to a middleware
|
2017-09-22 18:49:21 +02:00 |
|
Daniel García Aubert
|
f7b9287c93
|
Return an array of middlewares instead of big one in prepare context
|
2017-09-22 18:24:16 +02:00 |
|
Daniel García Aubert
|
85d4c81e58
|
Remove legacy hack
|
2017-09-22 18:15:48 +02:00 |
|
Daniel García Aubert
|
3bab081438
|
Rename req2params by prepareContext
|
2017-09-22 17:56:47 +02:00 |
|
Daniel García Aubert
|
6dc9cc0b23
|
Remove req2params dependency
|
2017-09-22 17:56:08 +02:00 |
|
Daniel García Aubert
|
8fd35849c7
|
Merge branch 'middlewarify' of github.com:CartoDB/Windshaft-cartodb into middlewarify
|
2017-09-22 17:15:41 +02:00 |
|
Simon
|
c09899913f
|
finishing integration of lzma middleware
|
2017-09-22 16:46:39 +02:00 |
|
Daniel García Aubert
|
0bdeee64a7
|
Use express router to group controllers' enpoints and reuse common middleware for named maps admin controller
|
2017-09-22 16:45:34 +02:00 |
|
Daniel García Aubert
|
ee8619c470
|
Use express router to group controllers' enpoints and reuse common middleware for analysis controller
|
2017-09-22 16:28:52 +02:00 |
|
Simon
|
9d81321d78
|
Merge branch 'master' into middlewarify
|
2017-09-22 16:26:56 +02:00 |
|
Simon Martín
|
ca63c2ef1a
|
Merge pull request #721 from CartoDB/lzma-middleware
Implement LZMA query param inflating as middleware
|
2017-09-22 16:16:36 +02:00 |
|
Daniel García Aubert
|
b0486f9bae
|
Use express router to group enpoints and reuse common middlewares for layergroup controller
|
2017-09-22 15:44:12 +02:00 |
|
Raul Ochoa
|
22b7828725
|
Layergroup Token parsing as middleware
Reuses LayergroupToken model from tests.
|
2017-09-22 12:05:40 +00:00 |
|
Raul Ochoa
|
78404b1308
|
Merge remote-tracking branch 'origin/master' into layergroup-token-param
|
2017-09-22 11:12:42 +00:00 |
|
Raul Ochoa
|
45698207d9
|
Merge remote-tracking branch 'origin/master' into static-named-maps-override-bbox
|
2017-09-22 11:08:12 +00:00 |
|
Daniel García Aubert
|
9bd862ffaf
|
Remove req2params from BaseController and update related test to use the middleware
|
2017-09-22 01:08:46 +02:00 |
|
Daniel García Aubert
|
8139cdf8b2
|
Use req2params middleware for name maps static views endpoint
|
2017-09-22 00:58:44 +02:00 |
|
Daniel García Aubert
|
a8898a8022
|
Use req2params middleware for name maps tile endpoint
|
2017-09-22 00:48:44 +02:00 |
|
Daniel García Aubert
|
df5ec0f4d9
|
Use req2params middleware for analysis catalog endpoint
|
2017-09-22 00:42:17 +02:00 |
|
Daniel García Aubert
|
51ba3db4ac
|
Use req2params middleware for instantiate named map endpoint
|
2017-09-22 00:31:16 +02:00 |
|
Daniel García Aubert
|
d31e52a625
|
Fix format, break line in bad position
|
2017-09-21 22:55:30 +02:00 |
|
Daniel García Aubert
|
3a8b99a14e
|
Use req2params middleware for tile and layer endpoint
|
2017-09-21 22:53:31 +02:00 |
|
Daniel García Aubert
|
fac1ab4a1c
|
Use req2params middleware for attributes endpoint
|
2017-09-21 22:47:08 +02:00 |
|
Daniel García Aubert
|
a9b0acc317
|
Use req2params middleware for static map (bbox & center) endpoint
|
2017-09-21 22:43:59 +02:00 |
|
Daniel García Aubert
|
e2ed0058d8
|
Use req2params middleware for layergroup create endpoint
|
2017-09-21 21:52:34 +02:00 |
|
Daniel García Aubert
|
2f499a148a
|
Use req2params middleware for dataview endpoint
|
2017-09-21 14:33:32 +02:00 |
|
Daniel García Aubert
|
49204650c6
|
Use req2params middleware for datavie search endpoint
|
2017-09-21 14:30:19 +02:00 |
|
Daniel García Aubert
|
234576ab5f
|
Use req2params middleware for analisys node status endpoint
|
2017-09-21 13:37:32 +02:00 |
|
Daniel García Aubert
|
02cd6a43ad
|
Move req2params method to a its own middleware
|
2017-09-21 13:27:22 +02:00 |
|
Daniel García Aubert
|
429f070372
|
Pass node's response object to req2params
|
2017-09-21 12:22:33 +02:00 |
|
Daniel García Aubert
|
3b9c561cee
|
Change signature of req2params to follow express' middleware pattern
|
2017-09-21 11:54:37 +02:00 |
|
Daniel García Aubert
|
daeae5d95c
|
Implement error-middleware to handle errors at top level
|
2017-09-21 11:46:42 +02:00 |
|
Simon
|
222cfb90fd
|
Removing 'self' vars using arrow functions
|
2017-09-18 12:20:59 +02:00 |
|
Simon
|
f63fab40ed
|
Removing 'self' vars using arrow functions
|
2017-09-18 11:34:18 +02:00 |
|
Daniel García Aubert
|
61ea05d1c2
|
Do not assign a value by default for special float values counters
|
2017-09-15 14:51:02 +02:00 |
|
Daniel García Aubert
|
64c3e68303
|
Fix double declaration of 'result'
|
2017-09-15 14:48:54 +02:00 |
|
Daniel García Aubert
|
d4bb4edd1d
|
Applyy extract method to check input options
|
2017-09-15 14:43:41 +02:00 |
|
Daniel García Aubert
|
419b29e609
|
Do not prefix with '_' template context
|
2017-09-15 14:43:26 +02:00 |
|
Daniel García Aubert
|
c7ed3d34e8
|
Use const instead of var to declare variables
|
2017-09-15 14:43:13 +02:00 |
|
Daniel García Aubert
|
1959a841fd
|
Use arrow function to take advantage of bound context
|
2017-09-15 14:26:22 +02:00 |
|
Daniel García Aubert
|
ef5049f28f
|
Use destructuring assignment to improve readability
|
2017-09-15 14:07:46 +02:00 |
|
Daniel García Aubert
|
d5d9044686
|
Use const keyword to declare variables
|
2017-09-15 14:05:23 +02:00 |
|
Daniel García Aubert
|
5d632d936e
|
Use ES6 class syntax
|
2017-09-15 14:04:09 +02:00 |
|
Daniel García Aubert
|
90c4796d4e
|
Remove empty line
|
2017-09-15 13:41:54 +02:00 |
|
Daniel García Aubert
|
ada58f6ea2
|
Use const keyword to declare varibles
|
2017-09-15 13:35:00 +02:00 |
|
Daniel García Aubert
|
b4ce13e429
|
Use object shorthand notation
|
2017-09-15 11:56:59 +02:00 |
|
Daniel García Aubert
|
11f7b38c69
|
Do not use dot module to build column type query
|
2017-09-15 11:54:56 +02:00 |
|
Daniel García Aubert
|
9771979b8f
|
Missing call to super class in constructor
|
2017-09-15 10:59:07 +02:00 |
|
Daniel García Aubert
|
c00a93f414
|
Use destruturing assignment to format the formula result
|
2017-09-15 10:58:11 +02:00 |
|
Daniel García Aubert
|
ecbc7a28e7
|
Declare constants with const keyword
|
2017-09-15 10:49:20 +02:00 |
|
Daniel García Aubert
|
68dfed8b85
|
Use ES6 class syntax
|
2017-09-15 10:48:44 +02:00 |
|
Daniel García Aubert
|
2437288d9d
|
Replace widget word by dataview
|
2017-09-15 10:37:51 +02:00 |
|
Daniel García Aubert
|
9c64d674b3
|
Do not use underscore
|
2017-09-14 18:02:13 +02:00 |
|
Daniel García Aubert
|
a4ecc18f2f
|
Use default values for constructor's arguments
|
2017-09-14 17:57:24 +02:00 |
|
Daniel García Aubert
|
1063d81c1b
|
Rename debug namespace
|
2017-09-14 17:56:40 +02:00 |
|
Daniel García Aubert
|
dcb9b8ec52
|
Rename BaseWidget by BaseDataview
|
2017-09-14 17:56:17 +02:00 |
|
Daniel García Aubert
|
dbb23bf9f0
|
Remove jshint's complaints
|
2017-09-14 17:24:13 +02:00 |
|
Daniel García Aubert
|
2a0b15f085
|
Remove prefix '_' while passing context param to templates
|
2017-09-14 17:22:34 +02:00 |
|
Daniel García Aubert
|
d0e2c9f898
|
Use debug module to print sql for debugging purposes
|
2017-09-14 17:21:21 +02:00 |
|
Daniel García Aubert
|
d328b534a5
|
Replace widget word by dataview
|
2017-09-14 17:19:16 +02:00 |
|
Daniel García Aubert
|
050e9776d1
|
Use const for requirements, constants and variables that are initialized once
|
2017-09-14 17:18:20 +02:00 |
|
Daniel García Aubert
|
c8ff61c531
|
Use ES6 class syntax
|
2017-09-14 17:15:43 +02:00 |
|
Daniel García Aubert
|
cdc56e703c
|
Rename BaseWidget by BaseDataview
|
2017-09-14 17:10:51 +02:00 |
|
Daniel García Aubert
|
9a4794ee10
|
Remove dot requirement and use template strings to build list aggregation query
|
2017-09-14 17:09:55 +02:00 |
|
Daniel García Aubert
|
51907b9545
|
Apply extract method to condition
|
2017-09-14 16:56:55 +02:00 |
|
Daniel García Aubert
|
1f3b0beddf
|
Fix missing parameter
|
2017-09-14 16:47:05 +02:00 |
|
Daniel García Aubert
|
38e2c040d1
|
Use template string to escape literals
|
2017-09-14 16:45:45 +02:00 |
|
Daniel García Aubert
|
46860541fe
|
Apply extract method to validate input options
|
2017-09-14 16:42:25 +02:00 |
|
Daniel García Aubert
|
c2e99219ef
|
Use ES6 goodies to refactor format method
|
2017-09-14 16:30:46 +02:00 |
|
Daniel García Aubert
|
cc2cf78264
|
Rename all 'widget' ocurrences by 'dataview'
|
2017-09-14 16:12:39 +02:00 |
|
Daniel García Aubert
|
746292610a
|
Rename debug namespace
|
2017-09-14 16:10:23 +02:00 |
|
Daniel García Aubert
|
b05083bcfc
|
Move search's templates along aggregation's templates
|
2017-09-14 16:09:44 +02:00 |
|
Daniel García Aubert
|
cd13107a4d
|
Use ES6 let & const to declare variables
|
2017-09-14 16:08:12 +02:00 |
|
Daniel García Aubert
|
46254eaf74
|
rename BaseWidget by BaseDataview
|
2017-09-14 15:59:15 +02:00 |
|
Daniel García Aubert
|
086eff01a9
|
Use ES6 class syntax
|
2017-09-14 15:57:18 +02:00 |
|
Daniel García Aubert
|
02949003a9
|
Build search query in two steps
|
2017-09-14 15:48:54 +02:00 |
|
Daniel García Aubert
|
0a894da0df
|
Remove prefix to context's properties
|
2017-09-14 15:27:57 +02:00 |
|
Daniel García Aubert
|
e2ab48bee2
|
Remove prefix to context's properties
|
2017-09-14 15:22:58 +02:00 |
|
Daniel García Aubert
|
132fce84c5
|
Remove string template in the middle
|
2017-09-14 15:07:30 +02:00 |
|
Daniel García Aubert
|
b1508af007
|
Remove prefix to context's props in order to share it throught all templates avoiding to duplicate passing custom params again and again
|
2017-09-14 13:14:12 +02:00 |
|
Daniel García Aubert
|
65dca454f4
|
Move aggragation query to its own query template
|
2017-09-14 12:18:03 +02:00 |
|
Daniel García Aubert
|
3682740f08
|
Build aggregation query with string templates avoiding to join all inner templates
|
2017-09-14 12:01:41 +02:00 |
|
Daniel García Aubert
|
a434015d5b
|
Move categories CTE template out of aggregation class
|
2017-09-14 11:27:03 +02:00 |
|
Daniel García Aubert
|
2f4f719f55
|
Use object properties in class method instead of passing them as parameters
|
2017-09-13 19:42:25 +02:00 |
|
Daniel García Aubert
|
75645e2d7a
|
Use string templates to build categories CTE sql
|
2017-09-13 19:34:09 +02:00 |
|
Daniel García Aubert
|
4d1a53c20f
|
Use string templates to build error message
|
2017-09-13 19:27:25 +02:00 |
|
Daniel García Aubert
|
ee471184b9
|
Use default values for input params
|
2017-09-13 19:19:25 +02:00 |
|
Daniel García Aubert
|
4518b7cb6e
|
Declare requirement with const keyword
|
2017-09-13 19:17:16 +02:00 |
|
Daniel García Aubert
|
306df5be5a
|
Replace underscore's function by ES6 equivalents
|
2017-09-13 19:16:08 +02:00 |
|
Daniel García Aubert
|
33e8657e35
|
Declare constants with const keyword
|
2017-09-13 18:40:09 +02:00 |
|
Daniel García Aubert
|
6fd3388fa2
|
Replace dot templates by ES6 string templates
|
2017-09-13 18:38:54 +02:00 |
|
Daniel García Aubert
|
4a89ad57d7
|
Remove '_' as prefix for template's context properties
|
2017-09-12 13:05:46 +02:00 |
|
Daniel García Aubert
|
c0cfdad7d1
|
Use hasOwnProperty method to check if histogram is a time-series
|
2017-09-12 10:38:53 +02:00 |
|
Daniel García Aubert
|
8f797c3c41
|
Fix EOF
|
2017-09-12 10:16:16 +02:00 |
|
Daniel García Aubert
|
2576c3e7d5
|
Rename _shouldOverrideRange & _shouldOverrideBins methods
|
2017-09-12 10:14:55 +02:00 |
|
Daniel García Aubert
|
3a936474cf
|
Fix bad merge with master
|
2017-09-11 19:48:46 +02:00 |
|
Daniel García Aubert
|
a98f5bf08b
|
Merge branch 'master' into time-series-refactor
|
2017-09-11 19:38:21 +02:00 |
|
Daniel García Aubert
|
03babcb43b
|
Simplify condition and remove unused method
|
2017-09-11 19:31:38 +02:00 |
|
Daniel García Aubert
|
9aa5a9e850
|
Improve comment
|
2017-09-11 19:26:28 +02:00 |
|
Daniel García Aubert
|
e3bffcd39d
|
Use inline functions to filter desired fields of the row
|
2017-09-11 19:24:01 +02:00 |
|
Daniel García Aubert
|
5fc2b46d56
|
Fix bad condition
|
2017-09-11 19:14:11 +02:00 |
|
Daniel García Aubert
|
7c69240748
|
Use parameter default value
|
2017-09-11 19:10:06 +02:00 |
|
Daniel García Aubert
|
ee43378c68
|
Use arrow function
|
2017-09-11 19:09:05 +02:00 |
|
Daniel García Aubert
|
09981c2560
|
Extract method to check valid aggregation
|
2017-09-11 18:57:16 +02:00 |
|
Daniel García Aubert
|
fd9534797c
|
Minor refactors
|
2017-09-11 18:44:14 +02:00 |
|
Daniel García Aubert
|
38e7e71328
|
Implement template method pattern to format histogram query output
|
2017-09-11 17:19:02 +02:00 |
|
Daniel García Aubert
|
271932a80d
|
Extract condition to a method
|
2017-09-11 17:17:42 +02:00 |
|
Daniel García Aubert
|
4f33e0d794
|
Rename Histogram.dataview by Histogram.histogramImplementation
|
2017-09-11 15:34:42 +02:00 |
|
Daniel García Aubert
|
ec23bfc79b
|
Rename HistogramBase by BaseHistogram
|
2017-09-11 13:54:46 +02:00 |
|
Daniel García Aubert
|
6c3fa045cd
|
Rename HistogramBase by BaseHistogram
|
2017-09-11 13:53:05 +02:00 |
|
Simon
|
d75ee965ae
|
changing some 'var' to 'let/const'
|
2017-09-11 11:48:33 +02:00 |
|
Simon
|
5e9b2e45c7
|
creating HistogramBase with the common functions of NumericHistogram and DateHistogram
|
2017-09-11 11:32:20 +02:00 |
|
Simon
|
e4a20fa954
|
adding forgotten return
|
2017-09-08 17:57:35 +02:00 |
|
Simon
|
a20900210d
|
removing unneeded _isDateHistogram function
|
2017-09-08 17:54:25 +02:00 |
|
Simon
|
2650c3b3e6
|
removing self=this assignment
|
2017-09-08 17:51:02 +02:00 |
|
Simon
|
25ef2610aa
|
Varible declarations to let/const
|
2017-09-08 17:43:10 +02:00 |
|
Simon
|
92f6f59e07
|
Fix jshint style errors
|
2017-09-08 16:13:23 +02:00 |
|
Simon
|
5e07cc2ad1
|
Remove unneeded condittion
|
2017-09-08 16:06:54 +02:00 |
|
Simon
|
5593d92c4b
|
Do not choose histogram implementation until getResult()
|
2017-09-08 15:55:23 +02:00 |
|
Simon
|
29f32cb9cc
|
Expose dataview's methods to bypass concrete overview's implementations
|
2017-09-08 15:53:00 +02:00 |
|
Simon
|
1d4935cc9a
|
Fix undefined while destrutcuring assignment
|
2017-09-08 15:50:01 +02:00 |
|
Simon
|
f75b4312a1
|
Fix undefined while destructuring assignment
|
2017-09-08 15:49:25 +02:00 |
|
Simon
|
23dd143fa5
|
Make Histogram class as context of state pattern
|
2017-09-08 12:48:08 +02:00 |
|
Simon
|
7d42afcdb4
|
remove unnecessary properties of NumericHistogram
|
2017-09-08 12:22:24 +02:00 |
|
Simon
|
78b95d05d0
|
make private functions
|
2017-09-08 12:21:22 +02:00 |
|
Simon
|
fb753e50a2
|
remove getOffset function
|
2017-09-08 12:19:05 +02:00 |
|
Simon
|
c863cdd9f6
|
remove getAggregation function
|
2017-09-08 12:17:29 +02:00 |
|
Simon
|
a4ebce52db
|
remove unnecessary properties in format function
|
2017-09-08 12:16:56 +02:00 |
|
Simon
|
4a00a2d673
|
rename buildQueryTpl by _buildQueryTpl
|
2017-09-08 12:15:21 +02:00 |
|
Simon
|
38f0e23efe
|
rename buildNumericHistogramQueryTpl by buildQueryTpl
|
2017-09-08 12:10:31 +02:00 |
|
Simon
|
7f14785091
|
fix namespace for debugging
|
2017-09-08 12:07:49 +02:00 |
|
Simon
|
db969a51ad
|
make public some private functions
|
2017-09-08 12:07:07 +02:00 |
|
Simon
|
3441ad6aa9
|
rename _buildDateHistogramQueryTpl by _buildQueryTpl
|
2017-09-08 12:04:25 +02:00 |
|
Simon
|
347dea8f66
|
naming private functions
|
2017-09-08 12:01:15 +02:00 |
|
Simon
|
a3112aa929
|
fix function name in recursion
|
2017-09-08 11:55:28 +02:00 |
|
Simon
|
157946cc42
|
Rename DateHistogram class
|
2017-09-08 11:54:30 +02:00 |
|
Simon
|
8ce25d958c
|
fix namespace for debugging
|
2017-09-08 11:53:47 +02:00 |
|
Daniel García Aubert
|
7e099be134
|
Add specific implementations of histograms based on column type; still not used
|
2017-09-08 10:29:54 +02:00 |
|
Javier Torres
|
7dd5c5b15d
|
Do not use distinct when calculating quantiles
|
2017-09-07 14:39:25 +02:00 |
|