Daniel García Aubert
446449bbde
Move variable declaration close to the place that it's used
2017-12-11 18:47:20 +01:00
Daniel García Aubert
b1f788fb57
Remove unuseful callback
2017-12-11 18:42:03 +01:00
Daniel García Aubert
f80e7112bc
Merge branch 'mapconfig-aggregation' of github.com:CartoDB/Windshaft-cartodb into mapconfig-aggregation
2017-12-11 18:35:54 +01:00
Daniel García Aubert
68f967e582
Extract adaptLayer method
2017-12-11 18:34:22 +01:00
Javier Goizueta
2edcbb4724
Implement aggregation queries.
...
Implmented for placements: centroid, point-gird, point-sample.
Aggregated columns not yet implemented (only count).
Aggregation could be made more efficient by using quadkeys
2017-12-11 18:33:06 +01:00
Daniel García Aubert
006dd86614
Merge branch 'master' into mapconfig-aggregation
2017-12-11 17:36:58 +01:00
Daniel García Aubert
dab204ea71
Do not aggregate if rows cout is lower than threshold or the layer's sql has geometries distinct of points
2017-12-11 17:32:06 +01:00
Simon Martín
1c6c3962db
Merge branch 'master' into errorLogs
2017-12-11 12:59:42 +01:00
Raul Marin
7c5b7641d8
Date histogram: Add missing GROUP BY column
2017-12-11 11:27:13 +01:00
Raul Marin
1b405e42c2
Date histogram optimizations
2017-12-11 11:27:13 +01:00
Raul Marin
088a8b81a6
Timeseries tests: Set timestamps to the start of the aggregations
...
Also, increase the end of the range check so it includes some data
2017-12-11 11:27:13 +01:00
Raul Marin
243e982bd6
Optimize formulae queries
2017-12-11 11:27:13 +01:00
Raul Marin
dfe01c836c
Escape getQueryRowCount with $$
2017-12-11 11:27:13 +01:00
Raul Marin
fcbf5ffcc5
Move sql helper functions to query-utils.js
2017-12-11 11:27:13 +01:00
Raul Marin
90c9ad18e0
Optimize histogram queries
2017-12-11 11:27:13 +01:00
Daniel García Aubert
214d684fcc
Adapt layer when is vector only map-caonfig
2017-12-05 20:39:30 +01:00
Daniel García Aubert
e7592ee570
Improve error message
2017-12-05 17:44:52 +01:00
Daniel García Aubert
7b35701fa8
Extract method
2017-12-05 16:50:18 +01:00
Daniel García Aubert
4f8b541010
Mark aggregation queries
2017-12-05 13:12:25 +01:00
Daniel García Aubert
55dd049812
Be able to skip aggregation to create a layergroup with aggregation defined already
2017-12-05 12:59:32 +01:00
Daniel García Aubert
855f47e446
Detect incompatible CartoCSS or interactivity for raster aggregation
2017-12-04 19:48:06 +01:00
Daniel García Aubert
077f19d506
Integrate aggregation and get metadata for layergroup
2017-12-04 12:40:53 +01:00
Daniel García Aubert
52630b8084
Minor improvementes
2017-12-01 17:06:42 +01:00
Daniel García Aubert
6f04214f5d
Simplify to pass test
2017-12-01 17:06:03 +01:00
Daniel García Aubert
f376a7cdd5
Use aggregation adapter before the overviews one
2017-12-01 17:05:01 +01:00
Daniel García Aubert
0887e5d5f7
Extract method
2017-12-01 15:43:15 +01:00
Daniel García Aubert
d01857923e
Plug aggregation mapconfig adapter
2017-11-30 19:31:00 +01:00
Daniel García Aubert
deb29f2c77
Implement aggregation mapconfig adapter (happy case)
2017-11-30 19:20:59 +01:00
Daniel García Aubert
d937ed31d5
Add params to instantiate aggregation
2017-11-30 19:10:57 +01:00
Daniel García Aubert
73ae736603
Add aggregation proxy
2017-11-30 19:02:30 +01:00
Daniel García Aubert
1767b83d09
Aggregation query models: bootstrap hierarchy classes
2017-11-30 15:34:20 +01:00
Simon Martín
e0d4a9e596
change funcion name
2017-11-30 15:04:07 +01:00
Simon Martín
555d3f558c
changing error log structure
2017-11-28 18:22:55 +01:00
Simon Martín
386d6bfea8
removing unneeded check
2017-11-28 18:19:28 +01:00
Simon Martín
a007fce913
ensuring vars
2017-11-28 16:02:12 +01:00
Simon Martín
605d7057c9
fix copying array of errors and adding error.label to logs
2017-11-27 18:12:44 +01:00
Simon Martín
60e4defa66
default value in errors header
2017-11-27 17:04:50 +01:00
Simon Martín
e7b8d9b223
moving logErrors to right position
2017-11-27 16:55:11 +01:00
Simon Martín
e041b5b8a9
removing ~lost space
2017-11-27 16:52:19 +01:00
Simon Martín
9a8f72b8db
format details
2017-11-27 16:47:45 +01:00
Simon Martín
667925c455
adding error name, ensuring data and moving errors copy
2017-11-27 16:43:04 +01:00
Simon Martín
f24217a400
cloning object and removing logs
2017-11-24 18:06:17 +01:00
Simon Martín
84fd01535c
adding errors to errors header
2017-11-24 17:53:07 +01:00
Daniel García Aubert
1a78b8a75a
Merge branch 'master' into middlewarify-analyses-controller
2017-11-23 11:47:57 +01:00
Daniel García Aubert
e131df601c
Use ES6 template string for route definition
2017-11-19 14:05:20 +01:00
Daniel García Aubert
bee04e2553
Usr ES6 string templates
2017-11-19 12:51:35 +01:00
Daniel García Aubert
37111f396d
Unify get catalog and tables middlewares
2017-11-19 12:37:09 +01:00
Daniel García Aubert
4df46fe5ea
Move creation of PG client to a middleware
2017-11-17 19:20:42 +01:00
Daniel García Aubert
b1b2054f0a
Split metadata function into two middlewares
2017-11-17 19:14:31 +01:00
Daniel García Aubert
c1f2b96bfc
Remove step from catalog middleware
2017-11-17 18:32:46 +01:00
Daniel García Aubert
804c6645fa
Make catalog method a regular middleware factory
2017-11-17 18:28:37 +01:00
Daniel García Aubert
5d6ccc07fd
Move functionality that prepares catalog to be used as response
2017-11-17 18:25:13 +01:00
Daniel García Aubert
a585ba5480
Use early retutn node pattern
2017-11-17 18:07:19 +01:00
Simon Martín
0aaafa2068
Merge branch 'master' into res-locals-user
2017-11-16 11:03:43 +01:00
Simon Martín
ccce598b04
Merge branch 'master' into res-locals-user
2017-11-15 18:37:49 +01:00
Simon Martín
667b2a9cb1
removing underscore dependency in locals middleware
2017-11-15 16:56:21 +01:00
Simon Martín
298882f410
remove with spaces and adding line as EOF
2017-11-15 15:07:30 +01:00
Simon Martín
22e3016cd3
Merge branch 'master' into timeoutVectorImage
2017-11-14 15:54:16 +01:00
Daniel García Aubert
d5c552a03a
Move functionality that sets cache control header to a middleware
2017-11-14 13:53:42 +01:00
Daniel García Aubert
a5347c27e3
Move sendResponse method to a middleware
2017-11-14 13:49:12 +01:00
Daniel García Aubert
27521964c7
Remove schema from analyses catalog query perfoming that query in the same way that we do for pooling the node status in analyses backend
2017-11-14 12:01:21 +01:00
Daniel García Aubert
bdf4827300
Fix bad call to next middleware callback
2017-11-14 11:28:06 +01:00
Daniel García Aubert
38ca5db51b
Inline method to set cache-cannel, rollback extract setCacheChannel method for named maps controller
2017-11-13 12:35:46 +01:00
Daniel García Aubert
590233e3ee
Inline method to set cache-cannel, rollback extract setCacheChannel method
2017-11-13 12:15:12 +01:00
Daniel García Aubert
6f59c61c8b
Add more steps while profiling
2017-11-08 14:27:35 +01:00
Daniel García Aubert
aff5fcda63
Add namespace for getMapConfig step while profiling
2017-11-08 14:08:27 +01:00
Daniel García Aubert
56d33b7f5b
Add profiling
2017-11-08 10:52:25 +01:00
Daniel
749b205944
Merge pull request #788 from CartoDB/786-number-categories-param
...
Add a "category" query param to define the number of categories to be ranked for aggregation dataviews
2017-11-07 17:11:25 +01:00
Daniel García Aubert
743bb0723b
Add query param to define the number of categories to be ranked
2017-11-07 16:14:47 +01:00
Simon Martín
0bf36fa058
remove unneeded encoding control
2017-11-07 16:02:37 +01:00
Simon Martín
970310bf7f
add vectorError middleware to named map endpoint
2017-11-07 16:01:08 +01:00
Simon Martín
1ea4fc50c9
make jshint happy
2017-11-07 11:17:32 +01:00
Simon Martín
216c877f4b
verctor error middleware
2017-11-07 11:07:38 +01:00
Daniel García Aubert
c48e89826d
Split middleware to follow SRP
2017-11-07 09:50:52 +01:00
Daniel García Aubert
693a2e7bee
Order middlewares
2017-11-05 19:13:56 +01:00
Daniel García Aubert
f9ba3c41d3
Create new middlewares to init profiling and another to check JSON content-type
2017-11-05 18:55:23 +01:00
Daniel García Aubert
46289f27df
Remove TODO
2017-11-03 15:26:25 +01:00
Daniel García Aubert
05ccf20634
Rename function
2017-11-03 15:12:18 +01:00
Daniel García Aubert
6acb873d95
Enforce all middlewares to follow the same constructor pattern
2017-11-03 15:06:15 +01:00
Daniel García Aubert
65e8609fec
Do not bind context if not needed
2017-11-03 09:47:46 +01:00
Daniel García Aubert
677f6caab8
remove funtion
2017-11-03 09:38:36 +01:00
Daniel García Aubert
cb167313d2
Unify middleware builder functions
2017-11-03 09:37:01 +01:00
Daniel García Aubert
2854d0252c
Fix typo
2017-11-03 08:48:13 +01:00
Daniel García Aubert
717332d941
Compose instantiate layergroup middleware
2017-11-02 19:24:33 +01:00
Daniel García Aubert
4607e4a12d
Compose create layergroup middleware
2017-11-02 19:03:20 +01:00
Daniel García Aubert
3e7106002d
Rename response middleware
2017-11-02 18:39:46 +01:00
Daniel García Aubert
08b91f935d
Rename error middleware
2017-11-02 18:38:34 +01:00
Daniel García Aubert
1d08734721
Rename middleware
2017-11-02 18:28:37 +01:00
Daniel García Aubert
b11b872b75
Remove step requirement
2017-11-02 11:29:43 +01:00
Daniel García Aubert
93bd2c9e50
Build afterLayergroupCreate middleware as an array of middlewares instead of preforming all them as one middleware
2017-11-02 10:43:22 +01:00
Daniel García Aubert
658763da8c
Build after layergroup create while registering routes
2017-11-02 10:33:39 +01:00
Daniel García Aubert
d2b5eaa8c3
Do not proxy create and intantiate middlewares
2017-11-02 10:28:33 +01:00
Daniel García Aubert
eb5bf52bd9
Move profiler start to the right place
2017-11-02 10:22:30 +01:00
Daniel García Aubert
c8000e5cf8
Make a middleware to respond layergroup
2017-11-01 20:06:32 +01:00
Daniel García Aubert
46c76d6a4c
Create middleware for layergroup creation (anonymous map)
2017-11-01 19:57:20 +01:00
Daniel García Aubert
e6bec5ccb0
Make style linter happy
2017-11-01 19:28:32 +01:00
Daniel García Aubert
125587522f
Create middleware for layergroup creation
2017-11-01 19:27:01 +01:00
Daniel García Aubert
aeb9585708
extract prepare mapconfig and get template to their respective middlewares
2017-11-01 19:02:07 +01:00
Daniel García Aubert
8ed5df0072
Move prepeareConfigFn to a middleware
2017-11-01 17:57:35 +01:00
Daniel García Aubert
6bbaeaa286
Create a custom error middleware to augment error info
2017-10-31 20:49:26 +01:00
Daniel García Aubert
3d15551cb5
Minor style umprovements
2017-10-31 20:10:37 +01:00
Daniel García Aubert
e0ffeb0adc
extract surrogate key functionality to its own middleware
2017-10-31 19:50:36 +01:00
Daniel García Aubert
e06f8fe25e
Set layergroup-id header in the right middleware
2017-10-31 18:54:32 +01:00
Daniel García Aubert
da2228088e
Extract context metadata (turbo-carto) functionallity to its own middleware
2017-10-31 18:42:11 +01:00
Daniel García Aubert
cdc39c8cae
Extract addAnalysesMetadata functionallity to its own middleware
2017-10-31 18:25:17 +01:00
Daniel García Aubert
99fa66c026
Extract hash template for layergroup id and dataviews/widgets to a middlewares
2017-10-31 18:06:14 +01:00
Daniel García Aubert
d85a5d83b7
Make afterLayergroupCreate function as a 'middleware' builder
2017-10-31 17:59:32 +01:00
Daniel García Aubert
bb02494e02
Do not perform "increment map view count" in parallel
2017-10-31 17:09:42 +01:00
Daniel García Aubert
39eb0f7bec
Avoid regression and update comment
2017-10-31 16:58:00 +01:00
Daniel García Aubert
5f7d5f6ec8
Get analyses results from res.locals
2017-10-31 16:01:18 +01:00
Daniel García Aubert
a4b2044e10
missing early return
2017-10-31 15:58:41 +01:00
Daniel García Aubert
d1093686a3
Avoid to hold info in local variables
2017-10-31 15:51:42 +01:00
Daniel García Aubert
12822c4341
Follow node.js convention regarding early returns
2017-10-31 15:49:10 +01:00
Daniel García Aubert
fab87e2168
Get layergroup from locals. It's not provided by previous middleware anymore
2017-10-31 15:47:59 +01:00
Daniel García Aubert
34e219353c
do not pass layergroup since it's already available in res.locals
2017-10-31 14:47:29 +01:00
Daniel García Aubert
3cf4a8f70b
Extract layergroup data augmentation to its own "middleware"
2017-10-31 13:46:03 +01:00
Daniel García Aubert
48172d4dc1
make afterLayergroupCreate to follow the middleware signature
2017-10-31 13:36:17 +01:00
Daniel García Aubert
467bee4c91
Split afterLayergroupCreate method in multiple "pre-middlewares"
2017-10-31 13:13:20 +01:00
Daniel García Aubert
3f2ef63976
Extract cache channel to its own method
2017-10-31 11:38:54 +01:00
Daniel García Aubert
235f5e4566
Extract cache channel to its own method
2017-10-31 11:38:18 +01:00
Daniel García Aubert
fb3afaa6ab
Fix jshint max-complexity issue by using extract method
2017-10-30 19:29:19 +01:00
Daniel García Aubert
b6c405bf68
Remove send method in base controller and remove BaseController class
2017-10-30 19:28:40 +01:00
Simon Martín
c0df0d12c6
ensure dont overwrite data in copy from req.params to res.locals
2017-10-20 17:21:55 +02:00
Daniel García Aubert
00f81db57e
Fixed default value for own_filter
2017-10-20 16:47:56 +02:00
Daniel García Aubert
0c9d60b573
Add support for no_filters params in dataviews
2017-10-20 16:19:24 +02:00
Daniel García Aubert
9ad6d0cbcc
Merge branch 'master' into stats-middleware
2017-10-16 15:06:20 +02:00
Raul Ochoa
ad227a5240
Merge remote-tracking branch 'origin/master' into analyses-filters
2017-10-10 16:35:11 +00:00
David Manzanares
d30f710534
Merge remote-tracking branch 'origin/master' into mvt-path-conf
2017-10-10 17:53:28 +02:00
Daniel García Aubert
02304dc450
Merge branch 'master' into stats-middleware
2017-10-10 16:56:35 +02:00
Simon Martín
8380d291d0
Merge branch 'master' into middlewarify
2017-10-10 14:59:50 +02:00
Daniel García Aubert
251e636ad2
Fix bad argument list while calling to staticMap function
2017-10-10 11:58:24 +02:00
Daniel García Aubert
a81e98995a
Merge branch 'middlewarify' into stats-middleware
2017-10-09 17:54:32 +02:00
Simon Martín
484e0fda2f
undo changing services params
2017-10-09 16:29:35 +02:00
Simon Martín
e3405ea2fc
doing changes after merge with middlewarify
2017-10-09 12:27:58 +02:00
Simon Martín
5c0f597cbb
Merge branch 'middlewarify' into res-locals
2017-10-09 10:55:43 +02:00
Daniel García Aubert
7289394f6a
Missing EOL
2017-10-07 19:16:15 +02:00
Daniel García Aubert
1ba1c488fa
Do not decorate response methods to set header and send stats
2017-10-07 19:02:26 +02:00
David Manzanares
43885f130b
Fix HTTP status code distinction between 200 and 204
2017-10-06 16:19:00 +02:00
David Manzanares
4e6253b717
Return HTTP 204 for empty tiles
2017-10-06 16:02:16 +02:00
Daniel García Aubert
242e63716f
Merge branch 'middlewarify' into stats-middleware
2017-10-05 18:21:02 +02:00
Daniel García Aubert
c70b8cb5bf
Set X-Served-By-DB-Host header in db-conn-setup middleware
2017-10-05 18:05:46 +02:00
Simon Martín
06138a82a8
Merge branch 'middlewarify' into res-locals
2017-10-05 17:53:15 +02:00
Daniel García Aubert
678fbb1c8f
Remove bad argument to middleware callback
2017-10-05 17:28:41 +02:00
Simon Martín
2f310a15bd
do not overwrite creation of res.locals
2017-10-05 17:23:07 +02:00
Daniel García Aubert
bf637ccd5b
Implement stats middleware removing some duplicated code
2017-10-05 17:06:42 +02:00
Simon Martín
9083fc2e20
fix forgotten comment
2017-10-05 12:44:03 +02:00
David Manzanares
102228c55b
Merge remote-tracking branch 'origin/master' into mvt-path-conf
2017-10-05 12:19:24 +02:00
David Manzanares
148e6e6ae5
Merge branch 'master' into mvt-path-conf
2017-10-05 12:18:08 +02:00
Daniel García Aubert
b93c09959c
Back to use just one router
2017-10-05 12:12:21 +02:00
Simon Martín
5abe25c316
undo style/format changes
2017-10-05 11:35:49 +02:00
Simon Martín
1f03a6b181
using res.locals instead of params in AuthApi
2017-10-05 11:28:41 +02:00
Simon Martín
ec8fcc7302
change param name and comments updated
2017-10-04 12:50:27 +02:00
Simon Martín
19e2515a8e
Merge pull request #749 from CartoDB/dataview-factory-refactor
...
Dataview factory refactor
2017-10-04 12:18:55 +02:00
Simon Martín
0a507d02bc
Merge branch 'master' into remove-list-dataview
2017-10-04 11:36:45 +02:00
Simon Martín
8fe31c45f3
fix 'this' scope with arrow function
2017-10-04 11:10:17 +02:00
Simon Martín
fe4c22d2ea
Merge branch 'master' into base-dataview-refactor
2017-10-04 11:08:43 +02:00
Simon Martín
d27cce915c
Merge pull request #747 from CartoDB/formula-dataview-refactor
...
Formula dataview refactor
2017-10-04 10:10:57 +02:00
Simon Martín
21720267cf
from req.context to res.locals
2017-10-03 17:47:57 +02:00
Simon Martín
3ce10690d6
send res.locals instead of res when possible
2017-10-03 13:06:12 +02:00
Simon Martín
6bfc5d8891
fix function name and removing comments of localsMiddleware
2017-10-03 13:03:02 +02:00
Simon Martín
430e1513d8
fix incorrect function parameter
2017-10-03 13:00:52 +02:00
Raul Ochoa
2b1f12e9d5
Allow to instantiate maps with analyses filters
...
This decouples filters from dataviews. They are more verbose now.
Misses validation of filters.
2017-10-02 19:16:44 +02:00
Simon Martín
4fd3c99531
Merge pull request #746 from CartoDB/list-dataview-refactor
...
List dataview refactor
2017-10-02 17:28:54 +02:00
Simon Martín
1e4c63a6dc
Merge pull request #745 from CartoDB/aggregation-dataview-refactor
...
Aggregation dataview refactor
2017-10-02 17:24:12 +02:00
Simon Martín
742420b159
Merge pull request #744 from CartoDB/time-series-refactor
...
Histogram refactor
2017-10-02 17:18:21 +02:00
Simon Martín
55f593eae6
adding forgotten semicolon
2017-10-02 12:08:10 +02:00
Simon Martín
f9d87bc40f
res.locals fixing controllers
2017-10-02 12:07:35 +02:00
Simon Martín
783eb0eec7
res.locals format and layer in namep maps
2017-09-29 17:03:57 +02:00
Simon Martín
c22a35489d
res.locals forgotten things and make jshint happy
2017-09-29 14:38:28 +02:00
Simon Martín
482feabce2
res.locals in named maps controller
2017-09-29 14:37:55 +02:00
Simon Martín
0a753400e0
res.locals in map controller
2017-09-29 12:54:21 +02:00
Simon Martín
a21648ab4a
res.locals in layergroup controller
2017-09-29 12:32:46 +02:00
Simon Martín
b4d03c074a
not move db params to res.locals.db
2017-09-29 11:07:11 +02:00
Raul Ochoa
78b75c7a88
Removes list dataview type
2017-09-28 10:47:44 +00:00
David Manzanares
ad1abb28af
Add configuration flag to enable/disable direct PgSQL MVT
2017-09-28 12:08:22 +02:00
Simon Martín
f824fc5243
base and analyses controller
2017-09-28 12:02:34 +02:00
Simon Martín
4a2cc6a5f8
res.locals in auth_api
2017-09-28 11:55:36 +02:00
Simon
ca612dd02a
res.locals in context middlewares
2017-09-28 11:43:12 +02:00
Unknown
fedcb0d0f9
remove unused middleware
2017-09-28 11:23:53 +02:00
Simon
178b9e8563
moving layergroup-token middleware to middlewarify style
2017-09-27 16:32:49 +02:00
Simon
ac474cb253
Merge branch 'middlewarify' into layergroup-token-param
2017-09-27 16:31:08 +02:00
Simon
84cd93b1b0
make jshint happy
2017-09-26 18:25:47 +02:00
Simon
134cc9ac0c
changing req.locals to res.locals
2017-09-26 18:23:49 +02:00
Daniel García Aubert
4600005a86
Bring ported test back
2017-09-26 17:31:57 +02:00
Simon
b94dfe066d
removing some repeated things
2017-09-26 15:39:48 +02:00
Simon
3f6afb4530
validation middleware for layer route (conflicting route)
2017-09-26 14:56:20 +02:00
Simon
540fda1e6c
Merge branch 'master' into middlewarify
2017-09-26 14:53:57 +02:00
Daniel García Aubert
4899c7ffef
Inject prepare context middleware to controllers
2017-09-25 19:40:27 +02:00
Raul Ochoa
b943b09532
Merge pull request #736 from CartoDB/static-named-maps-override-bbox
...
Static named maps override bbox
2017-09-25 14:10:27 +02:00
Daniel García Aubert
f0920aedef
Remove unused module
2017-09-25 13:43:15 +02:00
Daniel García Aubert
b236112069
Split prepare context middleware and fix unit test
2017-09-25 13:40:22 +02:00
Daniel García Aubert
0e8fb68794
Extract token param to a middleware
2017-09-22 18:49:21 +02:00
Daniel García Aubert
f7b9287c93
Return an array of middlewares instead of big one in prepare context
2017-09-22 18:24:16 +02:00
Daniel García Aubert
85d4c81e58
Remove legacy hack
2017-09-22 18:15:48 +02:00
Daniel García Aubert
3bab081438
Rename req2params by prepareContext
2017-09-22 17:56:47 +02:00
Daniel García Aubert
6dc9cc0b23
Remove req2params dependency
2017-09-22 17:56:08 +02:00
Daniel García Aubert
8fd35849c7
Merge branch 'middlewarify' of github.com:CartoDB/Windshaft-cartodb into middlewarify
2017-09-22 17:15:41 +02:00
Simon
c09899913f
finishing integration of lzma middleware
2017-09-22 16:46:39 +02:00
Daniel García Aubert
0bdeee64a7
Use express router to group controllers' enpoints and reuse common middleware for named maps admin controller
2017-09-22 16:45:34 +02:00
Daniel García Aubert
ee8619c470
Use express router to group controllers' enpoints and reuse common middleware for analysis controller
2017-09-22 16:28:52 +02:00
Simon
9d81321d78
Merge branch 'master' into middlewarify
2017-09-22 16:26:56 +02:00
Simon Martín
ca63c2ef1a
Merge pull request #721 from CartoDB/lzma-middleware
...
Implement LZMA query param inflating as middleware
2017-09-22 16:16:36 +02:00
Daniel García Aubert
b0486f9bae
Use express router to group enpoints and reuse common middlewares for layergroup controller
2017-09-22 15:44:12 +02:00
Raul Ochoa
22b7828725
Layergroup Token parsing as middleware
...
Reuses LayergroupToken model from tests.
2017-09-22 12:05:40 +00:00
Raul Ochoa
78404b1308
Merge remote-tracking branch 'origin/master' into layergroup-token-param
2017-09-22 11:12:42 +00:00
Raul Ochoa
45698207d9
Merge remote-tracking branch 'origin/master' into static-named-maps-override-bbox
2017-09-22 11:08:12 +00:00
Daniel García Aubert
9bd862ffaf
Remove req2params from BaseController and update related test to use the middleware
2017-09-22 01:08:46 +02:00
Daniel García Aubert
8139cdf8b2
Use req2params middleware for name maps static views endpoint
2017-09-22 00:58:44 +02:00
Daniel García Aubert
a8898a8022
Use req2params middleware for name maps tile endpoint
2017-09-22 00:48:44 +02:00
Daniel García Aubert
df5ec0f4d9
Use req2params middleware for analysis catalog endpoint
2017-09-22 00:42:17 +02:00
Daniel García Aubert
51ba3db4ac
Use req2params middleware for instantiate named map endpoint
2017-09-22 00:31:16 +02:00
Daniel García Aubert
d31e52a625
Fix format, break line in bad position
2017-09-21 22:55:30 +02:00
Daniel García Aubert
3a8b99a14e
Use req2params middleware for tile and layer endpoint
2017-09-21 22:53:31 +02:00
Daniel García Aubert
fac1ab4a1c
Use req2params middleware for attributes endpoint
2017-09-21 22:47:08 +02:00
Daniel García Aubert
a9b0acc317
Use req2params middleware for static map (bbox & center) endpoint
2017-09-21 22:43:59 +02:00
Daniel García Aubert
e2ed0058d8
Use req2params middleware for layergroup create endpoint
2017-09-21 21:52:34 +02:00
Daniel García Aubert
2f499a148a
Use req2params middleware for dataview endpoint
2017-09-21 14:33:32 +02:00
Daniel García Aubert
49204650c6
Use req2params middleware for datavie search endpoint
2017-09-21 14:30:19 +02:00
Daniel García Aubert
234576ab5f
Use req2params middleware for analisys node status endpoint
2017-09-21 13:37:32 +02:00
Daniel García Aubert
02cd6a43ad
Move req2params method to a its own middleware
2017-09-21 13:27:22 +02:00
Daniel García Aubert
429f070372
Pass node's response object to req2params
2017-09-21 12:22:33 +02:00
Daniel García Aubert
3b9c561cee
Change signature of req2params to follow express' middleware pattern
2017-09-21 11:54:37 +02:00
Daniel García Aubert
daeae5d95c
Implement error-middleware to handle errors at top level
2017-09-21 11:46:42 +02:00
Simon
222cfb90fd
Removing 'self' vars using arrow functions
2017-09-18 12:20:59 +02:00
Simon
f63fab40ed
Removing 'self' vars using arrow functions
2017-09-18 11:34:18 +02:00
Daniel García Aubert
61ea05d1c2
Do not assign a value by default for special float values counters
2017-09-15 14:51:02 +02:00
Daniel García Aubert
64c3e68303
Fix double declaration of 'result'
2017-09-15 14:48:54 +02:00
Daniel García Aubert
d4bb4edd1d
Applyy extract method to check input options
2017-09-15 14:43:41 +02:00
Daniel García Aubert
419b29e609
Do not prefix with '_' template context
2017-09-15 14:43:26 +02:00
Daniel García Aubert
c7ed3d34e8
Use const instead of var to declare variables
2017-09-15 14:43:13 +02:00
Daniel García Aubert
1959a841fd
Use arrow function to take advantage of bound context
2017-09-15 14:26:22 +02:00
Daniel García Aubert
ef5049f28f
Use destructuring assignment to improve readability
2017-09-15 14:07:46 +02:00
Daniel García Aubert
d5d9044686
Use const keyword to declare variables
2017-09-15 14:05:23 +02:00
Daniel García Aubert
5d632d936e
Use ES6 class syntax
2017-09-15 14:04:09 +02:00
Daniel García Aubert
90c4796d4e
Remove empty line
2017-09-15 13:41:54 +02:00
Daniel García Aubert
ada58f6ea2
Use const keyword to declare varibles
2017-09-15 13:35:00 +02:00
Daniel García Aubert
b4ce13e429
Use object shorthand notation
2017-09-15 11:56:59 +02:00
Daniel García Aubert
11f7b38c69
Do not use dot module to build column type query
2017-09-15 11:54:56 +02:00
Daniel García Aubert
9771979b8f
Missing call to super class in constructor
2017-09-15 10:59:07 +02:00
Daniel García Aubert
c00a93f414
Use destruturing assignment to format the formula result
2017-09-15 10:58:11 +02:00
Daniel García Aubert
ecbc7a28e7
Declare constants with const keyword
2017-09-15 10:49:20 +02:00
Daniel García Aubert
68dfed8b85
Use ES6 class syntax
2017-09-15 10:48:44 +02:00
Daniel García Aubert
2437288d9d
Replace widget word by dataview
2017-09-15 10:37:51 +02:00
Daniel García Aubert
9c64d674b3
Do not use underscore
2017-09-14 18:02:13 +02:00
Daniel García Aubert
a4ecc18f2f
Use default values for constructor's arguments
2017-09-14 17:57:24 +02:00
Daniel García Aubert
1063d81c1b
Rename debug namespace
2017-09-14 17:56:40 +02:00
Daniel García Aubert
dcb9b8ec52
Rename BaseWidget by BaseDataview
2017-09-14 17:56:17 +02:00
Daniel García Aubert
dbb23bf9f0
Remove jshint's complaints
2017-09-14 17:24:13 +02:00
Daniel García Aubert
2a0b15f085
Remove prefix '_' while passing context param to templates
2017-09-14 17:22:34 +02:00
Daniel García Aubert
d0e2c9f898
Use debug module to print sql for debugging purposes
2017-09-14 17:21:21 +02:00
Daniel García Aubert
d328b534a5
Replace widget word by dataview
2017-09-14 17:19:16 +02:00
Daniel García Aubert
050e9776d1
Use const for requirements, constants and variables that are initialized once
2017-09-14 17:18:20 +02:00
Daniel García Aubert
c8ff61c531
Use ES6 class syntax
2017-09-14 17:15:43 +02:00
Daniel García Aubert
cdc56e703c
Rename BaseWidget by BaseDataview
2017-09-14 17:10:51 +02:00
Daniel García Aubert
9a4794ee10
Remove dot requirement and use template strings to build list aggregation query
2017-09-14 17:09:55 +02:00
Daniel García Aubert
51907b9545
Apply extract method to condition
2017-09-14 16:56:55 +02:00
Daniel García Aubert
1f3b0beddf
Fix missing parameter
2017-09-14 16:47:05 +02:00
Daniel García Aubert
38e2c040d1
Use template string to escape literals
2017-09-14 16:45:45 +02:00
Daniel García Aubert
46860541fe
Apply extract method to validate input options
2017-09-14 16:42:25 +02:00
Daniel García Aubert
c2e99219ef
Use ES6 goodies to refactor format method
2017-09-14 16:30:46 +02:00
Daniel García Aubert
cc2cf78264
Rename all 'widget' ocurrences by 'dataview'
2017-09-14 16:12:39 +02:00
Daniel García Aubert
746292610a
Rename debug namespace
2017-09-14 16:10:23 +02:00
Daniel García Aubert
b05083bcfc
Move search's templates along aggregation's templates
2017-09-14 16:09:44 +02:00
Daniel García Aubert
cd13107a4d
Use ES6 let & const to declare variables
2017-09-14 16:08:12 +02:00
Daniel García Aubert
46254eaf74
rename BaseWidget by BaseDataview
2017-09-14 15:59:15 +02:00
Daniel García Aubert
086eff01a9
Use ES6 class syntax
2017-09-14 15:57:18 +02:00
Daniel García Aubert
02949003a9
Build search query in two steps
2017-09-14 15:48:54 +02:00
Daniel García Aubert
0a894da0df
Remove prefix to context's properties
2017-09-14 15:27:57 +02:00
Daniel García Aubert
e2ab48bee2
Remove prefix to context's properties
2017-09-14 15:22:58 +02:00
Daniel García Aubert
132fce84c5
Remove string template in the middle
2017-09-14 15:07:30 +02:00
Daniel García Aubert
b1508af007
Remove prefix to context's props in order to share it throught all templates avoiding to duplicate passing custom params again and again
2017-09-14 13:14:12 +02:00
Daniel García Aubert
65dca454f4
Move aggragation query to its own query template
2017-09-14 12:18:03 +02:00
Daniel García Aubert
3682740f08
Build aggregation query with string templates avoiding to join all inner templates
2017-09-14 12:01:41 +02:00
Daniel García Aubert
a434015d5b
Move categories CTE template out of aggregation class
2017-09-14 11:27:03 +02:00
Daniel García Aubert
2f4f719f55
Use object properties in class method instead of passing them as parameters
2017-09-13 19:42:25 +02:00
Daniel García Aubert
75645e2d7a
Use string templates to build categories CTE sql
2017-09-13 19:34:09 +02:00
Daniel García Aubert
4d1a53c20f
Use string templates to build error message
2017-09-13 19:27:25 +02:00
Daniel García Aubert
ee471184b9
Use default values for input params
2017-09-13 19:19:25 +02:00
Daniel García Aubert
4518b7cb6e
Declare requirement with const keyword
2017-09-13 19:17:16 +02:00
Daniel García Aubert
306df5be5a
Replace underscore's function by ES6 equivalents
2017-09-13 19:16:08 +02:00
Daniel García Aubert
33e8657e35
Declare constants with const keyword
2017-09-13 18:40:09 +02:00
Daniel García Aubert
6fd3388fa2
Replace dot templates by ES6 string templates
2017-09-13 18:38:54 +02:00
Daniel García Aubert
4a89ad57d7
Remove '_' as prefix for template's context properties
2017-09-12 13:05:46 +02:00
Daniel García Aubert
c0cfdad7d1
Use hasOwnProperty method to check if histogram is a time-series
2017-09-12 10:38:53 +02:00
Daniel García Aubert
8f797c3c41
Fix EOF
2017-09-12 10:16:16 +02:00
Daniel García Aubert
2576c3e7d5
Rename _shouldOverrideRange & _shouldOverrideBins methods
2017-09-12 10:14:55 +02:00
Daniel García Aubert
3a936474cf
Fix bad merge with master
2017-09-11 19:48:46 +02:00
Daniel García Aubert
a98f5bf08b
Merge branch 'master' into time-series-refactor
2017-09-11 19:38:21 +02:00
Daniel García Aubert
03babcb43b
Simplify condition and remove unused method
2017-09-11 19:31:38 +02:00
Daniel García Aubert
9aa5a9e850
Improve comment
2017-09-11 19:26:28 +02:00
Daniel García Aubert
e3bffcd39d
Use inline functions to filter desired fields of the row
2017-09-11 19:24:01 +02:00
Daniel García Aubert
5fc2b46d56
Fix bad condition
2017-09-11 19:14:11 +02:00
Daniel García Aubert
7c69240748
Use parameter default value
2017-09-11 19:10:06 +02:00
Daniel García Aubert
ee43378c68
Use arrow function
2017-09-11 19:09:05 +02:00
Daniel García Aubert
09981c2560
Extract method to check valid aggregation
2017-09-11 18:57:16 +02:00
Daniel García Aubert
fd9534797c
Minor refactors
2017-09-11 18:44:14 +02:00
Daniel García Aubert
38e7e71328
Implement template method pattern to format histogram query output
2017-09-11 17:19:02 +02:00
Daniel García Aubert
271932a80d
Extract condition to a method
2017-09-11 17:17:42 +02:00
Daniel García Aubert
4f33e0d794
Rename Histogram.dataview by Histogram.histogramImplementation
2017-09-11 15:34:42 +02:00
Daniel García Aubert
ec23bfc79b
Rename HistogramBase by BaseHistogram
2017-09-11 13:54:46 +02:00
