Daniel García Aubert
35d4fb4d27
Improve readability, using extract method pattern
2017-06-07 16:11:09 +02:00
Daniel García Aubert
42e2f9e4b1
Update commented use cases
2017-06-07 15:54:28 +02:00
Daniel García Aubert
d3bcf6f80d
Do not omit nonexistent property
2017-06-06 09:15:49 +02:00
Daniel García Aubert
eeea51e10d
Removed unused column in group by statement
2017-06-05 17:26:37 +02:00
Daniel García Aubert
9337cd948c
Fix typo
2017-06-05 16:26:29 +02:00
Daniel García Aubert
e82d688a18
Fix typo
2017-06-05 16:09:47 +02:00
Daniel García Aubert
95a6ad3b86
Support quarter aggregation in histograms over date columns
2017-06-05 16:04:42 +02:00
Daniel García Aubert
d01787842f
Support UTC timezone override
2017-06-05 15:23:04 +02:00
Daniel García Aubert
6ff3b33cde
Removed bins_start as query output
2017-06-05 14:17:50 +02:00
Daniel García Aubert
32eeb57fce
Reduce complexity in function
2017-06-02 19:00:26 +02:00
Daniel García Aubert
8bc38a375a
Support timezone aggregation
2017-06-02 18:37:49 +02:00
Daniel García Aubert
c1fac13d6b
Be able to accept timezone parameter
2017-06-02 12:45:34 +02:00
Daniel García Aubert
9c34428984
Allow override start and end params
2017-06-02 12:15:43 +02:00
Daniel García Aubert
1d66e49910
WIP implemented date histogram
2017-06-01 20:07:46 +02:00
Javier Goizueta
31557b06be
Add test to detect and fix incorrect bbox filter splitting
...
When bbox crosses date line and is split in two, the eastern box wasn't correct
2017-05-31 11:09:51 -04:00
Raul Ochoa
8b0964ad7e
Remove Promise hack from turbo-carto adapter
2017-05-22 18:45:24 +02:00
Daniel García Aubert
3978d58d66
Remove empty line
2017-05-18 16:12:28 +02:00
Daniel García Aubert
3ce38d7081
Going green: fix type error when no buffersize is defined in mapconfig
2017-05-18 15:49:57 +02:00
Daniel García Aubert
fb4ee61b83
Use setInmmediate vs process.nextTick
2017-05-17 12:55:05 +02:00
Daniel García Aubert
808c729a0e
Now supported formats for buffer-size customization are bound to the adapter
2017-05-17 12:33:41 +02:00
Daniel García Aubert
5a44d6c547
Drop geojson support for buffersize customization
2017-05-10 18:35:30 +02:00
Daniel García Aubert
53d1b2fbbf
Rename mapconfig-named-map-adapter by mapconfig-buffer-size-adapter
2017-05-10 18:16:22 +02:00
Daniel García Aubert
2c9d30e042
Be more flexible validating buffer-size customization
2017-05-10 17:49:28 +02:00
Mario de Frutos
be58adb1b9
Be able to override buffer-size configuration without placeholders in named maps
2017-04-28 19:20:00 +02:00
Mario de Frutos
9707881bf9
Include check for surrogate-key header and renamed the test file
2017-04-07 15:59:58 +02:00
Mario de Frutos
fa6493ae44
Affected tables are now included in X-Cache-Channel
2017-04-07 15:59:58 +02:00
Mario de Frutos
5e4d1d5c1c
Get affected tables and add it to the layergroup
2017-04-07 15:59:58 +02:00
Raul Ochoa
e0c2423ace
Remove unused import
2017-03-23 01:14:56 +01:00
Raul Ochoa
5e429ba71f
Use crc32 instead of md5 for computing subdomain candidate
2017-03-23 01:03:45 +01:00
Raul Ochoa
2da834784f
Generate URLs for resources based on CDN + template rules
2017-03-22 18:58:37 +01:00
Raul Ochoa
fa94550261
Include changes for overviews implementation
2017-03-16 19:15:34 +01:00
Raul Ochoa
992b2b6ba7
Histogram column type discovery query uses non-filtered query
...
Pass all queries to the dataview and use the no filters one for
discovering what is the column type associated to the histogram dataview.
2017-03-13 18:40:29 +01:00
Mario de Frutos
b446c31cbc
Other category now uses the selected aggregated function ( #633 )
...
* Other category in category widget uses selected aggregation function
Fixes https://github.com/CartoDB/Windshaft-cartodb/issues/628
2017-03-02 10:48:20 +01:00
Raul Ochoa
8a76cd506f
Fix issue with global Promise object
2017-02-20 18:46:48 +01:00
Daniel García Aubert
83301238d2
Port changes to overviews
2017-01-17 17:10:08 +01:00
Daniel García Aubert
a4a1fb930a
Be able to not compute NULL categories and null values wheter aggregation operation is not 'count'
2017-01-17 17:09:17 +01:00
Javier Goizueta
6a4f5d52ec
Don't use overviews for date histograms
2016-12-16 17:51:36 +01:00
Javier Goizueta
ccaae2dd66
Remove spurious parameter from overviews dataviews functions
...
In the overviews-specialized dataview classes the sql-generating
functions had an unneeded parameter filters.
In some cases, since this parameter was not being paaased from
the base dataviews class it was masking the override parameter.
2016-12-16 17:37:05 +01:00
Javier Goizueta
cfcba4e578
Wueries with sql_wrap should not be rewritten
2016-12-02 14:00:21 +01:00
Raul Ochoa
adf5c17e0d
Use context from adapters as provider context
2016-09-28 19:22:03 +02:00
Raul Ochoa
61d31ec054
Handle metadata from turbo-carto
2016-09-20 16:08:53 +02:00
Daniel García Aubert
dfaa6ec024
Fixes #546 , added node_id
property to analysis errors
2016-07-11 15:48:26 +02:00
Raul Ochoa
71c7d8a90c
Limit analysis creation concurrency
2016-07-07 00:36:59 +02:00
Raul Ochoa
57bb8dbbe3
Use mapconfig to to store/retrieve dataviews queries
2016-07-06 22:31:08 +02:00
Raul Ochoa
c539d4fbbd
Change camshaft naming from filters
2016-07-06 21:11:39 +02:00
Raul Ochoa
80d5b29902
More clear turbo-carto error messages: no context in message
2016-07-06 12:34:09 +02:00
Raul Ochoa
b3107916ce
Return multiple turbo-carto errors
...
Closes #541
2016-07-06 00:32:30 +02:00
Raul Ochoa
616aac9771
Upgrade camshaft to 0.25.0
...
Use new configuration with user for nodes.
2016-07-03 10:49:45 +02:00
Daniel García Aubert
ed7f95a1a7
Merge branch 'master' into fix-error-context
2016-06-29 19:02:54 +02:00
Raul Ochoa
dd8a70eb95
Uses node list so identical nodes are not de-duplicated and can be used with different ids
...
Fixes #528
2016-06-29 16:10:26 +02:00
Daniel García Aubert
accab9e78a
Gets layerId from the layer that raises the error
2016-06-29 12:21:15 +02:00
Daniel García Aubert
016adb64ef
Fix error context, replaced turbo-carto
error type by layer
type. Context is no longer used, custom property for each type will be used instead.
2016-06-26 18:43:04 +02:00
Daniel García Aubert
d80f2b9566
Now errors with context have the same schema.
2016-06-21 18:26:10 +02:00
Raul Ochoa
a2e74a3e1b
Improve error messages for missing analyses for layers and dataviews
2016-06-21 17:25:28 +02:00
Raul Ochoa
7114311b75
Split turbo-carto adapter substitutions tokens query
2016-06-21 15:05:44 +02:00
Raul Ochoa
d00379af6b
Pixel size query for turbo-carto adapter using radians and degrees instead of meters
2016-06-21 14:01:43 +02:00
Raul Ochoa
863128013d
Use psql client instead of pg query runner to use proper params
2016-06-21 12:08:40 +02:00
Raul Ochoa
e8df09c85b
Add support for min, max, and avg operations in aggregation dataview
2016-06-20 16:26:24 +02:00
Daniel García Aubert
0540696c3e
Avoid to expose internal naming
2016-06-14 10:27:35 +02:00
Daniel García Aubert
d9297d54de
made error_with_context non optional and adapted test's assertion
2016-06-13 16:14:01 +02:00
Daniel García Aubert
c0ce6e7a8a
WIP fixes 478, adds more error information when either analysis or turbo-carto is not well formed.
2016-06-13 12:20:56 +02:00
Raul Ochoa
4a11115dd0
Improve errors for dataviews validation
2016-06-09 18:13:54 +02:00
Raul Ochoa
3269fef845
Sort start and end override params
...
Fixes #375
2016-06-06 17:10:52 +02:00
Raul Ochoa
284a8f2465
Deduplicate and skip falsy column names for geojson queries
...
Although Windshaft is already removing duplicates and skipping falsy
columns it's better to provide it with good input.
Closes #476
2016-06-06 15:58:16 +02:00
Raul Ochoa
653beb1952
Dataviews/widgets adapter working with non sql, non source, and non widgets layers
...
Ref #480
2016-06-06 11:46:27 +02:00
Raul Ochoa
1ae86e039b
Dataviews adapter: skip layers not containing SQL or widgets
2016-06-02 20:17:39 +02:00
Raul Ochoa
f75cadf6ba
Dataviews adapter should work when there is a mix of layers with and without widgets
2016-06-02 19:51:16 +02:00
Raul Ochoa
f8f6508449
Merge branch 'master' into mapconfig-dataviews-adapter
...
Conflicts:
NEWS.md
npm-shrinkwrap.json
2016-06-02 10:57:43 +02:00
Raul Ochoa
94bf2748be
Ignore errors coming from overviews adapter
2016-06-01 15:03:02 +02:00
Raul Ochoa
4c25828540
Fix sql signature in agg, formula, and list dataviews
2016-06-01 11:42:24 +02:00
Javier Goizueta
d5423c88ea
Replace use of the name widget by dataview for consistency
2016-05-31 15:30:38 +02:00
Javier Goizueta
5838b7a455
Remove debugging messages
2016-05-31 15:19:33 +02:00
Javier Goizueta
ef276bd51e
Merge branch 'master' into 466-overviews-dataviews
2016-05-30 17:26:06 +02:00
Javier Goizueta
7ac3784f32
Increase the ratio used to select an overview level from a bounding box
...
This value would ideally be adjusted to prevent the grid size of the
overview used being greater that one pixel. So, this should be the
larger dimension of the map window in pixels.
2016-05-30 17:21:56 +02:00
Raul Ochoa
f602ea88e2
Convert widgets from layers into dataviews
...
It also converts filters so full dataviews backend is reusable, that removes
widgets backend dependency.
2016-05-26 19:32:58 +02:00
Raul Ochoa
da6870cf1e
Adds new adapter to transform widgets into dataviews
2016-05-26 11:57:55 +02:00
Raul Ochoa
f7c528277b
Add tests for generic MapConfig adapter
2016-05-26 11:23:19 +02:00
Raul Ochoa
2ff33b5010
Generic MapConfig adapter can receive an arbitrary number of adapters
2016-05-26 11:02:43 +02:00
Raul Ochoa
f34213a147
Reorder public/private functions
2016-05-25 17:24:28 +02:00
Raul Ochoa
a785ebef65
Use generic map config adapter
2016-05-23 23:29:06 +02:00
Raul Ochoa
4137de5adf
Remove class members
2016-05-23 22:01:08 +02:00
Raul Ochoa
f012e6092f
Remove unused var
2016-05-23 21:58:42 +02:00
Raul Ochoa
9ce4929d87
Use generic adapter in named maps
2016-05-23 21:56:38 +02:00
Raul Ochoa
8efe844474
Use generic adapter
2016-05-23 21:37:06 +02:00
Raul Ochoa
02cb80daa1
Use context for datasource 2/2
2016-05-23 19:14:03 +02:00
Raul Ochoa
e9d1951d48
Use context for datasource 1/2
2016-05-23 19:09:57 +02:00
Raul Ochoa
a11cc28dc7
Use context for analyses results
2016-05-23 18:59:23 +02:00
Raul Ochoa
a8fdd6726e
Fix style
2016-05-23 18:36:03 +02:00
Raul Ochoa
7ad8a99373
Unify getMapConfig signature for overviews adapter
2016-05-23 18:35:16 +02:00
Javier Goizueta
c0a24108ba
Implement overviews histogram dataviews
2016-05-23 18:11:10 +02:00
Javier Goizueta
ae9b8a0380
Remove comment
2016-05-23 18:10:46 +02:00
Raul Ochoa
31a0b01a27
Rename param
2016-05-23 18:08:42 +02:00
Raul Ochoa
efcb73e0d1
Named layers adapter with getMapConfig signature
2016-05-23 18:03:45 +02:00
Javier Goizueta
f008c74419
Specific aggregation dataview implementation for overviews
2016-05-23 17:42:26 +02:00
Javier Goizueta
4a646d4700
Refactor overviews formula dataview
2016-05-23 17:20:04 +02:00
Javier Goizueta
657b262d92
Override all dataview types for overviews
...
All are using now the default behaviour defined in the base
class.
2016-05-23 17:06:52 +02:00
Javier Goizueta
988412fc07
Define default overviews dataview behaviour in base class
2016-05-23 16:53:28 +02:00
Raul Ochoa
70750d2c43
Unify getMapConfig signature
2016-05-23 16:50:26 +02:00
Raul Ochoa
9c1db98f67
Unifiy getMapConfig signature
2016-05-23 16:44:14 +02:00
Raul Ochoa
12c44fda6f
Unify getMapConfig interface
2016-05-23 16:20:42 +02:00
Raul Ochoa
6ccdb6cefd
Overviews adapter with getMapConfig interface
2016-05-23 15:52:31 +02:00
Raul Ochoa
9f6ce64a31
Named maps adapter with getMapConfig interface
2016-05-23 15:39:11 +02:00
Raul Ochoa
3e35604df0
turbo-carto adapter with getMapConfig interface
2016-05-23 15:18:20 +02:00
Raul Ochoa
01a69ef15c
Merge remote-tracking branch 'origin/master' into mapconfig-reorg
2016-05-23 15:14:25 +02:00
Raul Ochoa
fb045f1836
Merge branch 'master' into turbo-carto-tokens
2016-05-23 15:06:55 +02:00
Raul Ochoa
ee49b8b2a2
Turbo-carto adapter into adapters package
2016-05-23 14:18:58 +02:00
Javier Goizueta
5ba72b4894
Create base class for overviews dataviews
2016-05-23 14:18:45 +02:00
Raul Ochoa
8134aca14d
Named map provider into providers package
2016-05-23 13:32:28 +02:00
Raul Ochoa
215bbbd29c
Store provider into providers package
2016-05-23 13:29:34 +02:00
Raul Ochoa
c4b6f65404
Create map provider into providers package
2016-05-23 13:28:11 +02:00
Raul Ochoa
20725900b6
Overviews adapter into adapters package
2016-05-23 13:25:11 +02:00
Raul Ochoa
ab984729f5
Named layers adapter into adapters package
2016-05-23 13:16:34 +02:00
Raul Ochoa
9f8551058d
Analysis adapter into adapter package
2016-05-23 13:10:52 +02:00
Raul Ochoa
c372d69e98
LayergroupToken only makes sense at testing environment
2016-05-23 13:01:23 +02:00
Javier Goizueta
3add61ec57
Use Camshaft's API to get node filters
2016-05-19 18:32:49 +02:00
Raul Ochoa
64dd033c94
Merge branch 'master' into turbo-carto-tokens
2016-05-19 13:39:36 +02:00
Raul Ochoa
2e79781711
Adds support for sql wrap in all layers
...
Previously it was only working for analyses ones.
2016-05-19 13:34:29 +02:00
Raul Ochoa
c7f37047b0
Save original query from analysis before wrapping it
2016-05-19 11:41:06 +02:00
Javier Goizueta
4c375780c7
replace underscore functions by standard (ES5) equivalents
...
Note: _.find(a,...) is not replaced by a.find(...)
because it is not available for all the collections
we need it for.
2016-05-18 15:43:20 +02:00
Javier Goizueta
8da7cf73c1
Remove comment
2016-05-18 13:55:09 +02:00
Javier Goizueta
aa0ddaae95
Remove comment
2016-05-18 08:07:48 +02:00
Javier Goizueta
3d8f6576aa
Implement category and range filters
2016-05-18 07:48:11 +02:00
Javier Goizueta
42ef40282b
💄 shorten long lines
2016-05-17 15:46:13 +02:00
Javier Goizueta
7f7204df6c
Add filter stats information to query rewriter data
2016-05-17 15:41:31 +02:00
Javier Goizueta
3c6d930434
Fix bug
2016-05-17 15:39:32 +02:00
Javier Goizueta
df63fbbd04
Refactor filter application into own model
...
This also avoids storing an object in the overviews query rewriter
for the bbox filter (a plain data structure is used instead).
2016-05-17 13:55:00 +02:00
Javier Goizueta
9d82e8c27c
Use bounding box of dataviews to select overviews level
2016-05-13 20:47:36 +02:00
Javier Goizueta
224eb392ba
Add overviews-dependent dataviews behaviour
...
Now QueryRewriter is used in dataview objects they can decide
whether overviews are applicable, have the oportunity to
adapt queries for overviews, etc.
This is done by having overviews-related behaviour in models/dataview/overviews
and falling back to the regular models/dataview.
2016-05-13 18:46:58 +02:00
Javier Goizueta
55cf0a8447
Fix typo
2016-05-12 16:43:09 +02:00
Javier Goizueta
64a87690ee
💄 Fix line lengths, etc.
2016-05-12 16:20:34 +02:00
Javier Goizueta
65612f0109
Add filters information at map instantion time to the query rewriter data
2016-05-11 19:24:13 +02:00
Raul Ochoa
4570d17ce1
Use original query from source nodes
...
Doing a st_transform doesn't make sense as we already should have
the_geom_webmercator column available
2016-05-10 17:09:36 +02:00
Raul Ochoa
3e94e3288f
Use sql as replacement variable
2016-05-06 17:09:41 +02:00
Raul Ochoa
7d4caf6974
Analysis layers can have a sql_wrap option to wrap node queries
2016-05-06 16:37:52 +02:00
Raul Ochoa
755dfe6822
Append dataviews related columns to layers
2016-04-27 18:30:05 +02:00
Raul Ochoa
dd731399dc
Starts using turbo-carto dependency
2016-04-26 16:28:05 +02:00
Raul Ochoa
c5bed48d61
Handle missing analyses nodes for layers pointing to them
...
Fixes #422
2016-04-21 17:24:52 +02:00
Raul Ochoa
93dd8a2213
Add analyses metadata for named maps excluding queries
2016-04-21 17:03:41 +02:00
Raul Ochoa
4e4a223f24
Better naming for analysis mapconfig adapter
2016-04-21 16:25:59 +02:00
Raul Ochoa
bc845b2e8d
Validate dataviews format before instantiating
2016-04-21 16:16:00 +02:00
Raul Ochoa
e04a9a2579
Append dataviews filters after checking if mapconfig must be adapted
2016-04-20 15:40:14 +02:00
Raul Ochoa
f932862ce4
Improve configuration for batch queries
2016-04-18 15:13:00 +02:00
Raul Ochoa
263b3e3682
Rename file
2016-04-18 14:47:35 +02:00
Raul Ochoa
a26025b259
Add analysis backend so it's possible to inject configuration
2016-04-14 17:09:07 +02:00
Raul Ochoa
a9ca453b17
Remove some JSON.stringify
2016-04-14 13:20:22 +02:00
Raul Ochoa
0981ccd0c4
Add metadata information about analyses
2016-04-07 17:58:12 +02:00
Raul Ochoa
077c4ab907
Adds analysis MapConfig adapter to named maps
2016-04-07 16:18:48 +02:00
Raul Ochoa
1c250bf243
Remove dependency
2016-04-07 14:30:49 +02:00
Raul Ochoa
ab6bae6a7f
Merge branch 'master' into analysis-layers
2016-04-04 16:24:31 +02:00
Javier Goizueta
b97a67b844
Fix overviews integration for named layers
...
Fixes #400
2016-03-31 18:33:41 +02:00