Daniel García Aubert
65e8609fec
Do not bind context if not needed
2017-11-03 09:47:46 +01:00
Daniel García Aubert
677f6caab8
remove funtion
2017-11-03 09:38:36 +01:00
Daniel García Aubert
cb167313d2
Unify middleware builder functions
2017-11-03 09:37:01 +01:00
Daniel García Aubert
2854d0252c
Fix typo
2017-11-03 08:48:13 +01:00
Daniel García Aubert
717332d941
Compose instantiate layergroup middleware
2017-11-02 19:24:33 +01:00
Daniel García Aubert
4607e4a12d
Compose create layergroup middleware
2017-11-02 19:03:20 +01:00
Daniel García Aubert
3e7106002d
Rename response middleware
2017-11-02 18:39:46 +01:00
Daniel García Aubert
08b91f935d
Rename error middleware
2017-11-02 18:38:34 +01:00
Daniel García Aubert
1d08734721
Rename middleware
2017-11-02 18:28:37 +01:00
Daniel García Aubert
b11b872b75
Remove step requirement
2017-11-02 11:29:43 +01:00
Daniel García Aubert
93bd2c9e50
Build afterLayergroupCreate middleware as an array of middlewares instead of preforming all them as one middleware
2017-11-02 10:43:22 +01:00
Daniel García Aubert
658763da8c
Build after layergroup create while registering routes
2017-11-02 10:33:39 +01:00
Daniel García Aubert
d2b5eaa8c3
Do not proxy create and intantiate middlewares
2017-11-02 10:28:33 +01:00
Daniel García Aubert
eb5bf52bd9
Move profiler start to the right place
2017-11-02 10:22:30 +01:00
Daniel García Aubert
c8000e5cf8
Make a middleware to respond layergroup
2017-11-01 20:06:32 +01:00
Daniel García Aubert
46c76d6a4c
Create middleware for layergroup creation (anonymous map)
2017-11-01 19:57:20 +01:00
Daniel García Aubert
e6bec5ccb0
Make style linter happy
2017-11-01 19:28:32 +01:00
Daniel García Aubert
125587522f
Create middleware for layergroup creation
2017-11-01 19:27:01 +01:00
Daniel García Aubert
aeb9585708
extract prepare mapconfig and get template to their respective middlewares
2017-11-01 19:02:07 +01:00
Daniel García Aubert
8ed5df0072
Move prepeareConfigFn to a middleware
2017-11-01 17:57:35 +01:00
Daniel García Aubert
6bbaeaa286
Create a custom error middleware to augment error info
2017-10-31 20:49:26 +01:00
Daniel García Aubert
3d15551cb5
Minor style umprovements
2017-10-31 20:10:37 +01:00
Daniel García Aubert
e0ffeb0adc
extract surrogate key functionality to its own middleware
2017-10-31 19:50:36 +01:00
Daniel García Aubert
e06f8fe25e
Set layergroup-id header in the right middleware
2017-10-31 18:54:32 +01:00
Daniel García Aubert
da2228088e
Extract context metadata (turbo-carto) functionallity to its own middleware
2017-10-31 18:42:11 +01:00
Daniel García Aubert
cdc39c8cae
Extract addAnalysesMetadata functionallity to its own middleware
2017-10-31 18:25:17 +01:00
Daniel García Aubert
99fa66c026
Extract hash template for layergroup id and dataviews/widgets to a middlewares
2017-10-31 18:06:14 +01:00
Daniel García Aubert
d85a5d83b7
Make afterLayergroupCreate function as a 'middleware' builder
2017-10-31 17:59:32 +01:00
Daniel García Aubert
bb02494e02
Do not perform "increment map view count" in parallel
2017-10-31 17:09:42 +01:00
Daniel García Aubert
39eb0f7bec
Avoid regression and update comment
2017-10-31 16:58:00 +01:00
Daniel García Aubert
5f7d5f6ec8
Get analyses results from res.locals
2017-10-31 16:01:18 +01:00
Daniel García Aubert
a4b2044e10
missing early return
2017-10-31 15:58:41 +01:00
Daniel García Aubert
d1093686a3
Avoid to hold info in local variables
2017-10-31 15:51:42 +01:00
Daniel García Aubert
12822c4341
Follow node.js convention regarding early returns
2017-10-31 15:49:10 +01:00
Daniel García Aubert
fab87e2168
Get layergroup from locals. It's not provided by previous middleware anymore
2017-10-31 15:47:59 +01:00
Daniel García Aubert
34e219353c
do not pass layergroup since it's already available in res.locals
2017-10-31 14:47:29 +01:00
Daniel García Aubert
3cf4a8f70b
Extract layergroup data augmentation to its own "middleware"
2017-10-31 13:46:03 +01:00
Daniel García Aubert
48172d4dc1
make afterLayergroupCreate to follow the middleware signature
2017-10-31 13:36:17 +01:00
Daniel García Aubert
467bee4c91
Split afterLayergroupCreate method in multiple "pre-middlewares"
2017-10-31 13:13:20 +01:00
Daniel García Aubert
3f2ef63976
Extract cache channel to its own method
2017-10-31 11:38:54 +01:00
Daniel García Aubert
235f5e4566
Extract cache channel to its own method
2017-10-31 11:38:18 +01:00
Daniel García Aubert
fb3afaa6ab
Fix jshint max-complexity issue by using extract method
2017-10-30 19:29:19 +01:00
Daniel García Aubert
b6c405bf68
Remove send method in base controller and remove BaseController class
2017-10-30 19:28:40 +01:00
Simon Martín
c0df0d12c6
ensure dont overwrite data in copy from req.params to res.locals
2017-10-20 17:21:55 +02:00
Daniel García Aubert
00f81db57e
Fixed default value for own_filter
2017-10-20 16:47:56 +02:00
Daniel García Aubert
0c9d60b573
Add support for no_filters params in dataviews
2017-10-20 16:19:24 +02:00
Daniel García Aubert
9ad6d0cbcc
Merge branch 'master' into stats-middleware
2017-10-16 15:06:20 +02:00
Raul Ochoa
ad227a5240
Merge remote-tracking branch 'origin/master' into analyses-filters
2017-10-10 16:35:11 +00:00
David Manzanares
d30f710534
Merge remote-tracking branch 'origin/master' into mvt-path-conf
2017-10-10 17:53:28 +02:00
Daniel García Aubert
02304dc450
Merge branch 'master' into stats-middleware
2017-10-10 16:56:35 +02:00
Simon Martín
8380d291d0
Merge branch 'master' into middlewarify
2017-10-10 14:59:50 +02:00
Daniel García Aubert
251e636ad2
Fix bad argument list while calling to staticMap function
2017-10-10 11:58:24 +02:00
Daniel García Aubert
a81e98995a
Merge branch 'middlewarify' into stats-middleware
2017-10-09 17:54:32 +02:00
Simon Martín
484e0fda2f
undo changing services params
2017-10-09 16:29:35 +02:00
Simon Martín
e3405ea2fc
doing changes after merge with middlewarify
2017-10-09 12:27:58 +02:00
Simon Martín
5c0f597cbb
Merge branch 'middlewarify' into res-locals
2017-10-09 10:55:43 +02:00
Daniel García Aubert
7289394f6a
Missing EOL
2017-10-07 19:16:15 +02:00
Daniel García Aubert
1ba1c488fa
Do not decorate response methods to set header and send stats
2017-10-07 19:02:26 +02:00
David Manzanares
43885f130b
Fix HTTP status code distinction between 200 and 204
2017-10-06 16:19:00 +02:00
David Manzanares
4e6253b717
Return HTTP 204 for empty tiles
2017-10-06 16:02:16 +02:00
Daniel García Aubert
242e63716f
Merge branch 'middlewarify' into stats-middleware
2017-10-05 18:21:02 +02:00
Daniel García Aubert
c70b8cb5bf
Set X-Served-By-DB-Host header in db-conn-setup middleware
2017-10-05 18:05:46 +02:00
Simon Martín
06138a82a8
Merge branch 'middlewarify' into res-locals
2017-10-05 17:53:15 +02:00
Daniel García Aubert
678fbb1c8f
Remove bad argument to middleware callback
2017-10-05 17:28:41 +02:00
Simon Martín
2f310a15bd
do not overwrite creation of res.locals
2017-10-05 17:23:07 +02:00
Daniel García Aubert
bf637ccd5b
Implement stats middleware removing some duplicated code
2017-10-05 17:06:42 +02:00
Simon Martín
9083fc2e20
fix forgotten comment
2017-10-05 12:44:03 +02:00
David Manzanares
102228c55b
Merge remote-tracking branch 'origin/master' into mvt-path-conf
2017-10-05 12:19:24 +02:00
David Manzanares
148e6e6ae5
Merge branch 'master' into mvt-path-conf
2017-10-05 12:18:08 +02:00
Daniel García Aubert
b93c09959c
Back to use just one router
2017-10-05 12:12:21 +02:00
Simon Martín
5abe25c316
undo style/format changes
2017-10-05 11:35:49 +02:00
Simon Martín
1f03a6b181
using res.locals instead of params in AuthApi
2017-10-05 11:28:41 +02:00
Simon Martín
ec8fcc7302
change param name and comments updated
2017-10-04 12:50:27 +02:00
Simon Martín
19e2515a8e
Merge pull request #749 from CartoDB/dataview-factory-refactor
...
Dataview factory refactor
2017-10-04 12:18:55 +02:00
Simon Martín
0a507d02bc
Merge branch 'master' into remove-list-dataview
2017-10-04 11:36:45 +02:00
Simon Martín
8fe31c45f3
fix 'this' scope with arrow function
2017-10-04 11:10:17 +02:00
Simon Martín
fe4c22d2ea
Merge branch 'master' into base-dataview-refactor
2017-10-04 11:08:43 +02:00
Simon Martín
d27cce915c
Merge pull request #747 from CartoDB/formula-dataview-refactor
...
Formula dataview refactor
2017-10-04 10:10:57 +02:00
Simon Martín
21720267cf
from req.context to res.locals
2017-10-03 17:47:57 +02:00
Simon Martín
3ce10690d6
send res.locals instead of res when possible
2017-10-03 13:06:12 +02:00
Simon Martín
6bfc5d8891
fix function name and removing comments of localsMiddleware
2017-10-03 13:03:02 +02:00
Simon Martín
430e1513d8
fix incorrect function parameter
2017-10-03 13:00:52 +02:00
Raul Ochoa
2b1f12e9d5
Allow to instantiate maps with analyses filters
...
This decouples filters from dataviews. They are more verbose now.
Misses validation of filters.
2017-10-02 19:16:44 +02:00
Simon Martín
4fd3c99531
Merge pull request #746 from CartoDB/list-dataview-refactor
...
List dataview refactor
2017-10-02 17:28:54 +02:00
Simon Martín
1e4c63a6dc
Merge pull request #745 from CartoDB/aggregation-dataview-refactor
...
Aggregation dataview refactor
2017-10-02 17:24:12 +02:00
Simon Martín
742420b159
Merge pull request #744 from CartoDB/time-series-refactor
...
Histogram refactor
2017-10-02 17:18:21 +02:00
Simon Martín
55f593eae6
adding forgotten semicolon
2017-10-02 12:08:10 +02:00
Simon Martín
f9d87bc40f
res.locals fixing controllers
2017-10-02 12:07:35 +02:00
Simon Martín
783eb0eec7
res.locals format and layer in namep maps
2017-09-29 17:03:57 +02:00
Simon Martín
c22a35489d
res.locals forgotten things and make jshint happy
2017-09-29 14:38:28 +02:00
Simon Martín
482feabce2
res.locals in named maps controller
2017-09-29 14:37:55 +02:00
Simon Martín
0a753400e0
res.locals in map controller
2017-09-29 12:54:21 +02:00
Simon Martín
a21648ab4a
res.locals in layergroup controller
2017-09-29 12:32:46 +02:00
Simon Martín
b4d03c074a
not move db params to res.locals.db
2017-09-29 11:07:11 +02:00
Raul Ochoa
78b75c7a88
Removes list dataview type
2017-09-28 10:47:44 +00:00
David Manzanares
ad1abb28af
Add configuration flag to enable/disable direct PgSQL MVT
2017-09-28 12:08:22 +02:00
Simon Martín
f824fc5243
base and analyses controller
2017-09-28 12:02:34 +02:00
Simon Martín
4a2cc6a5f8
res.locals in auth_api
2017-09-28 11:55:36 +02:00
Simon
ca612dd02a
res.locals in context middlewares
2017-09-28 11:43:12 +02:00
Unknown
fedcb0d0f9
remove unused middleware
2017-09-28 11:23:53 +02:00
Simon
178b9e8563
moving layergroup-token middleware to middlewarify style
2017-09-27 16:32:49 +02:00
Simon
ac474cb253
Merge branch 'middlewarify' into layergroup-token-param
2017-09-27 16:31:08 +02:00
Simon
84cd93b1b0
make jshint happy
2017-09-26 18:25:47 +02:00
Simon
134cc9ac0c
changing req.locals to res.locals
2017-09-26 18:23:49 +02:00
Daniel García Aubert
4600005a86
Bring ported test back
2017-09-26 17:31:57 +02:00
Simon
b94dfe066d
removing some repeated things
2017-09-26 15:39:48 +02:00
Simon
3f6afb4530
validation middleware for layer route (conflicting route)
2017-09-26 14:56:20 +02:00
Simon
540fda1e6c
Merge branch 'master' into middlewarify
2017-09-26 14:53:57 +02:00
Daniel García Aubert
4899c7ffef
Inject prepare context middleware to controllers
2017-09-25 19:40:27 +02:00
Raul Ochoa
b943b09532
Merge pull request #736 from CartoDB/static-named-maps-override-bbox
...
Static named maps override bbox
2017-09-25 14:10:27 +02:00
Daniel García Aubert
f0920aedef
Remove unused module
2017-09-25 13:43:15 +02:00
Daniel García Aubert
b236112069
Split prepare context middleware and fix unit test
2017-09-25 13:40:22 +02:00
Daniel García Aubert
0e8fb68794
Extract token param to a middleware
2017-09-22 18:49:21 +02:00
Daniel García Aubert
f7b9287c93
Return an array of middlewares instead of big one in prepare context
2017-09-22 18:24:16 +02:00
Daniel García Aubert
85d4c81e58
Remove legacy hack
2017-09-22 18:15:48 +02:00
Daniel García Aubert
3bab081438
Rename req2params by prepareContext
2017-09-22 17:56:47 +02:00
Daniel García Aubert
6dc9cc0b23
Remove req2params dependency
2017-09-22 17:56:08 +02:00
Daniel García Aubert
8fd35849c7
Merge branch 'middlewarify' of github.com:CartoDB/Windshaft-cartodb into middlewarify
2017-09-22 17:15:41 +02:00
Simon
c09899913f
finishing integration of lzma middleware
2017-09-22 16:46:39 +02:00
Daniel García Aubert
0bdeee64a7
Use express router to group controllers' enpoints and reuse common middleware for named maps admin controller
2017-09-22 16:45:34 +02:00
Daniel García Aubert
ee8619c470
Use express router to group controllers' enpoints and reuse common middleware for analysis controller
2017-09-22 16:28:52 +02:00
Simon
9d81321d78
Merge branch 'master' into middlewarify
2017-09-22 16:26:56 +02:00
Simon Martín
ca63c2ef1a
Merge pull request #721 from CartoDB/lzma-middleware
...
Implement LZMA query param inflating as middleware
2017-09-22 16:16:36 +02:00
Daniel García Aubert
b0486f9bae
Use express router to group enpoints and reuse common middlewares for layergroup controller
2017-09-22 15:44:12 +02:00
Raul Ochoa
22b7828725
Layergroup Token parsing as middleware
...
Reuses LayergroupToken model from tests.
2017-09-22 12:05:40 +00:00
Raul Ochoa
78404b1308
Merge remote-tracking branch 'origin/master' into layergroup-token-param
2017-09-22 11:12:42 +00:00
Raul Ochoa
45698207d9
Merge remote-tracking branch 'origin/master' into static-named-maps-override-bbox
2017-09-22 11:08:12 +00:00
Daniel García Aubert
9bd862ffaf
Remove req2params from BaseController and update related test to use the middleware
2017-09-22 01:08:46 +02:00
Daniel García Aubert
8139cdf8b2
Use req2params middleware for name maps static views endpoint
2017-09-22 00:58:44 +02:00
Daniel García Aubert
a8898a8022
Use req2params middleware for name maps tile endpoint
2017-09-22 00:48:44 +02:00
Daniel García Aubert
df5ec0f4d9
Use req2params middleware for analysis catalog endpoint
2017-09-22 00:42:17 +02:00
Daniel García Aubert
51ba3db4ac
Use req2params middleware for instantiate named map endpoint
2017-09-22 00:31:16 +02:00
Daniel García Aubert
d31e52a625
Fix format, break line in bad position
2017-09-21 22:55:30 +02:00
Daniel García Aubert
3a8b99a14e
Use req2params middleware for tile and layer endpoint
2017-09-21 22:53:31 +02:00
Daniel García Aubert
fac1ab4a1c
Use req2params middleware for attributes endpoint
2017-09-21 22:47:08 +02:00
Daniel García Aubert
a9b0acc317
Use req2params middleware for static map (bbox & center) endpoint
2017-09-21 22:43:59 +02:00
Daniel García Aubert
e2ed0058d8
Use req2params middleware for layergroup create endpoint
2017-09-21 21:52:34 +02:00
Daniel García Aubert
2f499a148a
Use req2params middleware for dataview endpoint
2017-09-21 14:33:32 +02:00
Daniel García Aubert
49204650c6
Use req2params middleware for datavie search endpoint
2017-09-21 14:30:19 +02:00
Daniel García Aubert
234576ab5f
Use req2params middleware for analisys node status endpoint
2017-09-21 13:37:32 +02:00
Daniel García Aubert
02cd6a43ad
Move req2params method to a its own middleware
2017-09-21 13:27:22 +02:00
Daniel García Aubert
429f070372
Pass node's response object to req2params
2017-09-21 12:22:33 +02:00
Daniel García Aubert
3b9c561cee
Change signature of req2params to follow express' middleware pattern
2017-09-21 11:54:37 +02:00
Daniel García Aubert
daeae5d95c
Implement error-middleware to handle errors at top level
2017-09-21 11:46:42 +02:00
Simon
222cfb90fd
Removing 'self' vars using arrow functions
2017-09-18 12:20:59 +02:00
Simon
f63fab40ed
Removing 'self' vars using arrow functions
2017-09-18 11:34:18 +02:00
Daniel García Aubert
61ea05d1c2
Do not assign a value by default for special float values counters
2017-09-15 14:51:02 +02:00
Daniel García Aubert
64c3e68303
Fix double declaration of 'result'
2017-09-15 14:48:54 +02:00
Daniel García Aubert
d4bb4edd1d
Applyy extract method to check input options
2017-09-15 14:43:41 +02:00
Daniel García Aubert
419b29e609
Do not prefix with '_' template context
2017-09-15 14:43:26 +02:00
Daniel García Aubert
c7ed3d34e8
Use const instead of var to declare variables
2017-09-15 14:43:13 +02:00
Daniel García Aubert
1959a841fd
Use arrow function to take advantage of bound context
2017-09-15 14:26:22 +02:00
Daniel García Aubert
ef5049f28f
Use destructuring assignment to improve readability
2017-09-15 14:07:46 +02:00
Daniel García Aubert
d5d9044686
Use const keyword to declare variables
2017-09-15 14:05:23 +02:00
Daniel García Aubert
5d632d936e
Use ES6 class syntax
2017-09-15 14:04:09 +02:00
Daniel García Aubert
90c4796d4e
Remove empty line
2017-09-15 13:41:54 +02:00
Daniel García Aubert
ada58f6ea2
Use const keyword to declare varibles
2017-09-15 13:35:00 +02:00
Daniel García Aubert
b4ce13e429
Use object shorthand notation
2017-09-15 11:56:59 +02:00
Daniel García Aubert
11f7b38c69
Do not use dot module to build column type query
2017-09-15 11:54:56 +02:00
Daniel García Aubert
9771979b8f
Missing call to super class in constructor
2017-09-15 10:59:07 +02:00
Daniel García Aubert
c00a93f414
Use destruturing assignment to format the formula result
2017-09-15 10:58:11 +02:00
Daniel García Aubert
ecbc7a28e7
Declare constants with const keyword
2017-09-15 10:49:20 +02:00
Daniel García Aubert
68dfed8b85
Use ES6 class syntax
2017-09-15 10:48:44 +02:00
Daniel García Aubert
2437288d9d
Replace widget word by dataview
2017-09-15 10:37:51 +02:00
Daniel García Aubert
9c64d674b3
Do not use underscore
2017-09-14 18:02:13 +02:00
Daniel García Aubert
a4ecc18f2f
Use default values for constructor's arguments
2017-09-14 17:57:24 +02:00
Daniel García Aubert
1063d81c1b
Rename debug namespace
2017-09-14 17:56:40 +02:00
Daniel García Aubert
dcb9b8ec52
Rename BaseWidget by BaseDataview
2017-09-14 17:56:17 +02:00
Daniel García Aubert
dbb23bf9f0
Remove jshint's complaints
2017-09-14 17:24:13 +02:00
Daniel García Aubert
2a0b15f085
Remove prefix '_' while passing context param to templates
2017-09-14 17:22:34 +02:00
Daniel García Aubert
d0e2c9f898
Use debug module to print sql for debugging purposes
2017-09-14 17:21:21 +02:00
Daniel García Aubert
d328b534a5
Replace widget word by dataview
2017-09-14 17:19:16 +02:00
Daniel García Aubert
050e9776d1
Use const for requirements, constants and variables that are initialized once
2017-09-14 17:18:20 +02:00
Daniel García Aubert
c8ff61c531
Use ES6 class syntax
2017-09-14 17:15:43 +02:00
Daniel García Aubert
cdc56e703c
Rename BaseWidget by BaseDataview
2017-09-14 17:10:51 +02:00
Daniel García Aubert
9a4794ee10
Remove dot requirement and use template strings to build list aggregation query
2017-09-14 17:09:55 +02:00
Daniel García Aubert
51907b9545
Apply extract method to condition
2017-09-14 16:56:55 +02:00
Daniel García Aubert
1f3b0beddf
Fix missing parameter
2017-09-14 16:47:05 +02:00
Daniel García Aubert
38e2c040d1
Use template string to escape literals
2017-09-14 16:45:45 +02:00
Daniel García Aubert
46860541fe
Apply extract method to validate input options
2017-09-14 16:42:25 +02:00
Daniel García Aubert
c2e99219ef
Use ES6 goodies to refactor format method
2017-09-14 16:30:46 +02:00
Daniel García Aubert
cc2cf78264
Rename all 'widget' ocurrences by 'dataview'
2017-09-14 16:12:39 +02:00
Daniel García Aubert
746292610a
Rename debug namespace
2017-09-14 16:10:23 +02:00
Daniel García Aubert
b05083bcfc
Move search's templates along aggregation's templates
2017-09-14 16:09:44 +02:00
Daniel García Aubert
cd13107a4d
Use ES6 let & const to declare variables
2017-09-14 16:08:12 +02:00
Daniel García Aubert
46254eaf74
rename BaseWidget by BaseDataview
2017-09-14 15:59:15 +02:00
Daniel García Aubert
086eff01a9
Use ES6 class syntax
2017-09-14 15:57:18 +02:00
Daniel García Aubert
02949003a9
Build search query in two steps
2017-09-14 15:48:54 +02:00
Daniel García Aubert
0a894da0df
Remove prefix to context's properties
2017-09-14 15:27:57 +02:00
Daniel García Aubert
e2ab48bee2
Remove prefix to context's properties
2017-09-14 15:22:58 +02:00
Daniel García Aubert
132fce84c5
Remove string template in the middle
2017-09-14 15:07:30 +02:00
Daniel García Aubert
b1508af007
Remove prefix to context's props in order to share it throught all templates avoiding to duplicate passing custom params again and again
2017-09-14 13:14:12 +02:00
Daniel García Aubert
65dca454f4
Move aggragation query to its own query template
2017-09-14 12:18:03 +02:00
Daniel García Aubert
3682740f08
Build aggregation query with string templates avoiding to join all inner templates
2017-09-14 12:01:41 +02:00
Daniel García Aubert
a434015d5b
Move categories CTE template out of aggregation class
2017-09-14 11:27:03 +02:00
Daniel García Aubert
2f4f719f55
Use object properties in class method instead of passing them as parameters
2017-09-13 19:42:25 +02:00
Daniel García Aubert
75645e2d7a
Use string templates to build categories CTE sql
2017-09-13 19:34:09 +02:00
Daniel García Aubert
4d1a53c20f
Use string templates to build error message
2017-09-13 19:27:25 +02:00
Daniel García Aubert
ee471184b9
Use default values for input params
2017-09-13 19:19:25 +02:00
Daniel García Aubert
4518b7cb6e
Declare requirement with const keyword
2017-09-13 19:17:16 +02:00
Daniel García Aubert
306df5be5a
Replace underscore's function by ES6 equivalents
2017-09-13 19:16:08 +02:00
Daniel García Aubert
33e8657e35
Declare constants with const keyword
2017-09-13 18:40:09 +02:00
Daniel García Aubert
6fd3388fa2
Replace dot templates by ES6 string templates
2017-09-13 18:38:54 +02:00
Daniel García Aubert
4a89ad57d7
Remove '_' as prefix for template's context properties
2017-09-12 13:05:46 +02:00
Daniel García Aubert
c0cfdad7d1
Use hasOwnProperty method to check if histogram is a time-series
2017-09-12 10:38:53 +02:00
Daniel García Aubert
8f797c3c41
Fix EOF
2017-09-12 10:16:16 +02:00
Daniel García Aubert
2576c3e7d5
Rename _shouldOverrideRange & _shouldOverrideBins methods
2017-09-12 10:14:55 +02:00
Daniel García Aubert
3a936474cf
Fix bad merge with master
2017-09-11 19:48:46 +02:00
Daniel García Aubert
a98f5bf08b
Merge branch 'master' into time-series-refactor
2017-09-11 19:38:21 +02:00
Daniel García Aubert
03babcb43b
Simplify condition and remove unused method
2017-09-11 19:31:38 +02:00
Daniel García Aubert
9aa5a9e850
Improve comment
2017-09-11 19:26:28 +02:00
Daniel García Aubert
e3bffcd39d
Use inline functions to filter desired fields of the row
2017-09-11 19:24:01 +02:00
Daniel García Aubert
5fc2b46d56
Fix bad condition
2017-09-11 19:14:11 +02:00
Daniel García Aubert
7c69240748
Use parameter default value
2017-09-11 19:10:06 +02:00
Daniel García Aubert
ee43378c68
Use arrow function
2017-09-11 19:09:05 +02:00
Daniel García Aubert
09981c2560
Extract method to check valid aggregation
2017-09-11 18:57:16 +02:00
Daniel García Aubert
fd9534797c
Minor refactors
2017-09-11 18:44:14 +02:00
Daniel García Aubert
38e7e71328
Implement template method pattern to format histogram query output
2017-09-11 17:19:02 +02:00
Daniel García Aubert
271932a80d
Extract condition to a method
2017-09-11 17:17:42 +02:00
Daniel García Aubert
4f33e0d794
Rename Histogram.dataview by Histogram.histogramImplementation
2017-09-11 15:34:42 +02:00
Daniel García Aubert
ec23bfc79b
Rename HistogramBase by BaseHistogram
2017-09-11 13:54:46 +02:00
Daniel García Aubert
6c3fa045cd
Rename HistogramBase by BaseHistogram
2017-09-11 13:53:05 +02:00
Simon
d75ee965ae
changing some 'var' to 'let/const'
2017-09-11 11:48:33 +02:00
Simon
5e9b2e45c7
creating HistogramBase with the common functions of NumericHistogram and DateHistogram
2017-09-11 11:32:20 +02:00
Simon
e4a20fa954
adding forgotten return
2017-09-08 17:57:35 +02:00
Simon
a20900210d
removing unneeded _isDateHistogram function
2017-09-08 17:54:25 +02:00
Simon
2650c3b3e6
removing self=this assignment
2017-09-08 17:51:02 +02:00
Simon
25ef2610aa
Varible declarations to let/const
2017-09-08 17:43:10 +02:00
Simon
92f6f59e07
Fix jshint style errors
2017-09-08 16:13:23 +02:00
Simon
5e07cc2ad1
Remove unneeded condittion
2017-09-08 16:06:54 +02:00
Simon
5593d92c4b
Do not choose histogram implementation until getResult()
2017-09-08 15:55:23 +02:00
Simon
29f32cb9cc
Expose dataview's methods to bypass concrete overview's implementations
2017-09-08 15:53:00 +02:00
Simon
1d4935cc9a
Fix undefined while destrutcuring assignment
2017-09-08 15:50:01 +02:00
Simon
f75b4312a1
Fix undefined while destructuring assignment
2017-09-08 15:49:25 +02:00
Simon
23dd143fa5
Make Histogram class as context of state pattern
2017-09-08 12:48:08 +02:00
Simon
7d42afcdb4
remove unnecessary properties of NumericHistogram
2017-09-08 12:22:24 +02:00
Simon
78b95d05d0
make private functions
2017-09-08 12:21:22 +02:00
Simon
fb753e50a2
remove getOffset function
2017-09-08 12:19:05 +02:00
Simon
c863cdd9f6
remove getAggregation function
2017-09-08 12:17:29 +02:00
Simon
a4ebce52db
remove unnecessary properties in format function
2017-09-08 12:16:56 +02:00
Simon
4a00a2d673
rename buildQueryTpl by _buildQueryTpl
2017-09-08 12:15:21 +02:00
Simon
38f0e23efe
rename buildNumericHistogramQueryTpl by buildQueryTpl
2017-09-08 12:10:31 +02:00
Simon
7f14785091
fix namespace for debugging
2017-09-08 12:07:49 +02:00
Simon
db969a51ad
make public some private functions
2017-09-08 12:07:07 +02:00
Simon
3441ad6aa9
rename _buildDateHistogramQueryTpl by _buildQueryTpl
2017-09-08 12:04:25 +02:00
Simon
347dea8f66
naming private functions
2017-09-08 12:01:15 +02:00
Simon
a3112aa929
fix function name in recursion
2017-09-08 11:55:28 +02:00
Simon
157946cc42
Rename DateHistogram class
2017-09-08 11:54:30 +02:00
Simon
8ce25d958c
fix namespace for debugging
2017-09-08 11:53:47 +02:00
Daniel García Aubert
7e099be134
Add specific implementations of histograms based on column type; still not used
2017-09-08 10:29:54 +02:00
Javier Torres
7dd5c5b15d
Do not use distinct when calculating quantiles
2017-09-07 14:39:25 +02:00
Daniel García Aubert
63a7ee08d0
Avoid nested ternaries for date histograms
2017-09-06 19:15:39 +02:00
Daniel García Aubert
b63a67a5b8
Avoid nested ternaries
2017-09-06 18:33:51 +02:00
Daniel García Aubert
1ac8455dc2
Use template strings to build histogram query
2017-09-06 18:13:34 +02:00
Daniel García Aubert
9f52e58be8
Rename BaseWidget by BaseDataview
2017-09-06 16:54:08 +02:00
Daniel García Aubert
4edf18f77a
Remove underscore requirement
2017-09-06 16:52:17 +02:00
Daniel García Aubert
b5d2de8edc
Do not use _.omit()
2017-09-06 16:49:00 +02:00
Ivan Malagon
bd8d147a7d
Fix out of range bug in date histograms
2017-09-06 16:21:01 +02:00
Daniel García Aubert
8ac041805c
Use typeof !== string instead of underscore's equivalent
2017-09-06 16:20:01 +02:00
Daniel García Aubert
6e0dc8666d
Use .hasOwnProperty() instead of underscore's equivalent
2017-09-06 16:14:29 +02:00
Daniel García Aubert
3e55bd2abb
Make happy to jshint
2017-09-06 15:56:52 +02:00
Daniel García Aubert
da1d0550f6
Use const keyword for constants
2017-09-06 15:52:13 +02:00
Daniel García Aubert
c37ef36a61
Move parseOffset function to a class method
2017-09-06 15:49:05 +02:00
Daniel García Aubert
9e3e1cad9a
Move getWidth function to a class method
2017-09-06 15:47:21 +02:00
Daniel García Aubert
e84f30488f
Move getBinsCount function to a class method
2017-09-06 15:45:51 +02:00
Daniel García Aubert
49a60caffc
Move getBinEnd function to a class method
2017-09-06 15:42:29 +02:00
Daniel García Aubert
392e004879
Move getBinStart and populateBinStart function to a class method
2017-09-06 15:38:23 +02:00
Daniel García Aubert
288656301b
Move getOffset function to a class method
2017-09-06 15:37:28 +02:00
Daniel García Aubert
96740b82ed
Move getAggregation function to a class method
2017-09-06 13:52:02 +02:00
Daniel García Aubert
1be66e1552
Use const for requirements
2017-09-06 13:47:19 +02:00
Daniel García Aubert
5ba2dfbbd6
Use ES6 class syntax
2017-09-06 13:43:54 +02:00
Daniel García Aubert
af4b3d81cd
make happy to jshint
2017-09-06 11:55:40 +02:00
Daniel García Aubert
bbd42b73f2
Remove dot requirement
2017-09-06 11:44:52 +02:00
Daniel García Aubert
8e2535745e
Use template string for columnCastTpl
2017-09-06 11:44:25 +02:00
Daniel García Aubert
4f75f6c07b
Use template string for dateBinsQueryTpl and dateHistogramQueryTpl
2017-09-06 11:41:24 +02:00
Daniel García Aubert
0ede3013db
Use template string for dateOverrideBasicsQueryTpl
2017-09-06 10:57:38 +02:00
Daniel García Aubert
0b79ac76db
Use template string for dateBasicsQueryTpl
2017-09-06 10:39:17 +02:00
Daniel García Aubert
2739364193
Use template string for histogramQueryTpl
2017-09-05 15:53:21 +02:00
Daniel García Aubert
adcff54589
Use template string for nansQueryTpl
2017-09-05 15:53:06 +02:00
Daniel García Aubert
734cfa6d83
Fix undefined argument
2017-09-05 15:51:31 +02:00
Daniel García Aubert
7ea6b3e371
Use template string for infinitiesQueryTpl
2017-09-05 12:21:30 +02:00
Daniel García Aubert
f1018f3272
Use template string for nullsQueryTpl
2017-09-05 12:18:42 +02:00
Daniel García Aubert
151bdec1fd
Use template string for overrideBinsQueryTpl
2017-09-05 12:16:38 +02:00
Daniel García Aubert
5d413ac1f9
Use template string for overrideBasicsQueryTpl
2017-09-05 11:26:38 +02:00
Daniel García Aubert
37b1376767
Fix bad find & replace
2017-09-05 11:26:27 +02:00
Daniel García Aubert
00741bc0a4
Use template string for basicsQueryTpl
2017-09-05 10:41:48 +02:00
Daniel García Aubert
c580600590
Extract template to filter out special numeric values
2017-09-05 10:36:18 +02:00
Daniel García Aubert
6373fe8652
Use template string for filteredQueryTpl
2017-09-04 19:01:58 +02:00
Daniel García Aubert
5ce419d863
Use template string for dateIntervalQueryTpl
2017-09-04 18:42:30 +02:00
Raul Ochoa
91ce3a5489
Going green: allow to use bbox param, along lon, lat, and zoom
...
The `bbox` param was removed from the base controller, the rest kept
working as they are declared in the base, but it's better to declare
them here as well.
Fixes #735 .
2017-08-29 13:05:03 +00:00
Raul Ochoa
1c6a76af72
Merge pull request #726 from CartoDB/725-polygon-count
...
725 fix polygon count
2017-08-16 15:33:19 +02:00
Raul Ochoa
e7c206762d
String comparison and regex to match errors instead of indexOf
2017-08-10 16:09:26 +02:00
Raul Ochoa
69eaa72819
String comparison and regex to match errors instead of indexOf
2017-08-10 16:06:10 +02:00
Raul Ochoa
23edf78a67
Remove unnecessary step
2017-08-10 15:58:25 +02:00
Simon
814b123b2b
fix 725 using the ST_Intersects function instead of &&
2017-08-09 18:55:14 +02:00
Daniel García Aubert
14f85abd39
Merge branch 'master' into response-time-limit
2017-08-09 18:48:38 +02:00
Daniel García Aubert
c643160671
Prefix date interval query (to calculate automatic aggregation) to avoid name collision
2017-08-08 10:32:53 +02:00
Daniel García Aubert
e7a0b246a3
Prefix with double underscore
2017-08-08 10:20:36 +02:00
Daniel García Aubert
3c061769c6
Prefix basics columns to avoid name collision
2017-08-08 10:11:35 +02:00
Daniel García Aubert
7e159c565b
Prefix iqr query calculation to avoid name collision
2017-08-08 10:03:40 +02:00
Daniel García Aubert
ff3d7ed7b2
Fix jshint typo
2017-08-08 09:57:12 +02:00
Daniel García Aubert
cf71489a7f
Prefix nans and infinities counters to avoid name collision
2017-08-08 09:54:49 +02:00
Daniel García Aubert
c7e5dbf158
Fix query aliases
2017-08-08 09:46:34 +02:00
Daniel García Aubert
34cf45bc9d
Prefix infinities query to avoid name collision
2017-08-08 09:43:31 +02:00
Daniel García Aubert
7e058955ea
Use final naming to group by
2017-08-08 09:39:51 +02:00
Daniel García Aubert
a9e3bc3cda
Prefix filtered source to avoid name collision
2017-08-08 09:36:23 +02:00
Daniel García Aubert
3ee064a59f
Prefix nulls query to avoid name collision
2017-08-08 09:32:13 +02:00
Daniel García Aubert
f3ababffc1
Prefix bins query to avoid name collision
2017-08-08 09:12:52 +02:00
Daniel García Aubert
0f8de9e74b
Add prefix to basics query to avoid name collision
2017-08-08 09:06:36 +02:00
Daniel García Aubert
91d5a0e4e4
Remove column avg_val in group_by
2017-08-08 08:46:26 +02:00
Daniel García Aubert
e446160151
Use final columns to group by
2017-08-08 08:45:05 +02:00
Daniel García Aubert
823925d091
Add prefix to bins_array to avoid name collision
2017-08-08 08:41:22 +02:00
Daniel García Aubert
994e58bef7
Add prefix to bins_number and nulls_cout to avoid name collision
2017-08-08 08:33:26 +02:00
Daniel García Aubert
5c80ff8191
Extract query: move condition to a method
2017-08-07 19:24:15 +02:00
Daniel García Aubert
b2bbc329ea
Apply prefix for intermediate query variables to avoid name colision
2017-08-07 19:03:49 +02:00
Daniel García Aubert
1f8da14c2a
Cast to timestamp start_date and end_date to calculate bins when date column is timestamptz
2017-08-07 18:27:24 +02:00
Daniel García Aubert
660078f284
Fix minor issues with timezones
2017-08-07 16:53:08 +02:00
Raul Ochoa
e9d925334c
Move layergroup-token to models
...
We will share it between tests and a middleware to parse the token.
2017-08-04 17:51:10 +02:00
Raul Ochoa
399561d076
Implement LZMA query param inflating as middleware
...
The req2params method is doing too many things,
this is an initial step to do fewer things in that method.
2017-08-04 17:30:46 +02:00
Javier Goizueta
82cab3ccc7
Merge pull request #719 from CartoDB/ramp-infinities-nans
...
Exclude Infinities & NaNs from ramps
2017-08-04 09:38:44 +02:00
Daniel García Aubert
48ad7059e1
Going green: do not rely on falsy conditional
2017-08-03 18:23:55 +02:00
Daniel
a696bdc723
Merge pull request #706 from CartoDB/705-special-numeric-values
...
Support special numeric values for json responses
2017-08-03 15:21:29 +02:00
Daniel García Aubert
b56d2ec30b
Validate aggregation value
2017-08-03 12:24:05 +02:00
Daniel García Aubert
7fed91900d
Handle error
2017-08-03 12:19:34 +02:00
Javier Goizueta
b4799124e6
Exclude non-finite values when computing ramps
2017-08-02 17:28:46 +02:00
Daniel García Aubert
0a57e86cb8
Do not build data histogram infinitely when overriding aggregation with auto mode
2017-08-02 12:06:10 +02:00
Daniel García Aubert
3574700c2d
Remove tiler render limit
2017-08-02 11:07:44 +02:00
Daniel García Aubert
ab879e2634
Use new version of getUserTimeoutRenderLimits
2017-08-01 19:13:55 +02:00
Daniel García Aubert
9034508244
Support automattic aggregation only when aggregation para is set to 'auto'
2017-08-01 17:15:45 +02:00
Daniel García Aubert
b2b68ffd5c
Merge branch 'master' into 691-date-histogram
2017-08-01 16:07:27 +02:00
Daniel García Aubert
0594407b38
Change error message
2017-08-01 15:03:09 +02:00
Daniel García Aubert
262f854e68
Remove error wrapping
2017-08-01 13:10:55 +02:00
Daniel García Aubert
9258ad7ecc
Fix style typo
2017-08-01 12:56:03 +02:00
Daniel García Aubert
4c3e3005aa
Apply asset fallback to database timeout errors
2017-08-01 12:52:34 +02:00
Daniel García Aubert
44fc34b1ce
Improve timeout error message
2017-07-31 20:07:31 +02:00
Daniel García Aubert
1fdc0621e7
Categorize timeout errors
2017-07-31 19:36:07 +02:00
Daniel García Aubert
5974413d5c
Use 429 to indicate timeout errors
2017-07-31 19:08:29 +02:00
Daniel García Aubert
49d2f513c6
Fix typo
2017-07-31 18:51:23 +02:00
Daniel García Aubert
f2e043b063
Do not expose database error info
2017-07-31 17:56:58 +02:00
Daniel García Aubert
eee4fc815e
Do not expose database error details
2017-07-25 19:11:56 +02:00
Daniel García Aubert
669707b26c
Fix typo
2017-07-18 11:56:54 +02:00
Daniel García Aubert
40dc94e010
Merge branch 'master' into response-time-limit
2017-07-18 11:25:23 +02:00
Daniel García Aubert
eccc3597aa
Respond with 204 when vector tile is empty
2017-07-17 19:44:18 +02:00
Carlos Matallín
e30b883906
Merge branch '691-date-histogram' into 691-date-histogram-offset
2017-07-14 18:38:13 +02:00
Carlos Matallín
70b4d5b7fd
replace timezone => offset
2017-07-14 18:30:36 +02:00
Daniel García Aubert
0fffafa1db
Add timestamp_start in histogram summary to help to build the histogram in frontend side
2017-07-14 18:22:05 +02:00
Daniel García Aubert
21b8655f85
Return timezone applied or 0 if not present
2017-07-13 19:42:22 +02:00
Daniel García Aubert
c8286233be
Do not apply timezone for minute an hour aggregations
2017-07-12 17:08:55 +02:00
Daniel García Aubert
b67f6053e8
Should respect first timestamp as bin_start
2017-07-12 15:19:28 +02:00
Daniel García Aubert
967dca9578
Improve readability
2017-07-12 15:10:39 +02:00
