Daniel García Aubert
6229455d25
Remove mechanism to reset named map's provider as, in the end, it's reading from storage (redis) always so cache isn't doing its job. There is already a mechanism to invalidate cache entry when a template is modified (see template-maps emits on "update" and "delete", and listeners attached at server startup)
2019-09-12 20:34:18 +02:00
Daniel García Aubert
9d6726227a
Add maxAge param to lru-cache to be able to refresh entries when staled
2019-09-12 18:02:13 +02:00
Daniel García Aubert
64b4efef17
Do not cache map template CRUD errors in Named Map provider
2019-09-12 17:23:19 +02:00
Daniel García Aubert
2fbd9893bd
Going green: do not fail when source is empty
2019-09-02 14:09:13 +02:00
Daniel García Aubert
9a85b661b0
Remove safe limit
2019-08-23 18:04:19 +02:00
Daniel García Aubert
d4d981909b
Remove unused code
2019-08-23 17:43:20 +02:00
Daniel García Aubert
16035131bc
Rename method
2019-08-23 17:25:37 +02:00
Daniel García Aubert
b2adb8f058
Use substituteDummyTokens
2019-08-23 17:21:01 +02:00
Daniel García Aubert
780cb80c8c
Move method
2019-08-23 17:16:35 +02:00
Daniel García Aubert
2a8a8f6e6a
Export methods to get max, min, values od a column and sample based on a range
2019-08-23 17:10:46 +02:00
Daniel García Aubert
850bda9669
Use modified sample method
2019-08-23 17:09:53 +02:00
Daniel García Aubert
25e3395580
Modify sample metadata
2019-08-23 17:09:24 +02:00
Daniel García Aubert
a220af4fad
Please jshint
2019-07-29 19:20:38 +02:00
Daniel García Aubert
945c122dda
Update windshaft devel branch
2019-07-29 19:14:27 +02:00
Raul Marin
b572b979a1
Style
2019-07-16 13:43:46 +02:00
Raul Marin
de49aa0bd4
Aggregation: Style improvements
2019-07-16 12:49:09 +02:00
Raul Marin
286daa9bec
Simplify aggregation templates
2019-07-16 12:49:09 +02:00
Raul Marin
63b6af2ac7
Query utils: Use webmercator utils, reuse code and always substitute tokens
2019-07-16 12:49:09 +02:00
Raul Marin
46600bf4fc
Please jshint
2019-07-16 12:48:58 +02:00
Raul Marin
aed456bf32
Cluster: Use new webmercator utilities
2019-07-16 12:48:58 +02:00
Raul Marin
d3e807583a
Use proper mode
2019-07-16 12:48:58 +02:00
Raul Marin
262f957218
Aggregation: Improve speeeeeeed
2019-07-16 12:48:58 +02:00
Raul Marin
8454eef6e9
Aggregation: Extract the query to get the grid data
2019-07-16 12:48:58 +02:00
Raul Marin
5e24f650af
Rework how aggregations are calculated
...
Pending fixing Mapnik tiles (pg-mvt work ok)
2019-07-16 12:48:12 +02:00
Raul Marin
a3e8f45552
WIP to change how aggregations are calculated
2019-07-16 12:48:12 +02:00
Raul Marin
cd8624ae2d
Improve subquery naming
2019-07-16 12:48:12 +02:00
Raul Marin
7b731a24d1
Overviews Adapter: Do not check overviews if using MVT pure style or aggregations
2019-07-16 12:48:12 +02:00
Daniel García Aubert
619cad9c35
Typo
2019-07-09 15:44:34 +02:00
Daniel García Aubert
a84184852e
Going green: skip analyses table while computing max-age directive
2019-07-08 18:05:30 +02:00
Daniel García Aubert
4def4b0341
Improve condition
2019-07-04 16:41:30 +02:00
Daniel García Aubert
ec0c0eb810
Improve readability
2019-07-04 16:24:17 +02:00
Daniel García Aubert
a894194b6b
Add more specific tests
2019-07-04 15:58:39 +02:00
Daniel García Aubert
a374deaf30
Please linter
2019-07-03 17:16:09 +02:00
Daniel García Aubert
bc29587c55
Set directive 'max-age' to 5 min when there are affacted tables where we can't know when were updated for the last time, e.g: non cartodified tables or foreing tables without cartodb support
2019-07-03 17:15:14 +02:00
Daniel García Aubert
f21eda2b40
Adapt endpoints to the new preview interface
2019-06-17 10:43:30 +02:00
Daniel García Aubert
20fe04de38
Do not get headers from abaculus
2019-06-10 13:16:05 +02:00
Daniel García Aubert
dc16f4cebf
Update windshaft devel branch
2019-06-10 12:49:56 +02:00
Daniel García Aubert
6808ab496a
Use semver for cheking dependencies version
2019-03-29 15:30:29 +01:00
Daniel García Aubert
035acb343e
Fix uncaught exception: TypeError: Cannot read property 'id' of undefined
2019-03-27 11:45:47 +01:00
Raul Marin
ae59c4f996
Merge remote-tracking branch 'blessed/master' into 1073-aggregation-false
2019-03-14 17:01:07 +01:00
Raul Marin
8db090ae9c
Numeric histogram: Test when start and end are provided but not bins
2019-03-14 15:16:23 +01:00
Raul Marin
730076469e
Numeric histogram: Simplify bin calculation
2019-03-14 15:16:23 +01:00
Raul Marin
6241b23d4f
Histogram: Speed up IRQ calculation
2019-03-14 15:16:23 +01:00
Daniel García Aubert
367ca399c8
Improve readability
2019-03-11 18:53:47 +01:00
Daniel García Aubert
d86b01ba33
Add debug statement
2019-03-11 18:09:41 +01:00
Daniel García Aubert
0aa3b288a0
Improve validation
2019-03-11 18:04:47 +01:00
Daniel García Aubert
589996b79c
Reduce complexity
2019-03-11 17:53:34 +01:00
Daniel García Aubert
49104a6add
Reduce complexity by extracting function to validate expressions
2019-03-11 17:25:29 +01:00
Daniel García Aubert
8051dc5110
Reduce complexity by extracting validation condition to its function
2019-03-11 17:14:07 +01:00
Daniel García Aubert
fecedfdc68
Reduce complexity by extracting validation to a function
2019-03-11 17:06:04 +01:00
Daniel García Aubert
f0c82f21d2
Reduce complexity by extracting a complex condition to a function
2019-03-11 17:01:13 +01:00
Javier Goizueta
c91b28ee92
Lint fixes
2019-03-06 18:32:17 +01:00
Javier Goizueta
113b3728b1
Fix support of boolean aggregation layer option
2019-03-06 18:14:15 +01:00
Daniel García Aubert
2a0287b358
Add todos
2019-03-01 17:49:26 +01:00
Daniel García Aubert
f5fb60aa56
Filter output
2019-03-01 17:34:32 +01:00
Daniel García Aubert
dcf147cdfb
linter
2019-03-01 17:05:35 +01:00
Daniel García Aubert
f9e5d9d0a9
Validate aggregation expresions
2019-03-01 17:02:06 +01:00
Daniel García Aubert
57a229655c
Implement aggregation functions
2019-03-01 15:45:38 +01:00
Daniel García Aubert
6dadb1bf6f
Validate aggregation input
2019-03-01 15:17:22 +01:00
Daniel García Aubert
77d5d8ebd4
Be able to aggregate by a field
2019-03-01 11:21:18 +01:00
Daniel García Aubert
92e62069d4
Improve error handling
2019-02-28 12:13:15 +01:00
Daniel García Aubert
32938eeab7
Validated only aggregated layers can be requested by the new endpoint
2019-02-27 18:54:21 +01:00
Daniel García Aubert
6531770e48
Remove subtitution tokens
2019-02-27 12:47:20 +01:00
Daniel García Aubert
b87298bad9
Fix resolution definition and use zoom as path param
2019-02-27 12:42:54 +01:00
Daniel García Aubert
c3df075d91
Draft
2019-02-26 19:19:44 +01:00
Daniel García Aubert
f82e403180
Implement query to get features of a cluster for an aggregated map from @jgoizueta's cluster query
2019-02-25 19:40:18 +01:00
Daniel García Aubert
63c95df81c
Lint
2019-01-30 16:36:08 +01:00
Daniel García Aubert
065f9c0a53
Add subtype to the limit error
2019-01-30 16:15:29 +01:00
Daniel García Aubert
2e85e130c8
Be able to customize max waiting workers parameter
2019-01-30 10:41:39 +01:00
Daniel García Aubert
d70a87b299
Handle 'max waitingClients count exceeded' error as 429 Too many requests
2019-01-30 10:27:00 +01:00
Simon Martín
644b4232ca
adding Authorization to Access-Control-Allow-Headers
2019-01-10 16:56:07 +01:00
Daniel G. Aubert
420c39337c
Merge pull request #1052 from CartoDB/use-strict
...
Use strict mode
2018-10-26 11:21:37 +02:00
Daniel García Aubert
ca7acb8339
Merge branch 'master' into use-strict
2018-10-25 11:11:30 +02:00
Javier Goizueta
6908aa532c
Fix iso format for hours in time dimensions
...
The HH specifies hour of day 01-12, we need HH24 for 00-23
2018-10-24 21:15:10 +02:00
Daniel García Aubert
361e99006b
Ignore line
2018-10-23 18:20:11 +02:00
Daniel García Aubert
b6dcf72268
Missing semicolon
2018-10-23 17:55:35 +02:00
Daniel García Aubert
76cfd185de
Please jshint
2018-10-23 17:54:11 +02:00
Daniel García Aubert
79820a0f05
Add function as method of to be stric mode compilant
2018-10-23 17:52:19 +02:00
Daniel García Aubert
a0126f6a15
Use stric mode for resource-locator module
2018-10-23 17:48:53 +02:00
Daniel García Aubert
e7e3d612a1
Use strict mode in modules under lib folder (except lib/cartodb/models/resource-locator.js)
2018-10-23 17:45:42 +02:00
Raul Ochoa
26e4a05276
Going green: prevent TypeError for empty tables/results
...
This is the intial step to fix https://github.com/CartoDB/carto-vl/issues/1049 .
2018-10-23 13:50:49 +00:00
Daniel García Aubert
12d58f3af2
Prevent from uncaught exception: Range filter Error from camshaft when getting analysis query
2018-10-22 15:26:59 +02:00
Daniel García Aubert
5573db2bc1
Do not use Object.assign as _.defautls equivalent
2018-10-19 11:57:54 +02:00
Daniel García Aubert
17886d0e43
Revert "Use early return pattern"
...
This reverts commit 297e56f4e1
.
2018-10-11 18:17:16 +02:00
Daniel García Aubert
1f112d587f
Revert "Rename function"
...
This reverts commit 12dc1626a7
.
2018-10-11 18:17:03 +02:00
Daniel García Aubert
e158e3e426
Pass overview-query-rewriter to mvt renderer
2018-10-11 15:41:38 +02:00
Daniel García Aubert
12dc1626a7
Rename function
2018-10-10 15:07:47 +02:00
Daniel García Aubert
297e56f4e1
Use early return pattern
2018-10-10 15:06:56 +02:00
Javier Goizueta
73b3402d85
Refactor stats collection
2018-10-09 13:24:08 +02:00
Javier Goizueta
ee63b247cd
Slight refactor
2018-10-08 19:25:04 +02:00
Javier Goizueta
10baf43ede
Fix dimension metadata bug
2018-10-07 00:28:53 +02:00
Javier Goizueta
996d7fc90d
Lint fixes
2018-10-06 18:26:43 +02:00
Javier Goizueta
c0febf2fd1
Rename time dimension parameters
2018-10-05 20:08:40 +02:00
Javier Goizueta
f841f65a1e
Dimensions metadata
2018-10-04 19:50:14 +02:00
Javier Goizueta
c9786ee3f6
Catch aggregation query errors
2018-10-03 23:13:22 +02:00
Javier Goizueta
99b62edcbd
Bug fixes
2018-10-03 23:12:58 +02:00
Javier Goizueta
c588d4139e
Refactor time dimensions
2018-10-03 21:02:22 +02:00
Javier Goizueta
aff55351ad
Unify parameter names
2018-10-03 19:07:47 +02:00
Javier Goizueta
96ba075698
Unify handling of cyclic time groupings
...
Remove generic cyclic grouping
2018-10-03 18:57:00 +02:00
Javier Goizueta
a7d5415f64
Remove offsets from time dimension computations
2018-10-03 17:12:01 +02:00
Javier Goizueta
dede22c915
Changes in time dimensions API
...
Use single `starting` epoch instead of various offsets.
Add ISO text representation.
Adopt ISO conventions for day of week and week of year.
Rename internal parameters for consistency with external API.
2018-10-03 17:05:58 +02:00
Javier Goizueta
fbf3fd9d8c
Support old and new dimension definitions
2018-09-25 19:10:56 +02:00
Javier Goizueta
fbcfc7a582
WIP: time dimensions for aggregation
2018-09-20 21:12:54 +02:00
Javier Goizueta
0f20cdaae1
More robust adjustment of spatial limits to the aggregation grid
...
See #1034
2018-09-12 19:27:21 +02:00
Javier Goizueta
1e65804a1b
Avoid requiring the_geom for point-sample aggregation
2018-09-12 11:26:14 +02:00
Raúl Marín
fb6987e91a
Merge pull request #1027 from CartoDB/carto_mvt_extent
...
Update Windshaft to 4.9.0
2018-09-05 13:30:12 +02:00
Eneko Lakasta
65e10bc20d
use as flag overviewsAddedToMapconfig instead of overviewsUsed
2018-09-05 13:14:55 +02:00
Eneko Lakasta
dd1ee56648
use .some instead of .map & .some
2018-09-05 11:56:45 +02:00
Eneko Lakasta
c54c3754ef
fix indentation
2018-09-05 11:51:58 +02:00
Eneko Lakasta
6dde5fc6f1
use .some instead of reduce
2018-09-04 18:22:48 +02:00
Eneko Lakasta
880ef63720
add to logs named maps overviews instantiation
2018-09-04 16:21:20 +02:00
Eneko Lakasta
b75150e91e
set mapType in the controller instead of in the adapter
2018-09-04 16:20:38 +02:00
Eneko Lakasta
006e21379f
please jshint line to long
2018-09-04 15:30:20 +02:00
Eneko Lakasta
7df0fb456b
add to log anonymous maps instantiations that use overviews tables
...
Added to tiler profiler object:
overviewsAddedToMapconfig: true
mapType: 'anonymous'
2018-09-04 15:13:17 +02:00
Eneko Lakasta
95d179835c
add to logs even if no overviews tables were used.
...
{usesOverviews:false}
2018-08-30 14:52:37 +02:00
Eneko Lakasta
7c52f504e5
add dataview type to overviews logs
2018-08-30 14:30:03 +02:00
Raul Marin
cd25150056
MVT: Removed error parsing for empty tiles
2018-09-03 14:59:16 +02:00
Eneko Lakasta
c9d50c412d
add tests for dataviews
2018-08-29 18:00:13 +02:00
Eneko Lakasta
732f891850
refactor in order not to tamper the dataview results data
2018-08-29 15:06:48 +02:00
Eneko Lakasta
8ef260972d
add to log when overviews are being used in dataviews
2018-08-29 13:50:21 +02:00
Javier Goizueta
d338b5ca37
Fix column stats to support spaces in names
...
This complements changes in #1020
2018-08-21 12:55:30 +02:00
Jesús Arroyo Torrens
e0f49ca8f5
Fix aggregation-query dimension functions regarding to spaces in columns
2018-08-16 15:34:06 +02:00
Jesús Arroyo Torrens
925328c43b
Fix bug in date-wrapper regarding to columns with spaces
2018-08-16 13:38:26 +02:00
Jesús Arroyo Torrens
14cf3c1093
Fix typo
2018-08-16 12:16:20 +02:00
Daniel G. Aubert
dfa057d979
Merge pull request #1016 from CartoDB/remove-step-template-maps
...
Remove step template maps
2018-08-02 15:02:59 +02:00
Daniel García Aubert
98ab237bf7
Merge branch 'master' into remove-step-template-maps
2018-08-02 14:10:26 +02:00
Daniel García Aubert
63e4bcebef
Move function to class as private method
2018-08-02 13:13:48 +02:00
Daniel García Aubert
593a72a967
Reorganize code, estract methods and rename others
2018-08-02 11:40:41 +02:00
Simon Martín
6c8f38a241
improve var naming
2018-08-02 11:38:54 +02:00
Simon Martín
a910f1442e
explicit error return
2018-08-02 11:35:54 +02:00
Daniel García Aubert
df14afb55f
Remove unnecessary code
2018-08-01 19:15:28 +02:00
Daniel García Aubert
732a2d7742
Early return is the way to go. Avoid checking conditions later
2018-08-01 17:39:08 +02:00
Daniel García Aubert
78f4cf3155
Move code
2018-08-01 17:33:20 +02:00
Daniel García Aubert
8f763d655d
Do not rename output values
2018-08-01 17:23:40 +02:00
Daniel García Aubert
64329c3fac
Rename callback
2018-08-01 16:39:15 +02:00
Daniel García Aubert
c8c22a787e
CamelCase
2018-08-01 16:35:19 +02:00
Daniel García Aubert
6a6ec4300b
Extract functions to compose query-rewrite-data
2018-08-01 16:30:59 +02:00
Simon Martín
44ba5aa568
forgotten return
2018-08-01 16:22:43 +02:00
Simon Martín
01658c33fd
remove step and assert dependencies
2018-08-01 16:03:36 +02:00
Simon Martín
efafd4cb3e
success callback without err
2018-08-01 16:02:53 +02:00
Daniel García Aubert
d25740ed51
Extract function to avoid dynamic clousures
2018-08-01 16:02:05 +02:00
Simon Martín
3bb4ad86ff
remove template 5 refactor
2018-08-01 16:00:31 +02:00
Simon Martín
b169c96f1c
remove step 5
2018-08-01 15:57:22 +02:00
Daniel García Aubert
843f4b8e28
Use early return
2018-08-01 15:53:43 +02:00
Simon Martín
e5b75abc76
some details
2018-08-01 15:53:41 +02:00
Daniel García Aubert
83777540d0
Merge branch 'master' into remove-step-mapconfig-overviews-adapter
2018-08-01 15:51:43 +02:00
Simon Martín
0e28348e16
manage JSON parse and stringify sinc errors
2018-08-01 15:48:24 +02:00
Simon Martín
7b7bee2901
improve naming
2018-08-01 15:43:45 +02:00
Simon Martín
2a2f703abc
style details
2018-08-01 15:40:40 +02:00
Simon Martín
e85f4e4129
selft to this
2018-08-01 15:39:25 +02:00