Commit Graph

2449 Commits

Author SHA1 Message Date
Daniel G. Aubert
09d3e8aabb
Merge pull request #1139 from CartoDB/fix/bad-aggregation-method-overview
Validate aggregation method is either sum or count
2019-11-13 10:11:28 +01:00
Raúl Marín
aa09c079f6 Fix multiple DB login issues 2019-11-12 13:15:32 +01:00
Raúl Marín
3c586caba4 Qualify calls to cartodb extension so having it in the search_path isn't necessary 2019-11-12 13:15:32 +01:00
Esther Lozano
acecb88efb Validate aggregation method is either sum or count 2019-11-11 18:14:30 +01:00
Daniel García Aubert
734c373f3d Camel case 2019-11-11 12:26:04 +01:00
Daniel García Aubert
cc24228511 Fix eslint issues 2019-11-06 13:56:59 +01:00
Daniel García Aubert
27106fea57 Avoid regular string contains what looks like a template literal placeholder 2019-11-06 13:29:03 +01:00
Simon Martín
3e7c294989 linter 2019-10-29 11:32:27 +01:00
Simon Martín
8a02156ac0 fix tests 2019-10-29 10:31:31 +01:00
Simon Martín
c4a75de0d8 windshaft 5.6.4 2019-10-28 18:15:15 +01:00
Simon Martín
db03bcdf8f windshaft logger by config param 2019-10-28 15:41:46 +01:00
Simon Martín
dd5825c770 using a new logger 2019-10-28 11:55:43 +01:00
Daniel García Aubert
575fe8e350 Remove unnecessary escape usage 2019-10-24 19:18:47 +02:00
Daniel García Aubert
d5218a86f6 Enforce callback error handling 2019-10-24 18:38:37 +02:00
Simon Martín
080f93f6de passing logger to MapStore 2019-10-24 17:34:46 +02:00
Daniel García Aubert
ad4a1ada45 Do not use string concatenation when using __dirname and __filename 2019-10-22 18:22:33 +02:00
Daniel García Aubert
7a1d2ca205 Avoid calling Object.prototype methods directly on object instances 2019-10-21 23:33:27 +02:00
Daniel García Aubert
d89e785440 Stop using deprecated Buffer constructor 2019-10-21 20:05:51 +02:00
Daniel García Aubert
4d70ac0894 Apply automatic eslint fixes 2019-10-21 19:07:24 +02:00
Daniel García Aubert
0c9cfefcd0 Please jshint, can you be a regular linter? 2019-10-21 11:13:54 +02:00
Daniel García Aubert
8ed187b0f5 Do not set Last-Modifed to January 1st 1970 when cache buster ins layergroup token is 0. In this case, 0 means we don't know when the resource was updated for the last time. 2019-10-21 11:01:05 +02:00
Daniel García Aubert
ebff2ac9f2 Please JSHint 2019-10-15 13:27:40 +02:00
Daniel García Aubert
5a7ffcf499 Be able to synchronize the TTL of cache-control header to expire in a coherent way 2019-10-15 12:48:50 +02:00
Daniel García Aubert
c4054f0ac9 Use develop branch of query-tables 2019-10-15 10:39:31 +02:00
Daniel García Aubert
f7707141d6 Rename variable 2019-10-08 17:22:24 +02:00
Daniel García Aubert
6cad976078 Remove environment configuration adapter 2019-10-08 11:02:32 +02:00
Daniel García Aubert
ea6e064e42 Convert from v1 to api in routes config 2019-10-07 14:08:59 +02:00
Daniel García Aubert
e8cff194fc Rename template_maps -> template-maps 2019-10-07 10:50:14 +02:00
Daniel García Aubert
a134ab3012 Rename server_options -> server-options 2019-10-07 10:10:51 +02:00
Daniel García Aubert
5a84d7233b Rename table_name_parser -> table-name-parser 2019-10-07 10:07:25 +02:00
Daniel García Aubert
8fe0112568 Rename overviews_query_rewriter -> overviews-query-rewriter 2019-10-07 10:06:01 +02:00
Daniel García Aubert
3acaac5403 Rename icu_data_env_setter -> icu-data-env-setter 2019-10-07 10:04:39 +02:00
Daniel García Aubert
7dbac5a565 Rename profiler_proxy -> profiler-proxy 2019-10-07 10:01:18 +02:00
Daniel García Aubert
8fb4f4063f Rename health_check -> health-check 2019-10-07 09:59:54 +02:00
Daniel García Aubert
808718fb26 Rename cdb_request -> cdb-request 2019-10-07 09:58:21 +02:00
Daniel García Aubert
6dc8de315a Rename surrogate_keys_cache -> surrogate-keys-cache 2019-10-07 09:56:20 +02:00
Daniel García Aubert
afb9b08925 Rename surrogate_keys_cache -> surrogate-keys-cache 2019-10-07 09:55:55 +02:00
Daniel García Aubert
2bed034e64 Rename named_map_provider_cache -> named-map-provider-cache 2019-10-07 09:54:54 +02:00
Daniel García Aubert
2328bb6261 Rename layergroup_affected_tables -> layergroup-affected-tables 2019-10-07 09:53:06 +02:00
Daniel García Aubert
06357fa3f9 Rename named_maps_entry -> named-maps-entry 2019-10-07 09:51:51 +02:00
Daniel García Aubert
83f58288f9 Rename varnish_http -> varnish-http 2019-10-07 09:47:42 +02:00
Daniel García Aubert
b1d5f0f9e8 Rename pg_query_runner -> pg-query-runner 2019-10-07 09:45:46 +02:00
Daniel García Aubert
7142e4db37 Rename pg_connection -> pg-connection 2019-10-07 09:43:40 +02:00
Daniel García Aubert
281a079a62 Simplify folder structure 2019-10-07 09:40:50 +02:00
Daniel García Aubert
43a63feaca Keep the backwards compatibility for routing configuration 2019-10-06 18:58:21 +02:00
Daniel García Aubert
2ce688ee2a Missed to apply configuration changes to default server options 2019-10-04 12:56:36 +02:00
Daniel García Aubert
93edf07da8 Temporary workaround to not depend on configuration changes 2019-10-04 12:35:12 +02:00
Daniel García Aubert
a684bead92 Rename method 'register' -> 'route' 2019-10-04 12:22:23 +02:00
Daniel García Aubert
dd06de2632 Use new routes configuration 2019-10-04 12:07:58 +02:00
Daniel García Aubert
975f07df99 Use Object.values() 2019-10-02 10:42:29 +02:00
Daniel García Aubert
3220e3de31 Remove old api configuration paths 2019-10-01 19:34:03 +02:00
Daniel García Aubert
9cfaf6eefc Draft: be able to inject middlewares from configuration 2019-09-30 19:18:36 +02:00
Raúl Marín
b93caa7410
Merge pull request #1123 from Algunenano/query_tables_update
Query tables update
2019-09-18 11:26:51 +02:00
Daniel García Aubert
68a9b4ccae Typo 2019-09-16 13:09:23 +02:00
Daniel García Aubert
f6c205baf9 Typo 2019-09-16 13:08:10 +02:00
Daniel García Aubert
c19c723795 Add named map providers reporter to gather some stats 2019-09-13 20:01:03 +02:00
Daniel García Aubert
788cd9d6fb Be explicit while forwarding parametes 2019-09-13 18:15:11 +02:00
Daniel García Aubert
824d41ef0f Consitent quotes 2019-09-13 18:11:47 +02:00
Daniel García Aubert
329b5d9b9e Use ES6 class syntax 2019-09-13 18:07:50 +02:00
Daniel García Aubert
b55c2ec55c Use template string 2019-09-13 18:03:39 +02:00
Daniel García Aubert
d99e5a44f5 Use const instead of var 2019-09-13 18:00:13 +02:00
Daniel García Aubert
e8d5e42300 Use Object.assign() instead of _.defaults() 2019-09-13 17:58:23 +02:00
Daniel García Aubert
c0afd42fa2 Use template strings instead of dot module 2019-09-13 17:53:10 +02:00
Daniel García Aubert
1bb6a2ac0d Move invalidation closer to its definition 2019-09-13 17:42:56 +02:00
Daniel García Aubert
3d2f554be9 Use early return pattern 2019-09-13 16:53:53 +02:00
Raul Marin
a673e6d138 Update dependencies 2019-09-13 16:32:37 +02:00
Raul Marin
f9b6e92745 Stop throwing up warnings during testing
Yeah, I test with different repos and branches. Big deal. Shut up.
2019-09-13 16:26:46 +02:00
Daniel García Aubert
6229455d25 Remove mechanism to reset named map's provider as, in the end, it's reading from storage (redis) always so cache isn't doing its job. There is already a mechanism to invalidate cache entry when a template is modified (see template-maps emits on "update" and "delete", and listeners attached at server startup) 2019-09-12 20:34:18 +02:00
Daniel García Aubert
9d6726227a Add maxAge param to lru-cache to be able to refresh entries when staled 2019-09-12 18:02:13 +02:00
Daniel García Aubert
64b4efef17 Do not cache map template CRUD errors in Named Map provider 2019-09-12 17:23:19 +02:00
Daniel García Aubert
2fbd9893bd Going green: do not fail when source is empty 2019-09-02 14:09:13 +02:00
Daniel García Aubert
9a85b661b0 Remove safe limit 2019-08-23 18:04:19 +02:00
Daniel García Aubert
d4d981909b Remove unused code 2019-08-23 17:43:20 +02:00
Daniel García Aubert
16035131bc Rename method 2019-08-23 17:25:37 +02:00
Daniel García Aubert
b2adb8f058 Use substituteDummyTokens 2019-08-23 17:21:01 +02:00
Daniel García Aubert
780cb80c8c Move method 2019-08-23 17:16:35 +02:00
Daniel García Aubert
2a8a8f6e6a Export methods to get max, min, values od a column and sample based on a range 2019-08-23 17:10:46 +02:00
Daniel García Aubert
850bda9669 Use modified sample method 2019-08-23 17:09:53 +02:00
Daniel García Aubert
25e3395580 Modify sample metadata 2019-08-23 17:09:24 +02:00
Daniel García Aubert
a220af4fad Please jshint 2019-07-29 19:20:38 +02:00
Daniel García Aubert
945c122dda Update windshaft devel branch 2019-07-29 19:14:27 +02:00
Raul Marin
b572b979a1 Style 2019-07-16 13:43:46 +02:00
Raul Marin
de49aa0bd4 Aggregation: Style improvements 2019-07-16 12:49:09 +02:00
Raul Marin
286daa9bec Simplify aggregation templates 2019-07-16 12:49:09 +02:00
Raul Marin
63b6af2ac7 Query utils: Use webmercator utils, reuse code and always substitute tokens 2019-07-16 12:49:09 +02:00
Raul Marin
46600bf4fc Please jshint 2019-07-16 12:48:58 +02:00
Raul Marin
aed456bf32 Cluster: Use new webmercator utilities 2019-07-16 12:48:58 +02:00
Raul Marin
d3e807583a Use proper mode 2019-07-16 12:48:58 +02:00
Raul Marin
262f957218 Aggregation: Improve speeeeeeed 2019-07-16 12:48:58 +02:00
Raul Marin
8454eef6e9 Aggregation: Extract the query to get the grid data 2019-07-16 12:48:58 +02:00
Raul Marin
5e24f650af Rework how aggregations are calculated
Pending fixing Mapnik tiles (pg-mvt work ok)
2019-07-16 12:48:12 +02:00
Raul Marin
a3e8f45552 WIP to change how aggregations are calculated 2019-07-16 12:48:12 +02:00
Raul Marin
cd8624ae2d Improve subquery naming 2019-07-16 12:48:12 +02:00
Raul Marin
7b731a24d1 Overviews Adapter: Do not check overviews if using MVT pure style or aggregations 2019-07-16 12:48:12 +02:00
Daniel García Aubert
619cad9c35 Typo 2019-07-09 15:44:34 +02:00
Daniel García Aubert
a84184852e Going green: skip analyses table while computing max-age directive 2019-07-08 18:05:30 +02:00
Daniel García Aubert
4def4b0341 Improve condition 2019-07-04 16:41:30 +02:00
Daniel García Aubert
ec0c0eb810 Improve readability 2019-07-04 16:24:17 +02:00
Daniel García Aubert
a894194b6b Add more specific tests 2019-07-04 15:58:39 +02:00
Daniel García Aubert
a374deaf30 Please linter 2019-07-03 17:16:09 +02:00
Daniel García Aubert
bc29587c55 Set directive 'max-age' to 5 min when there are affacted tables where we can't know when were updated for the last time, e.g: non cartodified tables or foreing tables without cartodb support 2019-07-03 17:15:14 +02:00
Daniel García Aubert
f21eda2b40 Adapt endpoints to the new preview interface 2019-06-17 10:43:30 +02:00
Daniel García Aubert
20fe04de38 Do not get headers from abaculus 2019-06-10 13:16:05 +02:00
Daniel García Aubert
dc16f4cebf Update windshaft devel branch 2019-06-10 12:49:56 +02:00
Daniel García Aubert
6808ab496a Use semver for cheking dependencies version 2019-03-29 15:30:29 +01:00
Daniel García Aubert
035acb343e Fix uncaught exception: TypeError: Cannot read property 'id' of undefined 2019-03-27 11:45:47 +01:00
Raul Marin
ae59c4f996 Merge remote-tracking branch 'blessed/master' into 1073-aggregation-false 2019-03-14 17:01:07 +01:00
Raul Marin
8db090ae9c Numeric histogram: Test when start and end are provided but not bins 2019-03-14 15:16:23 +01:00
Raul Marin
730076469e Numeric histogram: Simplify bin calculation 2019-03-14 15:16:23 +01:00
Raul Marin
6241b23d4f Histogram: Speed up IRQ calculation 2019-03-14 15:16:23 +01:00
Daniel García Aubert
367ca399c8 Improve readability 2019-03-11 18:53:47 +01:00
Daniel García Aubert
d86b01ba33 Add debug statement 2019-03-11 18:09:41 +01:00
Daniel García Aubert
0aa3b288a0 Improve validation 2019-03-11 18:04:47 +01:00
Daniel García Aubert
589996b79c Reduce complexity 2019-03-11 17:53:34 +01:00
Daniel García Aubert
49104a6add Reduce complexity by extracting function to validate expressions 2019-03-11 17:25:29 +01:00
Daniel García Aubert
8051dc5110 Reduce complexity by extracting validation condition to its function 2019-03-11 17:14:07 +01:00
Daniel García Aubert
fecedfdc68 Reduce complexity by extracting validation to a function 2019-03-11 17:06:04 +01:00
Daniel García Aubert
f0c82f21d2 Reduce complexity by extracting a complex condition to a function 2019-03-11 17:01:13 +01:00
Javier Goizueta
c91b28ee92 Lint fixes 2019-03-06 18:32:17 +01:00
Javier Goizueta
113b3728b1 Fix support of boolean aggregation layer option 2019-03-06 18:14:15 +01:00
Daniel García Aubert
2a0287b358 Add todos 2019-03-01 17:49:26 +01:00
Daniel García Aubert
f5fb60aa56 Filter output 2019-03-01 17:34:32 +01:00
Daniel García Aubert
dcf147cdfb linter 2019-03-01 17:05:35 +01:00
Daniel García Aubert
f9e5d9d0a9 Validate aggregation expresions 2019-03-01 17:02:06 +01:00
Daniel García Aubert
57a229655c Implement aggregation functions 2019-03-01 15:45:38 +01:00
Daniel García Aubert
6dadb1bf6f Validate aggregation input 2019-03-01 15:17:22 +01:00
Daniel García Aubert
77d5d8ebd4 Be able to aggregate by a field 2019-03-01 11:21:18 +01:00
Daniel García Aubert
92e62069d4 Improve error handling 2019-02-28 12:13:15 +01:00
Daniel García Aubert
32938eeab7 Validated only aggregated layers can be requested by the new endpoint 2019-02-27 18:54:21 +01:00
Daniel García Aubert
6531770e48 Remove subtitution tokens 2019-02-27 12:47:20 +01:00
Daniel García Aubert
b87298bad9 Fix resolution definition and use zoom as path param 2019-02-27 12:42:54 +01:00
Daniel García Aubert
c3df075d91 Draft 2019-02-26 19:19:44 +01:00
Daniel García Aubert
f82e403180 Implement query to get features of a cluster for an aggregated map from @jgoizueta's cluster query 2019-02-25 19:40:18 +01:00
Daniel García Aubert
63c95df81c Lint 2019-01-30 16:36:08 +01:00
Daniel García Aubert
065f9c0a53 Add subtype to the limit error 2019-01-30 16:15:29 +01:00
Daniel García Aubert
2e85e130c8 Be able to customize max waiting workers parameter 2019-01-30 10:41:39 +01:00
Daniel García Aubert
d70a87b299 Handle 'max waitingClients count exceeded' error as 429 Too many requests 2019-01-30 10:27:00 +01:00
Simon Martín
644b4232ca adding Authorization to Access-Control-Allow-Headers 2019-01-10 16:56:07 +01:00
Daniel G. Aubert
420c39337c
Merge pull request #1052 from CartoDB/use-strict
Use strict mode
2018-10-26 11:21:37 +02:00
Daniel García Aubert
ca7acb8339 Merge branch 'master' into use-strict 2018-10-25 11:11:30 +02:00
Javier Goizueta
6908aa532c Fix iso format for hours in time dimensions
The HH specifies hour of day 01-12, we need HH24 for 00-23
2018-10-24 21:15:10 +02:00
Daniel García Aubert
361e99006b Ignore line 2018-10-23 18:20:11 +02:00
Daniel García Aubert
b6dcf72268 Missing semicolon 2018-10-23 17:55:35 +02:00
Daniel García Aubert
76cfd185de Please jshint 2018-10-23 17:54:11 +02:00
Daniel García Aubert
79820a0f05 Add function as method of to be stric mode compilant 2018-10-23 17:52:19 +02:00
Daniel García Aubert
a0126f6a15 Use stric mode for resource-locator module 2018-10-23 17:48:53 +02:00
Daniel García Aubert
e7e3d612a1 Use strict mode in modules under lib folder (except lib/cartodb/models/resource-locator.js) 2018-10-23 17:45:42 +02:00
Raul Ochoa
26e4a05276 Going green: prevent TypeError for empty tables/results
This is the intial step to fix https://github.com/CartoDB/carto-vl/issues/1049.
2018-10-23 13:50:49 +00:00
Daniel García Aubert
12d58f3af2 Prevent from uncaught exception: Range filter Error from camshaft when getting analysis query 2018-10-22 15:26:59 +02:00
Daniel García Aubert
5573db2bc1 Do not use Object.assign as _.defautls equivalent 2018-10-19 11:57:54 +02:00