Raul Ochoa
4c25828540
Fix sql signature in agg, formula, and list dataviews
2016-06-01 11:42:24 +02:00
Javier Goizueta
d5423c88ea
Replace use of the name widget by dataview for consistency
2016-05-31 15:30:38 +02:00
Javier Goizueta
5838b7a455
Remove debugging messages
2016-05-31 15:19:33 +02:00
Javier Goizueta
ef276bd51e
Merge branch 'master' into 466-overviews-dataviews
2016-05-30 17:26:06 +02:00
Javier Goizueta
7ac3784f32
Increase the ratio used to select an overview level from a bounding box
...
This value would ideally be adjusted to prevent the grid size of the
overview used being greater that one pixel. So, this should be the
larger dimension of the map window in pixels.
2016-05-30 17:21:56 +02:00
Raul Ochoa
f602ea88e2
Convert widgets from layers into dataviews
...
It also converts filters so full dataviews backend is reusable, that removes
widgets backend dependency.
2016-05-26 19:32:58 +02:00
Raul Ochoa
da6870cf1e
Adds new adapter to transform widgets into dataviews
2016-05-26 11:57:55 +02:00
Raul Ochoa
f7c528277b
Add tests for generic MapConfig adapter
2016-05-26 11:23:19 +02:00
Raul Ochoa
2ff33b5010
Generic MapConfig adapter can receive an arbitrary number of adapters
2016-05-26 11:02:43 +02:00
Raul Ochoa
f34213a147
Reorder public/private functions
2016-05-25 17:24:28 +02:00
Raul Ochoa
a785ebef65
Use generic map config adapter
2016-05-23 23:29:06 +02:00
Raul Ochoa
4137de5adf
Remove class members
2016-05-23 22:01:08 +02:00
Raul Ochoa
f012e6092f
Remove unused var
2016-05-23 21:58:42 +02:00
Raul Ochoa
9ce4929d87
Use generic adapter in named maps
2016-05-23 21:56:38 +02:00
Raul Ochoa
8efe844474
Use generic adapter
2016-05-23 21:37:06 +02:00
Raul Ochoa
02cb80daa1
Use context for datasource 2/2
2016-05-23 19:14:03 +02:00
Raul Ochoa
e9d1951d48
Use context for datasource 1/2
2016-05-23 19:09:57 +02:00
Raul Ochoa
a11cc28dc7
Use context for analyses results
2016-05-23 18:59:23 +02:00
Raul Ochoa
a8fdd6726e
Fix style
2016-05-23 18:36:03 +02:00
Raul Ochoa
7ad8a99373
Unify getMapConfig signature for overviews adapter
2016-05-23 18:35:16 +02:00
Javier Goizueta
c0a24108ba
Implement overviews histogram dataviews
2016-05-23 18:11:10 +02:00
Javier Goizueta
ae9b8a0380
Remove comment
2016-05-23 18:10:46 +02:00
Raul Ochoa
31a0b01a27
Rename param
2016-05-23 18:08:42 +02:00
Raul Ochoa
efcb73e0d1
Named layers adapter with getMapConfig signature
2016-05-23 18:03:45 +02:00
Javier Goizueta
f008c74419
Specific aggregation dataview implementation for overviews
2016-05-23 17:42:26 +02:00
Javier Goizueta
4a646d4700
Refactor overviews formula dataview
2016-05-23 17:20:04 +02:00
Javier Goizueta
657b262d92
Override all dataview types for overviews
...
All are using now the default behaviour defined in the base
class.
2016-05-23 17:06:52 +02:00
Javier Goizueta
988412fc07
Define default overviews dataview behaviour in base class
2016-05-23 16:53:28 +02:00
Raul Ochoa
70750d2c43
Unify getMapConfig signature
2016-05-23 16:50:26 +02:00
Raul Ochoa
9c1db98f67
Unifiy getMapConfig signature
2016-05-23 16:44:14 +02:00
Raul Ochoa
12c44fda6f
Unify getMapConfig interface
2016-05-23 16:20:42 +02:00
Raul Ochoa
6ccdb6cefd
Overviews adapter with getMapConfig interface
2016-05-23 15:52:31 +02:00
Raul Ochoa
9f6ce64a31
Named maps adapter with getMapConfig interface
2016-05-23 15:39:11 +02:00
Raul Ochoa
3e35604df0
turbo-carto adapter with getMapConfig interface
2016-05-23 15:18:20 +02:00
Raul Ochoa
01a69ef15c
Merge remote-tracking branch 'origin/master' into mapconfig-reorg
2016-05-23 15:14:25 +02:00
Raul Ochoa
fb045f1836
Merge branch 'master' into turbo-carto-tokens
2016-05-23 15:06:55 +02:00
Raul Ochoa
ee49b8b2a2
Turbo-carto adapter into adapters package
2016-05-23 14:18:58 +02:00
Javier Goizueta
5ba72b4894
Create base class for overviews dataviews
2016-05-23 14:18:45 +02:00
Raul Ochoa
8134aca14d
Named map provider into providers package
2016-05-23 13:32:28 +02:00
Raul Ochoa
215bbbd29c
Store provider into providers package
2016-05-23 13:29:34 +02:00
Raul Ochoa
c4b6f65404
Create map provider into providers package
2016-05-23 13:28:11 +02:00
Raul Ochoa
20725900b6
Overviews adapter into adapters package
2016-05-23 13:25:11 +02:00
Raul Ochoa
ab984729f5
Named layers adapter into adapters package
2016-05-23 13:16:34 +02:00
Raul Ochoa
9f8551058d
Analysis adapter into adapter package
2016-05-23 13:10:52 +02:00
Raul Ochoa
c372d69e98
LayergroupToken only makes sense at testing environment
2016-05-23 13:01:23 +02:00
Javier Goizueta
3add61ec57
Use Camshaft's API to get node filters
2016-05-19 18:32:49 +02:00
Raul Ochoa
64dd033c94
Merge branch 'master' into turbo-carto-tokens
2016-05-19 13:39:36 +02:00
Raul Ochoa
2e79781711
Adds support for sql wrap in all layers
...
Previously it was only working for analyses ones.
2016-05-19 13:34:29 +02:00
Raul Ochoa
c7f37047b0
Save original query from analysis before wrapping it
2016-05-19 11:41:06 +02:00
Javier Goizueta
4c375780c7
replace underscore functions by standard (ES5) equivalents
...
Note: _.find(a,...) is not replaced by a.find(...)
because it is not available for all the collections
we need it for.
2016-05-18 15:43:20 +02:00
Javier Goizueta
8da7cf73c1
Remove comment
2016-05-18 13:55:09 +02:00
Javier Goizueta
aa0ddaae95
Remove comment
2016-05-18 08:07:48 +02:00
Javier Goizueta
3d8f6576aa
Implement category and range filters
2016-05-18 07:48:11 +02:00
Javier Goizueta
42ef40282b
💄 shorten long lines
2016-05-17 15:46:13 +02:00
Javier Goizueta
7f7204df6c
Add filter stats information to query rewriter data
2016-05-17 15:41:31 +02:00
Javier Goizueta
3c6d930434
Fix bug
2016-05-17 15:39:32 +02:00
Javier Goizueta
df63fbbd04
Refactor filter application into own model
...
This also avoids storing an object in the overviews query rewriter
for the bbox filter (a plain data structure is used instead).
2016-05-17 13:55:00 +02:00
Javier Goizueta
9d82e8c27c
Use bounding box of dataviews to select overviews level
2016-05-13 20:47:36 +02:00
Javier Goizueta
224eb392ba
Add overviews-dependent dataviews behaviour
...
Now QueryRewriter is used in dataview objects they can decide
whether overviews are applicable, have the oportunity to
adapt queries for overviews, etc.
This is done by having overviews-related behaviour in models/dataview/overviews
and falling back to the regular models/dataview.
2016-05-13 18:46:58 +02:00
Javier Goizueta
55cf0a8447
Fix typo
2016-05-12 16:43:09 +02:00
Javier Goizueta
64a87690ee
💄 Fix line lengths, etc.
2016-05-12 16:20:34 +02:00
Javier Goizueta
65612f0109
Add filters information at map instantion time to the query rewriter data
2016-05-11 19:24:13 +02:00
Raul Ochoa
4570d17ce1
Use original query from source nodes
...
Doing a st_transform doesn't make sense as we already should have
the_geom_webmercator column available
2016-05-10 17:09:36 +02:00
Raul Ochoa
3e94e3288f
Use sql as replacement variable
2016-05-06 17:09:41 +02:00
Raul Ochoa
7d4caf6974
Analysis layers can have a sql_wrap option to wrap node queries
2016-05-06 16:37:52 +02:00
Raul Ochoa
755dfe6822
Append dataviews related columns to layers
2016-04-27 18:30:05 +02:00
Raul Ochoa
dd731399dc
Starts using turbo-carto dependency
2016-04-26 16:28:05 +02:00
Raul Ochoa
c5bed48d61
Handle missing analyses nodes for layers pointing to them
...
Fixes #422
2016-04-21 17:24:52 +02:00
Raul Ochoa
93dd8a2213
Add analyses metadata for named maps excluding queries
2016-04-21 17:03:41 +02:00
Raul Ochoa
4e4a223f24
Better naming for analysis mapconfig adapter
2016-04-21 16:25:59 +02:00
Raul Ochoa
bc845b2e8d
Validate dataviews format before instantiating
2016-04-21 16:16:00 +02:00
Raul Ochoa
e04a9a2579
Append dataviews filters after checking if mapconfig must be adapted
2016-04-20 15:40:14 +02:00
Raul Ochoa
f932862ce4
Improve configuration for batch queries
2016-04-18 15:13:00 +02:00
Raul Ochoa
263b3e3682
Rename file
2016-04-18 14:47:35 +02:00
Raul Ochoa
a26025b259
Add analysis backend so it's possible to inject configuration
2016-04-14 17:09:07 +02:00
Raul Ochoa
a9ca453b17
Remove some JSON.stringify
2016-04-14 13:20:22 +02:00
Raul Ochoa
0981ccd0c4
Add metadata information about analyses
2016-04-07 17:58:12 +02:00
Raul Ochoa
077c4ab907
Adds analysis MapConfig adapter to named maps
2016-04-07 16:18:48 +02:00
Raul Ochoa
1c250bf243
Remove dependency
2016-04-07 14:30:49 +02:00
Raul Ochoa
ab6bae6a7f
Merge branch 'master' into analysis-layers
2016-04-04 16:24:31 +02:00
Javier Goizueta
b97a67b844
Fix overviews integration for named layers
...
Fixes #400
2016-03-31 18:33:41 +02:00
Raul Ochoa
2bd3e46a4d
Build dataviews with factory to generalise them
2016-03-22 13:10:42 +01:00
Raul Ochoa
26512f6485
Remove unused function
2016-03-22 12:22:48 +01:00
Raul Ochoa
90b92f0180
Adds support for category filters
2016-03-22 12:22:04 +01:00
Raul Ochoa
f928147559
Fix bbox template
2016-03-21 18:16:54 +01:00
Raul Ochoa
d5c5c7bdbb
Do not remove analysis, camshaft takes care of source root nodes now
2016-03-21 18:02:19 +01:00
Raul Ochoa
1e239658d8
Just remove analysis if there are analysis
2016-03-18 17:34:40 +01:00
Raul Ochoa
52f35d74b9
Allow a higher jshint maxcomplexity
2016-03-18 17:31:28 +01:00
Raul Ochoa
57e6e49749
Another workaround to not delete analyses if there are dataviews
2016-03-18 17:28:36 +01:00
Raul Ochoa
b3bbb9d97a
Initial checkin for dataviews
...
It only supports histograms.
2016-03-18 17:22:02 +01:00
Raul Ochoa
5bd30b6b5f
Analysis layers adapter skips analysis if there is only source nodes
2016-03-17 12:50:42 +01:00
Raul Ochoa
43c56af0fc
Merge remote-tracking branch 'origin/master' into analysis-layers
...
Conflicts:
npm-shrinkwrap.json
2016-03-16 16:13:44 +01:00
Daniel García Aubert
d52d3d909f
Fixed double-check error in turbo-cartocss preprocesing.
2016-03-14 15:25:56 +01:00
Raul Ochoa
eec44dd62d
Merge branch 'master' into analysis-layers
...
Conflicts:
npm-shrinkwrap.json
test/support/test-client.js
2016-03-14 15:13:19 +01:00
Raul Ochoa
3f41f19ab9
Rename adapter
2016-03-14 11:50:52 +01:00
Daniel García Aubert
052b58ab90
Moved turbo-cartocss integration from named maps admin to named map provider
2016-03-11 18:28:14 +01:00
Raul Ochoa
7fa8d1e0c9
Analyses are now an array and layers consume from their nodes
...
Layers now can define a `source: {id: 'a0'}` option to point to an
analysis node that will be used as the query for that layer.
2016-03-09 17:39:20 +01:00
Raul Ochoa
634a4c2a01
Debug option for internal nodes: it allows to display and customize cartocss
2016-03-04 16:20:23 +01:00
Raul Ochoa
c7bdabfc65
Merge branch 'new_querytables_library' into analysis-layers
2016-03-04 12:08:57 +01:00
Raul Ochoa
ce032fcc96
Improve styling in analysis layers
2016-03-02 12:42:42 +01:00
Alejandro Martínez
e491c0b825
Rename node-cartodb-query-tables to cartodb-query-tables
2016-02-22 19:11:54 +01:00
Alejandro Martínez
e67f7b0d0e
Drop old QueryTablesApi
2016-02-22 15:26:06 +01:00
Raul Ochoa
30f8234bd0
Use analysis configuration as per new camshaft api
2016-02-19 17:13:28 +01:00
Raul Ochoa
6d91172630
Remove console.log
2016-02-18 13:43:39 +01:00
Raul Ochoa
ed1f753690
Fix style
2016-02-12 18:45:46 +01:00
Raul Ochoa
bcf3ce71ef
Adds experimental adapter to use queries based on camshaft analysis
2016-02-12 18:38:06 +01:00
Javier Goizueta
cd2bc319d8
Fix: bad error message
2016-02-10 12:27:39 +01:00
Javier Goizueta
4f8534afb3
Fix: accept empty layers in the MapConfigOverviewsAdapter
2016-02-10 12:16:37 +01:00
Javier Goizueta
0a218da835
Implement an Overviews query rewriter
...
Use the Windshaft query-rewriter interface to adapt queries so
they use available overview tables.
This requires a version of Windshaft that implements the query-rewriter
interface (package.json/npm-shrinkwap.json have yet to be updated)
2016-02-04 10:26:31 +01:00
Javier Goizueta
2a819e559b
Remove commented code
2016-01-22 11:15:25 +01:00
Javier Goizueta
c8033700c3
Fix equality operator use
2016-01-21 17:40:57 +01:00
Javier Goizueta
87bffb9657
Fix: overviews entry should be inside options
2016-01-21 12:06:01 +01:00
Javier Goizueta
094c9076be
Fix: only mapnik layers can have overviews
2016-01-21 12:04:40 +01:00
Javier Goizueta
cc0385d614
Fix class name
2016-01-21 12:03:50 +01:00
Javier Goizueta
ed9b3e1230
Bring in code commented out for tests
2016-01-21 10:58:50 +01:00
Javier Goizueta
5543fcb736
Fix: handle error properly when augmented layers with overviews
2016-01-20 18:09:00 +01:00
Javier Goizueta
b9f8812c98
Update comments
2016-01-20 17:09:15 +01:00
Javier Goizueta
3dad225568
Fix bug
2016-01-20 13:12:45 +01:00
Javier Goizueta
4ca8ecf64c
Refactor/fix potential problems
2016-01-20 12:44:00 +01:00
Javier Goizueta
8a49e46626
Accept minor jshint suggestions
2016-01-20 11:51:46 +01:00
Javier Goizueta
9feae66173
Bugfixes
2016-01-20 11:49:17 +01:00
Javier Goizueta
54854f0984
Avoid wrapper-functions to capture looping variable values
...
Use async-queue defer additional parameters
2016-01-20 10:07:19 +01:00
Javier Goizueta
89590d32df
Sketch of vector overviews support
2016-01-19 19:31:43 +01:00
Raul Ochoa
79375616d5
Default host to empty string when header is not found
...
A String object is required to not fail on `.match` interface.
2015-09-30 16:31:56 +02:00
Raul Ochoa
857548bbe4
Adds support for named layers in named tiles/static maps
2015-09-23 18:44:11 +02:00
Raul Ochoa
f553efa69e
Named map mapconfig provider takes care of template modifications
...
If a template changes it will flush the provider so it recreates the mapconfig
2015-09-23 16:45:20 +02:00
Raul Ochoa
2bdce4baa7
Replaces console.log with global logger
2015-09-18 17:13:22 +02:00
Raul Ochoa
9c6c63c167
More strict jshint
2015-07-15 15:03:28 +02:00
Raul Ochoa
1f7daab677
Caching named map providers by template name and config/auth token
...
Named Map provider cache buster changes on creation
2015-07-14 21:17:58 +02:00
Raul Ochoa
91ab64dda9
Fix cached result in getAffectedTablesAndLastUpdatedTime
2015-07-14 21:00:27 +02:00
Raul Ochoa
07c920bad5
Use named map provider cache to retrieve providers
2015-07-14 20:53:06 +02:00
Raul Ochoa
4aabe9d946
Named maps controller adding cache headers
...
This requires a cache for affected tables as it is hitting db for
every request right now
2015-07-14 20:10:55 +02:00
Raul Ochoa
c97610ad59
style
2015-07-14 14:30:37 +02:00
Raul Ochoa
f9554ec761
Re-enable render limits
2015-07-10 19:10:55 +02:00
Raul Ochoa
e45efbcfb0
New map config provider to allow injecting limits in context
2015-07-10 12:31:56 +02:00
Raul Ochoa
9f252dfac4
Improve named map config format for cache key
2015-07-09 19:49:11 +02:00
Raul Ochoa
5aad624346
NamedMaps controller using NamedMapMapConfigProvider
...
PreviewBackend with format param
2015-07-09 18:47:21 +02:00
Raul Ochoa
23d1109910
Adds named maps mapconfig provider
...
starts using it in named map instantiation
2015-07-09 14:39:25 +02:00
Raul Ochoa
2234a763cb
Uses model through model namespace
2015-07-07 23:52:39 +02:00
Raul Ochoa
d52b65470e
Ports acceptance tests from windshaft
2015-07-07 23:46:58 +02:00
Raul Ochoa
b63e697934
Handle no layers case
2015-07-07 23:45:56 +02:00
Raul Ochoa
f1e8c9a709
Tests for cdb request
2015-03-30 16:28:37 +02:00
Raul Ochoa
f5f7be627f
Move userByReq to its own model
2015-03-23 17:35:09 +01:00
Raul Ochoa
2c7bc6adde
Datasource to give per-layer authentication in named layers
...
Make beforeLayergroupCreate to return a datasource with different
authentication for the different layers.
- Named layers will get access to private tables in case it's needed
Changes in MapConfigNamedLayersAdapter:
- It will retrieve the dbAuth params only if named layers are present so
there is no extra overhead for normal layers
- Rename queue function signature from `callback` to `done` so it is easier
to follow the code
Add several tests to validate `named` layers authentication
2015-02-04 11:30:36 +01:00
Raul Ochoa
4949616c4e
Some acceptance tests, http_status = 403 should not happen in adapter,
...
needs improvement
2015-01-30 19:29:45 +01:00
Raul Ochoa
87eaeb0074
Some integration tests for different cases in named layers type
2015-01-30 18:57:01 +01:00
Raul Ochoa
d0ef87b0cf
Add a before layergroup creation action to allow first level named
...
maps layer type to be extended as other layers
2015-01-30 15:31:49 +01:00