Raul Ochoa
f8f6508449
Merge branch 'master' into mapconfig-dataviews-adapter
...
Conflicts:
NEWS.md
npm-shrinkwrap.json
2016-06-02 10:57:43 +02:00
Raul Ochoa
94bf2748be
Ignore errors coming from overviews adapter
2016-06-01 15:03:02 +02:00
Raul Ochoa
4c25828540
Fix sql signature in agg, formula, and list dataviews
2016-06-01 11:42:24 +02:00
Javier Goizueta
d5423c88ea
Replace use of the name widget by dataview for consistency
2016-05-31 15:30:38 +02:00
Javier Goizueta
5838b7a455
Remove debugging messages
2016-05-31 15:19:33 +02:00
Javier Goizueta
ef276bd51e
Merge branch 'master' into 466-overviews-dataviews
2016-05-30 17:26:06 +02:00
Javier Goizueta
7ac3784f32
Increase the ratio used to select an overview level from a bounding box
...
This value would ideally be adjusted to prevent the grid size of the
overview used being greater that one pixel. So, this should be the
larger dimension of the map window in pixels.
2016-05-30 17:21:56 +02:00
Raul Ochoa
f602ea88e2
Convert widgets from layers into dataviews
...
It also converts filters so full dataviews backend is reusable, that removes
widgets backend dependency.
2016-05-26 19:32:58 +02:00
Raul Ochoa
da6870cf1e
Adds new adapter to transform widgets into dataviews
2016-05-26 11:57:55 +02:00
Raul Ochoa
f7c528277b
Add tests for generic MapConfig adapter
2016-05-26 11:23:19 +02:00
Raul Ochoa
2ff33b5010
Generic MapConfig adapter can receive an arbitrary number of adapters
2016-05-26 11:02:43 +02:00
Raul Ochoa
f34213a147
Reorder public/private functions
2016-05-25 17:24:28 +02:00
Raul Ochoa
5a2afa9b89
Order of adapters: named maps should expand named layers as first step
2016-05-24 19:16:38 +02:00
Raul Ochoa
4759d178d3
No vars for adapters
2016-05-24 18:43:09 +02:00
Raul Ochoa
faa24caf5b
Use generic map config adapter
2016-05-23 23:35:42 +02:00
Raul Ochoa
a785ebef65
Use generic map config adapter
2016-05-23 23:29:06 +02:00
Raul Ochoa
4137de5adf
Remove class members
2016-05-23 22:01:08 +02:00
Raul Ochoa
f012e6092f
Remove unused var
2016-05-23 21:58:42 +02:00
Raul Ochoa
9ce4929d87
Use generic adapter in named maps
2016-05-23 21:56:38 +02:00
Raul Ochoa
8efe844474
Use generic adapter
2016-05-23 21:37:06 +02:00
Raul Ochoa
02cb80daa1
Use context for datasource 2/2
2016-05-23 19:14:03 +02:00
Raul Ochoa
e9d1951d48
Use context for datasource 1/2
2016-05-23 19:09:57 +02:00
Raul Ochoa
a11cc28dc7
Use context for analyses results
2016-05-23 18:59:23 +02:00
Raul Ochoa
a8fdd6726e
Fix style
2016-05-23 18:36:03 +02:00
Raul Ochoa
7ad8a99373
Unify getMapConfig signature for overviews adapter
2016-05-23 18:35:16 +02:00
Javier Goizueta
c0a24108ba
Implement overviews histogram dataviews
2016-05-23 18:11:10 +02:00
Javier Goizueta
ae9b8a0380
Remove comment
2016-05-23 18:10:46 +02:00
Raul Ochoa
31a0b01a27
Rename param
2016-05-23 18:08:42 +02:00
Raul Ochoa
efcb73e0d1
Named layers adapter with getMapConfig signature
2016-05-23 18:03:45 +02:00
Javier Goizueta
f008c74419
Specific aggregation dataview implementation for overviews
2016-05-23 17:42:26 +02:00
Javier Goizueta
4a646d4700
Refactor overviews formula dataview
2016-05-23 17:20:04 +02:00
Javier Goizueta
657b262d92
Override all dataview types for overviews
...
All are using now the default behaviour defined in the base
class.
2016-05-23 17:06:52 +02:00
Javier Goizueta
988412fc07
Define default overviews dataview behaviour in base class
2016-05-23 16:53:28 +02:00
Raul Ochoa
70750d2c43
Unify getMapConfig signature
2016-05-23 16:50:26 +02:00
Raul Ochoa
9c1db98f67
Unifiy getMapConfig signature
2016-05-23 16:44:14 +02:00
Raul Ochoa
12c44fda6f
Unify getMapConfig interface
2016-05-23 16:20:42 +02:00
Raul Ochoa
6ccdb6cefd
Overviews adapter with getMapConfig interface
2016-05-23 15:52:31 +02:00
Raul Ochoa
9f6ce64a31
Named maps adapter with getMapConfig interface
2016-05-23 15:39:11 +02:00
Raul Ochoa
3e35604df0
turbo-carto adapter with getMapConfig interface
2016-05-23 15:18:20 +02:00
Raul Ochoa
01a69ef15c
Merge remote-tracking branch 'origin/master' into mapconfig-reorg
2016-05-23 15:14:25 +02:00
Raul Ochoa
fb045f1836
Merge branch 'master' into turbo-carto-tokens
2016-05-23 15:06:55 +02:00
Raul Ochoa
ee49b8b2a2
Turbo-carto adapter into adapters package
2016-05-23 14:18:58 +02:00
Javier Goizueta
5ba72b4894
Create base class for overviews dataviews
2016-05-23 14:18:45 +02:00
Raul Ochoa
8134aca14d
Named map provider into providers package
2016-05-23 13:32:28 +02:00
Raul Ochoa
215bbbd29c
Store provider into providers package
2016-05-23 13:29:34 +02:00
Raul Ochoa
c4b6f65404
Create map provider into providers package
2016-05-23 13:28:11 +02:00
Raul Ochoa
20725900b6
Overviews adapter into adapters package
2016-05-23 13:25:11 +02:00
Raul Ochoa
ab984729f5
Named layers adapter into adapters package
2016-05-23 13:16:34 +02:00
Raul Ochoa
9f8551058d
Analysis adapter into adapter package
2016-05-23 13:10:52 +02:00
Raul Ochoa
c372d69e98
LayergroupToken only makes sense at testing environment
2016-05-23 13:01:23 +02:00
Javier Goizueta
3add61ec57
Use Camshaft's API to get node filters
2016-05-19 18:32:49 +02:00
Raul Ochoa
b308259e6f
Merge branch 'master' into turbo-carto-category
...
Conflicts:
lib/cartodb/utils/style/postgres-datasource.js
2016-05-19 16:58:31 +02:00
Raul Ochoa
14a0afc7c0
Merge branch 'master' into turbo-carto-tokens
2016-05-19 16:56:00 +02:00
Raul Ochoa
424cc6d93b
Fail on turbo-carto invalid quantification methods
2016-05-19 15:54:58 +02:00
Raul Ochoa
3bacfecc49
Merge branch 'master' into turbo-carto-category
2016-05-19 13:43:35 +02:00
Raul Ochoa
64dd033c94
Merge branch 'master' into turbo-carto-tokens
2016-05-19 13:39:36 +02:00
Raul Ochoa
2e79781711
Adds support for sql wrap in all layers
...
Previously it was only working for analyses ones.
2016-05-19 13:34:29 +02:00
Raul Ochoa
ee94b8a587
Very raw implementation of SubstitutionTokens based on origin data
2016-05-19 12:13:49 +02:00
Raul Ochoa
ba08745c23
Adds hasTokens method to SubstitutionTokens
2016-05-19 12:10:19 +02:00
Raul Ochoa
573932efba
Simplify condition and use positive naming for parsing cartocss
2016-05-19 11:48:57 +02:00
Raul Ochoa
c7f37047b0
Save original query from analysis before wrapping it
2016-05-19 11:41:06 +02:00
Javier Goizueta
2a06405a58
Move definition to the scope where it's needed
2016-05-18 18:21:17 +02:00
Javier Goizueta
a1e024e228
Fix dataview problem for bbox with no query rewrite data
...
Fixes #457
2016-05-18 17:49:09 +02:00
Javier Goizueta
e98a5aeff0
Small code clean-up
2016-05-18 15:48:30 +02:00
Javier Goizueta
4c375780c7
replace underscore functions by standard (ES5) equivalents
...
Note: _.find(a,...) is not replaced by a.find(...)
because it is not available for all the collections
we need it for.
2016-05-18 15:43:20 +02:00
Javier Goizueta
48415fb1f3
Merge branch 'master' into overviews-widgets-2
2016-05-18 13:58:55 +02:00
Javier Goizueta
8da7cf73c1
Remove comment
2016-05-18 13:55:09 +02:00
Javier Goizueta
ba30f460ee
Remove comment
...
Overviews will not be used for dataview search
2016-05-18 13:42:58 +02:00
Javier Goizueta
e1aa0bc7ae
Use JSON format for EXPLAIN
2016-05-18 13:09:55 +02:00
Javier Goizueta
aa0ddaae95
Remove comment
2016-05-18 08:07:48 +02:00
Javier Goizueta
cb3706e5cf
Update Query Rewriter comments
2016-05-18 08:04:11 +02:00
Javier Goizueta
3d8f6576aa
Implement category and range filters
2016-05-18 07:48:11 +02:00
Raul Ochoa
a1934c87d5
Adds turbo-carto category quantification with exact strategy
2016-05-17 19:45:37 +02:00
Javier Goizueta
42ef40282b
💄 shorten long lines
2016-05-17 15:46:13 +02:00
Javier Goizueta
7f7204df6c
Add filter stats information to query rewriter data
2016-05-17 15:41:31 +02:00
Javier Goizueta
3c6d930434
Fix bug
2016-05-17 15:39:32 +02:00
Raul Ochoa
8fb35571fe
Adds support for mapnik substitution token at turbo-carto level
...
Goes green and fixes #455
2016-05-17 15:00:18 +02:00
Javier Goizueta
df63fbbd04
Refactor filter application into own model
...
This also avoids storing an object in the overviews query rewriter
for the bbox filter (a plain data structure is used instead).
2016-05-17 13:55:00 +02:00
Javier Goizueta
9d82e8c27c
Use bounding box of dataviews to select overviews level
2016-05-13 20:47:36 +02:00
Javier Goizueta
224eb392ba
Add overviews-dependent dataviews behaviour
...
Now QueryRewriter is used in dataview objects they can decide
whether overviews are applicable, have the oportunity to
adapt queries for overviews, etc.
This is done by having overviews-related behaviour in models/dataview/overviews
and falling back to the regular models/dataview.
2016-05-13 18:46:58 +02:00
Raul Ochoa
c12e5f7a27
Fix named maps with analysis
...
Named map provider was missing analysis backend dependency
Fixes #450
2016-05-13 16:57:27 +02:00
Raul Ochoa
2e26e2e126
Use split strategy for head/tails turbo-carto quantification
2016-05-13 12:57:43 +02:00
Raul Ochoa
61765d20e1
Fail on turbo-carto specific errors
...
This will try to fallback on postcss errors so it still targets
carto parser in those cases.
Closes #434
2016-05-13 12:10:05 +02:00
Javier Goizueta
b574489950
Refactor to reduce cyclomatic complexity
2016-05-12 18:47:24 +02:00
Javier Goizueta
85788f42a6
Adapt QueryRewriter to new requirements
2016-05-12 18:30:10 +02:00
Javier Goizueta
5fb7f07498
Prevent problems with missing layers in mapconfig
2016-05-12 18:29:30 +02:00
Javier Goizueta
3300c095ed
Merge branch 'master' into overviews-widgets-2
2016-05-12 17:37:24 +02:00
Javier Goizueta
55cf0a8447
Fix typo
2016-05-12 16:43:09 +02:00
Javier Goizueta
64a87690ee
💄 Fix line lengths, etc.
2016-05-12 16:20:34 +02:00
Javier Goizueta
3890014250
Fix QueryRewriter use
...
QueryRewriter should be passed the query that would be used otherwise.
If QR cannot handle it, it will be returned unmodified.
So QR must be used when a query has been prepared and the result
of QR should be used to replace it.
2016-05-12 10:25:09 +02:00
Javier Goizueta
65612f0109
Add filters information at map instantion time to the query rewriter data
2016-05-11 19:24:13 +02:00
Raul Ochoa
3e4f71d873
Nicer error message when missing sql from layer options
...
Fixes #446
2016-05-11 18:24:47 +02:00
Javier Goizueta
fa19f90a6a
Apply overviews query rewriter to dataviews
...
This requires the QueryRewriter to handle a filters parametes in
its data (with Camshaft filter definitions) and a final
options parameters with a bounding_box parameter.
2016-05-11 18:18:22 +02:00
Raul Ochoa
4570d17ce1
Use original query from source nodes
...
Doing a st_transform doesn't make sense as we already should have
the_geom_webmercator column available
2016-05-10 17:09:36 +02:00
Raul Ochoa
6639664b3f
Allow override zoom+center or bbox for static named maps previews
2016-05-09 21:13:13 +02:00
Raul Ochoa
3e94e3288f
Use sql as replacement variable
2016-05-06 17:09:41 +02:00
Raul Ochoa
7d4caf6974
Analysis layers can have a sql_wrap option to wrap node queries
2016-05-06 16:37:52 +02:00
Raul Ochoa
c77ea49594
Use a more aggressive cache control header for node status endpoint
2016-05-05 17:52:37 +02:00
Raul Ochoa
e3d6da06a7
Remove console usage
2016-05-05 12:17:51 +02:00
Raul Ochoa
755dfe6822
Append dataviews related columns to layers
2016-04-27 18:30:05 +02:00
Raul Ochoa
dd731399dc
Starts using turbo-carto dependency
2016-04-26 16:28:05 +02:00
Raul Ochoa
c5bed48d61
Handle missing analyses nodes for layers pointing to them
...
Fixes #422
2016-04-21 17:24:52 +02:00
Raul Ochoa
93dd8a2213
Add analyses metadata for named maps excluding queries
2016-04-21 17:03:41 +02:00
Raul Ochoa
4e4a223f24
Better naming for analysis mapconfig adapter
2016-04-21 16:25:59 +02:00
Raul Ochoa
bc845b2e8d
Validate dataviews format before instantiating
2016-04-21 16:16:00 +02:00
Raul Ochoa
08ad961123
Adds support to return multiple errors in BaseController.sendError
2016-04-21 16:05:48 +02:00
Javier Goizueta
0bb6178d49
Merge pull request #421 from CartoDB/420-overviews-schema
...
Support unneeded schema names in overviews queries
2016-04-20 18:16:16 +02:00
Javier Goizueta
084b3e94a6
Remove unneeded variable
2016-04-20 18:01:34 +02:00
Javier Goizueta
a0445b5cdd
💄 Fix indentation
...
2 spaces were used instead of 4 in some places
2016-04-20 17:47:43 +02:00
Javier Goizueta
ecbae52abe
Refactor: use reduce for collecting overviews metadata
2016-04-20 17:24:16 +02:00
Raul Ochoa
a35403cd91
Add option to modify host header template for camshaft batch client
2016-04-20 16:36:29 +02:00
Raul Ochoa
e04a9a2579
Append dataviews filters after checking if mapconfig must be adapted
2016-04-20 15:40:14 +02:00
Javier Goizueta
57cba3d511
Fix comment
2016-04-20 14:30:13 +02:00
Javier Goizueta
7902b276ad
Support unneeded schema names in overviews queries
...
Fixes #420
Keep table schema of overviews base tables and use it
to support queries that use the schema name when not
strictly needed.
2016-04-19 22:50:05 +02:00
Raul Ochoa
f932862ce4
Improve configuration for batch queries
2016-04-18 15:13:00 +02:00
Raul Ochoa
ab55b083b4
Style
2016-04-18 14:48:14 +02:00
Raul Ochoa
263b3e3682
Rename file
2016-04-18 14:47:35 +02:00
Raul Ochoa
68b19c65fe
newline at end of file
2016-04-18 14:40:34 +02:00
Raul Ochoa
da602eeda0
Use inline execution in camshaft instead of a database service stub
2016-04-14 17:25:08 +02:00
Raul Ochoa
a26025b259
Add analysis backend so it's possible to inject configuration
2016-04-14 17:09:07 +02:00
Raul Ochoa
25a61c8479
Remove console log
2016-04-14 17:08:23 +02:00
Raul Ochoa
e73b64bfed
Merge branch 'master' into analysis-layers
2016-04-14 13:40:51 +02:00
Raul Ochoa
b5b8085444
Reformat for better indentation
2016-04-14 13:40:02 +02:00
Raul Ochoa
388f08a277
Remove unneeded comma
2016-04-14 13:39:19 +02:00
Raul Ochoa
aa36236ed2
Rename analysis to analysis status backend, making room for analysis backend
2016-04-14 13:25:56 +02:00
Raul Ochoa
a9ca453b17
Remove some JSON.stringify
2016-04-14 13:20:22 +02:00
Raul Ochoa
e037c8c1b2
Do not use layer index as analysis node is are unique
2016-04-14 11:08:39 +02:00
Raul Ochoa
09687b3811
Proper endpoint to check node status from analysis
2016-04-14 10:59:51 +02:00
Raul Ochoa
28400f4544
Better naming
2016-04-13 19:15:06 +02:00
Raul Ochoa
7a87b8ebef
Use node id instead of param id for endpoint
...
It will be easier to retrieve node status with that id
2016-04-13 18:04:49 +02:00
Raul Ochoa
9ff661480b
Do not append root as it is already included in sorted nodes
2016-04-13 18:02:28 +02:00
Raul Ochoa
ca564bfaad
Add fake analysis node status endpoint
2016-04-11 18:49:56 +02:00
Raul Ochoa
dd36877a20
Add per node status
2016-04-11 18:49:43 +02:00
Raul Ochoa
1d860fd202
Remove top level url for analysis
2016-04-11 18:49:22 +02:00
Raul Ochoa
0981ccd0c4
Add metadata information about analyses
2016-04-07 17:58:12 +02:00
Raul Ochoa
077c4ab907
Adds analysis MapConfig adapter to named maps
2016-04-07 16:18:48 +02:00
Raul Ochoa
efacafaa0d
Merge remote-tracking branch 'origin/master' into analysis-layers
2016-04-07 15:04:25 +02:00
Raul Ochoa
1c250bf243
Remove dependency
2016-04-07 14:30:49 +02:00
Daniel García Aubert
b5b8083acd
Overrided cartocss in the instantiation of named maps
2016-04-06 17:43:25 +02:00
Raul Ochoa
ab6bae6a7f
Merge branch 'master' into analysis-layers
2016-04-04 16:24:31 +02:00
Javier Goizueta
01218c6ea1
Merge pull request #409 from CartoDB/405-wrapped-overviews-queries
...
Support overviews for named layer wrapped queries
2016-04-04 14:18:57 +02:00
Javier Goizueta
fa2e884605
Support overviews for named layer wrapped queries
...
Fix #405
2016-04-01 15:40:44 +02:00
Javier Goizueta
b97a67b844
Fix overviews integration for named layers
...
Fixes #400
2016-03-31 18:33:41 +02:00
Raul Ochoa
499178319d
Add search endpoint/backend for dataviews
2016-03-23 12:14:17 +01:00
Raul Ochoa
2bd3e46a4d
Build dataviews with factory to generalise them
2016-03-22 13:10:42 +01:00
Raul Ochoa
26512f6485
Remove unused function
2016-03-22 12:22:48 +01:00
Raul Ochoa
90b92f0180
Adds support for category filters
2016-03-22 12:22:04 +01:00
Raul Ochoa
ebe25761d2
Extract variable
2016-03-22 10:52:02 +01:00
Raul Ochoa
f928147559
Fix bbox template
2016-03-21 18:16:54 +01:00
Raul Ochoa
d5c5c7bdbb
Do not remove analysis, camshaft takes care of source root nodes now
2016-03-21 18:02:19 +01:00