cartodb4/Windshaft-cartodb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Trim fields when normalizing

Browse Source
This commit is contained in:
Esther Lozano 2020-02-26 14:50:41 +01:00
parent 583765a298
commit 34c446909e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/api/middlewares/pubsub-metrics.js
View File

@ -45,7 +45,7 @@ function getEventData (req, res) {
} }
function normalizedField (field) { function normalizedField (field) {
return field.toString().substr(0, MAX_LENGTH); return field.toString().trim().substr(0, MAX_LENGTH);
} }
module.exports = pubSubMetrics; module.exports = pubSubMetrics;

4
test/integration/pubsub-metrics-test.js
View File

@ -12,7 +12,7 @@ const metricsHeaders = {
'Carto-Event-Group-Id': '1' 'Carto-Event-Group-Id': '1'
}; };
const tooLongField = 'If you are sending a text this long in a header you kind of deserve the worst, honestly. I mean ' + const tooLongField = ' If you are sending a text this long in a header you kind of deserve the worst, honestly. I mean ' +
'this is not a header, it is almost a novel, and you do not see any Novel cookie here, right?'; 'this is not a header, it is almost a novel, and you do not see any Novel cookie here, right?';
const badHeaders = { const badHeaders = {
@ -119,7 +119,7 @@ describe('pubsub metrics middleware', function () {
global.environment.pubSubMetrics.enabled = true; global.environment.pubSubMetrics.enabled = true;
const eventAttributes = buildEventAttributes(200); const eventAttributes = buildEventAttributes(200);
const maxLength = 100; const maxLength = 100;
const eventName = tooLongField.substr(0, maxLength); const eventName = tooLongField.trim().substr(0, maxLength);
testClient = new TestClient(mapConfig, 1234, badHeaders); testClient = new TestClient(mapConfig, 1234, badHeaders);