From 2cac43ef39a0a5d029ee11eef045a1be525eb18d Mon Sep 17 00:00:00 2001 From: Thomas Khyn Date: Thu, 14 Apr 2016 12:25:50 +1200 Subject: [PATCH] Taking the absolute value is actually not necessary --- src/js/plugin/update-scroll.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/plugin/update-scroll.js b/src/js/plugin/update-scroll.js index 85f0e3f..1fb40e4 100644 --- a/src/js/plugin/update-scroll.js +++ b/src/js/plugin/update-scroll.js @@ -54,7 +54,7 @@ module.exports = function (element, axis, value) { if (axis === 'top' && value >= i.contentHeight - i.containerHeight) { // don't allow scroll past container value = i.contentHeight - i.containerHeight; - if (Math.abs(value - element.scrollTop) <= 1) { + if (value - element.scrollTop <= 1) { // mitigates rounding errors on non-subpixel scroll values value = element.scrollTop; } else { @@ -66,7 +66,7 @@ module.exports = function (element, axis, value) { if (axis === 'left' && value >= i.contentWidth - i.containerWidth) { // don't allow scroll past container value = i.contentWidth - i.containerWidth; - if (Math.abs(value - element.scrollLeft) <= 1) { + if (value - element.scrollLeft <= 1) { // mitigates rounding errors on non-subpixel scroll values value = element.scrollLeft; } else {