Commit Graph

452 Commits

Author SHA1 Message Date
bmc
56a5903a02 Make throws in query error callback not break client
If you receive an error while running a query and in user's callback
they throw an exception it can disrupt the internal query queue
and prevent a client from ever cleaning up properly
2013-04-19 09:25:53 -05:00
bmc
9b1c4facc2 Make query callback exceptions not break client
If you throw an exception in a query callback the client will not pulse
its internal query queue and therefor will never process any
more queries or emit its own 'drain' event.

I don't find this to be an issue in production code since I restart
the process on exceptions, but it can break tests and cause things
to 'hang'.  My crude benchmarks show no noticable impact in perf
from the try/catch/rethrow.

:q
2013-04-19 09:09:28 -05:00
brianc
3f5df0afa2 make tests pass on pg@8.4.9 2013-04-17 10:29:42 -05:00
brianc
f5f5320b15 fix tests on older versions of postgres 2013-04-17 09:54:16 -05:00
bmc
f55a0cd1b4 fix tests for postgres >= v9.2.0 2013-04-17 09:26:31 -05:00
bmc
21ca91d801 allow assert.success to accept 0 arity callback 2013-04-04 11:54:31 -05:00
bmc
766b4286d5 merge branch v1.0 2013-04-04 11:51:55 -05:00
bmc
173f3f37b2 fix end race in test 2013-04-04 11:45:41 -05:00
brianc
6e3cc794c3 ignore socket hangup. fixes #314 2013-03-29 09:38:49 -05:00
brianc
07a049df96 use supplied connection params in new tests 2013-03-28 15:06:34 -05:00
brianc
683d636501 better handling of client stream termination
1. Pass an error to an active query if the client is ended while a query is in progress.
2. actually emit 'end' event on the client when the stream ends
3. do not emit an error from native bindings if lasterror is null
2013-03-28 13:24:33 -05:00
brianc
cee5f1d8b3 move buffer-writer to external module 2013-03-16 11:51:26 -05:00
Sandro Santilli
f38f9f084d Fix parsing of numeric[], previously returning array of ints
Closes #304, includes testcase
2013-03-14 10:06:46 +01:00
brianc
a5ee365116 remove parseFloat 2013-03-07 16:19:11 -06:00
brianc
e93a4a5d66 remove pauseDrain/resumeDrain 2013-03-07 16:12:09 -06:00
brianc
aadb2917cc fix broken test 2013-03-07 16:09:40 -06:00
brianc
9c7a33caca remove 2 parameter pg.connect function 2013-03-07 15:57:00 -06:00
brianc
f30158f7c4 deprecate float parsing - closes #296 2013-03-07 09:54:01 -06:00
swilly
49bff032aa fix tests 2013-03-06 12:00:17 -05:00
Andrew Dunstan
ed015f9b58 Fix Unix domain socket setting.
This code was misconceived in that the host parameter for a Unix
domain socket connection must point to the directory containing
the socket, and not to the socket itself. Libpq will look for
the socket based on the host and port settings. See
<http://www.postgresql.org/docs/current/static/libpq-connect.html#LIBPQ-PARAMKEYWORDS>
2013-02-23 11:11:44 -05:00
Brian C
c6d5f43473 Merge pull request #278 from adunstan/master
Allow passing a JS array instead of an array literal where SQL expects an array
2013-02-22 09:33:17 -08:00
Andrew Dunstan
44b15422a0 allow passing JS array as a parameter instead of an array literal where SQL expects an array 2013-02-21 17:32:47 -05:00
bmc
5c95886749 clear deprecation warning on client error - fix test race 2013-02-21 14:49:26 -06:00
bmc
cc84799c7a integrate new pool into existing codebase 2013-02-20 16:08:48 -06:00
bmc
bb448fe61a finish out the first rev of the improved pool api 2013-02-19 19:34:28 -06:00
bmc
971eb5d1ef initial work on new pool 2013-02-15 16:13:28 -06:00
Arkady Emelyanov
4c254e8edf force utf-8 encoding on connect 2013-01-29 20:19:38 -06:00
bmc
6f73583112 add another test for weird connection strings 2013-01-29 20:06:50 -06:00
Francois Payette
7d773508fc replace space by %20 in connection string before passing to url.parse 2013-01-24 20:05:55 -05:00
Brian C
beb3e4fcd1 Merge pull request #248 from liamks/master
Added varchar[] and char[] to array parsing.
2013-01-23 20:32:27 -08:00
Liam Kaufman
30fce731ca added unit tests for the three array types 2013-01-23 20:35:20 -05:00
bmc
113b6298e2 use ConnectionParameters with native bindings and remove unused util functions 2013-01-22 23:23:47 -06:00
bmc
edfa3b5cdc add assert.calls to async functions within tests 2013-01-21 16:30:59 -06:00
bmc
1e3107aa55 use ConnectionParameters for js client properties 2013-01-21 16:14:19 -06:00
bmc
9dad56a54e add more functionality to connection parameters 2013-01-21 15:44:55 -06:00
bmc
ec0d0beff2 build libpq connection string & support domain socket 2013-01-21 15:09:44 -06:00
anton
88d684f925 bugfix. sometimes native copy to loose rows 2013-01-20 19:45:41 -06:00
anton
583d059947 add tests that checks error reporting for incorrect copy to/copy from usage. add tests for fixed bug in native copy from implementation 2013-01-20 19:45:41 -06:00
bmc
868a9d0e8d remove node-tap 2013-01-20 19:42:40 -06:00
bmc
92e75f0577 add ConnectionParameters object 2013-01-20 19:42:39 -06:00
anton
4667e1dea3 test if copy query and other queries queued correctly 2013-01-06 12:06:27 -06:00
anton
b6fcffc302 write messages for assertions 2013-01-06 12:06:27 -06:00
anton
4ef99b2e8e write unit tests for CopyToStream class 2013-01-06 12:06:27 -06:00
anton
3a2684c928 add unit tests for copyFromStream class 2013-01-06 12:06:27 -06:00
anton
bcd47edd62 write tests for copy to/from on the level of client library 2013-01-06 12:06:27 -06:00
anton
965b7b4f84 test event exchange between libpq bindings and js while COPY TO/FROM 2013-01-06 12:06:26 -06:00
anton
ba1e3546f1 test connection and backend event exchange during COPY TO/FROM 2013-01-06 12:06:26 -06:00
Stephen Sugden
5d25bcdcf0 add some tests for normalizeQueryConfig 2012-12-16 00:58:30 -06:00
brianc
102a069bd2 have native bindings emit proper result object on 'end' event - closes #219 2012-12-10 23:25:26 -06:00
brianc
1c43930ba1 cleanup & fix failing tests to allow for green merge of pull #228 2012-12-10 22:44:58 -06:00