Commit Graph

1413 Commits

Author SHA1 Message Date
bmc
56a5903a02 Make throws in query error callback not break client
If you receive an error while running a query and in user's callback
they throw an exception it can disrupt the internal query queue
and prevent a client from ever cleaning up properly
2013-04-19 09:25:53 -05:00
bmc
9b1c4facc2 Make query callback exceptions not break client
If you throw an exception in a query callback the client will not pulse
its internal query queue and therefor will never process any
more queries or emit its own 'drain' event.

I don't find this to be an issue in production code since I restart
the process on exceptions, but it can break tests and cause things
to 'hang'.  My crude benchmarks show no noticable impact in perf
from the try/catch/rethrow.

:q
2013-04-19 09:09:28 -05:00
brianc
e95d28d3f1 version bump 2013-04-18 15:16:25 -05:00
Brian C
07fd762137 Merge pull request #331 from brianc/postgres-gte-9.2
fix tests on new versions of postgres
2013-04-17 08:32:51 -07:00
brianc
3f5df0afa2 make tests pass on pg@8.4.9 2013-04-17 10:29:42 -05:00
Brian C
01f3f3da53 use master branch url for travis image 2013-04-17 09:59:10 -05:00
brianc
f5f5320b15 fix tests on older versions of postgres 2013-04-17 09:54:16 -05:00
bmc
f55a0cd1b4 fix tests for postgres >= v9.2.0 2013-04-17 09:26:31 -05:00
Brian C
541832658e Merge pull request #329 from Pegase745/master
Travis Nodejs 0.10 build error correction
2013-04-17 06:34:57 -07:00
Pegase745
0ccdee4b93 Travis Nodejs 0.10 build error correction
Putting it between double quotes permits Travis to not see it as Node 0.1 but 0.10
2013-04-17 14:15:02 +03:00
za-creature
b6ef157e8e Update connection-parameters.js 2013-04-11 23:35:21 +03:00
za-creature
264839d3a9 Update creation-tests.js
connection exports 'database' instead of 'path'
2013-04-11 23:10:43 +03:00
za-creature
b536867349 Merge pull request #1 from za-creature/master
unittest
2013-04-11 12:54:15 -07:00
za-creature
20a2cbc810 Update creation-tests.js
added unittest for urlencoded components
2013-04-11 22:47:32 +03:00
za-creature
5493a52793 Update connection-parameters.js
Different double-encode removal strategy
2013-04-11 22:32:04 +03:00
za-creature
c666b20287 Update connection-parameters.js
The current connection url handling fails when the password contains
encoded special characters: After the encodeURI, the special
characters from the password are double encoded, and the password is
rejected by postgres.

Proposed fix handles one level of double encoding, and while it
might break compatibility with passwords like "asdfg%77fgh" (which
would've been escaped to asdfg%2577fgh before this patch), I
strongly feel that maintaining backwards compatibility is in this
case less important than following standards and discouraging bad
coding practices.
2013-04-11 19:57:03 +03:00
Candid Dauth
3aedebb0b0 Fixing parsing of timestamps without timezone in binary mode 2013-04-11 01:11:08 +02:00
Candid Dauth
62800f1db0 Adding test for timezone handling (#238) 2013-04-11 00:42:37 +02:00
Candid Dauth
694fc3eb6e Fixing code style to make #238 pass jshint 2013-04-11 00:41:15 +02:00
Candid Dauth
bde871707b Storing timezone-less dates in local time instead of UTC
Issue #225 caused such dates to be read, but not stored in local time.
2013-04-10 23:10:44 +02:00
bmc
b33c266734 increase speed of javascript parser ~5% 2013-04-08 19:04:17 -05:00
bmc
f16eaa8555 Merge branch 'benchmark' 2013-04-08 16:44:54 -05:00
bmc
ca5c10a02f clean up connection slightly & add initial bench 2013-04-08 16:44:41 -05:00
Brian C
4e822a11e2 Merge pull request #322 from KingKarl85/master
line 7 - var utils declared and not used on client.js
2013-04-05 07:29:54 -07:00
Karl Mikkelsen
44e4586e18 var utils declared and not used 2013-04-05 17:46:23 +12:00
bmc
835f71a76f reduce bench itterations 2013-04-04 13:50:17 -05:00
bmc
3d7c31fa4a Merge branch 'master' into benchmark 2013-04-04 13:06:53 -05:00
bmc
f98bbed610 update news file 2013-04-04 12:02:11 -05:00
bmc
23be617f3a fix missed merge conflict 2013-04-04 11:58:38 -05:00
bmc
21ca91d801 allow assert.success to accept 0 arity callback 2013-04-04 11:54:31 -05:00
bmc
766b4286d5 merge branch v1.0 2013-04-04 11:51:55 -05:00
bmc
173f3f37b2 fix end race in test 2013-04-04 11:45:41 -05:00
bmc
a28f156347 work in benchmark 2013-04-04 11:40:37 -05:00
brianc
3b2f4134b2 version bump 2013-03-29 10:39:05 -05:00
Brian C
1dd7caf26e Merge pull request #316 from brianc/ignore-socket-hangup
ignore socket hangup. fixes #314
2013-03-29 08:36:36 -07:00
brianc
6e3cc794c3 ignore socket hangup. fixes #314 2013-03-29 09:38:49 -05:00
brianc
95b1c75cfe version bump 2013-03-28 15:35:59 -05:00
Brian C
027c4961fa Merge pull request #315 from brianc/handle-stream-end
better handling of client stream termination
2013-03-28 13:32:57 -07:00
brianc
07a049df96 use supplied connection params in new tests 2013-03-28 15:06:34 -05:00
brianc
301f076f01 pin jshint version 2013-03-28 13:37:08 -05:00
brianc
683d636501 better handling of client stream termination
1. Pass an error to an active query if the client is ended while a query is in progress.
2. actually emit 'end' event on the client when the stream ends
3. do not emit an error from native bindings if lasterror is null
2013-03-28 13:24:33 -05:00
brianc
df766c9134 begin work on benchmarking 2013-03-19 10:07:13 -05:00
brianc
1d6541724e remove deprecation warnings & deprecate lib 2013-03-17 14:51:57 -05:00
brianc
cee5f1d8b3 move buffer-writer to external module 2013-03-16 11:51:26 -05:00
brianc
4b19869004 version bump 2013-03-14 08:53:15 -05:00
brianc
6d5e13d580 add NEWS.md file 2013-03-14 08:44:32 -05:00
Brian C
d06a2164ee Merge pull request #307 from strk/master-looser-pg-dep
Loosen generic-pool dependency to ~2.0.2
2013-03-14 06:38:57 -07:00
brianc
463884adc2 change versions of node tested with travis-ci 2013-03-14 08:37:58 -05:00
Brian C
8f58409195 Merge pull request #303 from strk/master-make-all
Add a default "make all" rule to "build" the project (npm install)
2013-03-14 06:34:06 -07:00
Brian C
fd288be411 Merge pull request #305 from strk/master-array-numeric
Fix parsing of numeric[], previously returning array of ints
2013-03-14 06:33:57 -07:00