cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,704 Commits 1 Branch 167 Tags 4 MiB
9bcf55dda9
Commit Graph

102 Commits

Author SHA1 Message Date
Brian C
842803c7ef Fix over-eager deprecation warnings (#1333) 
* WIP

* Remove console.log messages
 2017-06-20 08:59:07 -05:00
Brian M. Carlson
b5b49eb895 Add deprecations 
This adds deprecations in preparation for `pg@7.0`

- deprecate using event emitters on automatically created results from client.query.
- deprecate query.promise() - it should never have been a public method and it's not documented. I need to do better about using _ prefix on private methods in the future.
- deprecate singleton pool on the `pg` object. `pg.connect`, `pg.end`, and `pg.cancel`.
 2017-06-19 16:00:37 -05:00
T.J. Schuck
e5f0e5d36a s/2016/2017/ (#1291) 2017-05-17 16:47:07 -05:00
Linus Unnebäck
ce8f215c88 Fix throw in type parsers when in prepared statement (#1242) 2017-03-09 15:05:26 -06:00
Linus Unnebäck
5cb38f5892 Handle throws in type parsers (#1218) 
* Handle throws in type parsers

* Fix throw in type parsers test for Node 0.x
 2017-03-06 11:04:16 -06:00
Charmander
981960b445 Remove confusing conditions (#1159) 
* Remove unreachable code

* Remove redundant condition

Every path with `!this.values` results in `false` regardless of `this.binary`.
 2016-12-13 07:50:07 -06:00
Brian C
b1b2801c71 Add onFailure to query#then (#1082) 
The promise adapter I had implemented wasn't spec compliant: it didn't accept both `onSuccess` and `onFailure` in the call to `query#then`.  This subtly broke yield & async/await because they both rely on `onError` being passed into `Promise#then`.  The pool was also not returning the promise after a client was acquired, which broke awaiting on `pool.connect` - this is also fixed now.
 2016-07-19 10:16:48 -05:00
Illirik Smirnov
522d62229b Resolve merge conflict in PR #1041 (#1065) 
* Add license comment

* Delete pool.js
 2016-06-24 10:56:43 -05:00
Brian C
2fd9c77085 Make Query & NativeQuery implement the promise interface (#1047) 
* Make Query & NativeQuery implement the promise interface

* Fix test

* Use older node API for checking listener length

* Do not test for promises on node@v0.10.0
 2016-06-10 17:18:19 -05:00
Tristan Davies
55abbaa844 don't mutate params when preparing statement (#992) 2016-04-28 14:46:33 -05:00
Joost Farla
f50f5ce7e8 Require statements break Browserify compatibility 2015-10-10 11:10:51 +02:00
brianc
6f8292435d Respond to emptyQuery with a sync message 
When a __prepared statement__ has no body in the query the backend responds with an `emptyQuery` message but never with a `commandComplete` or `errorResponse` message.  The client was hanging forever waiting for one of the other two expected messages.  The server was hanging forever waiting for the client to respond with a `sync` message.  This change has the client send the required `sync` on receipt of an `emptyQuery` message when the query is a prepared statement.  Fixes #822
 2015-08-01 18:51:49 -05:00
Brian M. Carlson
fb2db0874d Merge with origin/master 2014-11-18 14:59:38 -05:00
Brian M. Carlson
9e2a3e599b Fix issue with parsed statement cache timing - closes #665 2014-10-21 13:50:49 -04:00
Brian M. Carlson
1e648c5df4 Do not consider a statement as prepared if it errors 
Fixes #600
 2014-10-19 22:53:08 -04:00
Brian M. Carlson
4c5f3aba65 Add support for native rowMode: array 
This completes the port from the old native bindings to the new node-pg-native bindings!

Time to build in support for older versions of postgres & start the pull request process.
 2014-10-11 14:09:29 -04:00
Brian M. Carlson
9c87253aff Fix memory leak with domains 2014-04-12 00:29:44 -05:00
Tim Griesser
cd050334ba Removed various unused vars 2014-04-09 08:46:17 -04:00
Brian M. Carlson
357b64d704 Remove query emit 'end' event when query has error 
Closes #547
 2014-04-06 11:53:47 -05:00
Nikhil Benesch
cb7bbe6502 query: remove dead type-parsing code path 
Type parsing was factored out into the pg-types package. Remove vestigal
`noParse` function.
 2014-03-30 19:02:11 -04:00
Brian M. Carlson
876abe8730 Break type parsing into separate module 2014-03-15 15:36:27 -05:00
Brian M. Carlson
99f9492c72 Clean up copy-in internal API 2013-10-22 00:23:43 -05:00
Brian M. Carlson
a72bd5cb3c Semi-colons 2013-10-21 09:39:49 -05:00
Brian M. Carlson
fc397ee7f5 Clean up client->query event delegation 2013-10-21 09:20:21 -05:00
Brian Carlson
145666c1b3 Support result rows as arrays 2013-07-08 17:45:06 -05:00
Brian Carlson
413eff72e5 Move row parsing into result object 2013-07-08 09:30:10 -05:00
Brian Carlson
337d49dddb Return field metadata on result object 
Closes #209
Native implementation requires significant refactor and so I wont work on this
if/until there is an issue for it
 2013-06-03 12:14:47 -05:00
brianc
c57eee8661 normalize whitespace, add comments, and do a little house cleaning 2013-03-06 10:26:40 -06:00
brianc
37bb13fc0c move type conversion related code under sub-folder 2013-03-06 08:57:38 -06:00
brianc
b58ae9e7f7 clean up prototype shorthand 
For some reason a few years ago I thought it would be neat to use a shorthand version of prototype to save myself some keystrokes.  That was a cosmetic mistake.  It also breaks ctags.

Also, normalized some whitespace.
 2013-03-06 08:48:52 -06:00
Philipp Borgers
051fa5558f remove trailing whitespaces in lib/query.js 2013-01-24 22:05:34 +01:00
Philipp Borgers
da1e62e684 fix jshint errors for lib/query.js 2013-01-24 21:59:28 +01:00
anton
7ca21acb25 handle situation, when broken copy to query, ends before it is canceled 2013-01-20 19:45:41 -06:00
anton
c5c31143c1 1. behave correctly if copy to/from is send to db by query method (report error in standart way); 2. bugfix and code review in native copy to implementation 2013-01-20 19:45:40 -06:00
Sandro Santilli
2fc22de21a Send backend a CopyFail when no stream is defined to copy from 2013-01-16 12:41:14 +01:00
Sandro Santilli
a39e0d7cc9 Rework handling of missing stream object for copy ops 
This version works better (doesn't throw) but also doesn't report
any error, which is not good
 2013-01-16 12:04:28 +01:00
Sandro Santilli
de9d5e3cd5 Cleanly handle missing stream error on COPY operation. Closes #241 2013-01-16 10:11:55 +01:00
anton
c014096e0e COPY TO/FROM native/libpq done. Looks like it works, but need to test 2013-01-06 12:06:26 -06:00
Stephen Sugden
5dae2b267f Extract query config normalization into utils 2012-12-16 00:58:30 -06:00
brianc
1c43930ba1 cleanup & fix failing tests to allow for green merge of pull #228 2012-12-10 22:44:58 -06:00
Troy Kruthoff
e62eb9339b make Query a public api 2012-12-10 21:32:20 -06:00
brianc
fa80b4e3fa make data conversion the same between native & javascript 2012-07-11 22:47:02 -05:00
Cameron Howey
f978cc6379 Add result to row event 
This makes the `result` object available from the row event.
 2012-03-26 09:05:34 -04:00
Alexander Sulfrian
59c5df6ef4 remove name duplication 2011-11-18 21:23:39 +01:00
Alexander Sulfrian
916895639b Merge remote branch 'upstream/master' 
Conflicts:
	lib/query.js
	lib/types.js
	test/unit/client/query-tests.js
	test/unit/client/typed-query-results-tests.js
 2011-11-18 21:12:28 +01:00
brianc
06585d6e2c require 'util' instead of 'sys' 2011-10-10 19:40:52 -05:00
brianc
1fbe54d5f2 fix gh#36 2011-07-12 23:08:16 -05:00
Alexander Sulfrian
207b7dbb2b Merge remote branch 'upstream/master' 
Conflicts:
	lib/query.js
	test/unit/client/typed-query-results-tests.js
 2011-06-21 21:42:43 +02:00
Alexander Sulfrian
e891e7f4fb parser: added bool parsing 2011-06-16 18:32:20 +02:00
Alexander Sulfrian
ba9b85fe26 binaryParser: added function to parse text fields 2011-06-06 19:31:57 +02:00