cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,301 Commits 1 Branch 167 Tags 4 MiB
981b4345f0
Commit Graph

537 Commits

Author SHA1 Message Date
Brian M. Carlson
bd74d48791 Fix query error emit on native bindings 2014-04-06 12:55:26 -05:00
Brian M. Carlson
357b64d704 Remove query emit 'end' event when query has error 
Closes #547
 2014-04-06 11:53:47 -05:00
Brian C
f3fc6ff705 Merge pull request #546 from CartoDB/2.11-ensure-connect-callback 
Ensure connect callback is invoked on premature socket hangup
 2014-04-06 11:18:23 -05:00
Brian C
82486929a9 Merge pull request #555 from benesch/custom-type-coercion 
Supercharge `prepareValue`
 2014-04-06 11:16:33 -05:00
Sandro Santilli
e1b1c62e3e Do not emit 'end' twice from Connection on close 2014-04-04 10:07:07 +02:00
Nikhil Benesch
619ba46ffe pass prepareValue hook to toPostgres 
Pass `toPostgres` type-coercers a reference to the `prepareValue`
function to ease constructing literals composed of other Postgres types.
 2014-04-03 10:28:02 -04:00
Brian C
7dbc4c9845 Merge pull request #552 from geon/patch-1 
Added missing argument to handleError method call.
 2014-04-03 08:58:48 -05:00
Nikhil Benesch
6ced524390 allow type-coercion overrides for custom objects 
Attempt to call a `toPostgres` method on objects passed as query values
before converting them to JSON. This allows custom types to convert
themselves to the appropriate PostgreSQL literal.

This strategy is fully backwards-compatible and uses the same pattern as
the `toJSON` override.
 2014-03-30 20:39:56 -04:00
Nikhil Benesch
c41eedc3e0 properly prepare complex arrays 
`arrayString` duplicated too much of `prepareValue`'s logic, and so
didn't receive bugfixes for handling dates with timestamps. Defer to
`prepareValue` whenever possible.

This change enforces double-quote escaping of all array elements,
regardless of whether escaping is necessary. This has the side-effect of
properly escaping JSON arrays.
 2014-03-30 19:12:18 -04:00
Nikhil Benesch
364cf4b3ca utils: convert tabs to spaces 2014-03-30 19:11:02 -04:00
Nikhil Benesch
7faa2b325e utils: reorganize prepareValue conditional for clarity 
Prefer positive tests; group tests for specific objects.
 2014-03-30 19:03:28 -04:00
Nikhil Benesch
cb7bbe6502 query: remove dead type-parsing code path 
Type parsing was factored out into the pg-types package. Remove vestigal
`noParse` function.
 2014-03-30 19:02:11 -04:00
Victor Widell
5079c1e0c4 Added missing argument to handleError method call. 
Before the change, it would crash with a very unhelpful error message:

	[project path]/node_modules/pg/lib/query.js:92
	    connection.sync();
	               ^
	TypeError: Cannot call method 'sync' of undefined
	    at Query.handleError ([project path]/node_modules/pg/lib/query.js:92:16)
	    at Client.connect ([project path]/node_modules/pg/lib/client.js:178:24)
	    at g (events.js:185:14)
	    at EventEmitter.emit (events.js:85:17)
	    at Socket.<anonymous> ([project path]/node_modules/pg/lib/connection.js:60:10)
	    at Socket.EventEmitter.emit (events.js:85:17)
	    at TCP.onread (net.js:424:51)


After the change, it reports a much more helpful

	error running query [Error: Stream unexpectedly ended during query execution]
 2014-03-29 16:45:00 +01:00
Brian C
b12dd4c420 Merge pull request #543 from CartoDB/2.11-remove-ended-connections 
Remove disconnected clients from the pool
 2014-03-22 10:47:53 -05:00
Sandro Santilli
96e4afdb1b Have Connection also emit 'end' on stream 'close' event 
Should fix missing connect callback call with node-0.8 (#534)
 2014-03-18 14:23:05 +01:00
Sandro Santilli
64d6883a81 Ensure connect callback is invoked on premature socket hangup 
Closes #534
 2014-03-18 13:03:15 +01:00
Sandro Santilli
fb118cf069 Avoid loop between pool.destroy and client.end 2014-03-18 09:42:19 +01:00
Sandro Santilli
9c5cd8d02d Remove disconnected clients from the pool 
Might fix #458
Fixes https://github.com/CartoDB/CartoDB-SQL-API/issues/135
 2014-03-17 18:51:32 +01:00
Brian M. Carlson
779c8064f2 Add domain support to connection pool 2014-03-15 16:41:33 -05:00
Brian M. Carlson
0254fa565f Add test for pg.types interface 2014-03-15 15:41:36 -05:00
Brian M. Carlson
876abe8730 Break type parsing into separate module 2014-03-15 15:36:27 -05:00
Brian M. Carlson
79f03948dd Use packet reader 2014-03-14 06:59:19 -05:00
Brian C
2716f95257 Merge pull request #514 from benighted/parse-date-as-local 
Parse date type as local time
 2014-02-26 06:16:12 -06:00
Brian C
ff8fb616f6 Merge pull request #501 from lalitkapoor/GH-452 
improve support for int arrays and float arrays
 2014-02-26 06:15:35 -06:00
Brian C
be37756607 Merge pull request #395 from aaronyo/master 
Unable to reconnect after calling pg.end()
 2014-02-26 06:12:57 -06:00
Brian M. Carlson
bf0c4bfaa9 Merge branch 'pull/326' 
Conflicts:
	lib/connection-parameters.js
	test/unit/connection-parameters/creation-tests.js
 2014-02-26 06:10:15 -06:00
Michael Payne
b81a60a260 Parse date type as local time 2014-01-26 10:43:15 -05:00
Brian C
62f6b2fbf9 Merge pull request #507 from brianc/issues/507 
Unexpected identifier with pg versions > 2.3.1
 2014-01-22 06:42:59 -08:00
Brian M. Carlson
5f592a1240 Fix exception caused by column names with single quotes 
Also rename some test files so they match the Makefile regex.  They will be included in the test suite from now on.
 2014-01-22 08:38:29 -06:00
Lalit Kapoor
8f4644dc3d parse values in float arrays as floats not strings 
javascript numbers are 64-bit floating numbers
 2014-01-08 00:09:34 -06:00
Lalit Kapoor
3cb35e0f46 big integer array support 2014-01-08 00:08:57 -06:00
Lalit Kapoor
58b4d9cf9c comment explaining how to get oid 2014-01-07 11:48:55 -06:00
Hannes Hörl
7fd79a41c3 Add support for (fallback_)application_name 2014-01-05 18:08:58 +01:00
Hannes Hörl
5c5c57e60b Fixes bug in test for extended years 2013-12-23 02:13:10 +01:00
Hannes Hörl
9ad0159037 merge with upstream 2013-12-22 23:21:42 +01:00
Aurélio A. Heckert
c0fd4b1431 Set database on socket string connection 
Allows to conect to a specific database trough this ways:
pg.connect('/some/path database', callback);
pg.connect('socket:/some/path?db=database', callback)
pg.connect('socket:/some/path?db=database&encoding=utf8', callback)
 2013-12-19 15:37:26 -03:00
Hannes Hörl
61f8f55d43 Handle .pgpass in the native client 2013-12-11 01:24:55 +01:00
Michael Payne
b9c9c6f329 Fix for Y10k problem 2013-12-09 23:35:18 -05:00
Hannes Hörl
95295ad2fb Handle .pgpass in the js client 2013-12-06 00:01:51 +01:00
Brar Piening
d5e459227a Modified defaults.js to use process.env.USERNAME instead of process.env.USER as default value for user and database on Windows platforms 2013-11-20 20:19:31 +01:00
Brian M. Carlson
99f9492c72 Clean up copy-in internal API 2013-10-22 00:23:43 -05:00
Brian M. Carlson
894c60e605 Accept anything with function 'submit' as a query 
This allows for passing in custom objects which conform to the query API
 2013-10-21 13:29:17 -05:00
Brian M. Carlson
a72bd5cb3c Semi-colons 2013-10-21 09:39:49 -05:00
Brian M. Carlson
fc397ee7f5 Clean up client->query event delegation 2013-10-21 09:20:21 -05:00
Albert Łącki
96018dbfae FIXED for jshint 2013-10-17 03:06:31 +02:00
Albert Łącki
67a47b9025 Parse arrays: json[], uuid[] 2013-10-16 07:03:43 +02:00
Brian C
aea984f7bc Merge pull request #447 from eugeneware/buffer-params 
Bind Buffer Variables as binary values (with Native implementation also)
 2013-10-02 20:32:03 -07:00
Brian C
4fcfc66a45 Merge pull request #423 from rpedela/master 
Add support for single row mode
 2013-09-30 09:31:07 -07:00
Eugene Ware
4662d41972 bind Buffer variables as binary values 2013-09-19 01:50:42 +10:00
Rob Raux
bf419d2659 fix global variable leaks 2013-09-11 14:36:29 +00:00