cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,349 Commits 1 Branch 167 Tags 4 MiB
5b03386c44
Commit Graph

555 Commits

Author SHA1 Message Date
Brian C
e81245fce4 Merge pull request #591 from seegno/allow-config-override 
Add support for overriding generic pool defaults
 2014-05-22 12:09:46 -04:00
Brian C
f8df873023 Merge pull request #594 from lukemurray/master 
avoid eval if the row is returned as an array
 2014-05-22 12:09:09 -04:00
Luke Murray
a8f9b7dc93 avoid eval if the row is returned as an array 2014-05-21 00:44:53 +10:00
Nuno Sousa
7612bbc402 Add support for overriding generic pool defaults 2014-05-16 15:00:18 +01:00
Marek
47b0aafa6d Make sure 'end' is emitted even if no connection has ever happened 2014-05-13 12:57:01 +01:00
Solomon English
48b5537683 adding an error handler for the tls socket connection 2014-05-07 02:18:03 -07:00
Ricky Ng-Adam
4de8f04c34 count reuse of each connection as client.poolCount 2014-04-25 13:10:16 +08:00
Ricky Ng-Adam
6216f6089f test to reproduce behavior of issue brianc/node-postgres#549 
a fix was provided in 5079c1e0c41f431ac2e02c40ebd875d8fbb34004;
test is modeled on query-error-handling-tests.js;
test both kill query and disconnection on prepared statement execution;
make connection error string message consistent between native and non-native;
disable test server-side kill for native as it hangs;
sync can cause error to be emitted so we catch that;
we also move _ending state before _send is called.
 2014-04-24 08:36:54 +08:00
Brian C
1047aeb3c2 Merge pull request #571 from letsface/ended-event-on-pool-drained 
emit event 'ended' on pool drained
 2014-04-22 16:27:57 -05:00
Matti Virolainen
17dbb640a6 Remove unused parameter 'name' from DataRowMessage. 2014-04-19 11:54:12 +03:00
Ricky Ng-Adam
0882c8da02 from ended to end 2014-04-18 23:30:45 +08:00
Ricky Ng-Adam
9ab6ed76d1 remove extra whitespace 2014-04-17 17:04:46 +08:00
Ricky Ng-Adam
85c28e9088 destroyAllNow also has a callback 2014-04-17 16:25:59 +08:00
Ricky Ng-Adam
382d6d66f9 emit event when all pool are actually destroyed 2014-04-17 16:18:49 +08:00
Philipp Borgers
fa3b1ccc5b remove pause/resumeDrain functions from native code as disccued in issue #515 2014-04-16 19:10:49 +02:00
Brian M. Carlson
9c87253aff Fix memory leak with domains 2014-04-12 00:29:44 -05:00
Tim Griesser
cd050334ba Removed various unused vars 2014-04-09 08:46:17 -04:00
Tim Griesser
0565ed6c05 Remove legacy .once events shim 2014-04-08 21:29:51 -04:00
Brian M. Carlson
bd74d48791 Fix query error emit on native bindings 2014-04-06 12:55:26 -05:00
Brian M. Carlson
357b64d704 Remove query emit 'end' event when query has error 
Closes #547
 2014-04-06 11:53:47 -05:00
Brian C
f3fc6ff705 Merge pull request #546 from CartoDB/2.11-ensure-connect-callback 
Ensure connect callback is invoked on premature socket hangup
 2014-04-06 11:18:23 -05:00
Brian C
82486929a9 Merge pull request #555 from benesch/custom-type-coercion 
Supercharge `prepareValue`
 2014-04-06 11:16:33 -05:00
Sandro Santilli
e1b1c62e3e Do not emit 'end' twice from Connection on close 2014-04-04 10:07:07 +02:00
Nikhil Benesch
619ba46ffe pass prepareValue hook to toPostgres 
Pass `toPostgres` type-coercers a reference to the `prepareValue`
function to ease constructing literals composed of other Postgres types.
 2014-04-03 10:28:02 -04:00
Brian C
7dbc4c9845 Merge pull request #552 from geon/patch-1 
Added missing argument to handleError method call.
 2014-04-03 08:58:48 -05:00
Nikhil Benesch
6ced524390 allow type-coercion overrides for custom objects 
Attempt to call a `toPostgres` method on objects passed as query values
before converting them to JSON. This allows custom types to convert
themselves to the appropriate PostgreSQL literal.

This strategy is fully backwards-compatible and uses the same pattern as
the `toJSON` override.
 2014-03-30 20:39:56 -04:00
Nikhil Benesch
c41eedc3e0 properly prepare complex arrays 
`arrayString` duplicated too much of `prepareValue`'s logic, and so
didn't receive bugfixes for handling dates with timestamps. Defer to
`prepareValue` whenever possible.

This change enforces double-quote escaping of all array elements,
regardless of whether escaping is necessary. This has the side-effect of
properly escaping JSON arrays.
 2014-03-30 19:12:18 -04:00
Nikhil Benesch
364cf4b3ca utils: convert tabs to spaces 2014-03-30 19:11:02 -04:00
Nikhil Benesch
7faa2b325e utils: reorganize prepareValue conditional for clarity 
Prefer positive tests; group tests for specific objects.
 2014-03-30 19:03:28 -04:00
Nikhil Benesch
cb7bbe6502 query: remove dead type-parsing code path 
Type parsing was factored out into the pg-types package. Remove vestigal
`noParse` function.
 2014-03-30 19:02:11 -04:00
Victor Widell
5079c1e0c4 Added missing argument to handleError method call. 
Before the change, it would crash with a very unhelpful error message:

	[project path]/node_modules/pg/lib/query.js:92
	    connection.sync();
	               ^
	TypeError: Cannot call method 'sync' of undefined
	    at Query.handleError ([project path]/node_modules/pg/lib/query.js:92:16)
	    at Client.connect ([project path]/node_modules/pg/lib/client.js:178:24)
	    at g (events.js:185:14)
	    at EventEmitter.emit (events.js:85:17)
	    at Socket.<anonymous> ([project path]/node_modules/pg/lib/connection.js:60:10)
	    at Socket.EventEmitter.emit (events.js:85:17)
	    at TCP.onread (net.js:424:51)


After the change, it reports a much more helpful

	error running query [Error: Stream unexpectedly ended during query execution]
 2014-03-29 16:45:00 +01:00
Brian C
b12dd4c420 Merge pull request #543 from CartoDB/2.11-remove-ended-connections 
Remove disconnected clients from the pool
 2014-03-22 10:47:53 -05:00
Sandro Santilli
96e4afdb1b Have Connection also emit 'end' on stream 'close' event 
Should fix missing connect callback call with node-0.8 (#534)
 2014-03-18 14:23:05 +01:00
Sandro Santilli
64d6883a81 Ensure connect callback is invoked on premature socket hangup 
Closes #534
 2014-03-18 13:03:15 +01:00
Sandro Santilli
fb118cf069 Avoid loop between pool.destroy and client.end 2014-03-18 09:42:19 +01:00
Sandro Santilli
9c5cd8d02d Remove disconnected clients from the pool 
Might fix #458
Fixes https://github.com/CartoDB/CartoDB-SQL-API/issues/135
 2014-03-17 18:51:32 +01:00
Brian M. Carlson
779c8064f2 Add domain support to connection pool 2014-03-15 16:41:33 -05:00
Brian M. Carlson
0254fa565f Add test for pg.types interface 2014-03-15 15:41:36 -05:00
Brian M. Carlson
876abe8730 Break type parsing into separate module 2014-03-15 15:36:27 -05:00
Brian M. Carlson
79f03948dd Use packet reader 2014-03-14 06:59:19 -05:00
Brian C
2716f95257 Merge pull request #514 from benighted/parse-date-as-local 
Parse date type as local time
 2014-02-26 06:16:12 -06:00
Brian C
ff8fb616f6 Merge pull request #501 from lalitkapoor/GH-452 
improve support for int arrays and float arrays
 2014-02-26 06:15:35 -06:00
Brian C
be37756607 Merge pull request #395 from aaronyo/master 
Unable to reconnect after calling pg.end()
 2014-02-26 06:12:57 -06:00
Brian M. Carlson
bf0c4bfaa9 Merge branch 'pull/326' 
Conflicts:
	lib/connection-parameters.js
	test/unit/connection-parameters/creation-tests.js
 2014-02-26 06:10:15 -06:00
Michael Payne
b81a60a260 Parse date type as local time 2014-01-26 10:43:15 -05:00
Brian C
62f6b2fbf9 Merge pull request #507 from brianc/issues/507 
Unexpected identifier with pg versions > 2.3.1
 2014-01-22 06:42:59 -08:00
Brian M. Carlson
5f592a1240 Fix exception caused by column names with single quotes 
Also rename some test files so they match the Makefile regex.  They will be included in the test suite from now on.
 2014-01-22 08:38:29 -06:00
Lalit Kapoor
8f4644dc3d parse values in float arrays as floats not strings 
javascript numbers are 64-bit floating numbers
 2014-01-08 00:09:34 -06:00
Lalit Kapoor
3cb35e0f46 big integer array support 2014-01-08 00:08:57 -06:00
Lalit Kapoor
58b4d9cf9c comment explaining how to get oid 2014-01-07 11:48:55 -06:00