cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add warning on long query names

Browse Source 
Postgres has a 63 character limit on query names.  To avoid potential footgunning of users we'll log to their stderr if they use a longer query name.

For reference: https://github.com/brianc/node-postgres/pull/772
This commit is contained in:
brianc 2015-05-21 13:14:01 -04:00
parent 540c3f16db
commit edef4fee53
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/connection.js
View File

@ -199,6 +199,11 @@ Connection.prototype.parse = function(query, more) {
//normalize missing query names to allow for null //normalize missing query names to allow for null
query.name = query.name || ''; query.name = query.name || '';
if (query.name.length > 63) {
console.error('Warning! Postgres only supports 63 characters for query names.');
console.error('You supplied', query.name, '(', query.name.length, ')');
console.error('This can cause conflicts and silent errors executing queries');
}
//normalize null type array //normalize null type array
query.types = query.types || []; query.types = query.types || [];
var len = query.types.length; var len = query.types.length;