cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add ability to opt-in to int8 parsing

Browse Source 
Switching the result of all COUNT operations to a string is
a pretty nasty breaking change, and the majority of us aren't
going to be hitting numbers larger than Number.MAX_VALUE
This commit is contained in:
Brian Carlson 2013-08-29 00:04:27 -05:00
parent 003ee692f0
commit e744d05df7
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/defaults.js
View File

@ -1,4 +1,4 @@
module.exports = {
var defaults = module.exports = {
// database host defaults to localhost
host: 'localhost',
@ -38,3 +38,8 @@ module.exports = {
client_encoding: ""
};
//parse int8 so you can get your count values as actual numbers
module.exports.__defineSetter__("parseInt8", function(val) {
require('./types').setTypeParser(20, 'text', val ? parseInt : function(val) { return val; });
});

18
test/integration/client/parse-int-8-tests.js Normal file
View File

@ -0,0 +1,18 @@
var helper = require(__dirname + '/../test-helper');
var pg = helper.pg;
test('ability to turn on and off parser', function() {
if(helper.args.binary) return false;
pg.connect(helper.config, assert.success(function(client, done) {
pg.defaults.parseInt8 = true;
client.query('CREATE TEMP TABLE asdf(id SERIAL PRIMARY KEY)');
client.query('SELECT COUNT(*) as "count" FROM asdf', assert.success(function(res) {
pg.defaults.parseInt8 = false;
client.query('SELECT COUNT(*) as "count" FROM asdf', assert.success(function(res) {
done();
assert.strictEqual("0", res.rows[0].count);
pg.end();
}));
}));
}));
});