cartodb/node-postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treat undefined values as NULL. Include test to verify.

Browse Source
This commit is contained in:
Brian Dunavant 2011-10-14 11:31:12 -04:00
parent 558cbbb66a
commit 94dc7fd4e8
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/connection.js
View File

@ -132,7 +132,7 @@ p.bind = function(config, more) {
.addInt16(len); //number of parameters
for(var i = 0; i < len; i++) {
var val = values[i];
if(val === null) {
if(val === null || typeof val === "undefined") {
buffer.addInt32(-1);
} else {
val = val.toString();

18
test/integration/client/api-tests.js
View File

@ -140,3 +140,21 @@ test('can provide callback and config and parameters', function() {
}))
}))
})
test('null and undefined are both inserted as NULL', function() {
pg.connect(connectionString, assert.calls(function(err, client) {
assert.isNull(err);
client.query("CREATE TEMP TABLE my_nulls(a varchar(1), b varchar(1), c integer, d integer, e date, f date)");
client.query("INSERT INTO my_nulls(a,b,c,d,e,f) VALUES ($1,$2,$3,$4,$5,$6)", [ null, undefined, null, undefined, null, undefined ]);
client.query("SELECT * FROM my_nulls", assert.calls(function(err, result) {
assert.isNull(err);
assert.equal(result.rows.length, 1);
assert.isNull(result.rows[0].a);
assert.isNull(result.rows[0].b);
assert.isNull(result.rows[0].c);
assert.isNull(result.rows[0].d);
assert.isNull(result.rows[0].e);
assert.isNull(result.rows[0].f);
}))
}))
})